Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 52242,
    "url": "http://patches.dpdk.org/api/patches/52242/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190403205041.4651-8-gage.eads@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190403205041.4651-8-gage.eads@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190403205041.4651-8-gage.eads@intel.com",
    "date": "2019-04-03T20:50:40",
    "name": "[v8,7/8] test/stack: add lock-free stack tests",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "4ed70c61d2b90d37219008c5663b6d542aba8985",
    "submitter": {
        "id": 586,
        "url": "http://patches.dpdk.org/api/people/586/?format=api",
        "name": "Eads, Gage",
        "email": "gage.eads@intel.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190403205041.4651-8-gage.eads@intel.com/mbox/",
    "series": [
        {
            "id": 4102,
            "url": "http://patches.dpdk.org/api/series/4102/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4102",
            "date": "2019-04-03T20:50:33",
            "name": "Add stack library and new mempool handler",
            "version": 8,
            "mbox": "http://patches.dpdk.org/series/4102/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/52242/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/52242/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 914AC1B2AE;\n\tWed,  3 Apr 2019 22:53:26 +0200 (CEST)",
            "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id EF4A9293B\n\tfor <dev@dpdk.org>; Wed,  3 Apr 2019 22:52:59 +0200 (CEST)",
            "from fmsmga007.fm.intel.com ([10.253.24.52])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t03 Apr 2019 13:52:59 -0700",
            "from txasoft-yocto.an.intel.com ([10.123.72.192])\n\tby fmsmga007.fm.intel.com with ESMTP; 03 Apr 2019 13:52:58 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.60,306,1549958400\"; d=\"scan'208\";a=\"139902570\"",
        "From": "Gage Eads <gage.eads@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "olivier.matz@6wind.com, arybchenko@solarflare.com,\n\tbruce.richardson@intel.com, konstantin.ananyev@intel.com,\n\tgavin.hu@arm.com, \n\tHonnappa.Nagarahalli@arm.com, nd@arm.com, thomas@monjalon.net",
        "Date": "Wed,  3 Apr 2019 15:50:40 -0500",
        "Message-Id": "<20190403205041.4651-8-gage.eads@intel.com>",
        "X-Mailer": "git-send-email 2.13.6",
        "In-Reply-To": "<20190403205041.4651-1-gage.eads@intel.com>",
        "References": "<20190403200916.16349-1-gage.eads@intel.com>\n\t<20190403205041.4651-1-gage.eads@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v8 7/8] test/stack: add lock-free stack tests",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "This commit adds lock-free stack variants of stack_autotest\n(stack_lf_autotest) and stack_perf_autotest (stack_lf_perf_autotest), which\ndiffer only in that the lock-free versions pass the RTE_STACK_F_LF flag to\nall rte_stack_create() calls.\n\nSigned-off-by: Gage Eads <gage.eads@intel.com>\nReviewed-by: Olivier Matz <olivier.matz@6wind.com>\n---\n app/test/meson.build       |  2 ++\n app/test/test_stack.c      | 41 +++++++++++++++++++++++++++--------------\n app/test/test_stack_perf.c | 17 +++++++++++++++--\n 3 files changed, 44 insertions(+), 16 deletions(-)",
    "diff": "diff --git a/app/test/meson.build b/app/test/meson.build\nindex 02eb788a4..867cc5863 100644\n--- a/app/test/meson.build\n+++ b/app/test/meson.build\n@@ -178,6 +178,7 @@ fast_parallel_test_names = [\n         'sched_autotest',\n         'spinlock_autotest',\n         'stack_autotest',\n+        'stack_nb_autotest',\n         'string_autotest',\n         'table_autotest',\n         'tailq_autotest',\n@@ -243,6 +244,7 @@ perf_test_names = [\n         'ring_pmd_perf_autotest',\n         'pmd_perf_autotest',\n         'stack_perf_autotest',\n+        'stack_nb_perf_autotest',\n ]\n \n # All test cases in driver_test_names list are non-parallel\ndiff --git a/app/test/test_stack.c b/app/test/test_stack.c\nindex 8392e4e4d..f199136aa 100644\n--- a/app/test/test_stack.c\n+++ b/app/test/test_stack.c\n@@ -97,7 +97,7 @@ test_stack_push_pop(struct rte_stack *s, void **obj_table, unsigned int bulk_sz)\n }\n \n static int\n-test_stack_basic(void)\n+test_stack_basic(uint32_t flags)\n {\n \tstruct rte_stack *s = NULL;\n \tvoid **obj_table = NULL;\n@@ -113,7 +113,7 @@ test_stack_basic(void)\n \tfor (i = 0; i < STACK_SIZE; i++)\n \t\tobj_table[i] = (void *)(uintptr_t)i;\n \n-\ts = rte_stack_create(__func__, STACK_SIZE, rte_socket_id(), 0);\n+\ts = rte_stack_create(__func__, STACK_SIZE, rte_socket_id(), flags);\n \tif (s == NULL) {\n \t\tprintf(\"[%s():%u] failed to create a stack\\n\",\n \t\t       __func__, __LINE__);\n@@ -177,18 +177,18 @@ test_stack_basic(void)\n }\n \n static int\n-test_stack_name_reuse(void)\n+test_stack_name_reuse(uint32_t flags)\n {\n \tstruct rte_stack *s[2];\n \n-\ts[0] = rte_stack_create(\"test\", STACK_SIZE, rte_socket_id(), 0);\n+\ts[0] = rte_stack_create(\"test\", STACK_SIZE, rte_socket_id(), flags);\n \tif (s[0] == NULL) {\n \t\tprintf(\"[%s():%u] Failed to create a stack\\n\",\n \t\t       __func__, __LINE__);\n \t\treturn -1;\n \t}\n \n-\ts[1] = rte_stack_create(\"test\", STACK_SIZE, rte_socket_id(), 0);\n+\ts[1] = rte_stack_create(\"test\", STACK_SIZE, rte_socket_id(), flags);\n \tif (s[1] != NULL) {\n \t\tprintf(\"[%s():%u] Failed to detect re-used name\\n\",\n \t\t       __func__, __LINE__);\n@@ -201,7 +201,7 @@ test_stack_name_reuse(void)\n }\n \n static int\n-test_stack_name_length(void)\n+test_stack_name_length(uint32_t flags)\n {\n \tchar name[RTE_STACK_NAMESIZE + 1];\n \tstruct rte_stack *s;\n@@ -209,7 +209,7 @@ test_stack_name_length(void)\n \tmemset(name, 's', sizeof(name));\n \tname[RTE_STACK_NAMESIZE] = '\\0';\n \n-\ts = rte_stack_create(name, STACK_SIZE, rte_socket_id(), 0);\n+\ts = rte_stack_create(name, STACK_SIZE, rte_socket_id(), flags);\n \tif (s != NULL) {\n \t\tprintf(\"[%s():%u] Failed to prevent long name\\n\",\n \t\t       __func__, __LINE__);\n@@ -328,7 +328,7 @@ stack_thread_push_pop(void *args)\n }\n \n static int\n-test_stack_multithreaded(void)\n+test_stack_multithreaded(uint32_t flags)\n {\n \tstruct test_args *args;\n \tunsigned int lcore_id;\n@@ -349,7 +349,7 @@ test_stack_multithreaded(void)\n \t\treturn -1;\n \t}\n \n-\ts = rte_stack_create(\"test\", STACK_SIZE, rte_socket_id(), 0);\n+\ts = rte_stack_create(\"test\", STACK_SIZE, rte_socket_id(), flags);\n \tif (s == NULL) {\n \t\tprintf(\"[%s():%u] Failed to create a stack\\n\",\n \t\t       __func__, __LINE__);\n@@ -384,9 +384,9 @@ test_stack_multithreaded(void)\n }\n \n static int\n-test_stack(void)\n+__test_stack(uint32_t flags)\n {\n-\tif (test_stack_basic() < 0)\n+\tif (test_stack_basic(flags) < 0)\n \t\treturn -1;\n \n \tif (test_lookup_null() < 0)\n@@ -395,16 +395,29 @@ test_stack(void)\n \tif (test_free_null() < 0)\n \t\treturn -1;\n \n-\tif (test_stack_name_reuse() < 0)\n+\tif (test_stack_name_reuse(flags) < 0)\n \t\treturn -1;\n \n-\tif (test_stack_name_length() < 0)\n+\tif (test_stack_name_length(flags) < 0)\n \t\treturn -1;\n \n-\tif (test_stack_multithreaded() < 0)\n+\tif (test_stack_multithreaded(flags) < 0)\n \t\treturn -1;\n \n \treturn 0;\n }\n \n+static int\n+test_stack(void)\n+{\n+\treturn __test_stack(0);\n+}\n+\n+static int\n+test_lf_stack(void)\n+{\n+\treturn __test_stack(RTE_STACK_F_LF);\n+}\n+\n REGISTER_TEST_COMMAND(stack_autotest, test_stack);\n+REGISTER_TEST_COMMAND(stack_lf_autotest, test_lf_stack);\ndiff --git a/app/test/test_stack_perf.c b/app/test/test_stack_perf.c\nindex 484370d30..e09d5384c 100644\n--- a/app/test/test_stack_perf.c\n+++ b/app/test/test_stack_perf.c\n@@ -297,14 +297,14 @@ test_bulk_push_pop(struct rte_stack *s)\n }\n \n static int\n-test_stack_perf(void)\n+__test_stack_perf(uint32_t flags)\n {\n \tstruct lcore_pair cores;\n \tstruct rte_stack *s;\n \n \trte_atomic32_init(&lcore_barrier);\n \n-\ts = rte_stack_create(STACK_NAME, STACK_SIZE, rte_socket_id(), 0);\n+\ts = rte_stack_create(STACK_NAME, STACK_SIZE, rte_socket_id(), flags);\n \tif (s == NULL) {\n \t\tprintf(\"[%s():%u] failed to create a stack\\n\",\n \t\t       __func__, __LINE__);\n@@ -340,4 +340,17 @@ test_stack_perf(void)\n \treturn 0;\n }\n \n+static int\n+test_stack_perf(void)\n+{\n+\treturn __test_stack_perf(0);\n+}\n+\n+static int\n+test_lf_stack_perf(void)\n+{\n+\treturn __test_stack_perf(RTE_STACK_F_LF);\n+}\n+\n REGISTER_TEST_COMMAND(stack_perf_autotest, test_stack_perf);\n+REGISTER_TEST_COMMAND(stack_lf_perf_autotest, test_lf_stack_perf);\n",
    "prefixes": [
        "v8",
        "7/8"
    ]
}