Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52215/?format=api
{ "id": 52215, "url": "http://patches.dpdk.org/api/patches/52215/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190403171601.9788-2-marcinx.hajkowski@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190403171601.9788-2-marcinx.hajkowski@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190403171601.9788-2-marcinx.hajkowski@intel.com", "date": "2019-04-03T17:15:57", "name": "[1/4] power: extend guest channel for query freq.", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "48cc0ffbc4046b99c0f3aaedbb8e254a1e52d211", "submitter": { "id": 1246, "url": "http://patches.dpdk.org/api/people/1246/?format=api", "name": "Marcin Hajkowski", "email": "marcinx.hajkowski@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190403171601.9788-2-marcinx.hajkowski@intel.com/mbox/", "series": [ { "id": 4096, "url": "http://patches.dpdk.org/api/series/4096/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4096", "date": "2019-04-03T17:15:56", "name": "Frequency list query", "version": 1, "mbox": "http://patches.dpdk.org/series/4096/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/52215/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/52215/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 13A261B53A;\n\tWed, 3 Apr 2019 19:16:37 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby dpdk.org (Postfix) with ESMTP id DB66D1B4EB\n\tfor <dev@dpdk.org>; Wed, 3 Apr 2019 19:16:20 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t03 Apr 2019 10:16:20 -0700", "from mhajkowx-mobl.ger.corp.intel.com ([10.104.116.180])\n\tby fmsmga001.fm.intel.com with ESMTP; 03 Apr 2019 10:16:19 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,305,1549958400\"; d=\"scan'208\";a=\"161086719\"", "From": "Hajkowski <marcinx.hajkowski@intel.com>", "To": "david.hunt@intel.com", "Cc": "dev@dpdk.org,\n\tMarcin Hajkowski <marcinx.hajkowski@intel.com>", "Date": "Wed, 3 Apr 2019 19:15:57 +0200", "Message-Id": "<20190403171601.9788-2-marcinx.hajkowski@intel.com>", "X-Mailer": "git-send-email 2.20.1.windows.1", "In-Reply-To": "<20190403171601.9788-1-marcinx.hajkowski@intel.com>", "References": "<20190403171601.9788-1-marcinx.hajkowski@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/4] power: extend guest channel for query freq.", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Marcin Hajkowski <marcinx.hajkowski@intel.com>\n\nExtend incoming packet reading API with new packet\ntype which carries CPU frequencies.\n\nSigned-off-by: Marcin Hajkowski <marcinx.hajkowski@intel.com>\n---\n lib/librte_power/channel_commands.h | 21 +++++++++++++++++++++\n lib/librte_power/guest_channel.c | 27 ++++++++++++++++-----------\n lib/librte_power/guest_channel.h | 21 ++++++++++++++++-----\n 3 files changed, 53 insertions(+), 16 deletions(-)", "diff": "diff --git a/lib/librte_power/channel_commands.h b/lib/librte_power/channel_commands.h\nindex 33fd53a6d..ce587283c 100644\n--- a/lib/librte_power/channel_commands.h\n+++ b/lib/librte_power/channel_commands.h\n@@ -15,6 +15,8 @@ extern \"C\" {\n /* Maximum number of channels per VM */\n #define CHANNEL_CMDS_MAX_VM_CHANNELS 64\n \n+/* --- Incoming messages --- */\n+\n /* Valid Commands */\n #define CPU_POWER 1\n #define CPU_POWER_CONNECT 2\n@@ -29,10 +31,19 @@ extern \"C\" {\n #define CPU_POWER_ENABLE_TURBO 5\n #define CPU_POWER_DISABLE_TURBO 6\n \n+/* CPU Power Queries */\n+#define CPU_POWER_QUERY_FREQ_LIST 7\n+#define CPU_POWER_QUERY_FREQ 8\n+\n+/* --- Outgoing messages --- */\n+\n /* Generic Power Command Response */\n #define CPU_POWER_CMD_ACK 1\n #define CPU_POWER_CMD_NACK 2\n \n+/* CPU Power Query Responses */\n+#define CPU_POWER_FREQ_LIST 3\n+\n #define HOURS 24\n \n #define MAX_VFS 10\n@@ -85,6 +96,16 @@ struct channel_packet {\n \tstruct t_boost_status t_boost_status;\n };\n \n+struct channel_packet_freq_list {\n+\tuint64_t resource_id; /**< core_num, device */\n+\tuint32_t unit; /**< scale down/up/min/max */\n+\tuint32_t command; /**< Power, IO, etc */\n+\tchar vm_name[VM_MAX_NAME_SZ];\n+\n+\tuint32_t freq_list[MAX_VCPU_PER_VM];\n+\tuint8_t num_vcpu;\n+};\n+\n \n #ifdef __cplusplus\n }\ndiff --git a/lib/librte_power/guest_channel.c b/lib/librte_power/guest_channel.c\nindex 888423891..439cd2f38 100644\n--- a/lib/librte_power/guest_channel.c\n+++ b/lib/librte_power/guest_channel.c\n@@ -129,13 +129,15 @@ int rte_power_guest_channel_send_msg(struct channel_packet *pkt,\n \treturn guest_channel_send_msg(pkt, lcore_id);\n }\n \n-int power_guest_channel_read_msg(struct channel_packet *pkt,\n-\t\t\tunsigned int lcore_id)\n+int power_guest_channel_read_msg(void *pkt,\n+\t\tsize_t pkt_len,\n+\t\tunsigned int lcore_id)\n {\n \tint ret;\n \tstruct pollfd fds;\n-\tvoid *buffer = pkt;\n-\tint buffer_len = sizeof(*pkt);\n+\n+\tif (pkt_len == 0 || pkt == NULL)\n+\t\treturn -1;\n \n \tfds.fd = global_fds[lcore_id];\n \tfds.events = POLLIN;\n@@ -161,29 +163,32 @@ int power_guest_channel_read_msg(struct channel_packet *pkt,\n \t\treturn -1;\n \t}\n \n-\twhile (buffer_len > 0) {\n+\twhile (pkt_len > 0) {\n \t\tret = read(global_fds[lcore_id],\n-\t\t\t\tbuffer, buffer_len);\n+\t\t\t\tpkt, pkt_len);\n+\n \t\tif (ret < 0) {\n \t\t\tif (errno == EINTR)\n \t\t\t\tcontinue;\n \t\t\treturn -1;\n \t\t}\n+\n \t\tif (ret == 0) {\n \t\t\tRTE_LOG(ERR, GUEST_CHANNEL, \"Expected more data, but connection has been closed.\\n\");\n \t\t\treturn -1;\n \t\t}\n-\t\tbuffer = (char *)buffer + ret;\n-\t\tbuffer_len -= ret;\n+\t\tpkt = (char *)pkt + ret;\n+\t\tpkt_len -= ret;\n \t}\n \n \treturn 0;\n }\n \n-int rte_power_guest_channel_receive_msg(struct channel_packet *pkt,\n-\t\t\tunsigned int lcore_id)\n+int rte_power_guest_channel_receive_msg(void *pkt,\n+\t\tsize_t pkt_len,\n+\t\tunsigned int lcore_id)\n {\n-\treturn power_guest_channel_read_msg(pkt, lcore_id);\n+\treturn power_guest_channel_read_msg(pkt, pkt_len, lcore_id);\n }\n \n void\ndiff --git a/lib/librte_power/guest_channel.h b/lib/librte_power/guest_channel.h\nindex 7c385df39..473901547 100644\n--- a/lib/librte_power/guest_channel.h\n+++ b/lib/librte_power/guest_channel.h\n@@ -17,6 +17,7 @@ extern \"C\" {\n *\n * @param path\n * The path to the serial device on the filesystem\n+ *\n * @param lcore_id\n * lcore_id.\n *\n@@ -73,7 +74,11 @@ int rte_power_guest_channel_send_msg(struct channel_packet *pkt,\n * from the host endpoint.\n *\n * @param pkt\n- * Pointer to a populated struct channel_packet\n+ * Pointer to channel_packet or\n+ * channel_packet_freq_list struct.\n+ *\n+ * @param pkt_len\n+ * Size of expected data packet.\n *\n * @param lcore_id\n * lcore_id.\n@@ -82,7 +87,8 @@ int rte_power_guest_channel_send_msg(struct channel_packet *pkt,\n * - 0 on success.\n * - Negative on error.\n */\n-int power_guest_channel_read_msg(struct channel_packet *pkt,\n+int power_guest_channel_read_msg(void *pkt,\n+\t\tsize_t pkt_len,\n \t\tunsigned int lcore_id);\n \n /**\n@@ -90,7 +96,11 @@ int power_guest_channel_read_msg(struct channel_packet *pkt,\n * from the host endpoint.\n *\n * @param pkt\n- * Pointer to a populated struct channel_packet\n+ * Pointer to channel_packet or\n+ * channel_packet_freq_list struct.\n+ *\n+ * @param pkt_len\n+ * Size of expected data packet.\n *\n * @param lcore_id\n * lcore_id.\n@@ -100,8 +110,9 @@ int power_guest_channel_read_msg(struct channel_packet *pkt,\n * - Negative on error.\n */\n int __rte_experimental\n-rte_power_guest_channel_receive_msg(struct channel_packet *pkt,\n-\t\t\tunsigned int lcore_id);\n+rte_power_guest_channel_receive_msg(void *pkt,\n+\t\tsize_t pkt_len,\n+\t\tunsigned int lcore_id);\n \n #ifdef __cplusplus\n }\n", "prefixes": [ "1/4" ] }