Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52201/?format=api
http://patches.dpdk.org/api/patches/52201/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190403144505.46234-4-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190403144505.46234-4-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190403144505.46234-4-bruce.richardson@intel.com", "date": "2019-04-03T14:45:03", "name": "[3/5] devtools/cocci: create safer version of strlcpy script", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "be931766fe9eb4dd3b1eb580414357908cfe7fe2", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190403144505.46234-4-bruce.richardson@intel.com/mbox/", "series": [ { "id": 4091, "url": "http://patches.dpdk.org/api/series/4091/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4091", "date": "2019-04-03T14:45:00", "name": "clean up snprintf use for string copying", "version": 1, "mbox": "http://patches.dpdk.org/series/4091/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/52201/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/52201/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6F4421B46F;\n\tWed, 3 Apr 2019 16:45:28 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby dpdk.org (Postfix) with ESMTP id 86ADB1B46F\n\tfor <dev@dpdk.org>; Wed, 3 Apr 2019 16:45:27 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t03 Apr 2019 07:45:27 -0700", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.222.236])\n\tby orsmga005.jf.intel.com with ESMTP; 03 Apr 2019 07:45:26 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,304,1549958400\"; d=\"scan'208\";a=\"312832737\"", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>", "Date": "Wed, 3 Apr 2019 15:45:03 +0100", "Message-Id": "<20190403144505.46234-4-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190403144505.46234-1-bruce.richardson@intel.com>", "References": "<20190403144505.46234-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 3/5] devtools/cocci: create safer version of\n\tstrlcpy script", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The existing cocci script for coccinelle replaces all matching instances\nof snprintf() with strlcpy() without regards to header inclusion. To allow\nchanges without build errors, we create a safer version of this script\nthat only makes changes when the rte_string_fns.h header is already\nincluded.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n devtools/cocci/strlcpy-with-header.cocci | 12 ++++++++++++\n 1 file changed, 12 insertions(+)\n create mode 100644 devtools/cocci/strlcpy-with-header.cocci", "diff": "diff --git a/devtools/cocci/strlcpy-with-header.cocci b/devtools/cocci/strlcpy-with-header.cocci\nnew file mode 100644\nindex 000000000..046cdbdad\n--- /dev/null\n+++ b/devtools/cocci/strlcpy-with-header.cocci\n@@ -0,0 +1,12 @@\n+@include@\n+@@\n+\n+#include <rte_string_fns.h>\n+\n+@use_strlcpy depends on include@\n+expression src, dst, size;\n+@@\n+(\n+- snprintf(dst, size, \"%s\", src)\n++ strlcpy(dst, src, size)\n+)\n", "prefixes": [ "3/5" ] }{ "id": 52201, "url": "