Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52195/?format=api
{ "id": 52195, "url": "http://patches.dpdk.org/api/patches/52195/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190403142357.17700-2-shreyansh.jain@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190403142357.17700-2-shreyansh.jain@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190403142357.17700-2-shreyansh.jain@nxp.com", "date": "2019-04-03T14:23:41", "name": "[1/3] bus/fslmc: cleanup unused firmware code", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "4e060df4e36256827e6d781bb23f98dbde75d57a", "submitter": { "id": 497, "url": "http://patches.dpdk.org/api/people/497/?format=api", "name": "Shreyansh Jain", "email": "shreyansh.jain@nxp.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190403142357.17700-2-shreyansh.jain@nxp.com/mbox/", "series": [ { "id": 4090, "url": "http://patches.dpdk.org/api/series/4090/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4090", "date": "2019-04-03T14:23:40", "name": "Update FSLMC bus firmware", "version": 1, "mbox": "http://patches.dpdk.org/series/4090/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/52195/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/52195/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 730461B3E0;\n\tWed, 3 Apr 2019 16:23:48 +0200 (CEST)", "from EUR04-VI1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr80077.outbound.protection.outlook.com [40.107.8.77])\n\tby dpdk.org (Postfix) with ESMTP id 91D481B2AF\n\tfor <dev@dpdk.org>; Wed, 3 Apr 2019 16:23:43 +0200 (CEST)", "from VI1PR04MB4688.eurprd04.prod.outlook.com (20.177.56.80) by\n\tVI1PR04MB4960.eurprd04.prod.outlook.com (20.177.49.213) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1750.19; Wed, 3 Apr 2019 14:23:42 +0000", "from VI1PR04MB4688.eurprd04.prod.outlook.com\n\t([fe80::f198:d57:e38d:30]) by VI1PR04MB4688.eurprd04.prod.outlook.com\n\t([fe80::f198:d57:e38d:30%4]) with mapi id 15.20.1750.017;\n\tWed, 3 Apr 2019 14:23:42 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=Yn0ITHROfsc88hQP8l9AYrVHxcRtpAJPeGnk/zlMyGw=;\n\tb=Y6wq9BuNRWkes6iS8Uoh5v7GzTqU1Fkwc8J3s+E6c33jpYyNDeE1QBoLp3c1R4p1h6g7mMZzYXlIU36VrBu9grXGV6/t0DY1629shEcNEhS3XUKSJfoMKlI5gxbYbYztszhiLL1Qu95OyTW2AR1E8Yljo7/NMC9kxcd0YgCNVqk=", "From": "Shreyansh Jain <shreyansh.jain@nxp.com>", "To": "\"ferruh.yigit@intel.com\" <ferruh.yigit@intel.com>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>, Shreyansh Jain <shreyansh.jain@nxp.com>", "Thread-Topic": "[PATCH 1/3] bus/fslmc: cleanup unused firmware code", "Thread-Index": "AQHU6ijWe5u8ZWRvxUyPqHOdbPKi/A==", "Date": "Wed, 3 Apr 2019 14:23:41 +0000", "Message-ID": "<20190403142357.17700-2-shreyansh.jain@nxp.com>", "References": "<20190403142357.17700-1-shreyansh.jain@nxp.com>", "In-Reply-To": "<20190403142357.17700-1-shreyansh.jain@nxp.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[92.120.0.8]", "x-mailer": "git-send-email 2.19.1", "x-clientproxiedby": "BM1PR01CA0155.INDPRD01.PROD.OUTLOOK.COM\n\t(2603:1096:b00:68::25) To VI1PR04MB4688.eurprd04.prod.outlook.com\n\t(2603:10a6:803:71::16)", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=shreyansh.jain@nxp.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "57e82f5f-32b1-429e-048f-08d6b83ff8b6", "x-ms-office365-filtering-ht": "Tenant", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(5600139)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020);\n\tSRVR:VI1PR04MB4960; ", "x-ms-traffictypediagnostic": "VI1PR04MB4960:", "x-microsoft-antispam-prvs": "<VI1PR04MB4960790E2BEB1356B38A897590570@VI1PR04MB4960.eurprd04.prod.outlook.com>", "x-forefront-prvs": "0996D1900D", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(366004)(396003)(136003)(346002)(39860400002)(376002)(189003)(199004)(81156014)(14454004)(6486002)(8676002)(478600001)(5640700003)(53936002)(2616005)(6916009)(66066001)(446003)(316002)(11346002)(36756003)(2351001)(81166006)(2501003)(1076003)(6512007)(71200400001)(68736007)(71190400001)(476003)(44832011)(256004)(86362001)(6506007)(5660300002)(76176011)(54906003)(486006)(26005)(6436002)(14444005)(8936002)(386003)(186003)(52116002)(50226002)(25786009)(2906002)(106356001)(97736004)(6116002)(305945005)(105586002)(99286004)(4326008)(3846002)(7736002)(102836004);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB4960;\n\tH:VI1PR04MB4688.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; MX:1; A:1; ", "received-spf": "None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "xoJFWP8+yZjtTvDgxP6zs4V/mUTVfT5kYT70By5ezla0RO3NmKgntvF2Onqg0s9TLMoGQTiFRZP4t8yoddKto+iiE+4mqNGvhbpGnyL6ONGr3Ut0KnD7nrurnOyQh+BXoT5JbohFBhEZQuC8FQq/XxnN9LiPIMQ0fsEfEUa9SXcqFDc6yqu+3ozRWOi5ur2cq5nAKi2UIhGdT98YZcHR9E9lswQeg0E6/3zzf/JukgxZctMeNmEo1qAcwS4b+tJS8o/pLp9ioFTB6vZBPry7m2HFdZjP9u2UCXsLmV3UljlBWpD0OVEcg1XkvHVW3SnQYoFE1x4Bqrd2t2Ff9RWnyhSX+I7mfMi2sqVROwtFJw3K7ox+TCEKTRmjCgzAGkQMOgzlfonizPej8NTUrb0CUVAvUMxfss7x2DsH3niCKIM=", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "57e82f5f-32b1-429e-048f-08d6b83ff8b6", "X-MS-Exchange-CrossTenant-originalarrivaltime": "03 Apr 2019 14:23:41.9025\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "VI1PR04MB4960", "Subject": "[dpdk-dev] [PATCH 1/3] bus/fslmc: cleanup unused firmware code", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Removes some unused firmware code which was added in last bump\nof the firmware version. No current features uses these APIs.\n\nSigned-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>\n---\n drivers/bus/fslmc/mc/dpci.c | 75 --------------------------------\n drivers/bus/fslmc/mc/dpcon.c | 30 -------------\n drivers/bus/fslmc/mc/fsl_dpci.h | 21 ---------\n drivers/bus/fslmc/mc/fsl_dpcon.h | 19 --------\n 4 files changed, 145 deletions(-)", "diff": "diff --git a/drivers/bus/fslmc/mc/dpci.c b/drivers/bus/fslmc/mc/dpci.c\nindex 95edae9d9..2874a6196 100644\n--- a/drivers/bus/fslmc/mc/dpci.c\n+++ b/drivers/bus/fslmc/mc/dpci.c\n@@ -301,81 +301,6 @@ int dpci_get_attributes(struct fsl_mc_io *mc_io,\n \treturn 0;\n }\n \n-/**\n- * dpci_get_peer_attributes() - Retrieve peer DPCI attributes.\n- * @mc_io:\tPointer to MC portal's I/O object\n- * @cmd_flags:\tCommand flags; one or more of 'MC_CMD_FLAG_'\n- * @token:\tToken of DPCI object\n- * @attr:\tReturned peer attributes\n- *\n- * Return:\t'0' on Success; Error code otherwise.\n- */\n-int dpci_get_peer_attributes(struct fsl_mc_io *mc_io,\n-\t\t\t uint32_t cmd_flags,\n-\t\t\t uint16_t token,\n-\t\t\t struct dpci_peer_attr *attr)\n-{\n-\tstruct dpci_rsp_get_peer_attr *rsp_params;\n-\tstruct mc_command cmd = { 0 };\n-\tint err;\n-\n-\t/* prepare command */\n-\tcmd.header = mc_encode_cmd_header(DPCI_CMDID_GET_PEER_ATTR,\n-\t\t\t\t\t cmd_flags,\n-\t\t\t\t\t token);\n-\n-\t/* send command to mc*/\n-\terr = mc_send_command(mc_io, &cmd);\n-\tif (err)\n-\t\treturn err;\n-\n-\t/* retrieve response parameters */\n-\trsp_params = (struct dpci_rsp_get_peer_attr *)cmd.params;\n-\tattr->peer_id = le32_to_cpu(rsp_params->id);\n-\tattr->num_of_priorities = rsp_params->num_of_priorities;\n-\n-\treturn 0;\n-}\n-\n-/**\n- * dpci_get_link_state() - Retrieve the DPCI link state.\n- * @mc_io:\tPointer to MC portal's I/O object\n- * @cmd_flags:\tCommand flags; one or more of 'MC_CMD_FLAG_'\n- * @token:\tToken of DPCI object\n- * @up:\t\tReturned link state; returns '1' if link is up, '0' otherwise\n- *\n- * DPCI can be connected to another DPCI, together they\n- * create a 'link'. In order to use the DPCI Tx and Rx queues,\n- * both objects must be enabled.\n- *\n- * Return:\t'0' on Success; Error code otherwise.\n- */\n-int dpci_get_link_state(struct fsl_mc_io *mc_io,\n-\t\t\tuint32_t cmd_flags,\n-\t\t\tuint16_t token,\n-\t\t\tint *up)\n-{\n-\tstruct dpci_rsp_get_link_state *rsp_params;\n-\tstruct mc_command cmd = { 0 };\n-\tint err;\n-\n-\t/* prepare command */\n-\tcmd.header = mc_encode_cmd_header(DPCI_CMDID_GET_LINK_STATE,\n-\t\t\t\t\t cmd_flags,\n-\t\t\t\t\t token);\n-\n-\t/* send command to mc*/\n-\terr = mc_send_command(mc_io, &cmd);\n-\tif (err)\n-\t\treturn err;\n-\n-\t/* retrieve response parameters */\n-\trsp_params = (struct dpci_rsp_get_link_state *)cmd.params;\n-\t*up = dpci_get_field(rsp_params->up, UP);\n-\n-\treturn 0;\n-}\n-\n /**\n * dpci_set_rx_queue() - Set Rx queue configuration\n * @mc_io:\tPointer to MC portal's I/O object\ndiff --git a/drivers/bus/fslmc/mc/dpcon.c b/drivers/bus/fslmc/mc/dpcon.c\nindex 92bd26512..3f6e04b97 100644\n--- a/drivers/bus/fslmc/mc/dpcon.c\n+++ b/drivers/bus/fslmc/mc/dpcon.c\n@@ -295,36 +295,6 @@ int dpcon_get_attributes(struct fsl_mc_io *mc_io,\n \treturn 0;\n }\n \n-/**\n- * dpcon_set_notification() - Set DPCON notification destination\n- * @mc_io:\tPointer to MC portal's I/O object\n- * @cmd_flags:\tCommand flags; one or more of 'MC_CMD_FLAG_'\n- * @token:\tToken of DPCON object\n- * @cfg:\tNotification parameters\n- *\n- * Return:\t'0' on Success; Error code otherwise\n- */\n-int dpcon_set_notification(struct fsl_mc_io *mc_io,\n-\t\t\t uint32_t cmd_flags,\n-\t\t\t uint16_t token,\n-\t\t\t struct dpcon_notification_cfg *cfg)\n-{\n-\tstruct dpcon_cmd_set_notification *dpcon_cmd;\n-\tstruct mc_command cmd = { 0 };\n-\n-\t/* prepare command */\n-\tcmd.header = mc_encode_cmd_header(DPCON_CMDID_SET_NOTIFICATION,\n-\t\t\t\t\t cmd_flags,\n-\t\t\t\t\t token);\n-\tdpcon_cmd = (struct dpcon_cmd_set_notification *)cmd.params;\n-\tdpcon_cmd->dpio_id = cpu_to_le32(cfg->dpio_id);\n-\tdpcon_cmd->priority = cfg->priority;\n-\tdpcon_cmd->user_ctx = cpu_to_le64(cfg->user_ctx);\n-\n-\t/* send command to mc*/\n-\treturn mc_send_command(mc_io, &cmd);\n-}\n-\n /**\n * dpcon_get_api_version - Get Data Path Concentrator API version\n * @mc_io:\tPointer to MC portal's DPCON object\ndiff --git a/drivers/bus/fslmc/mc/fsl_dpci.h b/drivers/bus/fslmc/mc/fsl_dpci.h\nindex 9af9097e5..cf3d15267 100644\n--- a/drivers/bus/fslmc/mc/fsl_dpci.h\n+++ b/drivers/bus/fslmc/mc/fsl_dpci.h\n@@ -108,27 +108,6 @@ int dpci_get_attributes(struct fsl_mc_io *mc_io,\n \t\t\tuint16_t token,\n \t\t\tstruct dpci_attr *attr);\n \n-/**\n- * struct dpci_peer_attr - Structure representing the peer DPCI attributes\n- * @peer_id:\t\tDPCI peer id; if no peer is connected returns (-1)\n- * @num_of_priorities:\tThe pper's number of receive priorities; determines the\n- *\t\t\tnumber of transmit priorities for the local DPCI object\n- */\n-struct dpci_peer_attr {\n-\tint peer_id;\n-\tuint8_t num_of_priorities;\n-};\n-\n-int dpci_get_peer_attributes(struct fsl_mc_io *mc_io,\n-\t\t\t uint32_t cmd_flags,\n-\t\t\t uint16_t token,\n-\t\t\t struct dpci_peer_attr *attr);\n-\n-int dpci_get_link_state(struct fsl_mc_io *mc_io,\n-\t\t\tuint32_t cmd_flags,\n-\t\t\tuint16_t token,\n-\t\t\tint *up);\n-\n /**\n * enum dpci_dest - DPCI destination types\n * @DPCI_DEST_NONE:\tUnassigned destination; The queue is set in parked mode\ndiff --git a/drivers/bus/fslmc/mc/fsl_dpcon.h b/drivers/bus/fslmc/mc/fsl_dpcon.h\nindex fc0430dc1..36dd5f3c1 100644\n--- a/drivers/bus/fslmc/mc/fsl_dpcon.h\n+++ b/drivers/bus/fslmc/mc/fsl_dpcon.h\n@@ -81,25 +81,6 @@ int dpcon_get_attributes(struct fsl_mc_io *mc_io,\n \t\t\t uint16_t token,\n \t\t\t struct dpcon_attr *attr);\n \n-/**\n- * struct dpcon_notification_cfg - Structure representing notification params\n- * @dpio_id:\tDPIO object ID; must be configured with a notification channel;\n- *\t\tto disable notifications set it to 'DPCON_INVALID_DPIO_ID';\n- * @priority:\tPriority selection within the DPIO channel; valid values\n- *\t\tare 0-7, depending on the number of priorities in that channel\n- * @user_ctx:\tUser context value provided with each CDAN message\n- */\n-struct dpcon_notification_cfg {\n-\tint dpio_id;\n-\tuint8_t priority;\n-\tuint64_t user_ctx;\n-};\n-\n-int dpcon_set_notification(struct fsl_mc_io *mc_io,\n-\t\t\t uint32_t cmd_flags,\n-\t\t\t uint16_t token,\n-\t\t\t struct dpcon_notification_cfg *cfg);\n-\n int dpcon_get_api_version(struct fsl_mc_io *mc_io,\n \t\t\t uint32_t cmd_flags,\n \t\t\t uint16_t *major_ver,\n", "prefixes": [ "1/3" ] }