Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52193/?format=api
{ "id": 52193, "url": "http://patches.dpdk.org/api/patches/52193/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1554300897-24032-1-git-send-email-viacheslavo@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1554300897-24032-1-git-send-email-viacheslavo@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1554300897-24032-1-git-send-email-viacheslavo@mellanox.com", "date": "2019-04-03T14:14:57", "name": "[1/1] net/mlx5: fix sharing context destroy order", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "cd183938fcaccfa7cea61ead200e2091a98a390c", "submitter": { "id": 1102, "url": "http://patches.dpdk.org/api/people/1102/?format=api", "name": "Slava Ovsiienko", "email": "viacheslavo@mellanox.com" }, "delegate": { "id": 6624, "url": "http://patches.dpdk.org/api/users/6624/?format=api", "username": "shahafs", "first_name": "Shahaf", "last_name": "Shuler", "email": "shahafs@mellanox.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1554300897-24032-1-git-send-email-viacheslavo@mellanox.com/mbox/", "series": [ { "id": 4089, "url": "http://patches.dpdk.org/api/series/4089/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4089", "date": "2019-04-03T14:14:57", "name": "[1/1] net/mlx5: fix sharing context destroy order", "version": 1, "mbox": "http://patches.dpdk.org/series/4089/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/52193/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/52193/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A35411B1F4;\n\tWed, 3 Apr 2019 16:15:06 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby dpdk.org (Postfix) with ESMTP id 4A6C61B1EF\n\tfor <dev@dpdk.org>; Wed, 3 Apr 2019 16:15:04 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n\tviacheslavo@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 3 Apr 2019 17:15:01 +0300", "from pegasus12.mtr.labs.mlnx. (pegasus12.mtr.labs.mlnx\n\t[10.210.17.40])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x33EF1ue029866;\n\tWed, 3 Apr 2019 17:15:01 +0300" ], "From": "Viacheslav Ovsiienko <viacheslavo@mellanox.com>", "To": "dev@dpdk.org", "Cc": "shahafs@mellanox.com", "Date": "Wed, 3 Apr 2019 14:14:57 +0000", "Message-Id": "<1554300897-24032-1-git-send-email-viacheslavo@mellanox.com>", "X-Mailer": "git-send-email 1.8.3.1", "Subject": "[dpdk-dev] [PATCH 1/1] net/mlx5: fix sharing context destroy order", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "At the mlx5 device closing the shared IB context was destroyed\nbefore cleanup routines completion. As it was found on some\nsetups (Netlink fails with old kernel drivers and we have to use\nsysfs to retrieve interface index, this requires IB device name,\nwhich is stored in shared context) the mlx5_nl_mac_addr_flush()\nrequires IB device name, and if shared context is removed it\ncauses the segmentation fault.\n\nFixes: 17e19bc4dde7 (\"net/mlx5: add IB shared context alloc/free functions\")\n\nSigned-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>\n---\n drivers/net/mlx5/mlx5.c | 13 ++++++++++---\n 1 file changed, 10 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c\nindex 9aa5f0b..570640d 100644\n--- a/drivers/net/mlx5/mlx5.c\n+++ b/drivers/net/mlx5/mlx5.c\n@@ -543,9 +543,6 @@ struct mlx5_dev_spawn_data {\n #ifdef HAVE_MLX5DV_DR\n \tmlx5_free_shared_dv(priv);\n #endif\n-\tif (priv->sh)\n-\t\tmlx5_free_shared_ibctx(priv->sh);\n-\tpriv->sh = NULL;\n \tif (priv->rss_conf.rss_key != NULL)\n \t\trte_free(priv->rss_conf.rss_key);\n \tif (priv->reta_idx != NULL)\n@@ -560,6 +557,16 @@ struct mlx5_dev_spawn_data {\n \t\tclose(priv->nl_socket_rdma);\n \tif (priv->tcf_context)\n \t\tmlx5_flow_tcf_context_destroy(priv->tcf_context);\n+\tif (priv->sh) {\n+\t\t/*\n+\t\t * Free the shared context in last turn, because the cleanup\n+\t\t * routines above may use some shared fields, like\n+\t\t * mlx5_nl_mac_addr_flush() uses ibdev_path for retrieveing\n+\t\t * ifindex if Netlink fails.\n+\t\t */\n+\t\tmlx5_free_shared_ibctx(priv->sh);\n+\t\tpriv->sh = NULL;\n+\t}\n \tret = mlx5_hrxq_ibv_verify(dev);\n \tif (ret)\n \t\tDRV_LOG(WARNING, \"port %u some hash Rx queue still remain\",\n", "prefixes": [ "1/1" ] }