Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52154/?format=api
{ "id": 52154, "url": "http://patches.dpdk.org/api/patches/52154/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1554281204-19196-8-git-send-email-rosen.xu@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1554281204-19196-8-git-send-email-rosen.xu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1554281204-19196-8-git-send-email-rosen.xu@intel.com", "date": "2019-04-03T08:46:37", "name": "[v4,07/14] raw/ifpga/base: clean up code for ifpga share code", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "837541dfadbea7c0a6ac865856428813b417be2c", "submitter": { "id": 946, "url": "http://patches.dpdk.org/api/people/946/?format=api", "name": "Xu, Rosen", "email": "rosen.xu@intel.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1554281204-19196-8-git-send-email-rosen.xu@intel.com/mbox/", "series": [ { "id": 4077, "url": "http://patches.dpdk.org/api/series/4077/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4077", "date": "2019-04-03T08:46:30", "name": "Add patch set for IPN3KE", "version": 4, "mbox": "http://patches.dpdk.org/series/4077/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/52154/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/52154/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DE7D61B185;\n\tWed, 3 Apr 2019 10:46:10 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id F26A51B1CE\n\tfor <dev@dpdk.org>; Wed, 3 Apr 2019 10:46:08 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t03 Apr 2019 01:46:08 -0700", "from dpdkx8602.sh.intel.com ([10.67.110.200])\n\tby orsmga001.jf.intel.com with ESMTP; 03 Apr 2019 01:46:06 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,304,1549958400\"; d=\"scan'208\";a=\"220102547\"", "From": "Rosen Xu <rosen.xu@intel.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, tianfei.zhang@intel.com, dan.wei@intel.com,\n\trosen.xu@intel.com, andy.pei@intel.com, qiming.yang@intel.com,\n\thaiyue.wang@intel.com, santos.chen@intel.com, zhang.zhang@intel.com", "Date": "Wed, 3 Apr 2019 16:46:37 +0800", "Message-Id": "<1554281204-19196-8-git-send-email-rosen.xu@intel.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1554281204-19196-1-git-send-email-rosen.xu@intel.com>", "References": "<1551338000-120348-1-git-send-email-rosen.xu@intel.com>\n\t<1554281204-19196-1-git-send-email-rosen.xu@intel.com>", "Subject": "[dpdk-dev] [PATCH v4 07/14] raw/ifpga/base: clean up code for ifpga\n\tshare code", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: \"Zhang, Tianfei\" <tianfei.zhang@intel.com>\n\nclean up code:\n1. use opae_memcpy instead of memcpy\n2. use opae_memset instead of memset\n3. disable opae_adapter_dump by default\n\nSigned-off-by: Zhang, Tianfei <tianfei.zhang@intel.com>\n---\n drivers/raw/ifpga_rawdev/base/ifpga_api.c | 2 +-\n drivers/raw/ifpga_rawdev/base/ifpga_feature_dev.c | 4 ++--\n drivers/raw/ifpga_rawdev/base/ifpga_fme_pr.c | 2 +-\n drivers/raw/ifpga_rawdev/base/opae_debug.c | 16 ++++++++--------\n drivers/raw/ifpga_rawdev/base/opae_hw_api.c | 2 +-\n drivers/raw/ifpga_rawdev/base/opae_osdep.h | 1 +\n drivers/raw/ifpga_rawdev/base/osdep_raw/osdep_generic.h | 1 +\n drivers/raw/ifpga_rawdev/base/osdep_rte/osdep_generic.h | 2 ++\n 8 files changed, 17 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/raw/ifpga_rawdev/base/ifpga_api.c b/drivers/raw/ifpga_rawdev/base/ifpga_api.c\nindex 540e171..77d9471 100644\n--- a/drivers/raw/ifpga_rawdev/base/ifpga_api.c\n+++ b/drivers/raw/ifpga_rawdev/base/ifpga_api.c\n@@ -202,7 +202,7 @@ static int ifpga_adapter_enumerate(struct opae_adapter *adapter)\n \tstruct ifpga_hw *hw = malloc(sizeof(*hw));\n \n \tif (hw) {\n-\t\tmemset(hw, 0, sizeof(*hw));\n+\t\topae_memset(hw, 0, sizeof(*hw));\n \t\thw->pci_data = adapter->data;\n \t\thw->adapter = adapter;\n \t\tif (ifpga_bus_enumerate(hw))\ndiff --git a/drivers/raw/ifpga_rawdev/base/ifpga_feature_dev.c b/drivers/raw/ifpga_rawdev/base/ifpga_feature_dev.c\nindex be7ac9e..0a27c38 100644\n--- a/drivers/raw/ifpga_rawdev/base/ifpga_feature_dev.c\n+++ b/drivers/raw/ifpga_rawdev/base/ifpga_feature_dev.c\n@@ -77,8 +77,8 @@ int fpga_get_afu_uuid(struct ifpga_port_hw *port, struct uuid *uuid)\n \tguidh = readq(&port_hdr->afu_header.guid.b[8]);\n \tspinlock_unlock(&port->lock);\n \n-\tmemcpy(uuid->b, &guidl, sizeof(u64));\n-\tmemcpy(uuid->b + 8, &guidh, sizeof(u64));\n+\topae_memcpy(uuid->b, &guidl, sizeof(u64));\n+\topae_memcpy(uuid->b + 8, &guidh, sizeof(u64));\n \n \treturn 0;\n }\ndiff --git a/drivers/raw/ifpga_rawdev/base/ifpga_fme_pr.c b/drivers/raw/ifpga_rawdev/base/ifpga_fme_pr.c\nindex ec0beeb..8890f4b 100644\n--- a/drivers/raw/ifpga_rawdev/base/ifpga_fme_pr.c\n+++ b/drivers/raw/ifpga_rawdev/base/ifpga_fme_pr.c\n@@ -257,7 +257,7 @@ static int fme_pr(struct ifpga_hw *hw, u32 port_id, void *buffer, u32 size,\n \t\treturn -EINVAL;\n \t}\n \n-\tmemset(&info, 0, sizeof(struct fpga_pr_info));\n+\topae_memset(&info, 0, sizeof(struct fpga_pr_info));\n \tinfo.flags = FPGA_MGR_PARTIAL_RECONFIG;\n \tinfo.port_id = port_id;\n \ndiff --git a/drivers/raw/ifpga_rawdev/base/opae_debug.c b/drivers/raw/ifpga_rawdev/base/opae_debug.c\nindex 024d7d2..88f2d5c 100644\n--- a/drivers/raw/ifpga_rawdev/base/opae_debug.c\n+++ b/drivers/raw/ifpga_rawdev/base/opae_debug.c\n@@ -78,13 +78,13 @@ void opae_adapter_dump(struct opae_adapter *adapter, int verbose)\n {\n \tstruct opae_accelerator *acc;\n \n-\topae_log(\"=====%s=====\\n\", __func__);\n-\topae_log(\"OPAE Adapter %s\\n\", adapter->name);\n-\topae_log(\"OPAE Adapter OPs = %p\\n\", adapter->ops);\n-\topae_log(\"OPAE Adapter Private Data = %p\\n\", adapter->data);\n-\topae_log(\"OPAE Manager (downstream) = %p\\n\", adapter->mgr);\n-\n \tif (verbose) {\n+\t\topae_log(\"=====%s=====\\n\", __func__);\n+\t\topae_log(\"OPAE Adapter %s\\n\", adapter->name);\n+\t\topae_log(\"OPAE Adapter OPs = %p\\n\", adapter->ops);\n+\t\topae_log(\"OPAE Adapter Private Data = %p\\n\", adapter->data);\n+\t\topae_log(\"OPAE Manager (downstream) = %p\\n\", adapter->mgr);\n+\n \t\tif (adapter->mgr)\n \t\t\topae_manager_dump(adapter->mgr);\n \n@@ -93,7 +93,7 @@ void opae_adapter_dump(struct opae_adapter *adapter, int verbose)\n \n \t\tif (adapter->data)\n \t\t\topae_adapter_data_dump(adapter->data);\n-\t}\n \n-\topae_log(\"==========================\\n\");\n+\t\topae_log(\"==========================\\n\");\n+\t}\n }\ndiff --git a/drivers/raw/ifpga_rawdev/base/opae_hw_api.c b/drivers/raw/ifpga_rawdev/base/opae_hw_api.c\nindex 1541b67..41c5903 100644\n--- a/drivers/raw/ifpga_rawdev/base/opae_hw_api.c\n+++ b/drivers/raw/ifpga_rawdev/base/opae_hw_api.c\n@@ -341,7 +341,7 @@ int opae_adapter_enumerate(struct opae_adapter *adapter)\n \t\tret = adapter->ops->enumerate(adapter);\n \n \tif (!ret)\n-\t\topae_adapter_dump(adapter, 1);\n+\t\topae_adapter_dump(adapter, 0);\n \n \treturn ret;\n }\ndiff --git a/drivers/raw/ifpga_rawdev/base/opae_osdep.h b/drivers/raw/ifpga_rawdev/base/opae_osdep.h\nindex 90f54f7..78fec50 100644\n--- a/drivers/raw/ifpga_rawdev/base/opae_osdep.h\n+++ b/drivers/raw/ifpga_rawdev/base/opae_osdep.h\n@@ -76,4 +76,5 @@ struct uuid {\n #define msleep(x) opae_udelay(1000 * (x))\n #define usleep_range(min, max) msleep(DIV_ROUND_UP(min, 1000))\n \n+#define opae_memset(a, b, c) memset((a), (b), (c))\n #endif\ndiff --git a/drivers/raw/ifpga_rawdev/base/osdep_raw/osdep_generic.h b/drivers/raw/ifpga_rawdev/base/osdep_raw/osdep_generic.h\nindex 895a1d8..6769109 100644\n--- a/drivers/raw/ifpga_rawdev/base/osdep_raw/osdep_generic.h\n+++ b/drivers/raw/ifpga_rawdev/base/osdep_raw/osdep_generic.h\n@@ -71,5 +71,6 @@ static inline void opae_writeq(uint64_t value, volatile void *addr)\n }\n \n #define opae_free(addr) free(addr)\n+#define opae_memcpy(a, b, c) memcpy((a), (b), (c))\n \n #endif\ndiff --git a/drivers/raw/ifpga_rawdev/base/osdep_rte/osdep_generic.h b/drivers/raw/ifpga_rawdev/base/osdep_rte/osdep_generic.h\nindex 76902e2..3d9a0ca 100644\n--- a/drivers/raw/ifpga_rawdev/base/osdep_rte/osdep_generic.h\n+++ b/drivers/raw/ifpga_rawdev/base/osdep_rte/osdep_generic.h\n@@ -11,6 +11,7 @@\n #include <rte_log.h>\n #include <rte_io.h>\n #include <rte_malloc.h>\n+#include <rte_memcpy.h>\n \n #define dev_printf(level, fmt, args...) \\\n \tRTE_LOG(level, PMD, \"osdep_rte: \" fmt, ## args)\n@@ -42,4 +43,5 @@\n #define spinlock_lock(x) rte_spinlock_lock(x)\n #define spinlock_unlock(x) rte_spinlock_unlock(x)\n \n+#define opae_memcpy(a, b, c) rte_memcpy((a), (b), (c))\n #endif\n", "prefixes": [ "v4", "07/14" ] }