Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52118/?format=api
{ "id": 52118, "url": "http://patches.dpdk.org/api/patches/52118/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190402152350.17572-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190402152350.17572-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190402152350.17572-3-stephen@networkplumber.org", "date": "2019-04-02T15:23:50", "name": "[v2,2/2] hexdump: align output of string", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0954a74cde901458d5864d8fc7dc3b657f94cb3f", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190402152350.17572-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 4060, "url": "http://patches.dpdk.org/api/series/4060/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4060", "date": "2019-04-02T15:23:48", "name": "eal: hexdump cleanups", "version": 2, "mbox": "http://patches.dpdk.org/series/4060/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/52118/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/52118/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A2FF94CA0;\n\tTue, 2 Apr 2019 17:24:02 +0200 (CEST)", "from mail-pg1-f195.google.com (mail-pg1-f195.google.com\n\t[209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 60716378B\n\tfor <dev@dpdk.org>; Tue, 2 Apr 2019 17:23:59 +0200 (CEST)", "by mail-pg1-f195.google.com with SMTP id v12so6757639pgq.1\n\tfor <dev@dpdk.org>; Tue, 02 Apr 2019 08:23:59 -0700 (PDT)", "from shemminger-XPS-13-9360.lan (204-195-22-127.wavecable.com.\n\t[204.195.22.127]) by smtp.gmail.com with ESMTPSA id\n\tp6sm5302514pfd.122.2019.04.02.08.23.56\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 02 Apr 2019 08:23:56 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=1iTJ2Ft983o/dXIRYncBU1LPb5ON3q3vZlUq5R1N/Bo=;\n\tb=ubPA/8053IwZkL+2t2PFqCitHDhPrZZoqIxJDW1vV/Fdz+c9yz1YdotCudrLvccbm0\n\tGJDFvSrsIL6feI7eaKvyhR98vi1ZuUBdfDI3LeWpfIQB5L3uF18Jqbjo/bKHHI0Md/m7\n\tc4rov/UAAcybUqzMr82/zLcNKrbN93XEHSH6Elv7HYvj5YmLmNNGDXOjllX4fKzDTrbN\n\ttHlsAhoupmyYz4w5rE8An7dZzAhByzCs+uzCQ94itS1CEc0P1yo51gJ7RD3HE9O0gW4c\n\t14IHV+1nH+H3no03IPrHbWKjuzgM85I/pwtB2hIBeA/dswVjVbCYvy4hIv//eUxRPj9k\n\tVS1w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=1iTJ2Ft983o/dXIRYncBU1LPb5ON3q3vZlUq5R1N/Bo=;\n\tb=gvZUNN95MWrkoJY/9cYZwlort9wtPwi3Fcqj0ijM7g9M+TdVy11nT5e1TWjy98tsag\n\t6SWY2ILgBrW4v+7ucKKbpZBKFYhwbyvp1KoEMLJSWUdjFJ47zdqFbx/nTVgRBsCH/JpE\n\txfebP3N6QhHsalcoR2fFh7/nsOqi1r65pa8FMEcOUjd5H4UZRpqa0ZK/TUJDsv3MND1x\n\t/L+KdX/gbSIhuQ4Rk7CMIZrzRHuCSAfZTN1dzvI6MMVOTjXZuG69N6ChNwGEn4XDhqVC\n\tNLXee4WiT/S2Dg6vAluKo1oVzIT4Yw3JZ6uG/KFBNL4GXMYCdrJ8ELmF1AYcsK3GcYO6\n\t0hGw==", "X-Gm-Message-State": "APjAAAXZE6e33iVv3mgLesfqs1f7Rs4+O6pxo/OmdWZ4LTQKOJot2aRL\n\tkRY7CZ3De6+ZjeTce0uMFBKVHzjbOx63VQ==", "X-Google-Smtp-Source": "APXvYqysmkIYYJdRbvKTYIw0Sors0iw1AgXOYf7dkx0RNbZsj7UhWJYUSNQjS+5PUkzGRgNyY0FRzg==", "X-Received": "by 2002:aa7:9095:: with SMTP id\n\ti21mr47432676pfa.134.1554218638153; \n\tTue, 02 Apr 2019 08:23:58 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Tue, 2 Apr 2019 08:23:50 -0700", "Message-Id": "<20190402152350.17572-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190402152350.17572-1-stephen@networkplumber.org>", "References": "<20180816153106.7608-1-stephen@networkplumber.org>\n\t<20190402152350.17572-1-stephen@networkplumber.org>", "Subject": "[dpdk-dev] [PATCH v2 2/2] hexdump: align output of string", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This fixes the issue where if the length of the output is not\na multiple of 16 the formatting was off.\n\nBefore:\n00000000: 45 00 00 1C 12 34 2C E0 40 06 B8 2E C0 A8 01 12 | E....4,.@.......\n00000010: C0 A8 01 37 | | | | | | | | | | | | | ...7\n\nAfter:\n00000000: 45 00 00 1C 12 34 2C E0 40 06 B8 2E C0 A8 01 12 | E....4,.@.......\n00000010: C0 A8 01 37 | ...7\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/librte_eal/common/eal_common_hexdump.c | 11 +++++++++--\n 1 file changed, 9 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_hexdump.c b/lib/librte_eal/common/eal_common_hexdump.c\nindex 6af818beb3cb..2d2179d4114e 100644\n--- a/lib/librte_eal/common/eal_common_hexdump.c\n+++ b/lib/librte_eal/common/eal_common_hexdump.c\n@@ -23,9 +23,16 @@ rte_hexdump(FILE *f, const char *title, const void *buf, unsigned int len)\n \twhile (ofs < len) {\n \t\t/* format the line in the buffer */\n \t\tout = snprintf(line, LINE_LEN, \"%08X:\", ofs);\n-\t\tfor (i = 0; i < 16 && ofs + i < len; i++)\n-\t\t\tout += snprintf(line + out, LINE_LEN - out,\n+\t\tfor (i = 0; i < 16; i++) {\n+\t\t\tif (ofs + i < len)\n+\t\t\t\tsnprintf(line + out, LINE_LEN - out,\n \t\t\t\t\t \" %02X\", (data[ofs + i] & 0xff));\n+\t\t\telse\n+\t\t\t\tstrcpy(line + out, \" \");\n+\t\t\tout += 3;\n+\t\t}\n+\n+\n \t\tfor (; i <= 16; i++)\n \t\t\tout += snprintf(line + out, LINE_LEN - out, \" | \");\n \n", "prefixes": [ "v2", "2/2" ] }