Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 52038,
    "url": "http://patches.dpdk.org/api/patches/52038/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190402035458.14664-3-anand.rawat@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190402035458.14664-3-anand.rawat@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190402035458.14664-3-anand.rawat@intel.com",
    "date": "2019-04-02T03:54:50",
    "name": "[v8,02/10] meson: required changes for windows",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "9cc9670a727b338363ccc84b2fdc055314c0afcc",
    "submitter": {
        "id": 1231,
        "url": "http://patches.dpdk.org/api/people/1231/?format=api",
        "name": "Anand Rawat",
        "email": "anand.rawat@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190402035458.14664-3-anand.rawat@intel.com/mbox/",
    "series": [
        {
            "id": 4042,
            "url": "http://patches.dpdk.org/api/series/4042/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4042",
            "date": "2019-04-02T03:54:48",
            "name": "HelloWorld example for Windows",
            "version": 8,
            "mbox": "http://patches.dpdk.org/series/4042/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/52038/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/52038/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7C0525B12;\n\tTue,  2 Apr 2019 05:55:07 +0200 (CEST)",
            "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id E0A735699\n\tfor <dev@dpdk.org>; Tue,  2 Apr 2019 05:55:01 +0200 (CEST)",
            "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t01 Apr 2019 20:55:00 -0700",
            "from anandraw-devbx.amr.corp.intel.com ([10.19.242.57])\n\tby orsmga004.jf.intel.com with ESMTP; 01 Apr 2019 20:54:59 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.60,298,1549958400\"; d=\"scan'208\";a=\"287910251\"",
        "From": "Anand Rawat <anand.rawat@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "anand.rawat@intel.com, pallavi.kadam@intel.com, ranjit.menon@intel.com, \n\tjeffrey.b.shaw@intel.com, bruce.richardson@intel.com, thomas@monjalon.net",
        "Date": "Mon,  1 Apr 2019 20:54:50 -0700",
        "Message-Id": "<20190402035458.14664-3-anand.rawat@intel.com>",
        "X-Mailer": "git-send-email 2.17.1.windows.2",
        "In-Reply-To": "<20190402035458.14664-1-anand.rawat@intel.com>",
        "References": "<20190306041634.12976-1-anand.rawat@intel.com>\n\t<20190402035458.14664-1-anand.rawat@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v8 02/10] meson: required changes for windows",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "These are the required meson changes for Windows.\nkernel/windows/meson is a stub file added to support\nWindows specific source in future releases.\n\nSigned-off-by: Anand Rawat <anand.rawat@intel.com>\nSigned-off-by: Pallavi Kadam <pallavi.kadam@intel.com>\nReviewed-by: Jeff Shaw <jeffrey.b.shaw@intel.com>\nReviewed-by: Ranjit Menon <ranjit.menon@intel.com>\n---\n config/meson.build                     | 23 ++++++++++++++++-------\n config/x86/meson.build                 | 14 ++++++++------\n kernel/windows/meson.build             |  4 ++++\n lib/librte_eal/meson.build             |  6 +++++-\n lib/librte_eal/windows/eal/meson.build | 10 ++++++++++\n 5 files changed, 43 insertions(+), 14 deletions(-)\n create mode 100644 kernel/windows/meson.build\n create mode 100644 lib/librte_eal/windows/eal/meson.build",
    "diff": "diff --git a/config/meson.build b/config/meson.build\nindex 30a7261a5..483139b10 100644\n--- a/config/meson.build\n+++ b/config/meson.build\n@@ -1,5 +1,5 @@\n # SPDX-License-Identifier: BSD-3-Clause\n-# Copyright(c) 2017 Intel Corporation\n+# Copyright(c) 2017-2019 Intel Corporation\n \n # set the major version, which might be used by drivers and libraries\n # depending on the configuration options\n@@ -80,18 +80,27 @@ dpdk_extra_ldflags += '-Wl,--no-as-needed'\n add_project_link_arguments('-pthread', language: 'c')\n dpdk_extra_ldflags += '-pthread'\n \n-# some libs depend on maths lib\n-add_project_link_arguments('-lm', language: 'c')\n-dpdk_extra_ldflags += '-lm'\n+# on some OS, maths functions are in a separate library\n+if cc.find_library('libm', required : false).found()\n+\t# some libs depend on maths lib\n+\tadd_project_link_arguments('-lm', language: 'c')\n+\tdpdk_extra_ldflags += '-lm'\n+endif\n \n # for linux link against dl, for bsd execinfo\n if host_machine.system() == 'linux'\n \tlink_lib = 'dl'\n-else\n+elif host_machine.system() == 'freebsd'\n \tlink_lib = 'execinfo'\n+else\n+\tlink_lib = ''\n+endif\n+\n+# if link_lib is empty, do not add it to project properties\n+if link_lib != ''\n+\tadd_project_link_arguments('-l' + link_lib, language: 'c')\n+\tdpdk_extra_ldflags += '-l' + link_lib\n endif\n-add_project_link_arguments('-l' + link_lib, language: 'c')\n-dpdk_extra_ldflags += '-l' + link_lib\n \n # check for libraries used in multiple places in DPDK\n has_libnuma = 0\ndiff --git a/config/x86/meson.build b/config/x86/meson.build\nindex 7504cb9e5..558edfda9 100644\n--- a/config/x86/meson.build\n+++ b/config/x86/meson.build\n@@ -1,15 +1,17 @@\n # SPDX-License-Identifier: BSD-3-Clause\n-# Copyright(c) 2017 Intel Corporation\n+# Copyright(c) 2017-2019 Intel Corporation\n \n # for checking defines we need to use the correct compiler flags\n march_opt = ['-march=@0@'.format(machine)]\n \n # get binutils version for the workaround of Bug 97\n-ldver = run_command('ld', '-v').stdout().strip()\n-if ldver.contains('2.30')\n-\tif cc.has_argument('-mno-avx512f')\n-\t\tmarch_opt += '-mno-avx512f'\n-\t\tmessage('Binutils 2.30 detected, disabling AVX512 support as workaround for bug #97')\n+if host_machine.system() != 'windows'\n+\tldver = run_command('ld', '-v').stdout().strip()\n+\tif ldver.contains('2.30')\n+\t\tif cc.has_argument('-mno-avx512f')\n+\t\t\tmarch_opt += '-mno-avx512f'\n+\t\t\tmessage('Binutils 2.30 detected, disabling AVX512 support as workaround for bug #97')\n+\t\tendif\n \tendif\n endif\n \ndiff --git a/kernel/windows/meson.build b/kernel/windows/meson.build\nnew file mode 100644\nindex 000000000..94c47682d\n--- /dev/null\n+++ b/kernel/windows/meson.build\n@@ -0,0 +1,4 @@\n+# SPDX-License-Identifier: BSD-3-Clause\n+# Copyright(c) 2019 Intel Corporation\n+\n+# stub file for supporting Windows logic in future release\ndiff --git a/lib/librte_eal/meson.build b/lib/librte_eal/meson.build\nindex d48c5e11d..1863622c0 100644\n--- a/lib/librte_eal/meson.build\n+++ b/lib/librte_eal/meson.build\n@@ -1,5 +1,5 @@\n # SPDX-License-Identifier: BSD-3-Clause\n-# Copyright(c) 2017 Intel Corporation\n+# Copyright(c) 2017-2019 Intel Corporation\n \n # Custom EAL processing. EAL is complicated enough that it can't just\n # have a straight list of headers and source files.\n@@ -17,6 +17,10 @@ elif host_machine.system() == 'freebsd'\n \tdpdk_conf.set('RTE_EXEC_ENV_FREEBSD', 1)\n \tsubdir('freebsd/eal')\n \n+elif host_machine.system() == 'windows'\n+\tdpdk_conf.set('RTE_EXEC_ENV_WINDOWS', 1)\n+\tsubdir('windows/eal')\n+\n else\n \terror('unsupported system type \"@0@\"'.format(host_machine.system()))\n endif\ndiff --git a/lib/librte_eal/windows/eal/meson.build b/lib/librte_eal/windows/eal/meson.build\nnew file mode 100644\nindex 000000000..8b1735623\n--- /dev/null\n+++ b/lib/librte_eal/windows/eal/meson.build\n@@ -0,0 +1,10 @@\n+# SPDX-License-Identifier: BSD-3-Clause\n+# Copyright(c) 2019 Intel Corporation\n+\n+env_objs = []\n+env_headers = []\n+env_sources = files('eal.c',\n+\t'eal_debug.c',\n+\t'eal_lcore.c',\n+\t'eal_thread.c',\n+)\n",
    "prefixes": [
        "v8",
        "02/10"
    ]
}