Patch Comment List
List patch comments
GET /api/patches/52/comments/?format=api
[ { "id": 514, "web_url": "http://patches.dpdk.org/comment/514/", "msgid": "<1982600.IVFo8mPmpM@xps13>", "list_archive_url": "https://inbox.dpdk.org/dev/1982600.IVFo8mPmpM@xps13", "date": "2014-08-27T15:36:39", "subject": "Re: [dpdk-dev] [PATCH 2/3] app/testpmd: enable RSS support for i40e", "submitter": { "id": 1, "url": "http://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "content": "2014-07-18 10:45, Helin Zhang:\n> i40e can support RSS no matter if SR-IOV is enabled or not, while\n> ixgbe/igb can not support RSS if it is SR-IOV. Code changes are\n> needed to support i40e RSS if SR-IOV is enabled.\n[...]\n> -\t\t/* In SR-IOV mode, RSS mode is not available */\n> -\t\tif (port->dcb_flag == 0 && port->dev_info.max_vfs == 0) {\n> +\t\t/**\n> +\t\t * For i40e, RSS is always available.\n> +\t\t * For non-i40e, RSS is available in non-SRIOV mode,\n> +\t\t * according to datasheet.\n> +\t\t */\n> +\t\tif (port->dcb_flag == 0 &&\n> +\t\t\t((port->dev_info.max_vfs == 0) ||\n> +\t\t\t(!strcmp(port->dev_info.driver_name,\n> +\t\t\t\t\t\"rte_i40e_pmd\")) ||\n> +\t\t\t(!strcmp(port->dev_info.driver_name,\n> +\t\t\t\t\t\"rte_i40evf_pmd\")))) {\n\nThis kind of knowledge should be coded in the drivers.\nApplication writer doesn't have to read the datasheet to use the drivers.\nI think returning an error in the driver could be enough to handle it at\napplication level.\n\nThanks", "headers": { "Return-Path": "<thomas.monjalon@6wind.com>", "Received": [ "from mail-we0-f174.google.com (mail-we0-f174.google.com\n\t[74.125.82.174]) by dpdk.org (Postfix) with ESMTP id 63B84B377\n\tfor <dev@dpdk.org>; Wed, 27 Aug 2014 17:32:44 +0200 (CEST)", "by mail-we0-f174.google.com with SMTP id x48so402080wes.5\n\tfor <dev@dpdk.org>; Wed, 27 Aug 2014 08:36:47 -0700 (PDT)", "from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by mx.google.com with ESMTPSA id\n\tj7sm24985521wia.9.2014.08.27.08.36.45 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 27 Aug 2014 08:36:46 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=JnLjM6iWO3XlE0JsPYhgAxt9soymYAjdY6+z63THm/8=;\n\tb=gSNZo2uC6k0f5HHgLJZ3n+vNXyzyPSo6RcVjocMfUiDOMUO3UoYjJhSyYeDI98bGTk\n\tdpcViSVLMS8trplz3DZFjljEkOB1mgFa5ERtQmohIIY6wToWiSr5JeCXUD6wMlIk6Yw9\n\tPAaH9YmFwN1UpLGKnQHwGAcoO6mKMQ9vo/Iw0FYSDY2/TpOu43bDS80RVsIau+0e9S0y\n\tIMIjwvmR29MGqpYPYt0n9Wg0MOYhRQPoZJ2uBoqcJvKrPiZQ369MPwweEG8fiQ6nvqIi\n\trWOs+FaJoNW6kh8vzFeeXLtkICSOJ48e94VdWjmYNQuDzXEtWU0SwfexME5NTCrlSqYF\n\tgRzA==", "X-Gm-Message-State": "ALoCoQmincjLaya3JQvF8EMPlfbHr7fqElG9zawgBBZqv61Xfj9pxWSSUDIuMIgm3HzmoDDaCV+C", "X-Received": "by 10.180.73.139 with SMTP id l11mr29343938wiv.30.1409153807446; \n\tWed, 27 Aug 2014 08:36:47 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "Helin Zhang <helin.zhang@intel.com>", "Date": "Wed, 27 Aug 2014 17:36:39 +0200", "Message-ID": "<1982600.IVFo8mPmpM@xps13>", "Organization": "6WIND", "User-Agent": "KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; )", "In-Reply-To": "<1405651521-14545-3-git-send-email-helin.zhang@intel.com>", "References": "<1405651521-14545-1-git-send-email-helin.zhang@intel.com>\n\t<1405651521-14545-3-git-send-email-helin.zhang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [PATCH 2/3] app/testpmd: enable RSS support for i40e", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Wed, 27 Aug 2014 15:32:44 -0000" }, "addressed": null } ]