Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/51909/?format=api
{ "id": 51909, "url": "http://patches.dpdk.org/api/patches/51909/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/b2e4acda1bb373cf241f47bc577cc887212a796a.1553868063.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<b2e4acda1bb373cf241f47bc577cc887212a796a.1553868063.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/b2e4acda1bb373cf241f47bc577cc887212a796a.1553868063.git.anatoly.burakov@intel.com", "date": "2019-03-29T14:01:29", "name": "[v4] mem: warn user when running without NUMA support", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ea49d21332f27130a676508d564667c09f074eff", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/b2e4acda1bb373cf241f47bc577cc887212a796a.1553868063.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 3998, "url": "http://patches.dpdk.org/api/series/3998/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3998", "date": "2019-03-29T14:01:29", "name": "[v4] mem: warn user when running without NUMA support", "version": 4, "mbox": "http://patches.dpdk.org/series/3998/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/51909/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/51909/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D35164C8D;\n\tFri, 29 Mar 2019 15:01:33 +0100 (CET)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 343FE3256;\n\tFri, 29 Mar 2019 15:01:32 +0100 (CET)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t29 Mar 2019 07:01:31 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby fmsmga005.fm.intel.com with ESMTP; 29 Mar 2019 07:01:30 -0700", "from sivswdev05.ir.intel.com (sivswdev05.ir.intel.com\n\t[10.243.17.64])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tx2TE1Tqw031694; Fri, 29 Mar 2019 14:01:29 GMT", "from sivswdev05.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev05.ir.intel.com with ESMTP id x2TE1TJo006040;\n\tFri, 29 Mar 2019 14:01:29 GMT", "(from aburakov@localhost)\n\tby sivswdev05.ir.intel.com with LOCAL id x2TE1TRB006036;\n\tFri, 29 Mar 2019 14:01:29 GMT" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,284,1549958400\"; d=\"scan'208\";a=\"333208969\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, stable@dpdk.org", "Date": "Fri, 29 Mar 2019 14:01:29 +0000", "Message-Id": "<b2e4acda1bb373cf241f47bc577cc887212a796a.1553868063.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": "<a5aec94e8cb4c238a2b5957ccb2a85b33ef78b94.1553862634.git.anatoly.burakov@intel.com>", "References": "<a5aec94e8cb4c238a2b5957ccb2a85b33ef78b94.1553862634.git.anatoly.burakov@intel.com>", "Subject": "[dpdk-dev] [PATCH v4] mem: warn user when running without NUMA\n\tsupport", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Running in non-legacy mode on a NUMA-enabled system without libnuma\nis unsupported, so explicitly print out a warning when trying to\ndo so.\n\nRunning in legacy mode without libnuma is still supported whether or\nnot we are running with libnuma support enabled, so also fix init to\nallow that scenario.\n\nCc: stable@dpdk.org\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n\nNotes:\n v4:\n - Fix missing __func__ in the print\n v3:\n - Fix compile issues\n\n lib/librte_eal/common/eal_options.h | 2 ++\n lib/librte_eal/linux/eal/eal_memalloc.c | 4 ++++\n lib/librte_eal/linux/eal/eal_memory.c | 14 ++++++++++++--\n 3 files changed, 18 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_options.h b/lib/librte_eal/common/eal_options.h\nindex 58ee9ae33..9855429e5 100644\n--- a/lib/librte_eal/common/eal_options.h\n+++ b/lib/librte_eal/common/eal_options.h\n@@ -5,6 +5,8 @@\n #ifndef EAL_OPTIONS_H\n #define EAL_OPTIONS_H\n \n+#include \"getopt.h\"\n+\n enum {\n \t/* long options mapped to a short option */\n #define OPT_HELP \"help\"\ndiff --git a/lib/librte_eal/linux/eal/eal_memalloc.c b/lib/librte_eal/linux/eal/eal_memalloc.c\nindex b6fb183db..36962d0b6 100644\n--- a/lib/librte_eal/linux/eal/eal_memalloc.c\n+++ b/lib/librte_eal/linux/eal/eal_memalloc.c\n@@ -725,6 +725,10 @@ alloc_seg(struct rte_memseg *ms, void *addr, int socket_id,\n \t\t\t__func__, socket_id, cur_socket_id);\n \t\tgoto mapped;\n \t}\n+#else\n+\tif (rte_socket_count() > 1)\n+\t\tRTE_LOG(DEBUG, EAL, \"%s(): not checking hugepage NUMA node.\\n\",\n+\t\t\t\t__func__);\n #endif\n \n \tms->addr = addr;\ndiff --git a/lib/librte_eal/linux/eal/eal_memory.c b/lib/librte_eal/linux/eal/eal_memory.c\nindex 1b96b576e..e5a0e57ff 100644\n--- a/lib/librte_eal/linux/eal/eal_memory.c\n+++ b/lib/librte_eal/linux/eal/eal_memory.c\n@@ -50,6 +50,7 @@\n #include \"eal_internal_cfg.h\"\n #include \"eal_filesystem.h\"\n #include \"eal_hugepages.h\"\n+#include \"eal_options.h\"\n \n #define PFN_MASK_SIZE\t8\n \n@@ -2088,7 +2089,8 @@ memseg_primary_init_32(void)\n \t\tsocket_id = rte_socket_id_by_idx(i);\n \n #ifndef RTE_EAL_NUMA_AWARE_HUGEPAGES\n-\t\tif (socket_id > 0)\n+\t\t/* we can still sort pages by socket in legacy mode */\n+\t\tif (!internal_config.legacy_mem && socket_id > 0)\n \t\t\tbreak;\n #endif\n \n@@ -2269,7 +2271,8 @@ memseg_primary_init(void)\n \t\t\tint socket_id = rte_socket_id_by_idx(i);\n \n #ifndef RTE_EAL_NUMA_AWARE_HUGEPAGES\n-\t\t\tif (socket_id > 0)\n+\t\t\t/* we can still sort pages by socket in legacy mode */\n+\t\t\tif (!internal_config.legacy_mem && socket_id > 0)\n \t\t\t\tbreak;\n #endif\n \t\t\tmemtypes[cur_type].page_sz = hugepage_sz;\n@@ -2428,6 +2431,13 @@ rte_eal_memseg_init(void)\n \t} else {\n \t\tRTE_LOG(ERR, EAL, \"Cannot get current resource limits\\n\");\n \t}\n+#ifndef RTE_EAL_NUMA_AWARE_HUGEPAGES\n+\tif (!internal_config.legacy_mem && rte_socket_count() > 1) {\n+\t\tRTE_LOG(WARNING, EAL, \"DPDK is running on a NUMA system, but is compiled without NUMA support.\\n\");\n+\t\tRTE_LOG(WARNING, EAL, \"This will have adverse consequences for performance and usability.\\n\");\n+\t\tRTE_LOG(WARNING, EAL, \"Please use --\"OPT_LEGACY_MEM\" option, or recompile with NUMA support.\\n\");\n+\t}\n+#endif\n \n \treturn rte_eal_process_type() == RTE_PROC_PRIMARY ?\n #ifndef RTE_ARCH_64\n", "prefixes": [ "v4" ] }