Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 51831,
    "url": "http://patches.dpdk.org/api/patches/51831/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190328022115.4660-9-anand.rawat@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190328022115.4660-9-anand.rawat@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190328022115.4660-9-anand.rawat@intel.com",
    "date": "2019-03-28T02:21:15",
    "name": "[v6,8/8] build: meson changes to build on windows",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "ae83eb69c25b82828016c1b92e6f94d1ea48bae0",
    "submitter": {
        "id": 1231,
        "url": "http://patches.dpdk.org/api/people/1231/?format=api",
        "name": "Anand Rawat",
        "email": "anand.rawat@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190328022115.4660-9-anand.rawat@intel.com/mbox/",
    "series": [
        {
            "id": 3962,
            "url": "http://patches.dpdk.org/api/series/3962/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3962",
            "date": "2019-03-28T02:21:09",
            "name": "HelloWorld example for windows",
            "version": 6,
            "mbox": "http://patches.dpdk.org/series/3962/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/51831/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/51831/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 11F846C9B;\n\tThu, 28 Mar 2019 03:21:48 +0100 (CET)",
            "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id E42305F16\n\tfor <dev@dpdk.org>; Thu, 28 Mar 2019 03:21:19 +0100 (CET)",
            "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t27 Mar 2019 19:21:16 -0700",
            "from anandraw-devbx.amr.corp.intel.com ([10.19.242.57])\n\tby fmsmga006.fm.intel.com with ESMTP; 27 Mar 2019 19:21:16 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.60,278,1549958400\"; d=\"scan'208\";a=\"331369626\"",
        "From": "Anand Rawat <anand.rawat@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "anand.rawat@intel.com, pallavi.kadam@intel.com, ranjit.menon@intel.com, \n\tjeffrey.b.shaw@intel.com, bruce.richardson@intel.com, thomas@monjalon.net",
        "Date": "Wed, 27 Mar 2019 19:21:15 -0700",
        "Message-Id": "<20190328022115.4660-9-anand.rawat@intel.com>",
        "X-Mailer": "git-send-email 2.17.1.windows.2",
        "In-Reply-To": "<20190328022115.4660-1-anand.rawat@intel.com>",
        "References": "<20190306041634.12976-1-anand.rawat@intel.com>\n\t<20190328022115.4660-1-anand.rawat@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v6 8/8] build: meson changes to build on windows",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Added meson workarounds to build helloworld on windows.\nWindows currently only supports kvargs and eal libraries.\nThis change restricts the build flow to supported libraries\nonly.\n\nSigned-off-by: Anand Rawat <anand.rawat@intel.com>\nSigned-off-by: Pallavi Kadam <pallavi.kadam@intel.com>\nReviewed-by: Jeff Shaw <jeffrey.b.shaw@intel.com>\nReviewed-by: Ranjit Menon <ranjit.menon@intel.com>\n---\n app/meson.build                   |  6 +++++-\n buildtools/meson.build            |  6 +++++-\n drivers/meson.build               |  6 +++++-\n examples/meson.build              |  6 +++++-\n kernel/windows/meson.build        |  4 ++++\n lib/librte_eal/common/meson.build | 14 +++++++++-----\n lib/meson.build                   |  4 ++++\n 7 files changed, 37 insertions(+), 9 deletions(-)\n create mode 100644 kernel/windows/meson.build",
    "diff": "diff --git a/app/meson.build b/app/meson.build\nindex aa353f657..e949624b7 100644\n--- a/app/meson.build\n+++ b/app/meson.build\n@@ -1,5 +1,9 @@\n # SPDX-License-Identifier: BSD-3-Clause\n-# Copyright(c) 2017 Intel Corporation\n+# Copyright(c) 2017-2019 Intel Corporation\n+\n+if host_machine.system() == 'windows'\n+\tsubdir_done()\n+endif\n \n apps = [\n \t'pdump',\ndiff --git a/buildtools/meson.build b/buildtools/meson.build\nindex cdd38ed24..0209bec8f 100644\n--- a/buildtools/meson.build\n+++ b/buildtools/meson.build\n@@ -1,5 +1,9 @@\n # SPDX-License-Identifier: BSD-3-Clause\n-# Copyright(c) 2017 Intel Corporation\n+# Copyright(c) 2017-2019 Intel Corporation\n+\n+if host_machine.system() == 'windows'\n+\tsubdir_done()\n+endif\n \n subdir('pmdinfogen')\n \ndiff --git a/drivers/meson.build b/drivers/meson.build\nindex 8c76a5659..7520a16e3 100644\n--- a/drivers/meson.build\n+++ b/drivers/meson.build\n@@ -1,5 +1,9 @@\n # SPDX-License-Identifier: BSD-3-Clause\n-# Copyright(c) 2017 Intel Corporation\n+# Copyright(c) 2017-2019 Intel Corporation\n+\n+if host_machine.system() == 'windows'\n+\tsubdir_done()\n+endif\n \n # Defines the order in which the drivers are buit.\n dpdk_driver_classes = ['common',\ndiff --git a/examples/meson.build b/examples/meson.build\nindex af81c762e..bc1430fa8 100644\n--- a/examples/meson.build\n+++ b/examples/meson.build\n@@ -35,7 +35,11 @@ foreach example: examples\n \n \text_deps = [execinfo]\n \tincludes = [include_directories(example)]\n-\tdeps = ['eal', 'mempool', 'net', 'mbuf', 'ethdev', 'cmdline']\n+\tif host_machine.system() != 'windows'\n+\t\tdeps = ['eal', 'mempool', 'net', 'mbuf', 'ethdev', 'cmdline']\n+\telse\n+\t\tdeps = ['eal'] # only supported lib on windows currently\n+\tendif\n \tsubdir(example)\n \n \tif build\ndiff --git a/kernel/windows/meson.build b/kernel/windows/meson.build\nnew file mode 100644\nindex 000000000..c4a2a656a\n--- /dev/null\n+++ b/kernel/windows/meson.build\n@@ -0,0 +1,4 @@\n+# SPDX-License-Identifier: BSD-3-Clause\n+# Copyright(c) 2019 Intel Corporation\n+\n+# stub file for supporting windows logic in future release\n\\ No newline at end of file\ndiff --git a/lib/librte_eal/common/meson.build b/lib/librte_eal/common/meson.build\nindex 5ecae0b1f..e9021c00c 100644\n--- a/lib/librte_eal/common/meson.build\n+++ b/lib/librte_eal/common/meson.build\n@@ -1,23 +1,26 @@\n # SPDX-License-Identifier: BSD-3-Clause\n-# Copyright(c) 2017 Intel Corporation\n+# Copyright(c) 2017-2019 Intel Corporation\n \n eal_inc += include_directories('.', 'include',\n \t\tjoin_paths('include/arch', arch_subdir))\n \n common_objs = []\n+common_sources = files(\n+\t\t'eal_common_errno.c',\n+\t\t'eal_common_launch.c',\n+\t\t'eal_common_lcore.c',\n+\t\t'eal_common_log.c'\n+\t)\n+if host_machine.system() != 'windows'\n common_sources = files(\n \t'eal_common_bus.c',\n \t'eal_common_cpuflags.c',\n \t'eal_common_class.c',\n \t'eal_common_devargs.c',\n \t'eal_common_dev.c',\n-\t'eal_common_errno.c',\n \t'eal_common_fbarray.c',\n \t'eal_common_hexdump.c',\n \t'eal_common_hypervisor.c',\n-\t'eal_common_launch.c',\n-\t'eal_common_lcore.c',\n-\t'eal_common_log.c',\n \t'eal_common_memalloc.c',\n \t'eal_common_memory.c',\n \t'eal_common_memzone.c',\n@@ -38,6 +41,7 @@ common_sources = files(\n \t'rte_reciprocal.c',\n \t'rte_service.c'\n )\n+endif\n \n # get architecture specific sources and objs\n eal_common_arch_sources = []\ndiff --git a/lib/meson.build b/lib/meson.build\nindex 9cba4662e..d3e556ae3 100644\n--- a/lib/meson.build\n+++ b/lib/meson.build\n@@ -30,6 +30,10 @@ libraries = [\n \t# flow_classify lib depends on pkt framework table lib\n \t'flow_classify', 'bpf', 'telemetry']\n \n+if host_machine.system() == 'windows'\n+\tlibraries = ['kvargs','eal'] # override libraries for windows\n+endif\n+\n default_cflags = machine_args\n if cc.has_argument('-Wno-format-truncation')\n \tdefault_cflags += '-Wno-format-truncation'\n",
    "prefixes": [
        "v6",
        "8/8"
    ]
}