Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 51821,
    "url": "http://patches.dpdk.org/api/patches/51821/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190327210843.13813-2-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190327210843.13813-2-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190327210843.13813-2-stephen@networkplumber.org",
    "date": "2019-03-27T21:08:42",
    "name": "[1/2] net/netvsc: fix lgtm static checker complaint",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "d1b784d565e747377dae6b5b244cf5a3c0964da5",
    "submitter": {
        "id": 27,
        "url": "http://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190327210843.13813-2-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 3959,
            "url": "http://patches.dpdk.org/api/series/3959/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3959",
            "date": "2019-03-27T21:08:41",
            "name": "minor lgtm warning fixes",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/3959/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/51821/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/51821/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 58A044CAB;\n\tWed, 27 Mar 2019 22:08:52 +0100 (CET)",
            "from mail-pl1-f195.google.com (mail-pl1-f195.google.com\n\t[209.85.214.195]) by dpdk.org (Postfix) with ESMTP id 41F4F11A4\n\tfor <dev@dpdk.org>; Wed, 27 Mar 2019 22:08:48 +0100 (CET)",
            "by mail-pl1-f195.google.com with SMTP id g12so3890801pll.11\n\tfor <dev@dpdk.org>; Wed, 27 Mar 2019 14:08:48 -0700 (PDT)",
            "from shemminger-XPS-13-9360.lan (204-195-22-127.wavecable.com.\n\t[204.195.22.127]) by smtp.gmail.com with ESMTPSA id\n\tl69sm19421348pga.73.2019.03.27.14.08.45\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 27 Mar 2019 14:08:46 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=6MHyJmT0vJaMBBZ2ZqXJzl1nO2TTpXumzwsQYNtPGwA=;\n\tb=XaBHM9LTepRmLl/CJeqtfQYq2IYC9JGV1lv+zobPPivTZ9vHKB7/KcLxATGagosYz/\n\tOsJpLPmc/D3RtBQWhH9APOAandeWWHlTlil2S2roJSKyO9yhi7/xsBkBUyVDxsJyVYhM\n\tfLuIXjmG4ScOexd1iZ4Ydi19ve6LS5cvZsJlWKuSpWNJWZ6DSu4gRaGkS3uaPTbp4t3T\n\thDgEBGPTAkHvn+EBKVxHKoOoaoEbE3wggMzaCLA4sEyVvrVY07WDWBcqiP3SCShyOgO6\n\t8UQ2J/5Ktyr5yfLtSIaRspSiZJpwlyWWwyPwgzAxALPd6zpWrrLt0aIBLwi4rtkba/x7\n\twM2g==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=6MHyJmT0vJaMBBZ2ZqXJzl1nO2TTpXumzwsQYNtPGwA=;\n\tb=CIsEgS5cmdBNRYL74/L/uamFEFgTlG8D8PuwtydDnQB+qOLmv8Sm7lq4LtJut58C+g\n\tb7ZVFOlyRowHTz/lVI0/D7Yj8e2CSYVUjJP0KNZ7ojZrm2tAm3I75A6UYkEtuKB1mFYP\n\tQcX4Yb/Owvo8Czr7u8TJ366juhpznCpPjRIJUlTMSCl+brYSd07jNlqGvOpoYyQEOOPD\n\tcmJOlsdI9nfHeO9qQ3fLru1V5VS3IkRAg+y0LO/VRIHVpKx4P0pKtFMibPPVEdvY1rpS\n\tGT42lAYrq9W5Qt2yIc4ccf7mXq+xcwBJtjCpz3p42V0mNkF82E71fxxkV/BM1xdFhcsl\n\tr/Bg==",
        "X-Gm-Message-State": "APjAAAXB9YqlW+SQnzfbaVgIUPNalG+7ntm8MDDaMHFeLbVNHgvXRopX\n\t00hsUDfL7bdN42cUUnYSUmuo9Q==",
        "X-Google-Smtp-Source": "APXvYqy3DybNkUj4cdkiB63ZARQEJIQQa9cp7lu8NP2krQGR8AYxEGhF3w0UyGJV+9b/c9ztmzGvmA==",
        "X-Received": "by 2002:a17:902:22f:: with SMTP id\n\t44mr39590564plc.138.1553720927502; \n\tWed, 27 Mar 2019 14:08:47 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "maxime.coquelin@redhat.com, tiwei.bie@intel.com, zhihong.wang@intel.com",
        "Cc": "dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>,\n\tStephen Hemminger <sthemmin@microsoft.com>",
        "Date": "Wed, 27 Mar 2019 14:08:42 -0700",
        "Message-Id": "<20190327210843.13813-2-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<20190327210843.13813-1-stephen@networkplumber.org>",
        "References": "<20190327210843.13813-1-stephen@networkplumber.org>",
        "Subject": "[dpdk-dev] [PATCH 1/2] net/netvsc: fix lgtm static checker complaint",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Since previous test is for mtu < 1519 the next else if\nis always true. This causes the lgtm static tool to complain.\nNot a real issue, just cosmetic.\n\nSigned-off-by: Stephen Hemminger <sthemmin@microsoft.com>\n---\n drivers/net/netvsc/hn_rxtx.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c\nindex 6197118b01ee..8818d68cea5c 100644\n--- a/drivers/net/netvsc/hn_rxtx.c\n+++ b/drivers/net/netvsc/hn_rxtx.c\n@@ -123,7 +123,7 @@ hn_update_packet_stats(struct hn_stats *stats, const struct rte_mbuf *m)\n \t\t\tstats->size_bins[0]++;\n \t\telse if (s < 1519)\n \t\t\tstats->size_bins[6]++;\n-\t\telse if (s >= 1519)\n+\t\telse\n \t\t\tstats->size_bins[7]++;\n \t}\n \n",
    "prefixes": [
        "1/2"
    ]
}