Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/51695/?format=api
{ "id": 51695, "url": "http://patches.dpdk.org/api/patches/51695/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1553581011-94181-8-git-send-email-wenzhuo.lu@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1553581011-94181-8-git-send-email-wenzhuo.lu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1553581011-94181-8-git-send-email-wenzhuo.lu@intel.com", "date": "2019-03-26T06:16:50", "name": "[v7,7/8] net/ice: support Rx scatter AVX2 vector", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "531b3939534c3810fb6067102da9c8e78773f2a6", "submitter": { "id": 258, "url": "http://patches.dpdk.org/api/people/258/?format=api", "name": "Wenzhuo Lu", "email": "wenzhuo.lu@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1553581011-94181-8-git-send-email-wenzhuo.lu@intel.com/mbox/", "series": [ { "id": 3914, "url": "http://patches.dpdk.org/api/series/3914/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3914", "date": "2019-03-26T06:16:43", "name": "Support vector instructions on ICE", "version": 7, "mbox": "http://patches.dpdk.org/series/3914/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/51695/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/51695/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0F46B5398;\n\tTue, 26 Mar 2019 07:11:44 +0100 (CET)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id 7F8F349E0\n\tfor <dev@dpdk.org>; Tue, 26 Mar 2019 07:11:25 +0100 (CET)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Mar 2019 23:11:25 -0700", "from dpdk26.sh.intel.com ([10.67.110.164])\n\tby fmsmga001.fm.intel.com with ESMTP; 25 Mar 2019 23:11:24 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,271,1549958400\"; d=\"scan'208\";a=\"158420143\"", "From": "Wenzhuo Lu <wenzhuo.lu@intel.com>", "To": "dev@dpdk.org", "Cc": "Wenzhuo Lu <wenzhuo.lu@intel.com>", "Date": "Tue, 26 Mar 2019 14:16:50 +0800", "Message-Id": "<1553581011-94181-8-git-send-email-wenzhuo.lu@intel.com>", "X-Mailer": "git-send-email 1.9.3", "In-Reply-To": "<1553581011-94181-1-git-send-email-wenzhuo.lu@intel.com>", "References": "<1551340136-83843-1-git-send-email-wenzhuo.lu@intel.com>\n\t<1553581011-94181-1-git-send-email-wenzhuo.lu@intel.com>", "Subject": "[dpdk-dev] [PATCH v7 7/8] net/ice: support Rx scatter AVX2 vector", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>\n---\n drivers/net/ice/ice_rxtx.c | 10 ++++--\n drivers/net/ice/ice_rxtx.h | 3 ++\n drivers/net/ice/ice_rxtx_vec_avx2.c | 64 +++++++++++++++++++++++++++++++++++++\n 3 files changed, 74 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c\nindex 28d5974..860155f 100644\n--- a/drivers/net/ice/ice_rxtx.c\n+++ b/drivers/net/ice/ice_rxtx.c\n@@ -1506,7 +1506,8 @@\n #ifdef RTE_ARCH_X86\n \tif (dev->rx_pkt_burst == ice_recv_pkts_vec ||\n \t dev->rx_pkt_burst == ice_recv_scattered_pkts_vec ||\n-\t dev->rx_pkt_burst == ice_recv_pkts_vec_avx2)\n+\t dev->rx_pkt_burst == ice_recv_pkts_vec_avx2 ||\n+\t dev->rx_pkt_burst == ice_recv_scattered_pkts_vec_avx2)\n \t\treturn ptypes;\n #endif\n \n@@ -2258,9 +2259,12 @@ void __attribute__((cold))\n \n \t\tif (dev->data->scattered_rx) {\n \t\t\tPMD_DRV_LOG(DEBUG,\n-\t\t\t\t \"Using Vector Scattered Rx (port %d).\",\n+\t\t\t\t \"Using %sVector Scattered Rx (port %d).\",\n+\t\t\t\t use_avx2 ? \"avx2 \" : \"\",\n \t\t\t\t dev->data->port_id);\n-\t\t\tdev->rx_pkt_burst = ice_recv_scattered_pkts_vec;\n+\t\t\tdev->rx_pkt_burst = use_avx2 ?\n+\t\t\t\t\t ice_recv_scattered_pkts_vec_avx2 :\n+\t\t\t\t\t ice_recv_scattered_pkts_vec;\n \t\t} else {\n \t\t\tPMD_DRV_LOG(DEBUG, \"Using %sVector Rx (port %d).\",\n \t\t\t\t use_avx2 ? \"avx2 \" : \"\",\ndiff --git a/drivers/net/ice/ice_rxtx.h b/drivers/net/ice/ice_rxtx.h\nindex d1c9b92..dfc3224 100644\n--- a/drivers/net/ice/ice_rxtx.h\n+++ b/drivers/net/ice/ice_rxtx.h\n@@ -181,4 +181,7 @@ uint16_t ice_xmit_pkts_vec(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\t\t uint16_t nb_pkts);\n uint16_t ice_recv_pkts_vec_avx2(void *rx_queue, struct rte_mbuf **rx_pkts,\n \t\t\t\tuint16_t nb_pkts);\n+uint16_t ice_recv_scattered_pkts_vec_avx2(void *rx_queue,\n+\t\t\t\t\t struct rte_mbuf **rx_pkts,\n+\t\t\t\t\t uint16_t nb_pkts);\n #endif /* _ICE_RXTX_H_ */\ndiff --git a/drivers/net/ice/ice_rxtx_vec_avx2.c b/drivers/net/ice/ice_rxtx_vec_avx2.c\nindex 42f761d..2459ff3 100644\n--- a/drivers/net/ice/ice_rxtx_vec_avx2.c\n+++ b/drivers/net/ice/ice_rxtx_vec_avx2.c\n@@ -620,3 +620,67 @@\n {\n \treturn _ice_recv_raw_pkts_vec_avx2(rx_queue, rx_pkts, nb_pkts, NULL);\n }\n+\n+/**\n+ * vPMD receive routine that reassembles single burst of 32 scattered packets\n+ * Notice:\n+ * - nb_pkts < ICE_DESCS_PER_LOOP, just return no packet\n+ */\n+static uint16_t\n+ice_recv_scattered_burst_vec_avx2(void *rx_queue, struct rte_mbuf **rx_pkts,\n+\t\t\t\t uint16_t nb_pkts)\n+{\n+\tstruct ice_rx_queue *rxq = rx_queue;\n+\tuint8_t split_flags[ICE_VPMD_RX_BURST] = {0};\n+\n+\t/* get some new buffers */\n+\tuint16_t nb_bufs = _ice_recv_raw_pkts_vec_avx2(rxq, rx_pkts, nb_pkts,\n+\t\t\t\t\t\t split_flags);\n+\tif (nb_bufs == 0)\n+\t\treturn 0;\n+\n+\t/* happy day case, full burst + no packets to be joined */\n+\tconst uint64_t *split_fl64 = (uint64_t *)split_flags;\n+\n+\tif (!rxq->pkt_first_seg &&\n+\t split_fl64[0] == 0 && split_fl64[1] == 0 &&\n+\t split_fl64[2] == 0 && split_fl64[3] == 0)\n+\t\treturn nb_bufs;\n+\n+\t/* reassemble any packets that need reassembly*/\n+\tunsigned int i = 0;\n+\n+\tif (!rxq->pkt_first_seg) {\n+\t\t/* find the first split flag, and only reassemble then*/\n+\t\twhile (i < nb_bufs && !split_flags[i])\n+\t\t\ti++;\n+\t\tif (i == nb_bufs)\n+\t\t\treturn nb_bufs;\n+\t}\n+\treturn i + ice_rx_reassemble_packets(rxq, &rx_pkts[i], nb_bufs - i,\n+\t\t\t\t\t &split_flags[i]);\n+}\n+\n+/**\n+ * vPMD receive routine that reassembles scattered packets.\n+ * Main receive routine that can handle arbitrary burst sizes\n+ * Notice:\n+ * - nb_pkts < ICE_DESCS_PER_LOOP, just return no packet\n+ */\n+uint16_t\n+ice_recv_scattered_pkts_vec_avx2(void *rx_queue, struct rte_mbuf **rx_pkts,\n+\t\t\t\t uint16_t nb_pkts)\n+{\n+\tuint16_t retval = 0;\n+\n+\twhile (nb_pkts > ICE_VPMD_RX_BURST) {\n+\t\tuint16_t burst = ice_recv_scattered_burst_vec_avx2(rx_queue,\n+\t\t\t\trx_pkts + retval, ICE_VPMD_RX_BURST);\n+\t\tretval += burst;\n+\t\tnb_pkts -= burst;\n+\t\tif (burst < ICE_VPMD_RX_BURST)\n+\t\t\treturn retval;\n+\t}\n+\treturn retval + ice_recv_scattered_burst_vec_avx2(rx_queue,\n+\t\t\t\trx_pkts + retval, nb_pkts);\n+}\n", "prefixes": [ "v7", "7/8" ] }