Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/51622/?format=api
{ "id": 51622, "url": "http://patches.dpdk.org/api/patches/51622/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190325103459.3228-1-andrius.sirvys@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190325103459.3228-1-andrius.sirvys@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190325103459.3228-1-andrius.sirvys@intel.com", "date": "2019-03-25T10:34:59", "name": "[v5] build: move variable definition to top level", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9bb0e56b3283183c0376373633609c32ce8b8084", "submitter": { "id": 1213, "url": "http://patches.dpdk.org/api/people/1213/?format=api", "name": "Andrius Sirvys", "email": "andrius.sirvys@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190325103459.3228-1-andrius.sirvys@intel.com/mbox/", "series": [ { "id": 3892, "url": "http://patches.dpdk.org/api/series/3892/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3892", "date": "2019-03-25T10:34:59", "name": "[v5] build: move variable definition to top level", "version": 5, "mbox": "http://patches.dpdk.org/series/3892/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/51622/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/51622/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 04D2D2BF7;\n\tMon, 25 Mar 2019 11:35:02 +0100 (CET)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id 54F472BF4\n\tfor <dev@dpdk.org>; Mon, 25 Mar 2019 11:35:00 +0100 (CET)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Mar 2019 03:34:59 -0700", "from silpixa00380299.ir.intel.com (HELO\n\tsilpixa00380299.ger.corp.intel.com) ([10.237.223.68])\n\tby orsmga007.jf.intel.com with ESMTP; 25 Mar 2019 03:34:58 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,256,1549958400\"; d=\"scan'208\";a=\"125640712\"", "From": "Andrius Sirvys <andrius.sirvys@intel.com>", "To": "dev@dpdk.org", "Cc": "bruce.richardson@intel.com,\n\tAndrius Sirvys <andrius.sirvys@intel.com>", "Date": "Mon, 25 Mar 2019 10:34:59 +0000", "Message-Id": "<20190325103459.3228-1-andrius.sirvys@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<1551958101-104223-1-git-send-email-andrius.sirvys@intel.com>", "References": "<1551958101-104223-1-git-send-email-andrius.sirvys@intel.com>", "Subject": "[dpdk-dev] [PATCH v5] build: move variable definition to top level", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If for debugging we disable the driver directory in the meson.build file,\nwe get an error because the variable \"driver_classes\" does not exist.\nThis is because driver_classes is only defined in the\ndrivers/meson.build file. Defining driver_classes in dpdk/meson.build file\nwill make it easier for compiling separate directories.\n\nIn the process, we rename driver_classes to dpdk_driver_classes for\nconsistency with the other variables.\n\nSigned-off-by: Andrius Sirvys <andrius.sirvys@intel.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\n---\nv5: Rebased off of master branch\n---\n drivers/meson.build | 4 ++--\n meson.build | 3 ++-\n 2 files changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/meson.build b/drivers/meson.build\nindex 69d0556d3..8c76a5659 100644\n--- a/drivers/meson.build\n+++ b/drivers/meson.build\n@@ -2,7 +2,7 @@\n # Copyright(c) 2017 Intel Corporation\n \n # Defines the order in which the drivers are buit.\n-driver_classes = ['common',\n+dpdk_driver_classes = ['common',\n \t 'bus',\n \t 'mempool', # depends on common and bus.\n \t 'net', # depends on common, bus and mempool.\n@@ -20,7 +20,7 @@ endif\n # specify -D_GNU_SOURCE unconditionally\n default_cflags += '-D_GNU_SOURCE'\n \n-foreach class:driver_classes\n+foreach class:dpdk_driver_classes\n \tdrivers = []\n \tstd_deps = []\n \tconfig_flag_fmt = '' # format string used to set the value in dpdk_conf\ndiff --git a/meson.build b/meson.build\nindex 69833de82..e945a27c3 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -13,6 +13,7 @@ cc = meson.get_compiler('c')\n dpdk_conf = configuration_data()\n dpdk_libraries = []\n dpdk_static_libraries = []\n+dpdk_driver_classes = []\n dpdk_drivers = []\n dpdk_extra_ldflags = []\n dpdk_app_link_libraries = []\n@@ -105,7 +106,7 @@ endforeach\n message(output_message + '\\n')\n \n output_message = '\\n===============\\nDrivers Enabled\\n===============\\n'\n-foreach class:driver_classes\n+foreach class:dpdk_driver_classes\n \tclass_drivers = get_variable(class + '_drivers')\n \toutput_message += '\\n' + class + ':\\n\\t'\n \toutput_count = 0\n", "prefixes": [ "v5" ] }