Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 51418,
    "url": "http://patches.dpdk.org/api/patches/51418/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1553102679-23576-4-git-send-email-konstantin.ananyev@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1553102679-23576-4-git-send-email-konstantin.ananyev@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1553102679-23576-4-git-send-email-konstantin.ananyev@intel.com",
    "date": "2019-03-20T17:24:35",
    "name": "[v2,3/7] ipsec: change the order in filling crypto op",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "8ec3031461d0b60ce29cfe552f5b1465128ab7ce",
    "submitter": {
        "id": 33,
        "url": "http://patches.dpdk.org/api/people/33/?format=api",
        "name": "Ananyev, Konstantin",
        "email": "konstantin.ananyev@intel.com"
    },
    "delegate": {
        "id": 6690,
        "url": "http://patches.dpdk.org/api/users/6690/?format=api",
        "username": "akhil",
        "first_name": "akhil",
        "last_name": "goyal",
        "email": "gakhil@marvell.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1553102679-23576-4-git-send-email-konstantin.ananyev@intel.com/mbox/",
    "series": [
        {
            "id": 3833,
            "url": "http://patches.dpdk.org/api/series/3833/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3833",
            "date": "2019-03-20T17:24:35",
            "name": null,
            "version": 2,
            "mbox": "http://patches.dpdk.org/series/3833/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/51418/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/51418/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1EF221B39E;\n\tWed, 20 Mar 2019 18:25:12 +0100 (CET)",
            "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby dpdk.org (Postfix) with ESMTP id 2FE251B204\n\tfor <dev@dpdk.org>; Wed, 20 Mar 2019 18:24:59 +0100 (CET)",
            "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t20 Mar 2019 10:24:52 -0700",
            "from sivswdev08.ir.intel.com (HELO localhost.localdomain)\n\t([10.237.217.47])\n\tby orsmga002.jf.intel.com with ESMTP; 20 Mar 2019 10:24:50 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.60,249,1549958400\"; d=\"scan'208\";a=\"143689971\"",
        "From": "Konstantin Ananyev <konstantin.ananyev@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "akhil.goyal@nxp.com, olivier.matz@6wind.com,\n\tKonstantin Ananyev <konstantin.ananyev@intel.com>",
        "Date": "Wed, 20 Mar 2019 17:24:35 +0000",
        "Message-Id": "<1553102679-23576-4-git-send-email-konstantin.ananyev@intel.com>",
        "X-Mailer": "git-send-email 1.7.0.7",
        "In-Reply-To": "<1551381661-21078-1-git-send-email-konstantin.ananyev@intel.com>",
        "References": "<1551381661-21078-1-git-send-email-konstantin.ananyev@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v2 3/7] ipsec: change the order in filling crypto\n\top",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Right now we first fill crypto_sym_op part of crypto_op,\nthen in a separate cycle we fill crypto op fields.\nIt makes more sense to fill whole crypto-op in one go instead.\n\nSigned-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>\n---\n lib/librte_ipsec/sa.c | 46 ++++++++++++++++++++-----------------------\n 1 file changed, 21 insertions(+), 25 deletions(-)",
    "diff": "diff --git a/lib/librte_ipsec/sa.c b/lib/librte_ipsec/sa.c\nindex 31548e968..74ed3b41e 100644\n--- a/lib/librte_ipsec/sa.c\n+++ b/lib/librte_ipsec/sa.c\n@@ -425,20 +425,17 @@ mbuf_bulk_copy(struct rte_mbuf *dst[], struct rte_mbuf * const src[],\n  * setup crypto ops for LOOKASIDE_NONE (pure crypto) type of devices.\n  */\n static inline void\n-lksd_none_cop_prepare(const struct rte_ipsec_session *ss,\n-\tstruct rte_mbuf *mb[], struct rte_crypto_op *cop[], uint16_t num)\n+lksd_none_cop_prepare(struct rte_crypto_op *cop,\n+\tstruct rte_cryptodev_sym_session *cs, struct rte_mbuf *mb)\n {\n-\tuint32_t i;\n \tstruct rte_crypto_sym_op *sop;\n \n-\tfor (i = 0; i != num; i++) {\n-\t\tsop = cop[i]->sym;\n-\t\tcop[i]->type = RTE_CRYPTO_OP_TYPE_SYMMETRIC;\n-\t\tcop[i]->status = RTE_CRYPTO_OP_STATUS_NOT_PROCESSED;\n-\t\tcop[i]->sess_type = RTE_CRYPTO_OP_WITH_SESSION;\n-\t\tsop->m_src = mb[i];\n-\t\t__rte_crypto_sym_op_attach_sym_session(sop, ss->crypto.ses);\n-\t}\n+\tsop = cop->sym;\n+\tcop->type = RTE_CRYPTO_OP_TYPE_SYMMETRIC;\n+\tcop->status = RTE_CRYPTO_OP_STATUS_NOT_PROCESSED;\n+\tcop->sess_type = RTE_CRYPTO_OP_WITH_SESSION;\n+\tsop->m_src = mb;\n+\t__rte_crypto_sym_op_attach_sym_session(sop, cs);\n }\n \n /*\n@@ -603,11 +600,13 @@ outb_tun_prepare(const struct rte_ipsec_session *ss, struct rte_mbuf *mb[],\n \tuint64_t sqn;\n \trte_be64_t sqc;\n \tstruct rte_ipsec_sa *sa;\n+\tstruct rte_cryptodev_sym_session *cs;\n \tunion sym_op_data icv;\n \tuint64_t iv[IPSEC_MAX_IV_QWORD];\n \tstruct rte_mbuf *dr[num];\n \n \tsa = ss->sa;\n+\tcs = ss->crypto.ses;\n \n \tn = num;\n \tsqn = esn_outb_update_sqn(sa, &n);\n@@ -625,10 +624,10 @@ outb_tun_prepare(const struct rte_ipsec_session *ss, struct rte_mbuf *mb[],\n \n \t\t/* success, setup crypto op */\n \t\tif (rc >= 0) {\n-\t\t\tmb[k] = mb[i];\n \t\t\toutb_pkt_xprepare(sa, sqc, &icv);\n+\t\t\tlksd_none_cop_prepare(cop[k], cs, mb[i]);\n \t\t\tesp_outb_cop_prepare(cop[k], sa, iv, &icv, 0, rc);\n-\t\t\tk++;\n+\t\t\tmb[k++] = mb[i];\n \t\t/* failure, put packet into the death-row */\n \t\t} else {\n \t\t\tdr[i - k] = mb[i];\n@@ -636,9 +635,6 @@ outb_tun_prepare(const struct rte_ipsec_session *ss, struct rte_mbuf *mb[],\n \t\t}\n \t}\n \n-\t/* update cops */\n-\tlksd_none_cop_prepare(ss, mb, cop, k);\n-\n \t /* copy not prepared mbufs beyond good ones */\n \tif (k != n && k != 0)\n \t\tmbuf_bulk_copy(mb + k, dr, n - k);\n@@ -739,11 +735,13 @@ outb_trs_prepare(const struct rte_ipsec_session *ss, struct rte_mbuf *mb[],\n \tuint64_t sqn;\n \trte_be64_t sqc;\n \tstruct rte_ipsec_sa *sa;\n+\tstruct rte_cryptodev_sym_session *cs;\n \tunion sym_op_data icv;\n \tuint64_t iv[IPSEC_MAX_IV_QWORD];\n \tstruct rte_mbuf *dr[num];\n \n \tsa = ss->sa;\n+\tcs = ss->crypto.ses;\n \n \tn = num;\n \tsqn = esn_outb_update_sqn(sa, &n);\n@@ -765,10 +763,10 @@ outb_trs_prepare(const struct rte_ipsec_session *ss, struct rte_mbuf *mb[],\n \n \t\t/* success, setup crypto op */\n \t\tif (rc >= 0) {\n-\t\t\tmb[k] = mb[i];\n \t\t\toutb_pkt_xprepare(sa, sqc, &icv);\n+\t\t\tlksd_none_cop_prepare(cop[k], cs, mb[i]);\n \t\t\tesp_outb_cop_prepare(cop[k], sa, iv, &icv, l2 + l3, rc);\n-\t\t\tk++;\n+\t\t\tmb[k++] = mb[i];\n \t\t/* failure, put packet into the death-row */\n \t\t} else {\n \t\t\tdr[i - k] = mb[i];\n@@ -776,9 +774,6 @@ outb_trs_prepare(const struct rte_ipsec_session *ss, struct rte_mbuf *mb[],\n \t\t}\n \t}\n \n-\t/* update cops */\n-\tlksd_none_cop_prepare(ss, mb, cop, k);\n-\n \t/* copy not prepared mbufs beyond good ones */\n \tif (k != n && k != 0)\n \t\tmbuf_bulk_copy(mb + k, dr, n - k);\n@@ -926,11 +921,13 @@ inb_pkt_prepare(const struct rte_ipsec_session *ss, struct rte_mbuf *mb[],\n \tint32_t rc;\n \tuint32_t i, k, hl;\n \tstruct rte_ipsec_sa *sa;\n+\tstruct rte_cryptodev_sym_session *cs;\n \tstruct replay_sqn *rsn;\n \tunion sym_op_data icv;\n \tstruct rte_mbuf *dr[num];\n \n \tsa = ss->sa;\n+\tcs = ss->crypto.ses;\n \trsn = rsn_acquire(sa);\n \n \tk = 0;\n@@ -938,9 +935,11 @@ inb_pkt_prepare(const struct rte_ipsec_session *ss, struct rte_mbuf *mb[],\n \n \t\thl = mb[i]->l2_len + mb[i]->l3_len;\n \t\trc = esp_inb_tun_pkt_prepare(sa, rsn, mb[i], hl, &icv);\n-\t\tif (rc >= 0)\n+\t\tif (rc >= 0) {\n+\t\t\tlksd_none_cop_prepare(cop[k], cs, mb[i]);\n \t\t\trc = esp_inb_tun_cop_prepare(cop[k], sa, mb[i], &icv,\n \t\t\t\thl, rc);\n+\t\t}\n \n \t\tif (rc == 0)\n \t\t\tmb[k++] = mb[i];\n@@ -952,9 +951,6 @@ inb_pkt_prepare(const struct rte_ipsec_session *ss, struct rte_mbuf *mb[],\n \n \trsn_release(sa, rsn);\n \n-\t/* update cops */\n-\tlksd_none_cop_prepare(ss, mb, cop, k);\n-\n \t/* copy not prepared mbufs beyond good ones */\n \tif (k != num && k != 0)\n \t\tmbuf_bulk_copy(mb + k, dr, num - k);\n",
    "prefixes": [
        "v2",
        "3/7"
    ]
}