Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/51360/?format=api
{ "id": 51360, "url": "http://patches.dpdk.org/api/patches/51360/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190320004050.13184-9-anand.rawat@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190320004050.13184-9-anand.rawat@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190320004050.13184-9-anand.rawat@intel.com", "date": "2019-03-20T00:40:50", "name": "[v3,8/8] build: meson changes to build on windows", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a1e0e51be47aea7b57fdf0c4157fbf3bf1e16428", "submitter": { "id": 1231, "url": "http://patches.dpdk.org/api/people/1231/?format=api", "name": "Anand Rawat", "email": "anand.rawat@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190320004050.13184-9-anand.rawat@intel.com/mbox/", "series": [ { "id": 3807, "url": "http://patches.dpdk.org/api/series/3807/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3807", "date": "2019-03-20T00:40:42", "name": "HelloWorld example for windows", "version": 3, "mbox": "http://patches.dpdk.org/series/3807/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/51360/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/51360/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5E3CC54AE;\n\tWed, 20 Mar 2019 01:41:16 +0100 (CET)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id 316112956\n\tfor <dev@dpdk.org>; Wed, 20 Mar 2019 01:40:55 +0100 (CET)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t19 Mar 2019 17:40:52 -0700", "from anandraw-devbx.amr.corp.intel.com ([10.19.242.57])\n\tby orsmga003.jf.intel.com with ESMTP; 19 Mar 2019 17:40:52 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,246,1549958400\"; d=\"scan'208\";a=\"135513438\"", "From": "Anand Rawat <anand.rawat@intel.com>", "To": "dev@dpdk.org", "Cc": "anand.rawat@intel.com, pallavi.kadam@intel.com, ranjit.menon@intel.com, \n\tjeffrey.b.shaw@intel.com, bruce.richardson@intel.com, thomas@monjalon.net", "Date": "Tue, 19 Mar 2019 17:40:50 -0700", "Message-Id": "<20190320004050.13184-9-anand.rawat@intel.com>", "X-Mailer": "git-send-email 2.17.1.windows.2", "In-Reply-To": "<20190320004050.13184-1-anand.rawat@intel.com>", "References": "<20190306041634.12976-1-anand.rawat@intel.com>\n\t<20190320004050.13184-1-anand.rawat@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 8/8] build: meson changes to build on windows", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Added meson workarounds to build helloworld on windows.\nWindows currently only supports kvargs and eal libraries.\nThis change restricts the build flow to supported libraries\nonly.\n\nSigned-off-by: Anand Rawat <anand.rawat@intel.com>\nSigned-off-by: Pallavi Kadam <pallavi.kadam@intel.com>\nReviewed-by: Jeff Shaw <jeffrey.b.shaw@intel.com>\nReviewed-by: Ranjit Menon <ranjit.menon@intel.com>\n---\n examples/meson.build | 6 +-\n lib/librte_eal/common/meson.build | 159 ++++++++++++++++--------------\n lib/meson.build | 4 +\n meson.build | 33 ++++---\n 4 files changed, 113 insertions(+), 89 deletions(-)", "diff": "diff --git a/examples/meson.build b/examples/meson.build\nindex af81c762e..107e378e7 100644\n--- a/examples/meson.build\n+++ b/examples/meson.build\n@@ -35,7 +35,11 @@ foreach example: examples\n \n \text_deps = [execinfo]\n \tincludes = [include_directories(example)]\n-\tdeps = ['eal', 'mempool', 'net', 'mbuf', 'ethdev', 'cmdline']\n+\tif host_machine.system() != 'windows'\n+\t\tdeps = ['eal', 'mempool', 'net', 'mbuf', 'ethdev', 'cmdline']\n+\telse\n+\t\tdeps = ['eal']\n+\tendif\n \tsubdir(example)\n \n \tif build\ndiff --git a/lib/librte_eal/common/meson.build b/lib/librte_eal/common/meson.build\nindex 5ecae0b1f..05ebd06b6 100644\n--- a/lib/librte_eal/common/meson.build\n+++ b/lib/librte_eal/common/meson.build\n@@ -1,91 +1,102 @@\n # SPDX-License-Identifier: BSD-3-Clause\n-# Copyright(c) 2017 Intel Corporation\n+# Copyright(c) 2017-2019 Intel Corporation\n \n eal_inc += include_directories('.', 'include',\n \t\tjoin_paths('include/arch', arch_subdir))\n \n common_objs = []\n+common_headers = []\n+\n common_sources = files(\n-\t'eal_common_bus.c',\n-\t'eal_common_cpuflags.c',\n-\t'eal_common_class.c',\n-\t'eal_common_devargs.c',\n-\t'eal_common_dev.c',\n-\t'eal_common_errno.c',\n-\t'eal_common_fbarray.c',\n-\t'eal_common_hexdump.c',\n-\t'eal_common_hypervisor.c',\n-\t'eal_common_launch.c',\n-\t'eal_common_lcore.c',\n-\t'eal_common_log.c',\n-\t'eal_common_memalloc.c',\n-\t'eal_common_memory.c',\n-\t'eal_common_memzone.c',\n-\t'eal_common_options.c',\n-\t'eal_common_proc.c',\n-\t'eal_common_string_fns.c',\n-\t'eal_common_tailqs.c',\n-\t'eal_common_thread.c',\n-\t'eal_common_timer.c',\n-\t'eal_common_uuid.c',\n-\t'hotplug_mp.c',\n-\t'malloc_elem.c',\n-\t'malloc_heap.c',\n-\t'malloc_mp.c',\n-\t'rte_keepalive.c',\n-\t'rte_malloc.c',\n-\t'rte_option.c',\n-\t'rte_reciprocal.c',\n-\t'rte_service.c'\n-)\n+\t\t'eal_common_errno.c',\n+\t\t'eal_common_launch.c',\n+\t\t'eal_common_lcore.c',\n+\t\t'eal_common_log.c'\n+\t)\n+if host_machine.system() != 'windows'\n+\tcommon_sources = files(\n+\t\t'eal_common_bus.c',\n+\t\t'eal_common_cpuflags.c',\n+\t\t'eal_common_class.c',\n+\t\t'eal_common_devargs.c',\n+\t\t'eal_common_dev.c',\n+\t\t'eal_common_fbarray.c',\n+\t\t'eal_common_hexdump.c',\n+\t\t'eal_common_hypervisor.c',\n+\t\t'eal_common_memalloc.c',\n+\t\t'eal_common_memory.c',\n+\t\t'eal_common_memzone.c',\n+\t\t'eal_common_options.c',\n+\t\t'eal_common_proc.c',\n+\t\t'eal_common_string_fns.c',\n+\t\t'eal_common_tailqs.c',\n+\t\t'eal_common_thread.c',\n+\t\t'eal_common_timer.c',\n+\t\t'eal_common_uuid.c',\n+\t\t'hotplug_mp.c',\n+\t\t'malloc_elem.c',\n+\t\t'malloc_heap.c',\n+\t\t'malloc_mp.c',\n+\t\t'rte_keepalive.c',\n+\t\t'rte_malloc.c',\n+\t\t'rte_option.c',\n+\t\t'rte_reciprocal.c',\n+\t\t'rte_service.c'\n+\t)\n+endif\n \n # get architecture specific sources and objs\n eal_common_arch_sources = []\n eal_common_arch_objs = []\n-subdir(join_paths('arch', arch_subdir))\n+\n+common_headers += files(\n+\t\t'include/rte_branch_prediction.h',\n+\t\t'include/rte_bus.h',\n+\t\t'include/rte_common.h',\n+\t\t'include/rte_debug.h',\n+\t\t'include/rte_dev.h',\n+\t\t'include/rte_eal.h',\n+\t\t'include/rte_errno.h',\n+\t\t'include/rte_launch.h',\n+\t\t'include/rte_lcore.h',\n+\t\t'include/rte_log.h',\n+\t\t'include/rte_memory.h',\n+\t\t'include/rte_pci_dev_feature_defs.h',\n+\t\t'include/rte_per_lcore.h',\n+\t\t'include/rte_string_fns.h'\n+\t)\n+if host_machine.system() != 'windows'\n+\tsubdir(join_paths('arch', arch_subdir))\n+endif\n common_sources += eal_common_arch_sources\n common_objs += eal_common_arch_objs\n \n-common_headers = files(\n-\t'include/rte_alarm.h',\n-\t'include/rte_branch_prediction.h',\n-\t'include/rte_bus.h',\n-\t'include/rte_bitmap.h',\n-\t'include/rte_class.h',\n-\t'include/rte_common.h',\n-\t'include/rte_compat.h',\n-\t'include/rte_debug.h',\n-\t'include/rte_devargs.h',\n-\t'include/rte_dev.h',\n-\t'include/rte_eal.h',\n-\t'include/rte_eal_memconfig.h',\n-\t'include/rte_eal_interrupts.h',\n-\t'include/rte_errno.h',\n-\t'include/rte_fbarray.h',\n-\t'include/rte_hexdump.h',\n-\t'include/rte_hypervisor.h',\n-\t'include/rte_interrupts.h',\n-\t'include/rte_keepalive.h',\n-\t'include/rte_launch.h',\n-\t'include/rte_lcore.h',\n-\t'include/rte_log.h',\n-\t'include/rte_malloc.h',\n-\t'include/rte_malloc_heap.h',\n-\t'include/rte_memory.h',\n-\t'include/rte_memzone.h',\n-\t'include/rte_option.h',\n-\t'include/rte_pci_dev_feature_defs.h',\n-\t'include/rte_pci_dev_features.h',\n-\t'include/rte_per_lcore.h',\n-\t'include/rte_random.h',\n-\t'include/rte_reciprocal.h',\n-\t'include/rte_service.h',\n-\t'include/rte_service_component.h',\n-\t'include/rte_string_fns.h',\n-\t'include/rte_tailq.h',\n-\t'include/rte_time.h',\n-\t'include/rte_uuid.h',\n-\t'include/rte_version.h')\n+common_headers += files(\n+\t\t'include/rte_alarm.h',\n+\t\t'include/rte_bitmap.h',\n+\t\t'include/rte_class.h',\n+\t\t'include/rte_compat.h',\n+\t\t'include/rte_devargs.h',\n+\t\t'include/rte_eal_memconfig.h',\n+\t\t'include/rte_eal_interrupts.h',\n+\t\t'include/rte_fbarray.h',\n+\t\t'include/rte_hexdump.h',\n+\t\t'include/rte_hypervisor.h',\n+\t\t'include/rte_interrupts.h',\n+\t\t'include/rte_keepalive.h',\n+\t\t'include/rte_malloc.h',\n+\t\t'include/rte_malloc_heap.h',\n+\t\t'include/rte_memzone.h',\n+\t\t'include/rte_option.h',\n+\t\t'include/rte_pci_dev_features.h',\n+\t\t'include/rte_random.h',\n+\t\t'include/rte_reciprocal.h',\n+\t\t'include/rte_service.h',\n+\t\t'include/rte_service_component.h',\n+\t\t'include/rte_tailq.h',\n+\t\t'include/rte_time.h',\n+\t\t'include/rte_uuid.h',\n+\t\t'include/rte_version.h')\n \n # special case install the generic headers, since they go in a subdir\n generic_headers = files(\ndiff --git a/lib/meson.build b/lib/meson.build\nindex 1fe1b4677..8d7711090 100644\n--- a/lib/meson.build\n+++ b/lib/meson.build\n@@ -30,6 +30,10 @@ libraries = [\n \t# flow_classify lib depends on pkt framework table lib\n \t'flow_classify', 'bpf', 'telemetry']\n \n+if host_machine.system() == 'windows'\n+\tlibraries = ['kvargs','eal'] # override libraries for windows\n+endif\n+\n default_cflags = machine_args\n if cc.has_argument('-Wno-format-truncation')\n \tdefault_cflags += '-Wno-format-truncation'\ndiff --git a/meson.build b/meson.build\nindex 797c86c44..856e94c37 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -1,5 +1,5 @@\n # SPDX-License-Identifier: BSD-3-Clause\n-# Copyright(c) 2017 Intel Corporation\n+# Copyright(c) 2017-2019 Intel Corporation\n \n project('DPDK', 'C',\n \tversion: '19.05.0-rc0',\n@@ -36,28 +36,33 @@ eal_pmd_path = join_paths(get_option('prefix'), driver_install_path)\n global_inc = include_directories('.', 'config', 'lib/librte_eal/common/include')\n subdir('config')\n \n-# build libs and drivers\n+# build libs\n subdir('lib')\n-subdir('buildtools')\n-subdir('drivers')\n \n-# build binaries and installable tools\n-subdir('usertools')\n-subdir('app')\n+if host_machine.system() != 'windows'\n+\t# build buildtools and drivers\n+\tsubdir('buildtools')\n+\tsubdir('drivers')\n \n-# build docs\n-subdir('doc')\n+\t# build binaries and installable tools\n+\tsubdir('usertools')\n+\tsubdir('app')\n+\tsubdir('test')\n+\n+\t# build kernel modules if enabled\n+\tif get_option('enable_kmods')\n+\t\tsubdir('kernel')\n+\tendif\n+\n+\t# build docs\n+\tsubdir('doc')\n+endif\n \n # build any examples explicitly requested - useful for developers\n if get_option('examples') != ''\n \tsubdir('examples')\n endif\n \n-# build kernel modules if enabled\n-if get_option('enable_kmods')\n-\tsubdir('kernel')\n-endif\n-\n # write the build config\n build_cfg = 'rte_build_config.h'\n configure_file(output: build_cfg,\n", "prefixes": [ "v3", "8/8" ] }