Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/51324/?format=api
{ "id": 51324, "url": "http://patches.dpdk.org/api/patches/51324/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190319064312.13743-8-tiwei.bie@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190319064312.13743-8-tiwei.bie@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190319064312.13743-8-tiwei.bie@intel.com", "date": "2019-03-19T06:43:09", "name": "[07/10] net/virtio: drop unused field in Tx region structure", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ad2342bfba408000c497a533a718e1a7e2213f3c", "submitter": { "id": 617, "url": "http://patches.dpdk.org/api/people/617/?format=api", "name": "Tiwei Bie", "email": "tiwei.bie@intel.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190319064312.13743-8-tiwei.bie@intel.com/mbox/", "series": [ { "id": 3795, "url": "http://patches.dpdk.org/api/series/3795/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3795", "date": "2019-03-19T06:43:02", "name": "net/virtio: cleanups and fixes for packed/split ring", "version": 1, "mbox": "http://patches.dpdk.org/series/3795/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/51324/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/51324/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8F74D54AE;\n\tTue, 19 Mar 2019 07:43:57 +0100 (CET)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby dpdk.org (Postfix) with ESMTP id 02ED74C91\n\tfor <dev@dpdk.org>; Tue, 19 Mar 2019 07:43:42 +0100 (CET)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t18 Mar 2019 23:43:42 -0700", "from dpdk-tbie.sh.intel.com ([10.67.104.173])\n\tby orsmga007.jf.intel.com with ESMTP; 18 Mar 2019 23:43:41 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.58,496,1544515200\"; d=\"scan'208\";a=\"123847068\"", "From": "Tiwei Bie <tiwei.bie@intel.com>", "To": "maxime.coquelin@redhat.com,\n\tzhihong.wang@intel.com,\n\tdev@dpdk.org", "Date": "Tue, 19 Mar 2019 14:43:09 +0800", "Message-Id": "<20190319064312.13743-8-tiwei.bie@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190319064312.13743-1-tiwei.bie@intel.com>", "References": "<20190319064312.13743-1-tiwei.bie@intel.com>", "Subject": "[dpdk-dev] [PATCH 07/10] net/virtio: drop unused field in Tx region\n\tstructure", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Drop the unused field tx_indir_pq from virtio_tx_region\nstructure.\n\nSigned-off-by: Tiwei Bie <tiwei.bie@intel.com>\n---\n drivers/net/virtio/virtio_ethdev.c | 10 +---------\n drivers/net/virtio/virtqueue.h | 8 ++------\n 2 files changed, 3 insertions(+), 15 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex f452a9a79..8aa250997 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -603,17 +603,9 @@ virtio_init_queue(struct rte_eth_dev *dev, uint16_t vtpci_queue_idx)\n \t\tmemset(txr, 0, vq_size * sizeof(*txr));\n \t\tfor (i = 0; i < vq_size; i++) {\n \t\t\tstruct vring_desc *start_dp = txr[i].tx_indir;\n-\t\t\tstruct vring_packed_desc *start_dp_packed =\n-\t\t\t\ttxr[i].tx_indir_pq;\n \n \t\t\t/* first indirect descriptor is always the tx header */\n-\t\t\tif (vtpci_packed_queue(hw)) {\n-\t\t\t\tstart_dp_packed->addr = txvq->virtio_net_hdr_mem\n-\t\t\t\t\t+ i * sizeof(*txr)\n-\t\t\t\t\t+ offsetof(struct virtio_tx_region,\n-\t\t\t\t\t\t tx_hdr);\n-\t\t\t\tstart_dp_packed->len = hw->vtnet_hdr_size;\n-\t\t\t} else {\n+\t\t\tif (!vtpci_packed_queue(hw)) {\n \t\t\t\tvring_desc_init_split(start_dp,\n \t\t\t\t\t\t RTE_DIM(txr[i].tx_indir));\n \t\t\t\tstart_dp->addr = txvq->virtio_net_hdr_mem\ndiff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h\nindex 78df6d390..6dab7db8e 100644\n--- a/drivers/net/virtio/virtqueue.h\n+++ b/drivers/net/virtio/virtqueue.h\n@@ -277,12 +277,8 @@ struct virtio_net_hdr_mrg_rxbuf {\n #define VIRTIO_MAX_TX_INDIRECT 8\n struct virtio_tx_region {\n \tstruct virtio_net_hdr_mrg_rxbuf tx_hdr;\n-\tunion {\n-\t\tstruct vring_desc tx_indir[VIRTIO_MAX_TX_INDIRECT]\n-\t\t\t__attribute__((__aligned__(16)));\n-\t\tstruct vring_packed_desc tx_indir_pq[VIRTIO_MAX_TX_INDIRECT]\n-\t\t\t__attribute__((__aligned__(16)));\n-\t};\n+\tstruct vring_desc tx_indir[VIRTIO_MAX_TX_INDIRECT]\n+\t\t__attribute__((__aligned__(16)));\n };\n \n static inline int\n", "prefixes": [ "07/10" ] }