Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 5121,
    "url": "http://patches.dpdk.org/api/patches/5121/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1433373024-5558-3-git-send-email-konstantin.ananyev@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1433373024-5558-3-git-send-email-konstantin.ananyev@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1433373024-5558-3-git-send-email-konstantin.ananyev@intel.com",
    "date": "2015-06-03T23:10:18",
    "name": "[dpdk-dev,2/8] ACL: code cleanup - use global RTE_LEN2MASK macro",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "2e0d192d12c2d4feb9d428229f0905054e826dc3",
    "submitter": {
        "id": 33,
        "url": "http://patches.dpdk.org/api/people/33/?format=api",
        "name": "Ananyev, Konstantin",
        "email": "konstantin.ananyev@intel.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1433373024-5558-3-git-send-email-konstantin.ananyev@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/5121/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/5121/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 0636CC33E;\n\tThu,  4 Jun 2015 01:10:37 +0200 (CEST)",
            "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id CAC835A8B\n\tfor <dev@dpdk.org>; Thu,  4 Jun 2015 01:10:32 +0200 (CEST)",
            "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga101.fm.intel.com with ESMTP; 03 Jun 2015 16:10:31 -0700",
            "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga001.jf.intel.com with ESMTP; 03 Jun 2015 16:10:28 -0700",
            "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\n\t[10.237.217.46])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tt53NAQgH006140; Thu, 4 Jun 2015 00:10:26 +0100",
            "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev02.ir.intel.com with ESMTP id t53NAQQ1005752;\n\tThu, 4 Jun 2015 00:10:26 +0100",
            "(from kananye1@localhost)\n\tby sivswdev02.ir.intel.com with  id t53NAQoY005748;\n\tThu, 4 Jun 2015 00:10:26 +0100"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.13,549,1427785200\"; d=\"scan'208\";a=\"704934626\"",
        "From": "Konstantin Ananyev <konstantin.ananyev@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Thu,  4 Jun 2015 00:10:18 +0100",
        "Message-Id": "<1433373024-5558-3-git-send-email-konstantin.ananyev@intel.com>",
        "X-Mailer": "git-send-email 1.7.4.1",
        "In-Reply-To": "<1433373024-5558-1-git-send-email-konstantin.ananyev@intel.com>",
        "References": "<1433373024-5558-1-git-send-email-konstantin.ananyev@intel.com>",
        "Subject": "[dpdk-dev] [PATCH 2/8] ACL: code cleanup - use global RTE_LEN2MASK\n\tmacro",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>\n---\n app/test-acl/main.c            | 3 ++-\n lib/librte_acl/acl_bld.c       | 3 ++-\n lib/librte_acl/rte_acl.c       | 3 ++-\n lib/librte_acl/rte_acl.h       | 2 +-\n lib/librte_acl/rte_acl_osdep.h | 2 --\n 5 files changed, 7 insertions(+), 6 deletions(-)",
    "diff": "diff --git a/app/test-acl/main.c b/app/test-acl/main.c\nindex 524c43a..be3d773 100644\n--- a/app/test-acl/main.c\n+++ b/app/test-acl/main.c\n@@ -739,7 +739,8 @@ add_cb_rules(FILE *f, struct rte_acl_ctx *ctx)\n \t\t\treturn rc;\n \t\t}\n \n-\t\tv.data.category_mask = LEN2MASK(RTE_ACL_MAX_CATEGORIES);\n+\t\tv.data.category_mask = RTE_LEN2MASK(RTE_ACL_MAX_CATEGORIES,\n+\t\t\ttypeof(v.data.category_mask));\n \t\tv.data.priority = RTE_ACL_MAX_PRIORITY - n;\n \t\tv.data.userdata = n;\n \ndiff --git a/lib/librte_acl/acl_bld.c b/lib/librte_acl/acl_bld.c\nindex e2db9bf..19a4178 100644\n--- a/lib/librte_acl/acl_bld.c\n+++ b/lib/librte_acl/acl_bld.c\n@@ -1772,7 +1772,8 @@ acl_bld(struct acl_build_context *bcx, struct rte_acl_ctx *ctx,\n \tbcx->pool.alignment = ACL_POOL_ALIGN;\n \tbcx->pool.min_alloc = ACL_POOL_ALLOC_MIN;\n \tbcx->cfg = *cfg;\n-\tbcx->category_mask = LEN2MASK(bcx->cfg.num_categories);\n+\tbcx->category_mask = RTE_LEN2MASK(bcx->cfg.num_categories,\n+\t\ttypeof(bcx->category_mask));\n \tbcx->node_max = node_max;\n \n \trc = sigsetjmp(bcx->pool.fail, 0);\ndiff --git a/lib/librte_acl/rte_acl.c b/lib/librte_acl/rte_acl.c\nindex b6ddeeb..a54d531 100644\n--- a/lib/librte_acl/rte_acl.c\n+++ b/lib/librte_acl/rte_acl.c\n@@ -271,7 +271,8 @@ acl_add_rules(struct rte_acl_ctx *ctx, const void *rules, uint32_t num)\n static int\n acl_check_rule(const struct rte_acl_rule_data *rd)\n {\n-\tif ((rd->category_mask & LEN2MASK(RTE_ACL_MAX_CATEGORIES)) == 0 ||\n+\tif ((RTE_LEN2MASK(RTE_ACL_MAX_CATEGORIES, typeof(rd->category_mask)) &\n+\t\t\trd->category_mask) == 0 ||\n \t\t\trd->priority > RTE_ACL_MAX_PRIORITY ||\n \t\t\trd->priority < RTE_ACL_MIN_PRIORITY ||\n \t\t\trd->userdata == RTE_ACL_INVALID_USERDATA)\ndiff --git a/lib/librte_acl/rte_acl.h b/lib/librte_acl/rte_acl.h\nindex 3a93730..8d9bbe5 100644\n--- a/lib/librte_acl/rte_acl.h\n+++ b/lib/librte_acl/rte_acl.h\n@@ -115,7 +115,7 @@ struct rte_acl_field {\n \n enum {\n \tRTE_ACL_TYPE_SHIFT = 29,\n-\tRTE_ACL_MAX_INDEX = LEN2MASK(RTE_ACL_TYPE_SHIFT),\n+\tRTE_ACL_MAX_INDEX = RTE_LEN2MASK(RTE_ACL_TYPE_SHIFT, uint32_t),\n \tRTE_ACL_MAX_PRIORITY = RTE_ACL_MAX_INDEX,\n \tRTE_ACL_MIN_PRIORITY = 0,\n };\ndiff --git a/lib/librte_acl/rte_acl_osdep.h b/lib/librte_acl/rte_acl_osdep.h\nindex 81fdefb..41f7e3d 100644\n--- a/lib/librte_acl/rte_acl_osdep.h\n+++ b/lib/librte_acl/rte_acl_osdep.h\n@@ -56,8 +56,6 @@\n  * Common defines.\n  */\n \n-#define\tLEN2MASK(ln)\t((uint32_t)(((uint64_t)1 << (ln)) - 1))\n-\n #define DIM(x) RTE_DIM(x)\n \n #include <rte_common.h>\n",
    "prefixes": [
        "dpdk-dev",
        "2/8"
    ]
}