Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/51200/?format=api
{ "id": 51200, "url": "http://patches.dpdk.org/api/patches/51200/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190314161730.20016-1-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190314161730.20016-1-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190314161730.20016-1-stephen@networkplumber.org", "date": "2019-03-14T16:17:30", "name": "[v2] ethdev: check for invalid device name", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1290ab2f1782e7fec6591f799792e9a3fc2d6f13", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190314161730.20016-1-stephen@networkplumber.org/mbox/", "series": [ { "id": 3748, "url": "http://patches.dpdk.org/api/series/3748/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3748", "date": "2019-03-14T16:17:30", "name": "[v2] ethdev: check for invalid device name", "version": 2, "mbox": "http://patches.dpdk.org/series/3748/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/51200/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/51200/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 603F54C99;\n\tThu, 14 Mar 2019 17:17:41 +0100 (CET)", "from mail-pf1-f195.google.com (mail-pf1-f195.google.com\n\t[209.85.210.195]) by dpdk.org (Postfix) with ESMTP id BEC4D4C96\n\tfor <dev@dpdk.org>; Thu, 14 Mar 2019 17:17:39 +0100 (CET)", "by mail-pf1-f195.google.com with SMTP id r15so1406035pfn.9\n\tfor <dev@dpdk.org>; Thu, 14 Mar 2019 09:17:39 -0700 (PDT)", "from shemminger-XPS-13-9360.lan (204-195-22-127.wavecable.com.\n\t[204.195.22.127]) by smtp.gmail.com with ESMTPSA id\n\tq13sm19786027pgh.24.2019.03.14.09.17.37\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 14 Mar 2019 09:17:37 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:reply-to;\n\tbh=JST/0p3t7+iqCyyGgtviykLjmmBKvV62AqBe2KNOY+0=;\n\tb=cUSClT79OoDGKJGraLrc7Y2tDURe+bqKymWqAXs8H7zNB7j1dOAalmC5j0K5t3oGjJ\n\t5DVFy2P7I2kLSL+U/E9eE8687JemI0P2B9ufAxM+Vat39FoukzQBY1F4J0kPYjRlskef\n\ttaIcp6DbduNDn2ULxMYUYAY3tWdZwPKLAwlRIFm7J+HTIwi9USwXCNr7Vazg+JnuYFWW\n\tLGq/MQ46vEH40UekF1ujbqQDZsXISeIYfEQA+n8RLVqCN1snhEvDKl2YOH9cWHBB6FC7\n\thC9FK+epkRgejGMNO/810QPiXN7A+CYP7vqlmKkrh3iSASZ6MzetQ3Fa1vqriWm72vZE\n\t54VA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=JST/0p3t7+iqCyyGgtviykLjmmBKvV62AqBe2KNOY+0=;\n\tb=K3xnCs6ipBrCEWmts9ZeLK6F9wcCsgA1xuvlNGlXNnKFMDFxmlv/pmWF9h1DR68+AW\n\th6SuSp/CPXXk/sDlkxXlt+uvzhc42OEewnu3lMMOGor4BHpasgi1UDOgTOr2TAlSEFnE\n\tficXnyA9Aa1OtgW8V/3YMNcDHlLpxpI/Pvbi+wKXJ7fw2Y4oen4mWMibKss4zM7dOEpR\n\t3pYyo/koZPTSb45CszFlJCc7K8AzZylh7xxsiF+naME8BZkOnK64l+PUKumK3oI91OYH\n\tZR28MtzuJSFBS10KiMH3n6qL+kOoMlY3abokGSO2Ec3lVcuyWvHDDC/ThqZ7sjXAZYLw\n\tJU0g==", "X-Gm-Message-State": "APjAAAUgm6NhY1x3I+r0IKOubcP8R2HyxGDUguAPNyktO1BogjUixf+d\n\t4tt0+zKTaQVw9ZNGAB8h/3Apg9n+ErKY0g==", "X-Google-Smtp-Source": "APXvYqwTNIi8OK3mdi+Px3cswHxEwRPWMuhDHt7MYigwIazCohCiDDAQEn76kop7TBWTgrYAEcHpgg==", "X-Received": "by 2002:a63:4146:: with SMTP id\n\to67mr32369468pga.122.1552580258568; \n\tThu, 14 Mar 2019 09:17:38 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Thu, 14 Mar 2019 09:17:30 -0700", "Message-Id": "<20190314161730.20016-1-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [PATCH v2] ethdev: check for invalid device name", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "Reply-To": "20190311181544.15646-1-stephen@networkplumber.org", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Do not allow creating a ethernet device with a name over the\nallowed maximum (or zero length). This is safer than silently truncating\nwhich is what happens now.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\nv2 - fix zero length name test\n\n lib/librte_ethdev/rte_ethdev.c | 12 ++++++++++++\n 1 file changed, 12 insertions(+)", "diff": "diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c\nindex 85c1794968dd..b19df3061d54 100644\n--- a/lib/librte_ethdev/rte_ethdev.c\n+++ b/lib/librte_ethdev/rte_ethdev.c\n@@ -438,6 +438,18 @@ rte_eth_dev_allocate(const char *name)\n {\n \tuint16_t port_id;\n \tstruct rte_eth_dev *eth_dev = NULL;\n+\tsize_t name_len;\n+\t\n+\tname_len = strnlen(name, RTE_ETH_NAME_MAX_LEN);\n+\tif (name_len == 0) {\n+\t\tRTE_ETHDEV_LOG(ERR, \"Zero length Ethernet device name\\n\");\n+\t\treturn NULL;\n+\t}\n+\n+\tif (name_len >= RTE_ETH_NAME_MAX_LEN) {\n+\t\tRTE_ETHDEV_LOG(ERR, \"Ethernet device name is too long\\n\");\n+\t\treturn NULL;\n+\t}\n \n \trte_eth_dev_shared_data_prepare();\n \n", "prefixes": [ "v2" ] }