Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/51169/?format=api
http://patches.dpdk.org/api/patches/51169/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190313170657.16688-10-ncopa@alpinelinux.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190313170657.16688-10-ncopa@alpinelinux.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190313170657.16688-10-ncopa@alpinelinux.org", "date": "2019-03-13T17:06:51", "name": "[v3,09/15] app/test: fix setting of -D_GNU_SOURCE with meson", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "110ab74c0dad0b40888b11782118226c26c26a87", "submitter": { "id": 1242, "url": "http://patches.dpdk.org/api/people/1242/?format=api", "name": "Natanael Copa", "email": "ncopa@alpinelinux.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190313170657.16688-10-ncopa@alpinelinux.org/mbox/", "series": [ { "id": 3735, "url": "http://patches.dpdk.org/api/series/3735/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3735", "date": "2019-03-13T17:06:42", "name": "Build fixes for musl libc", "version": 3, "mbox": "http://patches.dpdk.org/series/3735/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/51169/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/51169/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BE55B58FE;\n\tWed, 13 Mar 2019 18:07:37 +0100 (CET)", "from mx1.tetrasec.net (mx1.tetrasec.net [74.117.190.25])\n\tby dpdk.org (Postfix) with ESMTP id 4FF835323\n\tfor <dev@dpdk.org>; Wed, 13 Mar 2019 18:07:30 +0100 (CET)", "from mx1.tetrasec.net (mail.local [127.0.0.1])\n\tby mx1.tetrasec.net (Postfix) with ESMTP id C8A6A9E03AF;\n\tWed, 13 Mar 2019 17:07:29 +0000 (UTC)", "from ncopa-desktop.lan (67.63.200.37.customer.cdi.no\n\t[37.200.63.67])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\t(Authenticated sender: n@tanael.org)\n\tby mx1.tetrasec.net (Postfix) with ESMTPSA id F27DE9E1D58;\n\tWed, 13 Mar 2019 17:07:28 +0000 (UTC)" ], "From": "Natanael Copa <ncopa@alpinelinux.org>", "To": "dev@dpdk.org", "Cc": "Natanael Copa <ncopa@alpinelinux.org>", "Date": "Wed, 13 Mar 2019 18:06:51 +0100", "Message-Id": "<20190313170657.16688-10-ncopa@alpinelinux.org>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190313170657.16688-1-ncopa@alpinelinux.org>", "References": "<20190313170657.16688-1-ncopa@alpinelinux.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "quoted-printable", "Subject": "[dpdk-dev] [PATCH v3 09/15] app/test: fix setting of -D_GNU_SOURCE\n\twith meson", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "in app/test/meson.build the default_cflag is never used so the\n-D_GNU_SOURCE was never passed as intended.\n\nFixes the following build error with musl libc:\n\n../lib/librte_eal/common/include/rte_lcore.h:26:9: error: unknown type name 'cpu_set_t'\n typedef cpu_set_t rte_cpuset_t;\n ^~~~~~~~~\n\nThe problem is that cpu_set_t is only defined when _GNU_SOURCE is set.\n\nSigned-off-by: Natanael Copa <ncopa@alpinelinux.org>\n---\n app/test/meson.build | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/app/test/meson.build b/app/test/meson.build\nindex 05e5ddeb0..2f2ec5057 100644\n--- a/app/test/meson.build\n+++ b/app/test/meson.build\n@@ -298,7 +298,7 @@ if cc.has_argument('-Wno-format-truncation')\n endif\n \n # specify -D_GNU_SOURCE unconditionally\n-default_cflags += '-D_GNU_SOURCE'\n+cflags += '-D_GNU_SOURCE'\n \n test_dep_objs = []\n if dpdk_conf.has('RTE_LIBRTE_COMPRESSDEV')\n", "prefixes": [ "v3", "09/15" ] }{ "id": 51169, "url": "