Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/51130/?format=api
{ "id": 51130, "url": "http://patches.dpdk.org/api/patches/51130/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/87513983880d4f283bc0b3dbda4f2d15709828e8.1552402263.git.igor.russkikh@aquantia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<87513983880d4f283bc0b3dbda4f2d15709828e8.1552402263.git.igor.russkikh@aquantia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/87513983880d4f283bc0b3dbda4f2d15709828e8.1552402263.git.igor.russkikh@aquantia.com", "date": "2019-03-12T15:25:05", "name": "[v3,08/10] net/atlantic: eliminate excessive log levels on Rx/Tx", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "47ba5ca25a60f60f510a07f59a5119f356c35c19", "submitter": { "id": 1124, "url": "http://patches.dpdk.org/api/people/1124/?format=api", "name": "Igor Russkikh", "email": "igor.russkikh@aquantia.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/87513983880d4f283bc0b3dbda4f2d15709828e8.1552402263.git.igor.russkikh@aquantia.com/mbox/", "series": [ { "id": 3719, "url": "http://patches.dpdk.org/api/series/3719/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3719", "date": "2019-03-12T15:24:49", "name": "net/atlantic: bugfixes and code cleanup", "version": 3, "mbox": "http://patches.dpdk.org/series/3719/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/51130/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/51130/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7412C5B16;\n\tTue, 12 Mar 2019 16:25:11 +0100 (CET)", "from NAM02-SN1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr770082.outbound.protection.outlook.com [40.107.77.82])\n\tby dpdk.org (Postfix) with ESMTP id 1AE5756A3\n\tfor <dev@dpdk.org>; Tue, 12 Mar 2019 16:25:07 +0100 (CET)", "from DM6PR11MB3625.namprd11.prod.outlook.com (20.178.230.149) by\n\tDM6PR11MB3068.namprd11.prod.outlook.com (20.177.218.153) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1686.19; Tue, 12 Mar 2019 15:25:05 +0000", "from DM6PR11MB3625.namprd11.prod.outlook.com\n\t([fe80::d145:a1f4:ed34:e31b]) by\n\tDM6PR11MB3625.namprd11.prod.outlook.com\n\t([fe80::d145:a1f4:ed34:e31b%3]) with mapi id 15.20.1686.021;\n\tTue, 12 Mar 2019 15:25:05 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=ipuTH0c4InD4UNeJ540Sdqni4fRPmh8Pjb4kzF/gsGY=;\n\tb=Kok20R4CmEVdzsoELjNdua0zRhF+kgvxmrMsVvN26+WBllYTiMSdrRAXgTFIYcRXdruJwmg2V0JfdFjaK7KbANSbkiiD2HJq4fwEL7hE0fAVuHVKXiRPlv6+DR3FZUXMkDF6LFWFAMtv2tbCpFgGOpyw92Y1eNU54d9Haax0Oc0=", "From": "Igor Russkikh <Igor.Russkikh@aquantia.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>", "CC": "Pavel Belous <Pavel.Belous@aquantia.com>, Igor Russkikh\n\t<Igor.Russkikh@aquantia.com>", "Thread-Topic": "[PATCH v3 08/10] net/atlantic: eliminate excessive log levels\n\ton Rx/Tx", "Thread-Index": "AQHU2OfFtHZo2ocufUC8Ux6X24aGlg==", "Date": "Tue, 12 Mar 2019 15:25:05 +0000", "Message-ID": "<87513983880d4f283bc0b3dbda4f2d15709828e8.1552402263.git.igor.russkikh@aquantia.com>", "References": "<cover.1552402263.git.igor.russkikh@aquantia.com>", "In-Reply-To": "<cover.1552402263.git.igor.russkikh@aquantia.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "HE1PR0901CA0050.eurprd09.prod.outlook.com\n\t(2603:10a6:3:45::18) To DM6PR11MB3625.namprd11.prod.outlook.com\n\t(2603:10b6:5:13a::21)", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=Igor.Russkikh@aquantia.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-mailer": "git-send-email 2.17.1", "x-originating-ip": "[95.79.108.179]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "f48c7b45-31f8-4a92-9512-08d6a6fee75f", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020);\n\tSRVR:DM6PR11MB3068; ", "x-ms-traffictypediagnostic": "DM6PR11MB3068:", "x-microsoft-exchange-diagnostics": "=?iso-8859-1?Q?1; DM6PR11MB3068;\n\t23:0j7UJnmb5zsSwJOh/PKAERHUXe0pKSqi0Qv3uAE?=\n\t=?iso-8859-1?q?phl9h8Ra/k/DxeP3wCW+1feWl?=\n\t=?iso-8859-1?q?kVfTvKCKdFnyBbkFcpHwLLjMrJvCEREWuRHYw3G2ZcTpHPwu8K9?=\n\t=?iso-8859-1?q?oanyCDPACRCvzEuR/nIEbSuYo1bUQCE7hEC//8e8+ne1+lMu2KN?=\n\t=?iso-8859-1?q?ODUAdPfOuIKXzpvR9VeA7zxaFv9c/fixFG5ut/q/1ijp/pYdy+0?=\n\t=?iso-8859-1?q?g2E+odgWqnl8vnjFzxaLKxIVXTxM3fBdI021X+88RX137gqV3XS?=\n\t=?iso-8859-1?q?Stqv7sSjv3kPT/Xiiz3YG5KN0wW5RYHTW89nYUam6b+HncPFoXd?=\n\t=?iso-8859-1?q?Yzq5eCAI89IrBJpHa8c7Bgy0Nw46SGGaPCYAcIsWOmAT/E13Oa7?=\n\t=?iso-8859-1?q?lkOcnjdglcmVmd+espaH9Tj25J3szOlJSKmCZ1WCFwN8ZEzA3gA?=\n\t=?iso-8859-1?q?E89WowxLEDtMSWr8iE1Nd/5QYjMm7puyrQx7lAdHf2JI/iz17zO?=\n\t=?iso-8859-1?q?EEOPPkaoBdgNBIkPvm3/9BZk+Rbvavpe3TZN7MRhRsSa9CG/d1v?=\n\t=?iso-8859-1?q?Fz+83/Qh3S5JvH2ldBZY4OlOQ2c4Vcsi+lRO1FoacZBgrrUIfpw?=\n\t=?iso-8859-1?q?l52hKMqjAhNQeRj9DeZSzh3kS0i2teeero4IYkwM5k20D2TmPnQ?=\n\t=?iso-8859-1?q?QtggUVecAQETrrMhXwDXLt/H0yo+09sIADPk2SkQGiwyNPsl8xo?=\n\t=?iso-8859-1?q?DxM9FSPKs7ChNZZRR8D2Z2IVU6ASlLpshIYEx/tKrC4XUFmz4Kf?=\n\t=?iso-8859-1?q?t4hhp1o2B9qz+K/9P1dgjZYCx2Kf4/3w9mLzx9qFw/TDHHF0Z+V?=\n\t=?iso-8859-1?q?oAulyZBrk+eSbsqrYg51kyXET/8eCuarb8/ckSXLEOOcp4K776b?=\n\t=?iso-8859-1?q?PQQpnqSXfOmODxNsjW6fdxL3q9ueGJ2YWSPYpD83Vk8WLBxK1U6?=\n\t=?iso-8859-1?q?xmREzxXf7ySHBDsaKJXTAWu4iN7jo1nEyqAWJfcpiGJMPtGWOip?=\n\t=?iso-8859-1?q?cbJbsADHfPcTGwFt880M/oRwI3cGW+Jee2ap6+zlL9954V1cZAD?=\n\t=?iso-8859-1?q?uYt/7iDxr6PYFLP1MV0LHV+Fj6ShK8+4h0bhRYJwMNLC4PcklVh?=\n\t=?iso-8859-1?q?9LlhV/rg4t45BI4ke1EZVv19IckHnt1FK5KYubEiKqXPuHuYfzz?=\n\t=?iso-8859-1?q?rFLMjhxnB/SmFoB3hnnwoljV60QrXh8KtIknTYaPka1tK1HMBxq?=\n\t=?iso-8859-1?q?g6Oz3VBfQ7uJTJtDubN0bJ3u2VwzqEdp1nHA9VL6a5+6TDyCJrr?=\n\t=?iso-8859-1?q?8WY2I+mjfvpYbOI5/g9JPLnnOOV53V8OCykghxKe+V+SWEBTWSj?=\n\t=?iso-8859-1?q?azMbRpACx2zzSdS9u8PaVrT3Ut3B9tEjZWGKba/5Mgy6U/CteBc?=\n\t=?iso-8859-1?q?XCdClI/OxdYqanbj+46JuuYV19u2OamY9sINiswIdGmU35FRgM4?=\n\t=?iso-8859-1?q?7XThpnkFTxZWcmBflI4EvAvlJMg=3D=3D?=", "x-microsoft-antispam-prvs": "<DM6PR11MB30688809573F78FA9C383EBB98490@DM6PR11MB3068.namprd11.prod.outlook.com>", "x-forefront-prvs": "09749A275C", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(376002)(346002)(136003)(366004)(39850400004)(396003)(199004)(189003)(72206003)(97736004)(4326008)(14454004)(81166006)(2906002)(5660300002)(6916009)(8676002)(71200400001)(478600001)(25786009)(118296001)(71190400001)(86362001)(256004)(1730700003)(3846002)(81156014)(36756003)(68736007)(6116002)(305945005)(54906003)(316002)(446003)(8936002)(44832011)(53936002)(5640700003)(26005)(11346002)(476003)(76176011)(66066001)(106356001)(99286004)(2616005)(105586002)(186003)(386003)(52116002)(7736002)(107886003)(6436002)(6486002)(2351001)(6506007)(2501003)(6512007)(102836004)(50226002)(486006);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR11MB3068;\n\tH:DM6PR11MB3625.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; A:1; MX:1; ", "received-spf": "None (protection.outlook.com: aquantia.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "HBWjx3MFHwokOvtPtJ6kWgVtRlykUb3uRvz2++o46rjcIo68JSWU7woREq221A47XE+8iWNAnB0KFrjyU53wgV7NIMXXgaSQ9eJW+/bOkqEriq7ZBZZC5/dGZMwkDw0v5GOASV0R7TFOX/Lzmn0lgIFNJ57d9gKDNnZH6qybtE4P1nwqSo4aWI/eEtxZcTrq0DWDIOTvvhZizjoDoZefmJ7HnIQgrjAQ13Zb2NiA7CxhbRABD6OlmvSLIwXH5vVPbpll1sel67kUgt3UnyfAH04Rm+2UP7Bi0nmXxiISSFwB72KYaa5HCZ+bAq4WH9aKRbKYmaZH7K9Vg+Z/5Q3nIMlXgHVHftoqxqdV0WTr5rDZl3a/1pkxvTC0C+agm59y7N81ZOQyVP8uzU6Fl9Rieg/daWUSUaCAfrONbMOnuW4=", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "aquantia.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "f48c7b45-31f8-4a92-9512-08d6a6fee75f", "X-MS-Exchange-CrossTenant-originalarrivaltime": "12 Mar 2019 15:25:05.7421\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "83e2e134-991c-4ede-8ced-34d47e38e6b1", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM6PR11MB3068", "Subject": "[dpdk-dev] [PATCH v3 08/10] net/atlantic: eliminate excessive log\n\tlevels on Rx/Tx", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Default rxtx logging used ERR level, that caused logger to always\ntrigger. That may cause perf degradation even if logger was not enabled but\ncompiled in.\n\nSigned-off-by: Igor Russkikh <igor.russkikh@aquantia.com>\n---\n drivers/net/atlantic/atl_rxtx.c | 16 ++++------------\n 1 file changed, 4 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/atlantic/atl_rxtx.c b/drivers/net/atlantic/atl_rxtx.c\nindex aea58c0d5b83..f1519594adad 100644\n--- a/drivers/net/atlantic/atl_rxtx.c\n+++ b/drivers/net/atlantic/atl_rxtx.c\n@@ -946,7 +946,7 @@ atl_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n \t\t\tbreak;\n \t\t}\n \n-\t\tPMD_RX_LOG(ERR, \"port_id=%u queue_id=%u tail=%u \"\n+\t\tPMD_RX_LOG(DEBUG, \"port_id=%u queue_id=%u tail=%u \"\n \t\t\t \"eop=0x%x pkt_len=%u hash=0x%x hash_type=0x%x\",\n \t\t\t (unsigned int)rxq->port_id,\n \t\t\t (unsigned int)rxq->queue_id,\n@@ -981,7 +981,7 @@ atl_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n \t\twhile (true) {\n \t\t\tnew_mbuf = rte_mbuf_raw_alloc(rxq->mb_pool);\n \t\t\tif (new_mbuf == NULL) {\n-\t\t\t\tPMD_RX_LOG(ERR,\n+\t\t\t\tPMD_RX_LOG(DEBUG,\n \t\t\t\t \"RX mbuf alloc failed port_id=%u \"\n \t\t\t\t \"queue_id=%u\", (unsigned int)rxq->port_id,\n \t\t\t\t (unsigned int)rxq->queue_id);\n@@ -1084,7 +1084,7 @@ atl_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n \t\tadapter->sw_stats.q_ibytes[rxq->queue_id] +=\n \t\t\trx_mbuf_first->pkt_len;\n \n-\t\tPMD_RX_LOG(ERR, \"add mbuf segs=%d pkt_len=%d\",\n+\t\tPMD_RX_LOG(DEBUG, \"add mbuf segs=%d pkt_len=%d\",\n \t\t\trx_mbuf_first->nb_segs,\n \t\t\trx_mbuf_first->pkt_len);\n \t}\n@@ -1104,7 +1104,7 @@ atl_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n \t */\n \tnb_hold = (uint16_t)(nb_hold + rxq->nb_rx_hold);\n \tif (nb_hold > rxq->rx_free_thresh) {\n-\t\tPMD_RX_LOG(ERR, \"port_id=%u queue_id=%u rx_tail=%u \"\n+\t\tPMD_RX_LOG(DEBUG, \"port_id=%u queue_id=%u rx_tail=%u \"\n \t\t\t\"nb_hold=%u nb_rx=%u\",\n \t\t\t(unsigned int)rxq->port_id, (unsigned int)rxq->queue_id,\n \t\t\t(unsigned int)tail, (unsigned int)nb_hold,\n@@ -1129,8 +1129,6 @@ atl_xmit_cleanup(struct atl_tx_queue *txq)\n \tstruct hw_atl_txd_s *txd;\n \tint to_clean = 0;\n \n-\tPMD_INIT_FUNC_TRACE();\n-\n \tif (txq != NULL) {\n \t\tsw_ring = txq->sw_ring;\n \t\tint head = txq->tx_head;\n@@ -1181,11 +1179,7 @@ atl_tso_setup(struct rte_mbuf *tx_pkt, union hw_atl_txc_s *txc)\n \tuint32_t tx_cmd = 0;\n \tuint64_t ol_flags = tx_pkt->ol_flags;\n \n-\tPMD_INIT_FUNC_TRACE();\n-\n \tif (ol_flags & PKT_TX_TCP_SEG) {\n-\t\tPMD_DRV_LOG(DEBUG, \"xmit TSO pkt\");\n-\n \t\ttx_cmd |= tx_desc_cmd_lso | tx_desc_cmd_l4cs;\n \n \t\ttxc->cmd = 0x4;\n@@ -1240,8 +1234,6 @@ atl_xmit_pkt(struct aq_hw_s *hw, struct atl_tx_queue *txq,\n \tu32 tx_cmd = 0U;\n \tint desc_count = 0;\n \n-\tPMD_INIT_FUNC_TRACE();\n-\n \ttail = txq->tx_tail;\n \n \ttxc = (union hw_atl_txc_s *)&txq->hw_ring[tail];\n", "prefixes": [ "v3", "08/10" ] }