Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/51129/?format=api
{ "id": 51129, "url": "http://patches.dpdk.org/api/patches/51129/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/78c4ae4e6390cc14855961faf7c8568840aad47e.1552402263.git.igor.russkikh@aquantia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<78c4ae4e6390cc14855961faf7c8568840aad47e.1552402263.git.igor.russkikh@aquantia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/78c4ae4e6390cc14855961faf7c8568840aad47e.1552402263.git.igor.russkikh@aquantia.com", "date": "2019-03-12T15:25:03", "name": "[v3,07/10] net/atlantic: fix link configuration", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1cb6b3dd48324aabd60c8cd3da1be38fb69ee156", "submitter": { "id": 1124, "url": "http://patches.dpdk.org/api/people/1124/?format=api", "name": "Igor Russkikh", "email": "igor.russkikh@aquantia.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/78c4ae4e6390cc14855961faf7c8568840aad47e.1552402263.git.igor.russkikh@aquantia.com/mbox/", "series": [ { "id": 3719, "url": "http://patches.dpdk.org/api/series/3719/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3719", "date": "2019-03-12T15:24:49", "name": "net/atlantic: bugfixes and code cleanup", "version": 3, "mbox": "http://patches.dpdk.org/series/3719/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/51129/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/51129/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DFF915A4A;\n\tTue, 12 Mar 2019 16:25:09 +0100 (CET)", "from NAM02-SN1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr770071.outbound.protection.outlook.com [40.107.77.71])\n\tby dpdk.org (Postfix) with ESMTP id 0B7BE5699;\n\tTue, 12 Mar 2019 16:25:06 +0100 (CET)", "from DM6PR11MB3625.namprd11.prod.outlook.com (20.178.230.149) by\n\tDM6PR11MB3068.namprd11.prod.outlook.com (20.177.218.153) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1686.19; Tue, 12 Mar 2019 15:25:04 +0000", "from DM6PR11MB3625.namprd11.prod.outlook.com\n\t([fe80::d145:a1f4:ed34:e31b]) by\n\tDM6PR11MB3625.namprd11.prod.outlook.com\n\t([fe80::d145:a1f4:ed34:e31b%3]) with mapi id 15.20.1686.021;\n\tTue, 12 Mar 2019 15:25:04 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=/cpHjI6uoHXsoj+Y8vM6EkegxQ9MgOaR81q3imLsohc=;\n\tb=JPWoGOQ3ZYEwYdQalrT3l+pUydNUElzCx885+5Ds27o0T4KVbrrg4qEvwFkLAadVPRc5Iec/qmmn+IFIcpvYOm2qiUJSJAJBSSfJVXEJLZN+JQrLWQQkrwAWTIOW13bepai0CCL2Miwl5NoZ2wv+Ps4T1LCZU/C6uFZ9DUgu/XI=", "From": "Igor Russkikh <Igor.Russkikh@aquantia.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>", "CC": "Pavel Belous <Pavel.Belous@aquantia.com>, Igor Russkikh\n\t<Igor.Russkikh@aquantia.com>, \"stable@dpdk.org\" <stable@dpdk.org>", "Thread-Topic": "[PATCH v3 07/10] net/atlantic: fix link configuration", "Thread-Index": "AQHU2OfEXowG8t5j2U+ZL3BMTsOeLQ==", "Date": "Tue, 12 Mar 2019 15:25:03 +0000", "Message-ID": "<78c4ae4e6390cc14855961faf7c8568840aad47e.1552402263.git.igor.russkikh@aquantia.com>", "References": "<cover.1552402263.git.igor.russkikh@aquantia.com>", "In-Reply-To": "<cover.1552402263.git.igor.russkikh@aquantia.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "HE1PR0901CA0050.eurprd09.prod.outlook.com\n\t(2603:10a6:3:45::18) To DM6PR11MB3625.namprd11.prod.outlook.com\n\t(2603:10b6:5:13a::21)", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=Igor.Russkikh@aquantia.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-mailer": "git-send-email 2.17.1", "x-originating-ip": "[95.79.108.179]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "2faefe88-30ba-44a3-c308-08d6a6fee651", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020);\n\tSRVR:DM6PR11MB3068; ", "x-ms-traffictypediagnostic": "DM6PR11MB3068:", "x-microsoft-exchange-diagnostics": "=?iso-8859-1?Q?1; DM6PR11MB3068;\n\t23:w31+9t9pL9O0IbCLnmUeCfbvYlXt8o7ts5ju2bZ?=\n\t=?iso-8859-1?q?rYe6OnC7BwodUsACtY+XHc1+u?=\n\t=?iso-8859-1?q?7l/AFaAQSATVO63a9t3qD0p2OpyXyJZFvPDxfX2ODUmDTVkqSGs?=\n\t=?iso-8859-1?q?6kcdqF6ir2NDZWC1YW8pWz0wxmt+SOmtGPJNpIFGq80l+GxqeTY?=\n\t=?iso-8859-1?q?eUtRoDv/wtAynpfYyYqvREUBZ429Yb/fkUvdh5ol4oEn0o6m33c?=\n\t=?iso-8859-1?q?w4UIyqzBkELsmrZlNiRGJplIzRKvnSPuUqZlow+5e5TUEqzuGcV?=\n\t=?iso-8859-1?q?4RTBiBdyg9Bft2MnZsXomb6c7/IKSMBk25uLJ12NozCX+9G7VNl?=\n\t=?iso-8859-1?q?WbuEQQOB+YGkDrNiqY/Y1/5DSVNwlsUQpYyiHcPJ/9HRqjPMkbt?=\n\t=?iso-8859-1?q?kn9tCvF+pERmS/f4L2hvJlJ3HM2WtuRK+sOTydCkY3uRKAjbu3L?=\n\t=?iso-8859-1?q?gdaVgpLZzCzBZ/8KPOa+NMSdWgyS6Eeh4QTUcRNOLYpqetHlQSF?=\n\t=?iso-8859-1?q?e2J0cbhI/x4/zjPEb+u2YQInlQHinU8Wt2byZsVwlfgqQmOzkn8?=\n\t=?iso-8859-1?q?soqO8W9QmNBhIo9E/50oMTtUqNY2y+mVdYsOPpX/l2af1ZYWc7O?=\n\t=?iso-8859-1?q?a58Aq/YonnkyV3c3lbnJrsIE2vX3Us/wJa7+XI6fDzyKbbmVNGd?=\n\t=?iso-8859-1?q?dQJHcUDwUVK7fMW4uxjB89Hd7JtAI/cs1LciyZeUkezZlG9jfzQ?=\n\t=?iso-8859-1?q?NFtCU2iYCGgvtmy/wpKiAvtkEnXZJc2KYKIaJQUfw7eYKxflxTf?=\n\t=?iso-8859-1?q?BwKe1n4lFaVcHtdEKTGpQBxTm55PaPYQd/SsK/uIgLrMmSww6Rc?=\n\t=?iso-8859-1?q?Y1EAj8V5zum76IQFMRnpE2DkhDKs4gp6iFq21uAHJaz3LcuftzZ?=\n\t=?iso-8859-1?q?0lY7iBfvq+NWDXQv5VeSANfdjGdFnSZ6GCK5KdInDdIrdF2Mi6D?=\n\t=?iso-8859-1?q?w3pf31mSbn9xDZ7dIJ8yR5h6+3hNLok9NWVqiJ/Kjwavmue0zWT?=\n\t=?iso-8859-1?q?u+mYSfEDiyqaHRY7CPLZVzU8kwpm+5jeDB2Mv1B4zXmQPcMkt4i?=\n\t=?iso-8859-1?q?iO3OaLbYLrHATStT1IhQBK9RULU/9O91K0VdHj2ApBLGE4oHUzl?=\n\t=?iso-8859-1?q?JB03JZ9+geAx+fsu11zC2q+/54+2D1Zid3Df4B2Un/ky+mF4hR0?=\n\t=?iso-8859-1?q?yFCZsL9H/oIR0x8u+8aj0exVmUjnu1nBG3azNI4nuQrTMBS+VDn?=\n\t=?iso-8859-1?q?+QftOncNtS/Qg7jJEn8xHt4pgaB5JTWTDWiooAlG+bASMCPStz5?=\n\t=?iso-8859-1?q?sQ9gGgA+UPnvxbhwr0uTcbTGDsdfz+Qjt3NjOIz/I5trR2wQsIG?=\n\t=?iso-8859-1?q?Nc9IKONhVVJz9kW2QMzJeggS25ErnExk8mHILMFnMa2iqlVGAC9?=\n\t=?iso-8859-1?q?0H8TSZK1PhJi6Di+U4ArCmLS9fIQzEbbBAc3eFSLoDaxYiqjlmt?=\n\t=?iso-8859-1?q?7dU/wjRTmVrf9CQ9DcL6LZGD3zut2mCQZ/QG1G9g4dVNbofo=3D?=", "x-microsoft-antispam-prvs": "<DM6PR11MB30680C15711F2EAFC2239FBA98490@DM6PR11MB3068.namprd11.prod.outlook.com>", "x-forefront-prvs": "09749A275C", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(376002)(346002)(136003)(366004)(39850400004)(396003)(199004)(189003)(72206003)(97736004)(4326008)(14454004)(81166006)(2906002)(5660300002)(6916009)(8676002)(71200400001)(478600001)(25786009)(118296001)(71190400001)(86362001)(14444005)(256004)(1730700003)(3846002)(81156014)(36756003)(68736007)(6116002)(305945005)(54906003)(316002)(446003)(8936002)(44832011)(53936002)(5640700003)(26005)(11346002)(476003)(76176011)(66066001)(106356001)(99286004)(2616005)(105586002)(186003)(450100002)(386003)(52116002)(7736002)(6436002)(6486002)(2351001)(6506007)(2501003)(6512007)(102836004)(50226002)(486006);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR11MB3068;\n\tH:DM6PR11MB3625.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; A:1; MX:1; ", "received-spf": "None (protection.outlook.com: aquantia.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "z9ZoEmAuHmMCdNDU3twxtKwDxWL8oklx5QKMpFZtO+YNApbjV97id/gLcNgaMhK5WWtlduiDlC9LxfHeReOvlxVFsbMxdkTTfqiGtotRdLxZnqhgIWij5w12Yb/MGV784BgbUcZX8U4eBG6jxGRy9yUe0fQcoOXuCyqGjBqGbxjNDyi2uQ02wCR+K01ghB8gIn/Dg8xvh6e9rTk4B4uueB7MSS8zoK2kHsG25LMacHGm+OnfLkmc+0DTpWV2PDlCk8kLP1/RldTHDQezYD7j1k0dJMlHUhuIGhgCPcPVXcRWNgCGht1XSzH1x1Ybph8PQplgffaCyK0kBUWDGh0pec5/KDqJaKwuu73CgJK2vQN7/vtLJ5BC4WdqMUbLq6ScAL+e0jo9upYcnKiMJTtTsYxoY73ZGcaN46cEeRcvtTA=", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "aquantia.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "2faefe88-30ba-44a3-c308-08d6a6fee651", "X-MS-Exchange-CrossTenant-originalarrivaltime": "12 Mar 2019 15:25:03.9198\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "83e2e134-991c-4ede-8ced-34d47e38e6b1", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM6PR11MB3068", "Subject": "[dpdk-dev] [PATCH v3 07/10] net/atlantic: fix link configuration", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In case link speed is re configured after port start, it does not\ntakes the requested speed value, but instead just sets full autoneg\nmask.\n\nCc: stable@dpdk.org\nFixes: 7943ba05f67c (\"net/atlantic: add link status and interrupt management\")\nSigned-off-by: Igor Russkikh <igor.russkikh@aquantia.com>\n---\n drivers/net/atlantic/atl_ethdev.c | 44 ++++++++++++++-----------------\n 1 file changed, 20 insertions(+), 24 deletions(-)", "diff": "diff --git a/drivers/net/atlantic/atl_ethdev.c b/drivers/net/atlantic/atl_ethdev.c\nindex a510646a5f7e..e43e1e724696 100644\n--- a/drivers/net/atlantic/atl_ethdev.c\n+++ b/drivers/net/atlantic/atl_ethdev.c\n@@ -465,8 +465,6 @@ atl_dev_start(struct rte_eth_dev *dev)\n \tstruct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);\n \tstruct rte_intr_handle *intr_handle = &pci_dev->intr_handle;\n \tuint32_t intr_vector = 0;\n-\tuint32_t *link_speeds;\n-\tuint32_t speed = 0;\n \tint status;\n \tint err;\n \n@@ -543,6 +541,8 @@ atl_dev_start(struct rte_eth_dev *dev)\n \t\tgoto error;\n \t}\n \n+\terr = atl_dev_set_link_up(dev);\n+\n \terr = hw->aq_fw_ops->update_link_status(hw);\n \n \tif (err)\n@@ -550,26 +550,6 @@ atl_dev_start(struct rte_eth_dev *dev)\n \n \tdev->data->dev_link.link_status = hw->aq_link_status.mbps != 0;\n \n-\tlink_speeds = &dev->data->dev_conf.link_speeds;\n-\n-\tspeed = 0x0;\n-\n-\tif (*link_speeds == ETH_LINK_SPEED_AUTONEG) {\n-\t\tspeed = hw->aq_nic_cfg->link_speed_msk;\n-\t} else {\n-\t\tif (*link_speeds & ETH_LINK_SPEED_10G)\n-\t\t\tspeed |= AQ_NIC_RATE_10G;\n-\t\tif (*link_speeds & ETH_LINK_SPEED_5G)\n-\t\t\tspeed |= AQ_NIC_RATE_5G;\n-\t\tif (*link_speeds & ETH_LINK_SPEED_1G)\n-\t\t\tspeed |= AQ_NIC_RATE_1G;\n-\t\tif (*link_speeds & ETH_LINK_SPEED_2_5G)\n-\t\t\tspeed |= AQ_NIC_RATE_2G5;\n-\t\tif (*link_speeds & ETH_LINK_SPEED_100M)\n-\t\t\tspeed |= AQ_NIC_RATE_100M;\n-\t}\n-\n-\terr = hw->aq_fw_ops->set_link_speed(hw, speed);\n \tif (err)\n \t\tgoto error;\n \n@@ -657,9 +637,25 @@ static int\n atl_dev_set_link_up(struct rte_eth_dev *dev)\n {\n \tstruct aq_hw_s *hw = ATL_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n+\tuint32_t link_speeds = dev->data->dev_conf.link_speeds;\n+\tuint32_t speed_mask = 0;\n+\n+\tif (link_speeds == ETH_LINK_SPEED_AUTONEG) {\n+\t\tspeed_mask = hw->aq_nic_cfg->link_speed_msk;\n+\t} else {\n+\t\tif (link_speeds & ETH_LINK_SPEED_10G)\n+\t\t\tspeed_mask |= AQ_NIC_RATE_10G;\n+\t\tif (link_speeds & ETH_LINK_SPEED_5G)\n+\t\t\tspeed_mask |= AQ_NIC_RATE_5G;\n+\t\tif (link_speeds & ETH_LINK_SPEED_1G)\n+\t\t\tspeed_mask |= AQ_NIC_RATE_1G;\n+\t\tif (link_speeds & ETH_LINK_SPEED_2_5G)\n+\t\t\tspeed_mask |= AQ_NIC_RATE_2G5;\n+\t\tif (link_speeds & ETH_LINK_SPEED_100M)\n+\t\t\tspeed_mask |= AQ_NIC_RATE_100M;\n+\t}\n \n-\treturn hw->aq_fw_ops->set_link_speed(hw,\n-\t\t\thw->aq_nic_cfg->link_speed_msk);\n+\treturn hw->aq_fw_ops->set_link_speed(hw, speed_mask);\n }\n \n /*\n", "prefixes": [ "v3", "07/10" ] }