Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/51126/?format=api
{ "id": 51126, "url": "http://patches.dpdk.org/api/patches/51126/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/d430b969a0be6b590a55e825e4085351ece79042.1552402263.git.igor.russkikh@aquantia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<d430b969a0be6b590a55e825e4085351ece79042.1552402263.git.igor.russkikh@aquantia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/d430b969a0be6b590a55e825e4085351ece79042.1552402263.git.igor.russkikh@aquantia.com", "date": "2019-03-12T15:24:57", "name": "[v3,04/10] net/atlantic: fix buffer overflow", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "643eb4d9cc9a56a7096f32250bde31d602a1292e", "submitter": { "id": 1124, "url": "http://patches.dpdk.org/api/people/1124/?format=api", "name": "Igor Russkikh", "email": "igor.russkikh@aquantia.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/d430b969a0be6b590a55e825e4085351ece79042.1552402263.git.igor.russkikh@aquantia.com/mbox/", "series": [ { "id": 3719, "url": "http://patches.dpdk.org/api/series/3719/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3719", "date": "2019-03-12T15:24:49", "name": "net/atlantic: bugfixes and code cleanup", "version": 3, "mbox": "http://patches.dpdk.org/series/3719/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/51126/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/51126/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A4C5F5398;\n\tTue, 12 Mar 2019 16:25:01 +0100 (CET)", "from NAM03-CO1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr790044.outbound.protection.outlook.com [40.107.79.44])\n\tby dpdk.org (Postfix) with ESMTP id 3A21C4CE4;\n\tTue, 12 Mar 2019 16:24:59 +0100 (CET)", "from DM6PR11MB3625.namprd11.prod.outlook.com (20.178.230.149) by\n\tDM6PR11MB2747.namprd11.prod.outlook.com (20.176.100.10) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1686.18; Tue, 12 Mar 2019 15:24:57 +0000", "from DM6PR11MB3625.namprd11.prod.outlook.com\n\t([fe80::d145:a1f4:ed34:e31b]) by\n\tDM6PR11MB3625.namprd11.prod.outlook.com\n\t([fe80::d145:a1f4:ed34:e31b%3]) with mapi id 15.20.1686.021;\n\tTue, 12 Mar 2019 15:24:57 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=hD9ukWT3lFANCKM4/GuADDJnermSg3AqLmHYBv0WSDA=;\n\tb=SaqJN1XGN/uLilU9MPF0tv2o1uIgXm9SJQdaEDuG+hTNuHqo6ePO2iQw9MWD4HFHunoNBzRqvGOjwQzhbG8UaaboNhgixpVxIL7cxM6wySUxNS6lhru/GVvfOQfdsPkWF+fbRsoEgPS6ujLto37twy2W9gM2jmkYHiWR+z0qf9w=", "From": "Igor Russkikh <Igor.Russkikh@aquantia.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>", "CC": "Pavel Belous <Pavel.Belous@aquantia.com>, Igor Russkikh\n\t<Igor.Russkikh@aquantia.com>, \"stable@dpdk.org\" <stable@dpdk.org>, Pavel\n\tBelous <Pavel.Belous@aquantia.com>", "Thread-Topic": "[PATCH v3 04/10] net/atlantic: fix buffer overflow", "Thread-Index": "AQHU2OfAzEeFbMRQEkWoGSRW5bm8Lw==", "Date": "Tue, 12 Mar 2019 15:24:57 +0000", "Message-ID": "<d430b969a0be6b590a55e825e4085351ece79042.1552402263.git.igor.russkikh@aquantia.com>", "References": "<cover.1552402263.git.igor.russkikh@aquantia.com>", "In-Reply-To": "<cover.1552402263.git.igor.russkikh@aquantia.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "HE1PR0901CA0050.eurprd09.prod.outlook.com\n\t(2603:10a6:3:45::18) To DM6PR11MB3625.namprd11.prod.outlook.com\n\t(2603:10b6:5:13a::21)", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=Igor.Russkikh@aquantia.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-mailer": "git-send-email 2.17.1", "x-originating-ip": "[95.79.108.179]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "db426902-8cf6-4493-15de-08d6a6fee2ab", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020);\n\tSRVR:DM6PR11MB2747; ", "x-ms-traffictypediagnostic": "DM6PR11MB2747:", "x-microsoft-exchange-diagnostics": "=?iso-8859-1?Q?1; DM6PR11MB2747;\n\t23:LJ5rVY/GdnpW6ZovKtHUXGE9EO3eyomn2Edungu?=\n\t=?iso-8859-1?q?JSXHj0aHk5LvD/vER/tk+c0p/?=\n\t=?iso-8859-1?q?OLx44c6yoLUj1ZYshb0UmSnrBUDdTQLTcCuZYHAI/IU+KgIVRzp?=\n\t=?iso-8859-1?q?JL4MbT2QhV/hS8Gnd6P8C2PqGunbIfkmfc7WHlzSCByLPdibuJE?=\n\t=?iso-8859-1?q?C34FxXhn+oMC0zKZToVR1Hap5S3S9rIODUJ5s8r276zmp7plBGG?=\n\t=?iso-8859-1?q?43ymsjIS41xIu91VloqxwiObjNaKRsEbcfO1f4Rlo76L6MeKVSd?=\n\t=?iso-8859-1?q?GZLJgBYsVV0R9c2ZBjgZ71rGtNAv/CGl3JWb3WecWJffLQx6uhG?=\n\t=?iso-8859-1?q?quD1/Ed2NlBkAyun6K2vLK19zOIstY+01dQt7xihLRRjc3Ot7vs?=\n\t=?iso-8859-1?q?WKTQer7fgWSzDh0wjEikStqtQwql/fHKEMBbPswghj31mZZCArG?=\n\t=?iso-8859-1?q?bkHrxxUJaTgzUCyRUklyjHbbEj7kOAVBdMwhvC0CJD/GQ5KnyQe?=\n\t=?iso-8859-1?q?2YwB1uLbDCJrZ/Bjzu54GsJSoMIs7352+5ox04J4QOtOhqMDvWi?=\n\t=?iso-8859-1?q?zkdbZ3ZNJIErc/EMslvngPCP0n4wtAbzcv/wsRB+5Ojr4V8q/l9?=\n\t=?iso-8859-1?q?Y/7hUkWK0xqb2YnLddq0OzLxX4JBWdtgn0IeWfL6HmwGK4R/Vj5?=\n\t=?iso-8859-1?q?ktlwoFasf5R50btM1JwCwpc4sI6JA6I1AghfiemKkK6BXwW944R?=\n\t=?iso-8859-1?q?HdsB7Xf49mFPPOF3DHX/zb5kHXW0tZy0qNq270K3HzSDXxXks8/?=\n\t=?iso-8859-1?q?y5cngI8YjfS0AeBLebQ8HchqY8fM+a/gwO4xagVMqpStiFeCgXV?=\n\t=?iso-8859-1?q?5M1LmgnQS1ZovjTHoOsFOoJCrn5Qtovr/dB9L7HbTTZccBf0XVa?=\n\t=?iso-8859-1?q?aH0dtizHK84XKJOITXKyw+g3SCFNDTZ6Fh6QfxftluOajNQt5YW?=\n\t=?iso-8859-1?q?/EaJR5nooofXpkZBUbQWg1vMYXG+2lIRECdsb1lgikcJIhZNz8P?=\n\t=?iso-8859-1?q?ZcPbLnU+lXtV33y2RWTlCvXdmHI7P7BwhIzJwoxfBQKP9lfJfaF?=\n\t=?iso-8859-1?q?1irXdY+dEGBOtMg7HRDGXt+6s+UxGsbguUnhwYssRfhEyDBR212?=\n\t=?iso-8859-1?q?b/NmGGzDhMdhmCbo2IIIyeRpH+0e9BvZZZ+4k0lV5Ens9CNiv6K?=\n\t=?iso-8859-1?q?dx9YIFNRnthTrJcunNbAylzwK4UrWt1jDLKoEf+Txecms7Nvm08?=\n\t=?iso-8859-1?q?QENFNLe94HNe95OTSt1BbB8tHPbuIN1rXAqHTsImEnXtP5KH3j0?=\n\t=?iso-8859-1?q?YpyAdENE94MWb+h8oaDUUM1SCPOx2V33IPuA114ZpBY4EtK8IMY?=\n\t=?iso-8859-1?q?UkeT+hO68blS7RAPHtE9yM823Sd4Bl/SZ0JD8wr7aRw36WdEew0?=\n\t=?iso-8859-1?q?rhEvKmc/rkYkWmexW0pTlst7spFcjcg2EBkLdnHnSqfq3eBAEoh?=\n\t=?iso-8859-1?q?f0+fVg2QeU/wzLzrCinWvuiSctqEMZ5nK4RElv/K6EwegMoxD3E?=\n\t=?iso-8859-1?q?UBalgKyI+00wemltda?=", "x-microsoft-antispam-prvs": "<DM6PR11MB2747740BA56185882095E85598490@DM6PR11MB2747.namprd11.prod.outlook.com>", "x-forefront-prvs": "09749A275C", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(396003)(346002)(39850400004)(136003)(366004)(376002)(199004)(189003)(53936002)(2501003)(106356001)(86362001)(81166006)(5660300002)(99286004)(81156014)(6116002)(44832011)(2351001)(105586002)(4326008)(66066001)(2616005)(71200400001)(486006)(72206003)(478600001)(446003)(476003)(186003)(118296001)(14454004)(26005)(54906003)(71190400001)(11346002)(386003)(6506007)(305945005)(102836004)(25786009)(7736002)(14444005)(50226002)(3846002)(256004)(107886003)(316002)(36756003)(450100002)(6916009)(6486002)(52116002)(1730700003)(8676002)(76176011)(6512007)(97736004)(8936002)(68736007)(6436002)(2906002)(5640700003);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR11MB2747;\n\tH:DM6PR11MB3625.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; A:1; MX:1; ", "received-spf": "None (protection.outlook.com: aquantia.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "JaVvY/xXZpTvcPPlROe2KQAmtmdFKw8a+iZBBFke8KSAj82OT6/pFqWpEFUGt2IW8RRxSUtEEFhjPLt1XEnurgYkO7xP/JPpFAjAmX0O/h1CXBqoFdO8Bk/hHvrauWPm0oKQyn+BwM6W/sI5291fDbEM0vdGIQimVwr3FmIc084JOCkhwIKxXPqrm8Pr1qw/MlXDnelxf9zXqi6GXeLYRhwBBC4IuQtpTDKkHx04t6WrsY4U4D1yo67Fz9MYo+8Sa66hU1XIqlx6sxBdM7g6RbHJ8h5NAIpnXwYjzV4ZlX+PVhKECmr3eISxd+pkN/sudAXKggvEKG/UPpw7npSMs9tSh5Va/hrlu+gR3uaRtweXJ5pf204XztS1a6SV0q36AxgAj/ghTEYgQuThjBJkSIo8Z2V0ki+ZqHxNhgig7Zs=", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "aquantia.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "db426902-8cf6-4493-15de-08d6a6fee2ab", "X-MS-Exchange-CrossTenant-originalarrivaltime": "12 Mar 2019 15:24:57.7973\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "83e2e134-991c-4ede-8ced-34d47e38e6b1", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM6PR11MB2747", "Subject": "[dpdk-dev] [PATCH v3 04/10] net/atlantic: fix buffer overflow", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Pavel Belous <Pavel.Belous@aquantia.com>\n\nFound by Coverity scan. This is a real memory corruption.\nThere is no need in extra RTE_ALIGN macros since the\nrequest/result structures are 4-byte aligned by definition.\n\nCc: stable@dpdk.org\nFixes: ce4e8d418097 (\"net/atlantic: implement EEPROM get/set\")\nCoverity issue: 323518\nCoverity issue: 323520\nSigned-off-by: Igor Russkikh <igor.russkikh@aquantia.com>\nSigned-off-by: Pavel Belous <Pavel.Belous@aquantia.com>\n---\n drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c b/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c\nindex 6841d9bce39c..f90ccfe9e010 100644\n--- a/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c\n+++ b/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c\n@@ -501,7 +501,7 @@ static int aq_fw2x_get_eeprom(struct aq_hw_s *self, u32 *data, u32 len)\n \t/* Write SMBUS request to cfg memory */\n \terr = hw_atl_utils_fw_upload_dwords(self, self->rpc_addr,\n \t\t\t\t(u32 *)(void *)&request,\n-\t\t\t\tRTE_ALIGN(sizeof(request), sizeof(u32)));\n+\t\t\t\tsizeof(request) / sizeof(u32));\n \n \tif (err < 0)\n \t\treturn err;\n@@ -523,7 +523,7 @@ static int aq_fw2x_get_eeprom(struct aq_hw_s *self, u32 *data, u32 len)\n \n \terr = hw_atl_utils_fw_downld_dwords(self, self->rpc_addr + sizeof(u32),\n \t\t\t&result,\n-\t\t\tRTE_ALIGN(sizeof(result), sizeof(u32)));\n+\t\t\tsizeof(result) / sizeof(u32));\n \n \tif (err < 0)\n \t\treturn err;\n@@ -558,7 +558,7 @@ static int aq_fw2x_set_eeprom(struct aq_hw_s *self, u32 *data, u32 len)\n \t/* Write SMBUS request to cfg memory */\n \terr = hw_atl_utils_fw_upload_dwords(self, self->rpc_addr,\n \t\t\t\t(u32 *)(void *)&request,\n-\t\t\t\tRTE_ALIGN(sizeof(request), sizeof(u32)));\n+\t\t\t\tsizeof(request) / sizeof(u32));\n \n \tif (err < 0)\n \t\treturn err;\n@@ -589,7 +589,7 @@ static int aq_fw2x_set_eeprom(struct aq_hw_s *self, u32 *data, u32 len)\n \t/* Read status of write operation */\n \terr = hw_atl_utils_fw_downld_dwords(self, self->rpc_addr + sizeof(u32),\n \t\t\t\t&result,\n-\t\t\t\tRTE_ALIGN(sizeof(result), sizeof(u32)));\n+\t\t\t\tsizeof(result) / sizeof(u32));\n \n \tif (err < 0)\n \t\treturn err;\n", "prefixes": [ "v3", "04/10" ] }