Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/51125/?format=api
{ "id": 51125, "url": "http://patches.dpdk.org/api/patches/51125/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/9878dd7a3e0652025e6cdb4c9e2b6e889e2e33e9.1552402263.git.igor.russkikh@aquantia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<9878dd7a3e0652025e6cdb4c9e2b6e889e2e33e9.1552402263.git.igor.russkikh@aquantia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/9878dd7a3e0652025e6cdb4c9e2b6e889e2e33e9.1552402263.git.igor.russkikh@aquantia.com", "date": "2019-03-12T15:24:55", "name": "[v3,03/10] net/atlantic: extra checks for error codes", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ee718e6398c3d3614f4e9f853b6363aeae75bb1e", "submitter": { "id": 1124, "url": "http://patches.dpdk.org/api/people/1124/?format=api", "name": "Igor Russkikh", "email": "igor.russkikh@aquantia.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/9878dd7a3e0652025e6cdb4c9e2b6e889e2e33e9.1552402263.git.igor.russkikh@aquantia.com/mbox/", "series": [ { "id": 3719, "url": "http://patches.dpdk.org/api/series/3719/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3719", "date": "2019-03-12T15:24:49", "name": "net/atlantic: bugfixes and code cleanup", "version": 3, "mbox": "http://patches.dpdk.org/series/3719/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/51125/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/51125/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 92A2A4D3A;\n\tTue, 12 Mar 2019 16:24:59 +0100 (CET)", "from NAM03-CO1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr790083.outbound.protection.outlook.com [40.107.79.83])\n\tby dpdk.org (Postfix) with ESMTP id 08E254CA9\n\tfor <dev@dpdk.org>; Tue, 12 Mar 2019 16:24:57 +0100 (CET)", "from DM6PR11MB3625.namprd11.prod.outlook.com (20.178.230.149) by\n\tDM6PR11MB2747.namprd11.prod.outlook.com (20.176.100.10) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1686.18; Tue, 12 Mar 2019 15:24:55 +0000", "from DM6PR11MB3625.namprd11.prod.outlook.com\n\t([fe80::d145:a1f4:ed34:e31b]) by\n\tDM6PR11MB3625.namprd11.prod.outlook.com\n\t([fe80::d145:a1f4:ed34:e31b%3]) with mapi id 15.20.1686.021;\n\tTue, 12 Mar 2019 15:24:55 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=g7Ii1gRIOIBRycrBzLHNcTdLlen0JqZJaBksU87ef44=;\n\tb=C2k/QXJURdDAVAu04eZNPjSDzz0Dc7slfWGj4traU0O0QBxX7EO1pG0e8GYtcteySXa9uAFD/mGZRTXN4Lng3LZjMmWxywKcCMtLPYP693E2WF7Zez9JfXWEPNPNm0lbBa1OOntarHRm9lOnpSzpKovpO7DOwQWFkXFuEsGbN14=", "From": "Igor Russkikh <Igor.Russkikh@aquantia.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>", "CC": "Pavel Belous <Pavel.Belous@aquantia.com>, Igor Russkikh\n\t<Igor.Russkikh@aquantia.com>", "Thread-Topic": "[PATCH v3 03/10] net/atlantic: extra checks for error codes", "Thread-Index": "AQHU2Oe/hVhsezxOlkGYZSMyPLNwbA==", "Date": "Tue, 12 Mar 2019 15:24:55 +0000", "Message-ID": "<9878dd7a3e0652025e6cdb4c9e2b6e889e2e33e9.1552402263.git.igor.russkikh@aquantia.com>", "References": "<cover.1552402263.git.igor.russkikh@aquantia.com>", "In-Reply-To": "<cover.1552402263.git.igor.russkikh@aquantia.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "HE1PR0901CA0050.eurprd09.prod.outlook.com\n\t(2603:10a6:3:45::18) To DM6PR11MB3625.namprd11.prod.outlook.com\n\t(2603:10b6:5:13a::21)", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=Igor.Russkikh@aquantia.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-mailer": "git-send-email 2.17.1", "x-originating-ip": "[95.79.108.179]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "273a548b-2ebf-4130-9f5e-08d6a6fee14e", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020);\n\tSRVR:DM6PR11MB2747; ", "x-ms-traffictypediagnostic": "DM6PR11MB2747:", "x-microsoft-exchange-diagnostics": "=?iso-8859-1?Q?1; DM6PR11MB2747;\n\t23:TQPxj2+cM6EH+xHqTYC1c65u/mydgTxkrMvjlsE?=\n\t=?iso-8859-1?q?F6nj3HbtyJyUiHQuFLHspNcHM?=\n\t=?iso-8859-1?q?v1+vWgVg3++xFtXuOoVccNr1QlifaWGthA2ZAH39+SN0kjSFXEq?=\n\t=?iso-8859-1?q?Mj7REMLgx7nGTVs5bqS3QHDGK8LXwa6CYMLOUYP1Ta5fuWvwOxE?=\n\t=?iso-8859-1?q?p5nzoiJ5l27BPEu7tvfivnxnOqbWyJS1ucYHEdvIZkLuJWoXSvU?=\n\t=?iso-8859-1?q?SpHrXnBvPxkqMntp293BGL/ajWS+varZAyercH6VAKL0/9BWJWt?=\n\t=?iso-8859-1?q?oOT1ZU8RlbTYzxl3eD0kjEfaoNgvdoCWY6guml5Mg5b/kLAritc?=\n\t=?iso-8859-1?q?WNnFtlnp+HAVE6/dbeTqJ5FpRcKERtt5OigieSdslNG3dGt4CPu?=\n\t=?iso-8859-1?q?tmFiAki7v47WGnCHc5zwiDz1DbQbmpHQq5UHwLNYlL9QkoCKO0C?=\n\t=?iso-8859-1?q?TEHG6wrLBmJ+GaRkvdY96QbzyBdHs00p2YUmPRPVxxvEd+QVjWl?=\n\t=?iso-8859-1?q?mdB8D74Dy4ruCOnsvsXd9fk2556JPrVifhXGmx1uGPkQK773NYS?=\n\t=?iso-8859-1?q?CAiPh8uwd8Aq+GYpFseBNxlphNsSzItPvJsJTv1XEXNb9ffSNQl?=\n\t=?iso-8859-1?q?qxlSbFCHf7rPPYSTXLPQv3drn/DAdLWoyGan/wGecyrYdfylS/T?=\n\t=?iso-8859-1?q?hZ3yI8GcJenl+tNkfKEuEKWVQqOg9iPuNWWYUbdE4IeldsIrsQi?=\n\t=?iso-8859-1?q?hztYgbY/I93FiJR6J9m7kaE0zTBoipmEOj+p3+9TDehvUPEr8lA?=\n\t=?iso-8859-1?q?Z/mnBDiYwA31YjDi3ideJAKZMyKFzu+nKjTUGAqTkvtEdXpLCva?=\n\t=?iso-8859-1?q?T0FykRg6g5a25rQu4hk3wl1I+3Uo3N7kzB38iSnGVR3wSLiHmGo?=\n\t=?iso-8859-1?q?mubf+hEE7AxYyw/hOu+ZJBDwAweEevOvzhdcG2bMLoW/zoUv2iW?=\n\t=?iso-8859-1?q?jvOr8LjC2B+2+iGmxrET9a6RO7veTmOyAmuK4YOjsIvDJJAoc3f?=\n\t=?iso-8859-1?q?l7FRED6YYbzWQ3YDqQ2hPKF7ssbL3CbQf2D+LeNcgUOYsPllNZz?=\n\t=?iso-8859-1?q?HlG04Gm2CYcjp6kKrNVHIrtI86hgBxwJ6TeYEfK77kZN68D4i8k?=\n\t=?iso-8859-1?q?ZDp6lEiGCMkv7ludlATqmr8qqk7BFzfWm33eNm+e0efQIQbIj1+?=\n\t=?iso-8859-1?q?sL8kTBp0UtK9jxnDEqsNuTi4+USJQC1glXVYAKvbswvt/q0xNiY?=\n\t=?iso-8859-1?q?vvMahcV9Y7dEl1BoawnPTx4ao79xeljXtOxU1FK170ScHIBJDaJ?=\n\t=?iso-8859-1?q?nGQBoS89UnkJY3mJDm8fnlZ0ONGsj4TJJh4ah6gEt6haOOIzrPD?=\n\t=?iso-8859-1?q?DG1+P3JgZbDd5t6jBNbTbJIotvAeU1qXQRwtVty4xKz+RfYssm7?=\n\t=?iso-8859-1?q?5udJ+tL9qSmBCIARrWsic1lFpbivsYHN5Wo2FZNwXes/0MVxNx0?=\n\t=?iso-8859-1?q?7h9DWzmT3bdsvrB+J9/GkLjDo40D+NNI/kn7EGJ33NFcP+/M=3D?=", "x-microsoft-antispam-prvs": "<DM6PR11MB2747AF96A2390E26AAF2455C98490@DM6PR11MB2747.namprd11.prod.outlook.com>", "x-forefront-prvs": "09749A275C", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(396003)(346002)(39850400004)(136003)(366004)(376002)(199004)(189003)(53936002)(2501003)(106356001)(86362001)(81166006)(5660300002)(99286004)(81156014)(6116002)(44832011)(2351001)(105586002)(4326008)(66066001)(2616005)(71200400001)(4744005)(486006)(72206003)(478600001)(446003)(476003)(186003)(118296001)(14454004)(26005)(54906003)(71190400001)(11346002)(386003)(6506007)(305945005)(102836004)(25786009)(7736002)(50226002)(3846002)(256004)(107886003)(316002)(36756003)(6916009)(6486002)(52116002)(1730700003)(8676002)(76176011)(6512007)(97736004)(8936002)(68736007)(6436002)(2906002)(5640700003);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR11MB2747;\n\tH:DM6PR11MB3625.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; A:1; MX:1; ", "received-spf": "None (protection.outlook.com: aquantia.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "UivdVxVgrC9GlUa9psPO3HobEFhtznkkAaTo/3/Ez3ZThFDcm1k9ILtHgGX2Wvijdx/gtS/m0e+B2uX93QgVLfZxSPhpMNTILPDa1JtlOrIw5D24/tbUPEPKv9Y1l5v5T5g936q3ACIt6he0USosZwGUpbyYDOlEASzTtwNPhppIAqZLDczimbcJcu5A+Wc26/3tfwstUS0qaCnG0Sr/x/eRxDOl4Q7BiaK/NdYtH/UzoBgL1llg8khiGj/RxeAvY8/zI3f8LOPIuQcd7Pvnt4dMJr6X/q6uONZ/RIIttCFdNUXD28chcWp1x1AHBjRwBUIYu+8VmGDRZGSMd6CaLHTC2mcVaJ1tvw4tbFpZDpvjKKjQhv+xMuWLT9WK8VRReNPaLYqcQtxEwSAKJQ/Pu3M3jIlV9Fxn3o/G12sk+7U=", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "aquantia.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "273a548b-2ebf-4130-9f5e-08d6a6fee14e", "X-MS-Exchange-CrossTenant-originalarrivaltime": "12 Mar 2019 15:24:55.5947\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "83e2e134-991c-4ede-8ced-34d47e38e6b1", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM6PR11MB2747", "Subject": "[dpdk-dev] [PATCH v3 03/10] net/atlantic: extra checks for error\n\tcodes", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Found by Coverity scan. Checks are useless\nbecause at these code places err is always zero.\n\nSigned-off-by: Igor Russkikh <igor.russkikh@aquantia.com>\n---\n drivers/net/atlantic/hw_atl/hw_atl_utils.c | 5 +----\n 1 file changed, 1 insertion(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/atlantic/hw_atl/hw_atl_utils.c b/drivers/net/atlantic/hw_atl/hw_atl_utils.c\nindex f11093a50404..13f02b9f99c5 100644\n--- a/drivers/net/atlantic/hw_atl/hw_atl_utils.c\n+++ b/drivers/net/atlantic/hw_atl/hw_atl_utils.c\n@@ -462,8 +462,6 @@ int hw_atl_utils_fw_rpc_wait(struct aq_hw_s *self,\n \t\t\t\tgoto err_exit;\n \t\t}\n \t} while (sw.tid != fw.tid || 0xFFFFU == fw.len);\n-\tif (err < 0)\n-\t\tgoto err_exit;\n \n \tif (rpc) {\n \t\tif (fw.len) {\n@@ -875,8 +873,7 @@ static int aq_fw1x_set_wol(struct aq_hw_s *self, bool wol_enabled, u8 *mac)\n \t}\n \n \terr = hw_atl_utils_fw_rpc_call(self, rpc_size);\n-\tif (err < 0)\n-\t\tgoto err_exit;\n+\n err_exit:\n \treturn err;\n }\n", "prefixes": [ "v3", "03/10" ] }