Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 51104,
    "url": "http://patches.dpdk.org/api/patches/51104/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190311181544.15646-1-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190311181544.15646-1-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190311181544.15646-1-stephen@networkplumber.org",
    "date": "2019-03-11T18:15:44",
    "name": "ethdev: check for invalid device name",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "249b4b5224c69ad8de5553c19baddcaf6d0b1649",
    "submitter": {
        "id": 27,
        "url": "http://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190311181544.15646-1-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 3707,
            "url": "http://patches.dpdk.org/api/series/3707/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3707",
            "date": "2019-03-11T18:15:44",
            "name": "ethdev: check for invalid device name",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/3707/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/51104/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/51104/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 52EDC4C8E;\n\tMon, 11 Mar 2019 19:15:49 +0100 (CET)",
            "from mail-pg1-f193.google.com (mail-pg1-f193.google.com\n\t[209.85.215.193]) by dpdk.org (Postfix) with ESMTP id 74B2A49E0\n\tfor <dev@dpdk.org>; Mon, 11 Mar 2019 19:15:48 +0100 (CET)",
            "by mail-pg1-f193.google.com with SMTP id a22so4633581pgg.13\n\tfor <dev@dpdk.org>; Mon, 11 Mar 2019 11:15:48 -0700 (PDT)",
            "from shemminger-XPS-13-9360.lan (204-195-22-127.wavecable.com.\n\t[204.195.22.127]) by smtp.gmail.com with ESMTPSA id\n\tf192sm16171655pfc.180.2019.03.11.11.15.46\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 11 Mar 2019 11:15:46 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id;\n\tbh=UuTj3emvtx6KJu5w593NAp+KjMf137jVCkUzPAwoNfY=;\n\tb=HWue+Rp9ZiDPpOxD2WgTzuHdC30lfhtsPhD4ZePiYGm/nqPX6OMFaqGEeMuXoXmBBB\n\tLJ7c673pBchsD8kNBfHoU3A4q2F4WUbHUXx3B/KJ8wVLgr6kEIdvTQ4Nu+IMI4brtiTn\n\tNNaTzd6auYB5eQdGGPnmFUlNbcPMgGQSdcGqxakgub6C6ffXk6iVa7Z546M4EdRHnRXs\n\t90Z4J/Ju1sDN8m8EOe9iDZTaA2rI+8GL2hMVCcD+L2k9IAfW+RZa7JKU/5nxWh4OnWoL\n\tS3xt9GI3rP/fDv7JgF8NKAK4+g9hYXU+U9YI/1/2Rc5SZluTf2ADeynYEG5g5R3faDhw\n\tjmBQ==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=UuTj3emvtx6KJu5w593NAp+KjMf137jVCkUzPAwoNfY=;\n\tb=KLtSxTc4zThdQ5+kMY7tnQ8bZY43X4aL3TZy3Yf0RJ4rLdpVu24SSK4/kyOe0Y4093\n\txcAPJTWOUGYAU+WeNAa+Gpndcd+oesPXmo2T8XR+vloU9VLDyfXq6M9wcIC6KoczgCp/\n\tB8bwNF8dsYv+5eykueKD1Gjg89yiOS8hJwoZRNcw0aOP3SmNMNV8+Ni8Xdb13IV4WuJc\n\tkkZ+RQ5ejkQ3w7nAA7sdxMpqbjm2zQOQTKBVHpEsr/bIyyQ9GA5g5WwezI1tVNmAYMLs\n\t/foJVnXuGHd5+12j51rGD2NWcoOY9qtHskX69b9rBdWzS9zNAl1rbPy4ufNeiHGlVsCA\n\trmKA==",
        "X-Gm-Message-State": "APjAAAXZP8Qz+h8PnsaoVQ9qAo9wyVH8JtqnnZDDoapflOS8XC5NL6TV\n\tL+PqUGXrdYU0V5BGlQOlLKFZboqNMDc=",
        "X-Google-Smtp-Source": "APXvYqzrOnycCptuf3qcemGF1BGH2oj4SROL3EXmdZn20t1ssQbrl/iHlB6OP+scwzPRn4csozR/gQ==",
        "X-Received": "by 2002:a65:6559:: with SMTP id\n\ta25mr20906109pgw.99.1552328147422; \n\tMon, 11 Mar 2019 11:15:47 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>",
        "Date": "Mon, 11 Mar 2019 11:15:44 -0700",
        "Message-Id": "<20190311181544.15646-1-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.17.1",
        "Subject": "[dpdk-dev] [PATCH] ethdev: check for invalid device name",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Do not allow creating a ethernet device with a name over the\nallowed maximum (or zero length). This is safer than silently truncating\nwhich is what happens now.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\nv1 - previously sent as RFC\n\n lib/librte_ethdev/rte_ethdev.c | 10 ++++++++++\n 1 file changed, 10 insertions(+)",
    "diff": "diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c\nindex 85c1794968dd..0b81980ff71c 100644\n--- a/lib/librte_ethdev/rte_ethdev.c\n+++ b/lib/librte_ethdev/rte_ethdev.c\n@@ -439,6 +439,16 @@ rte_eth_dev_allocate(const char *name)\n \tuint16_t port_id;\n \tstruct rte_eth_dev *eth_dev = NULL;\n \n+\tif (*name) {\n+\t\tRTE_ETHDEV_LOG(ERR, \"Zero length Ethernet device name\\n\");\n+\t\treturn NULL;\n+\t}\n+\n+\tif (strnlen(name, RTE_ETH_NAME_MAX_LEN) >= RTE_ETH_NAME_MAX_LEN) {\n+\t\tRTE_ETHDEV_LOG(ERR, \"Ethernet device name is too long\\n\");\n+\t\treturn NULL;\n+\t}\n+\n \trte_eth_dev_shared_data_prepare();\n \n \t/* Synchronize port creation between primary and secondary threads. */\n",
    "prefixes": []
}