Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/51094/?format=api
{ "id": 51094, "url": "http://patches.dpdk.org/api/patches/51094/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190311173702.24471-11-ncopa@alpinelinux.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190311173702.24471-11-ncopa@alpinelinux.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190311173702.24471-11-ncopa@alpinelinux.org", "date": "2019-03-11T17:36:57", "name": "[10/15] bus/dpaa: use warn(3) instead of error(3) to improve portability", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3f9628eb0f74fdd13e7cd5b4d9b2c47b831b384e", "submitter": { "id": 1242, "url": "http://patches.dpdk.org/api/people/1242/?format=api", "name": "Natanael Copa", "email": "ncopa@alpinelinux.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190311173702.24471-11-ncopa@alpinelinux.org/mbox/", "series": [ { "id": 3705, "url": "http://patches.dpdk.org/api/series/3705/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3705", "date": "2019-03-11T17:36:47", "name": "Build fixes for musl libc", "version": 1, "mbox": "http://patches.dpdk.org/series/3705/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/51094/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/51094/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1FDC65920;\n\tMon, 11 Mar 2019 18:37:49 +0100 (CET)", "from mx1.tetrasec.net (mx1.tetrasec.net [74.117.190.25])\n\tby dpdk.org (Postfix) with ESMTP id 8C8BE5398\n\tfor <dev@dpdk.org>; Mon, 11 Mar 2019 18:37:40 +0100 (CET)", "from mx1.tetrasec.net (mail.local [127.0.0.1])\n\tby mx1.tetrasec.net (Postfix) with ESMTP id EF8759E1F68;\n\tMon, 11 Mar 2019 17:37:39 +0000 (UTC)", "from ncopa-desktop.lan (67.63.200.37.customer.cdi.no\n\t[37.200.63.67])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\t(Authenticated sender: n@tanael.org)\n\tby mx1.tetrasec.net (Postfix) with ESMTPSA id 302599E1F6A;\n\tMon, 11 Mar 2019 17:37:38 +0000 (UTC)" ], "From": "Natanael Copa <ncopa@alpinelinux.org>", "To": "dev@dpdk.org", "Cc": "Natanael Copa <ncopa@alpinelinux.org>", "Date": "Mon, 11 Mar 2019 18:36:57 +0100", "Message-Id": "<20190311173702.24471-11-ncopa@alpinelinux.org>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190311173702.24471-1-ncopa@alpinelinux.org>", "References": "<20190311173702.24471-1-ncopa@alpinelinux.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "quoted-printable", "Subject": "[dpdk-dev] [PATCH 10/15] bus/dpaa: use warn(3) instead of error(3)\n\tto improve portability", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Fix build with musl libc by using warn(3) instead of error(3).\n\nThis also fixes error message for kzmalloc failures which previously\nwould have given \"Unknown error -1\".\n\nSigned-off-by: Natanael Copa <ncopa@alpinelinux.org>\n---\n\nNote that err.h is not in POSIX standard either, but is implemented in musl\nlibc.\n\n drivers/bus/dpaa/base/fman/netcfg_layer.c | 4 ++--\n drivers/bus/dpaa/base/qbman/bman_driver.c | 6 +++---\n drivers/bus/dpaa/base/qbman/qman_driver.c | 12 ++++++------\n drivers/bus/dpaa/include/compat.h | 2 +-\n 4 files changed, 12 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/bus/dpaa/base/fman/netcfg_layer.c b/drivers/bus/dpaa/base/fman/netcfg_layer.c\nindex 6b5224203..0c3a1bfa3 100644\n--- a/drivers/bus/dpaa/base/fman/netcfg_layer.c\n+++ b/drivers/bus/dpaa/base/fman/netcfg_layer.c\n@@ -8,7 +8,7 @@\n #include <of.h>\n #include <net/if.h>\n #include <sys/ioctl.h>\n-#include <error.h>\n+#include <err.h>\n #include <net/if_arp.h>\n #include <assert.h>\n #include <unistd.h>\n@@ -89,7 +89,7 @@ netcfg_acquire(void)\n \t */\n \tskfd = socket(AF_PACKET, SOCK_RAW, 0);\n \tif (unlikely(skfd < 0)) {\n-\t\terror(0, errno, \"%s(): open(SOCK_RAW)\", __func__);\n+\t\twarn(\"%s(): open(SOCK_RAW)\", __func__);\n \t\treturn NULL;\n \t}\n \ndiff --git a/drivers/bus/dpaa/base/qbman/bman_driver.c b/drivers/bus/dpaa/base/qbman/bman_driver.c\nindex 750b756b9..dbe00d1c9 100644\n--- a/drivers/bus/dpaa/base/qbman/bman_driver.c\n+++ b/drivers/bus/dpaa/base/qbman/bman_driver.c\n@@ -40,7 +40,7 @@ static int fsl_bman_portal_init(uint32_t idx, int is_shared)\n \tret = pthread_getaffinity_np(pthread_self(), sizeof(cpu_set_t),\n \t\t\t\t &cpuset);\n \tif (ret) {\n-\t\terror(0, ret, \"pthread_getaffinity_np()\");\n+\t\twarn(\"pthread_getaffinity_np()\");\n \t\treturn ret;\n \t}\n \tpcfg.cpu = -1;\n@@ -60,7 +60,7 @@ static int fsl_bman_portal_init(uint32_t idx, int is_shared)\n \tmap.index = idx;\n \tret = process_portal_map(&map);\n \tif (ret) {\n-\t\terror(0, ret, \"process_portal_map()\");\n+\t\twarn(\"process_portal_map()\");\n \t\treturn ret;\n \t}\n \t/* Make the portal's cache-[enabled|inhibited] regions */\n@@ -105,7 +105,7 @@ static int fsl_bman_portal_finish(void)\n \tDPAA_BUG_ON(cfg != &pcfg);\n \tret = process_portal_unmap(&map.addr);\n \tif (ret)\n-\t\terror(0, ret, \"process_portal_unmap()\");\n+\t\twarn(\"process_portal_unmap()\");\n \treturn ret;\n }\n \ndiff --git a/drivers/bus/dpaa/base/qbman/qman_driver.c b/drivers/bus/dpaa/base/qbman/qman_driver.c\nindex ba153396d..163a66b30 100644\n--- a/drivers/bus/dpaa/base/qbman/qman_driver.c\n+++ b/drivers/bus/dpaa/base/qbman/qman_driver.c\n@@ -41,7 +41,7 @@ static int fsl_qman_portal_init(uint32_t index, int is_shared)\n \tret = pthread_getaffinity_np(pthread_self(), sizeof(cpu_set_t),\n \t\t\t\t &cpuset);\n \tif (ret) {\n-\t\terror(0, ret, \"pthread_getaffinity_np()\");\n+\t\twarn(\"pthread_getaffinity_np()\");\n \t\treturn ret;\n \t}\n \tqpcfg.cpu = -1;\n@@ -62,7 +62,7 @@ static int fsl_qman_portal_init(uint32_t index, int is_shared)\n \tmap.index = index;\n \tret = process_portal_map(&map);\n \tif (ret) {\n-\t\terror(0, ret, \"process_portal_map()\");\n+\t\twarn(\"process_portal_map()\");\n \t\treturn ret;\n \t}\n \tqpcfg.channel = map.channel;\n@@ -109,7 +109,7 @@ static int fsl_qman_portal_finish(void)\n \tDPAA_BUG_ON(cfg != &qpcfg);\n \tret = process_portal_unmap(&map.addr);\n \tif (ret)\n-\t\terror(0, ret, \"process_portal_unmap()\");\n+\t\twarn(\"process_portal_unmap()\");\n \treturn ret;\n }\n \n@@ -156,7 +156,7 @@ struct qman_portal *fsl_qman_portal_create(void)\n \n \tq_pcfg = kzalloc((sizeof(struct qm_portal_config)), 0);\n \tif (!q_pcfg) {\n-\t\terror(0, -1, \"q_pcfg kzalloc failed\");\n+\t\twarn(\"q_pcfg kzalloc failed\");\n \t\treturn NULL;\n \t}\n \n@@ -164,7 +164,7 @@ struct qman_portal *fsl_qman_portal_create(void)\n \tret = pthread_getaffinity_np(pthread_self(), sizeof(cpu_set_t),\n \t\t\t\t &cpuset);\n \tif (ret) {\n-\t\terror(0, ret, \"pthread_getaffinity_np()\");\n+\t\twarn(\"pthread_getaffinity_np()\");\n \t\tkfree(q_pcfg);\n \t\treturn NULL;\n \t}\n@@ -190,7 +190,7 @@ struct qman_portal *fsl_qman_portal_create(void)\n \tq_map.index = QBMAN_ANY_PORTAL_IDX;\n \tret = process_portal_map(&q_map);\n \tif (ret) {\n-\t\terror(0, ret, \"process_portal_map()\");\n+\t\twarn(\"process_portal_map()\");\n \t\tkfree(q_pcfg);\n \t\treturn NULL;\n \t}\ndiff --git a/drivers/bus/dpaa/include/compat.h b/drivers/bus/dpaa/include/compat.h\nindex 412265779..0c01c5514 100644\n--- a/drivers/bus/dpaa/include/compat.h\n+++ b/drivers/bus/dpaa/include/compat.h\n@@ -33,7 +33,7 @@\n #include <assert.h>\n #include <dirent.h>\n #include <inttypes.h>\n-#include <error.h>\n+#include <err.h>\n #include <rte_byteorder.h>\n #include <rte_atomic.h>\n #include <rte_spinlock.h>\n", "prefixes": [ "10/15" ] }