Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/51087/?format=api
{ "id": 51087, "url": "http://patches.dpdk.org/api/patches/51087/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190311173702.24471-4-ncopa@alpinelinux.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190311173702.24471-4-ncopa@alpinelinux.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190311173702.24471-4-ncopa@alpinelinux.org", "date": "2019-03-11T17:36:50", "name": "[03/15] bus/pci: add fallback for out[lwb]_p for non GNU libc", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c25a06866233d3cfae083501f048b3616c8fe060", "submitter": { "id": 1242, "url": "http://patches.dpdk.org/api/people/1242/?format=api", "name": "Natanael Copa", "email": "ncopa@alpinelinux.org" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190311173702.24471-4-ncopa@alpinelinux.org/mbox/", "series": [ { "id": 3705, "url": "http://patches.dpdk.org/api/series/3705/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3705", "date": "2019-03-11T17:36:47", "name": "Build fixes for musl libc", "version": 1, "mbox": "http://patches.dpdk.org/series/3705/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/51087/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/51087/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A19C54CBD;\n\tMon, 11 Mar 2019 18:37:35 +0100 (CET)", "from mx1.tetrasec.net (mx1.tetrasec.net [74.117.190.25])\n\tby dpdk.org (Postfix) with ESMTP id B7EB14C95\n\tfor <dev@dpdk.org>; Mon, 11 Mar 2019 18:37:31 +0100 (CET)", "from mx1.tetrasec.net (mail.local [127.0.0.1])\n\tby mx1.tetrasec.net (Postfix) with ESMTP id 337D89E1F6A;\n\tMon, 11 Mar 2019 17:37:31 +0000 (UTC)", "from ncopa-desktop.lan (67.63.200.37.customer.cdi.no\n\t[37.200.63.67])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\t(Authenticated sender: n@tanael.org)\n\tby mx1.tetrasec.net (Postfix) with ESMTPSA id 5E17A9E1F68;\n\tMon, 11 Mar 2019 17:37:30 +0000 (UTC)" ], "From": "Natanael Copa <ncopa@alpinelinux.org>", "To": "dev@dpdk.org", "Cc": "Natanael Copa <ncopa@alpinelinux.org>", "Date": "Mon, 11 Mar 2019 18:36:50 +0100", "Message-Id": "<20190311173702.24471-4-ncopa@alpinelinux.org>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190311173702.24471-1-ncopa@alpinelinux.org>", "References": "<20190311173702.24471-1-ncopa@alpinelinux.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "quoted-printable", "Subject": "[dpdk-dev] [PATCH 03/15] bus/pci: add fallback for out[lwb]_p for\n\tnon GNU libc", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add a fallback for non-GNU libc systems like musl libc for the\nnon-standard functions outl_p, outw_p and outb_p.\n\nThis ifixes the following buildtime errors when building with musl libc:\npci_uio.c:(.text+0xaa1): undefined reference to `outw_p'\npci_uio.c:(.text+0xac5): undefined reference to `outl_p'\npci_uio.c:(.text+0xadf): undefined reference to `outb_p'\n\nfixes https://bugs.dpdk.org/show_bug.cgi?id=35\n\nSigned-off-by: Natanael Copa <ncopa@alpinelinux.org>\n---\n\nPlease note that this is only compile tested with musl libc.\n\n drivers/bus/pci/linux/pci_uio.c | 32 +++++++++++++++++++++++++++++---\n 1 file changed, 29 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/bus/pci/linux/pci_uio.c b/drivers/bus/pci/linux/pci_uio.c\nindex 09ecbb7aa..6058cd9f8 100644\n--- a/drivers/bus/pci/linux/pci_uio.c\n+++ b/drivers/bus/pci/linux/pci_uio.c\n@@ -14,6 +14,32 @@\n \n #if defined(RTE_ARCH_X86)\n #include <sys/io.h>\n+#if defined(__GLIBC__)\n+#define pci_uio_outl_p outl_p\n+#define pci_uio_outw_p outw_p\n+#define pci_uio_outb_p outb_p\n+#else\n+static inline void\n+pci_uio_outl_p(unsigned int value, unsigned short int port)\n+{\n+ __asm__ __volatile__ (\"outl %0,%w1\\noutb %%al,$0x80\": :\"a\" (value),\n+\t\t\t\"Nd\" (port));\n+}\n+\n+static inline void\n+pci_uio_outw_p(unsigned short int value, unsigned short int port)\n+{\n+ __asm__ __volatile__ (\"outw %w0,%w1\\noutb %%al,$0x80\": :\"a\" (value),\n+\t\t\t\"Nd\" (port));\n+}\n+\n+static inline void\n+pci_uio_outb_p(unsigned char value, unsigned short int port)\n+{\n+ __asm__ __volatile__ (\"outb %b0,%w1\\noutb %%al,$0x80\": :\"a\" (value),\n+\t\t\t\"Nd\" (port));\n+}\n+#endif\n #endif\n \n #include <rte_log.h>\n@@ -527,21 +553,21 @@ pci_uio_ioport_write(struct rte_pci_ioport *p,\n \t\tif (len >= 4) {\n \t\t\tsize = 4;\n #if defined(RTE_ARCH_X86)\n-\t\t\toutl_p(*(const uint32_t *)s, reg);\n+\t\t\tpci_uio_outl_p(*(const uint32_t *)s, reg);\n #else\n \t\t\t*(volatile uint32_t *)reg = *(const uint32_t *)s;\n #endif\n \t\t} else if (len >= 2) {\n \t\t\tsize = 2;\n #if defined(RTE_ARCH_X86)\n-\t\t\toutw_p(*(const uint16_t *)s, reg);\n+\t\t\tpci_uio_outw_p(*(const uint16_t *)s, reg);\n #else\n \t\t\t*(volatile uint16_t *)reg = *(const uint16_t *)s;\n #endif\n \t\t} else {\n \t\t\tsize = 1;\n #if defined(RTE_ARCH_X86)\n-\t\t\toutb_p(*s, reg);\n+\t\t\tpci_uio_outb_p(*s, reg);\n #else\n \t\t\t*(volatile uint8_t *)reg = *s;\n #endif\n", "prefixes": [ "03/15" ] }