Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/51027/?format=api
{ "id": 51027, "url": "http://patches.dpdk.org/api/patches/51027/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1552283715-18723-1-git-send-email-anoobj@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1552283715-18723-1-git-send-email-anoobj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1552283715-18723-1-git-send-email-anoobj@marvell.com", "date": "2019-03-11T05:55:44", "name": "[v2] lib/cryptodev: fix driver name comparison", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "da0401af55f0d8630615dd794a62bbdd0cd8b45a", "submitter": { "id": 1205, "url": "http://patches.dpdk.org/api/people/1205/?format=api", "name": "Anoob Joseph", "email": "anoobj@marvell.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1552283715-18723-1-git-send-email-anoobj@marvell.com/mbox/", "series": [ { "id": 3694, "url": "http://patches.dpdk.org/api/series/3694/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3694", "date": "2019-03-11T05:55:44", "name": "[v2] lib/cryptodev: fix driver name comparison", "version": 2, "mbox": "http://patches.dpdk.org/series/3694/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/51027/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/51027/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 770563772;\n\tMon, 11 Mar 2019 06:55:55 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n\t[67.231.156.173]) by dpdk.org (Postfix) with ESMTP id A7959375B\n\tfor <dev@dpdk.org>; Mon, 11 Mar 2019 06:55:53 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n\tby mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id\n\tx2B5tc0p027858; Sun, 10 Mar 2019 22:55:53 -0700", "from sc-exch01.marvell.com ([199.233.58.181])\n\tby mx0b-0016f401.pphosted.com with ESMTP id 2r4dvrcq6t-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); \n\tSun, 10 Mar 2019 22:55:53 -0700", "from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH01.marvell.com\n\t(10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3;\n\tSun, 10 Mar 2019 22:55:45 -0700", "from NAM01-BN3-obe.outbound.protection.outlook.com (104.47.33.57)\n\tby SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1367.3 via Frontend Transport; Sun, 10 Mar 2019 22:55:45 -0700", "from MN2PR18MB2877.namprd18.prod.outlook.com (20.179.20.218) by\n\tMN2PR18MB2672.namprd18.prod.outlook.com (20.179.84.74) with Microsoft\n\tSMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1686.18; Mon, 11 Mar 2019 05:55:44 +0000", "from MN2PR18MB2877.namprd18.prod.outlook.com\n\t([fe80::1905:8cf6:f4a1:5d9a]) by\n\tMN2PR18MB2877.namprd18.prod.outlook.com\n\t([fe80::1905:8cf6:f4a1:5d9a%4]) with mapi id 15.20.1686.021;\n\tMon, 11 Mar 2019 05:55:44 +0000" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n\th=from : to : cc :\n\tsubject : date : message-id : references : in-reply-to : content-type\n\t: content-transfer-encoding : mime-version; s=pfpt0818;\n\tbh=4nKW9g7HuhvQaRrs1mR/j6CECSE05VZiolWToE1F8Jo=;\n\tb=N33HnBZYkkgVkf4/0nYSZn2OOWoic4F3M40H0VizIC2Tx62P1jwkLyuz9+C8rWgk+DH8\n\tFE24YCgxW5r/xrb1sgtN46USDi/XHLLuJg7Gus9pDQoaWF4z6DfhKd6rqOsBKIuWV99s\n\tBrinF3jwoAEpCttKl6MS5dvPZ4ZFdP4SieX6xlqytqiN/0xA0Dr6gdyale5q5E3P4z+1\n\tCVqlO/IoBvOFPXbPYBZ+BAQ4PY78Nh4iaVgJmaG95ZeL3c1Z1k+z/pa6hpSaeIHNxzqc\n\t4b1oDZ3cKZu38AhShQJ8ybkhG5+TK8XJlDsp0bCaLbqJEVDJZp/qyjVI5RNeZx2FSn1M\n\tsw== ", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=marvell.onmicrosoft.com; s=selector1-marvell-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=4nKW9g7HuhvQaRrs1mR/j6CECSE05VZiolWToE1F8Jo=;\n\tb=GuWs/YzLdksebj8HJ0FVzazVUv+ZdKuTkga0aMFepDKUN+cL95g/PCT774H+N4cEEE2yw7pupiXI20CX8D0jeUNmes3p3xJeWYrVz9uQRw8PMk5RlEgZ/mmQLzCYK1GO+r4Mdg8k5GQkO2RMyd0fWDBczGaw/Z6NkKWNW6QxR40=" ], "From": "Anoob Joseph <anoobj@marvell.com>", "To": "Akhil Goyal <akhil.goyal@nxp.com>, Declan Doherty\n\t<declan.doherty@intel.com>,\n\tPablo de Lara <pablo.de.lara.guarch@intel.com>", "CC": "Anoob Joseph <anoobj@marvell.com>, Ankur Dwivedi <adwivedi@marvell.com>, \n\tJerin Jacob Kollanukkaran <jerinj@marvell.com>,\n\tNarayana Prasad Raju Athreya <pathreya@marvell.com>,\n\tSuheil Chandran <schandran@marvell.com>, \"dev@dpdk.org\" <dev@dpdk.org>", "Thread-Topic": "[PATCH v2] lib/cryptodev: fix driver name comparison", "Thread-Index": "AQHU188QzNfa5uFkwUeHDLSJ/oWkIg==", "Date": "Mon, 11 Mar 2019 05:55:44 +0000", "Message-ID": "<1552283715-18723-1-git-send-email-anoobj@marvell.com>", "References": "<1549279528-10397-1-git-send-email-anoobj@marvell.com>", "In-Reply-To": "<1549279528-10397-1-git-send-email-anoobj@marvell.com>", "Accept-Language": "en-IN, en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "BMXPR01CA0014.INDPRD01.PROD.OUTLOOK.COM\n\t(2603:1096:b00:d::24) To MN2PR18MB2877.namprd18.prod.outlook.com\n\t(2603:10b6:208:3b::26)", "x-ms-exchange-messagesentrepresentingtype": "1", "x-mailer": "git-send-email 2.7.4", "x-originating-ip": "[115.113.156.2]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "348e956b-e921-404c-3a24-08d6a5e63312", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020);\n\tSRVR:MN2PR18MB2672; ", "x-ms-traffictypediagnostic": "MN2PR18MB2672:", "x-microsoft-exchange-diagnostics": "=?iso-8859-1?Q?1; MN2PR18MB2672;\n\t23:WUol04d7kVfa0d6XVpFTUTnzfQ9EwNflpTIUoVY?=\n\t=?iso-8859-1?q?WV0mnh2MV3725EQ4hZX4nF7RG?=\n\t=?iso-8859-1?q?SicmXfBV7Zqt7JBVv45hvLNrSeAPhajeDbDKsS50jM5AEsi+EfD?=\n\t=?iso-8859-1?q?7SzZb6DkBC72HfcUcuidk1+EdCLu/u885rAd8sLklN9aPWnAffO?=\n\t=?iso-8859-1?q?yVNobOFB0ztYSujk0h7RjmLGBc9KJDgKxNRimEeN2QB3MzvD3bR?=\n\t=?iso-8859-1?q?bpGx7LekA+No0eMNmeAJzmcODRontXpisHtua36HH+uflhhQ9XZ?=\n\t=?iso-8859-1?q?BxLM6x0Z0n4c8y6p1wO8gRSq4sAGsEDbU7wAbl5D8eoX8UGBo12?=\n\t=?iso-8859-1?q?HsoDjmScZz57Dqe6P14wce2zdCJbEm5H78Exu6S8T84uJrJVIfe?=\n\t=?iso-8859-1?q?1/DMbHhdKw2OBQIzSEbWbtQEMThj6nt6ME++7bKQT8BMDsKZLtc?=\n\t=?iso-8859-1?q?vXmSBTaglOzhfhgSxj14uZxQd5z2Uh/Bx46Rpkj0sXiDlLtCBkQ?=\n\t=?iso-8859-1?q?436At9qJpDl9CYL+yGJ95eYUHiLFUmh0YudwbCornkySau3EafC?=\n\t=?iso-8859-1?q?esdUKytGqkveyI/+p8ISALKGE4HERjlmNLtTvBv1hEV2B4C1Hlb?=\n\t=?iso-8859-1?q?7wuUqiH8aV5gyOJwLUkTpcVBUcs0ToIS8naDjQA3tbf32iSYlfm?=\n\t=?iso-8859-1?q?0uDXciKIQpXyOpNkzzMYvT3U+TkGnI/vIjRgoYZ+4XtqceqLP57?=\n\t=?iso-8859-1?q?xUcg3B5lxdtLqtC121rtKPm8NUOhED/t7Zf+ByMzkIwUGdVr6jw?=\n\t=?iso-8859-1?q?/eCbVlonHiRz6kBZQZ4lbEvchuac+1f9kCsRn4dE4HdicwmOXDT?=\n\t=?iso-8859-1?q?SG3a7GVPYIJMsMlnm6xSviy4pFEaXxOKcSmYgaD0PBlIiHiXPGo?=\n\t=?iso-8859-1?q?pJSOhftdy57McCV5f3Idiw0cWudEvlS7Tsm1N97g01S3uMoTBFO?=\n\t=?iso-8859-1?q?T3aF4wpK3vJR6WZM4sR39rkO6rv3I2ucGpoFnJ4tYG+wEADCTxr?=\n\t=?iso-8859-1?q?3nPj0UZQUYCcLt9k26qGkZIYT/bePZj5pDW0lFRFQTNyZrCVqOh?=\n\t=?iso-8859-1?q?LxjqZxBS4ubKgJxE1ehxu64IwMZEtMhQypBUlDO4C8Tjrer8cQM?=\n\t=?iso-8859-1?q?rRoyVLh+7Rr7ZIhBuRwmbN6Enu3O2ouCwbIeb1ZcMEHhxsMyWJs?=\n\t=?iso-8859-1?q?9i1fN3gJdn0+boHk7ks9Piw0sQ+QNOw2rXfZUW+hjNDGAbELF6e?=\n\t=?iso-8859-1?q?NAS1lHLttPKhK0kNqyEUiUxWHeRClRi+BrBJboPXtCYRxydyqSU?=\n\t=?iso-8859-1?q?RMpghfilR3kdv3/KY7YKHq9HpeUup6I9U2p3EwrMStmSuG3MDKo?=\n\t=?iso-8859-1?q?A=3D=3D?=", "x-microsoft-antispam-prvs": "<MN2PR18MB2672E472BA0D5C729D8DA78CDF480@MN2PR18MB2672.namprd18.prod.outlook.com>", "x-forefront-prvs": "09730BD177", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(136003)(396003)(39850400004)(376002)(346002)(366004)(199004)(189003)(25786009)(7736002)(36756003)(316002)(55236004)(6506007)(386003)(305945005)(102836004)(68736007)(6512007)(8936002)(97736004)(50226002)(53936002)(6436002)(6486002)(52116002)(76176011)(8676002)(3846002)(2906002)(105586002)(99286004)(81156014)(81166006)(4326008)(6116002)(486006)(476003)(66066001)(2616005)(86362001)(106356001)(14454004)(186003)(478600001)(54906003)(26005)(110136005)(71190400001)(71200400001)(11346002)(446003)(5660300002)(256004)(14444005);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB2672;\n\tH:MN2PR18MB2877.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; A:1; MX:1; ", "received-spf": "None (protection.outlook.com: marvell.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "TH3PS/uYyh2Omn7cQ7ZycB2/WMXLvU/JyWW3fl/AStMoPn6QqG6I8p//3iWU/OZUqi4YNp87GTK4OoYkXl4U3klesA0yT04ucmc8c6fYB2/7nubVGL+URrgAiIfRtiKjTn3QvcuO7eL+tgtCVayEFYQPzwmf1H4lI8VZr4xGSmnH6A0SmGtZ/z1ZABZFxBytpAsE7ff9Ol8rh9qtLe8qwPb05e0CESWydk2TZDBlx1DkAzBYPd6zPaFxOR+pri2AlgfkNosjqCOWMoxuPYJA7S5i6MXV7Y6smXCtJbRYYCVt0BmnISt1l8uLPLzBNF8niNeCVVfEpj2opfXxSu7AOzD+zIaUUbpmiaXEyxMFGARsP7FEYUV/DL1feGfK11AwCo+xa9d3/eJldG2PtSOrnhe9nVocSkLVzyS6dAnT/O0=", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-MS-Exchange-CrossTenant-Network-Message-Id": "348e956b-e921-404c-3a24-08d6a5e63312", "X-MS-Exchange-CrossTenant-originalarrivaltime": "11 Mar 2019 05:55:44.0679\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "70e1fb47-1155-421d-87fc-2e58f638b6e0", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MN2PR18MB2672", "X-OriginatorOrg": "marvell.com", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:, ,\n\tdefinitions=2019-03-11_05:, , signatures=0", "Subject": "[dpdk-dev] [PATCH v2] lib/cryptodev: fix driver name comparison", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The string compare to the length of driver name might give false\npositives when there are drivers with similar names (one being the\nsubset of another).\n\nFollowing is such a naming which could result in false positive.\n1. crypto_driver\n2. crypto_driver1\n\nWhen strncmp with len = strlen(\"crypto_driver\") is done, it could give\na false positive when compared against \"crypto_driver1\". For such cases,\n'strlen + 1' is done, so that the NULL termination also would be\nconsidered for the comparison.\n\nFixes: d11b0f30df88 (\"cryptodev: introduce API and framework for crypto devices\")\n\nSigned-off-by: Ankur Dwivedi <adwivedi@marvell.com>\nSigned-off-by: Anoob Joseph <anoobj@marvell.com>\n---\nv2:\n* Using strlen + 1, instead of RTE_CRYPTODEV_NAME_MAX_LEN for the comparison.\n* Strcmp would not cause this issue. Touching only the places which\n would result in the issue.\n\n lib/librte_cryptodev/rte_cryptodev.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c\nindex 7009735..871d7dd 100644\n--- a/lib/librte_cryptodev/rte_cryptodev.c\n+++ b/lib/librte_cryptodev/rte_cryptodev.c\n@@ -586,7 +586,7 @@ rte_cryptodev_devices_get(const char *driver_name, uint8_t *devices,\n \n \t\t\tcmp = strncmp(devs[i].device->driver->name,\n \t\t\t\t\tdriver_name,\n-\t\t\t\t\tstrlen(driver_name));\n+\t\t\t\t\tstrlen(driver_name) + 1);\n \n \t\t\tif (cmp == 0)\n \t\t\t\tdevices[count++] = devs[i].data->dev_id;\n@@ -1691,7 +1691,7 @@ rte_cryptodev_driver_id_get(const char *name)\n \n \tTAILQ_FOREACH(driver, &cryptodev_driver_list, next) {\n \t\tdriver_name = driver->driver->name;\n-\t\tif (strncmp(driver_name, name, strlen(driver_name)) == 0)\n+\t\tif (strncmp(driver_name, name, strlen(driver_name) + 1) == 0)\n \t\t\treturn driver->id;\n \t}\n \treturn -1;\n", "prefixes": [ "v2" ] }