Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/50995/?format=api
{ "id": 50995, "url": "http://patches.dpdk.org/api/patches/50995/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1552059647-2725-1-git-send-email-pablo.cascon@netronome.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1552059647-2725-1-git-send-email-pablo.cascon@netronome.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1552059647-2725-1-git-send-email-pablo.cascon@netronome.com", "date": "2019-03-08T15:40:47", "name": "[1/1] net/nfp: fix set_mac_addr", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0b159e13e44bafe06960f3e7f6d06f75da5d31ca", "submitter": { "id": 1241, "url": "http://patches.dpdk.org/api/people/1241/?format=api", "name": "Pablo Cascón", "email": "pablo.cascon@netronome.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1552059647-2725-1-git-send-email-pablo.cascon@netronome.com/mbox/", "series": [ { "id": 3681, "url": "http://patches.dpdk.org/api/series/3681/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3681", "date": "2019-03-08T15:40:47", "name": "[1/1] net/nfp: fix set_mac_addr", "version": 1, "mbox": "http://patches.dpdk.org/series/3681/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/50995/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/50995/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0BA302C52;\n\tFri, 8 Mar 2019 16:41:08 +0100 (CET)", "from mail-wm1-f66.google.com (mail-wm1-f66.google.com\n\t[209.85.128.66]) by dpdk.org (Postfix) with ESMTP id 58D692B91\n\tfor <dev@dpdk.org>; Fri, 8 Mar 2019 16:41:06 +0100 (CET)", "by mail-wm1-f66.google.com with SMTP id n19so12940852wmi.1\n\tfor <dev@dpdk.org>; Fri, 08 Mar 2019 07:41:06 -0800 (PST)", "from cbvirt1-3.netronome.com ([217.38.71.146])\n\tby smtp.googlemail.com with ESMTPSA id\n\tb10sm8135104wru.92.2019.03.08.07.41.04\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tFri, 08 Mar 2019 07:41:04 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=netronome-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=prZwodoc6Y4ZW5JsWlRE52/uEsG7NJKJX4rDsWw9yzc=;\n\tb=PWsAT+m4z/+MDH3kE3Vft/C/FyQ0sqC/4h6cDpwjMwVxtBWLA+5lBxB2rufO0WIlta\n\t1jUlECf8OhtMxnOMa1GxKEpauCsgFWmZWTbq/hJAT9aOdvrQdx3IbMNI8R626LxJIsAW\n\tKDZmn9OEpkytGAdnMBSBWPFy5MYXL7rza7GUbqC4m5DUU29GTq1D2ZTOvGxO2oTFF5d1\n\tb3EYL4zdnXQFPL3NjBxhnRwJ+GP5CcEXfWZ3HUiyJRshg5HQtKjiv/lQCL8osXFjUsAS\n\tOYcA9AjGam7f39oCeUJrwo6RnKq1tSKpHj7j43nzJd4oFxjRABllNcODKAFI/01ffPK4\n\toLPA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=prZwodoc6Y4ZW5JsWlRE52/uEsG7NJKJX4rDsWw9yzc=;\n\tb=MXzBEf/wovgt0jPsughnnfkhIStYw8VvmZvq2Qc/ZFyCenMFnasouAJJMVXyi5ARW6\n\tNwhdqKzjakiKePKuOjqV6dh9tf5aJOFG0MyZUJgTGXeiWQNusFPSH9p3YLiCCyLi0//H\n\tDWzhxj8CwRBfscwfgLdCUVwhNwPzbVVdxXU0sZgyMiAMGVy5IQQLAFdkQr2JvngNmmKE\n\tDyC9r5p2SI+C6xq+yJlaycBa/u2CwRe34A5J53qLzptQkhijnMbxSO6UBXl/XQ8BrEHx\n\tNQcrYETFbjmhBCICQlB44ruRhWxYAAlYdrcAqbjKN7MYOGgHPvTco+oIgdwPJRyANTD+\n\t3TVQ==", "X-Gm-Message-State": "APjAAAV/NsaYAXVoRnCNiGO7CVAGG5EmQX/rnD2yp7Qxzxb0CTQbUlEU\n\tYU7zvaDXbmOXXpWDpJtfjbbIC5rlXcA=", "X-Google-Smtp-Source": "APXvYqzqHFZmAQJ6NsXcHlV2RM8YUQr38bwDsK4GXzXuX952gi/N8VyNwDYrWsLZNfGLRpfLrBJaNg==", "X-Received": "by 2002:a1c:1dcd:: with SMTP id\n\td196mr9543846wmd.146.1552059665660; \n\tFri, 08 Mar 2019 07:41:05 -0800 (PST)", "From": "=?utf-8?q?Pablo_Casc=C3=B3n?= <pablo.cascon@netronome.com>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org, =?utf-8?q?Pablo_Casc=C3=B3n?=\n\t<pablo.cascon@netronome.com>", "Date": "Fri, 8 Mar 2019 15:40:47 +0000", "Message-Id": "<1552059647-2725-1-git-send-email-pablo.cascon@netronome.com>", "X-Mailer": "git-send-email 2.7.4", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/1] net/nfp: fix set_mac_addr", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Some firmwares, mostly for VFs, do not advertise the feature /\ncapability of changing the MAC address while the interface is up. With\nsuch firmware a request to change the MAC address that at the same\ntime also tries to enable the not available feature will be denied by\nthe firmware resulting in an error message like:\n\nnfp_net_reconfig(): Error nfp_net reconfig for ctrl: 80000000 update: 800\n\nFix set_mac_addr by not trying to enable a feature if it is not\nadvertised by the firmware.\n\nFixes: 2fe669f4bcd2 (\"net/nfp: support MAC address change\")\n\nSigned-off-by: Pablo Cascón <pablo.cascon@netronome.com>\n---\n drivers/net/nfp/nfp_net.c | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c\nindex 54c6da9..278e154 100644\n--- a/drivers/net/nfp/nfp_net.c\n+++ b/drivers/net/nfp/nfp_net.c\n@@ -566,7 +566,10 @@ nfp_set_mac_addr(struct rte_eth_dev *dev, struct ether_addr *mac_addr)\n \n \t/* Signal the NIC about the change */\n \tupdate = NFP_NET_CFG_UPDATE_MACADDR;\n-\tctrl = hw->ctrl | NFP_NET_CFG_CTRL_LIVE_ADDR;\n+\tctrl = hw->ctrl;\n+\tif ((hw->ctrl & NFP_NET_CFG_CTRL_ENABLE) &&\n+\t (hw->cap & NFP_NET_CFG_CTRL_LIVE_ADDR))\n+\t\tctrl |= NFP_NET_CFG_CTRL_LIVE_ADDR;\n \tif (nfp_net_reconfig(hw, ctrl, update) < 0) {\n \t\tPMD_INIT_LOG(INFO, \"MAC address update failed\");\n \t\treturn -EIO;\n", "prefixes": [ "1/1" ] }