Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/50758/?format=api
{ "id": 50758, "url": "http://patches.dpdk.org/api/patches/50758/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190302104251.32565-13-hyonkim@cisco.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190302104251.32565-13-hyonkim@cisco.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190302104251.32565-13-hyonkim@cisco.com", "date": "2019-03-02T10:42:50", "name": "[v2,12/13] net/enic: fix an endian bug in VLAN match", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "552aee4b46ed924b4cf6051b8a531b5a80021e29", "submitter": { "id": 948, "url": "http://patches.dpdk.org/api/people/948/?format=api", "name": "Hyong Youb Kim (hyonkim)", "email": "hyonkim@cisco.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190302104251.32565-13-hyonkim@cisco.com/mbox/", "series": [ { "id": 3613, "url": "http://patches.dpdk.org/api/series/3613/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3613", "date": "2019-03-02T10:42:38", "name": "net/enic: 19.05 updates", "version": 2, "mbox": "http://patches.dpdk.org/series/3613/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/50758/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/50758/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7D4842C38;\n\tSat, 2 Mar 2019 11:46:04 +0100 (CET)", "from alln-iport-5.cisco.com (alln-iport-5.cisco.com\n\t[173.37.142.92]) by dpdk.org (Postfix) with ESMTP id BB4DF2B9E;\n\tSat, 2 Mar 2019 11:46:02 +0100 (CET)", "from rcdn-core-11.cisco.com ([173.37.93.147])\n\tby alln-iport-5.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t02 Mar 2019 10:46:01 +0000", "from cisco.com (savbu-usnic-a.cisco.com [10.193.184.48])\n\tby rcdn-core-11.cisco.com (8.15.2/8.15.2) with ESMTP id\n\tx22Ak0Cn004550; Sat, 2 Mar 2019 10:46:00 GMT", "by cisco.com (Postfix, from userid 508933)\n\tid 9131520F2001; Sat, 2 Mar 2019 02:46:00 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n\td=cisco.com; i=@cisco.com; l=3229; q=dns/txt; s=iport;\n\tt=1551523563; x=1552733163;\n\th=from:to:cc:subject:date:message-id:in-reply-to: references;\n\tbh=Q5FVgCoRgrL12wvL5QS9YvoEWhpOFA+f+o/eDOFZaBo=;\n\tb=ZXgF4kOO8qDnGXZ0ULvzL/YFkMXVHEa2TM05VHcXudJoF+A7BjqiVVAv\n\tb2geRzLTV9iOH+OvIUxs2G7HwonYcTBkK93lnPsMVYcFqu+h9K8lTrlnI\n\tPx6B2rN0b3Xa+/INXLyMuZHAhOFcZ8gg3b55U3ZG+hWQRNbtJFIkbdyaa 4=;", "X-IronPort-AV": "E=Sophos;i=\"5.58,431,1544486400\"; d=\"scan'208\";a=\"241307553\"", "From": "Hyong Youb Kim <hyonkim@cisco.com>", "To": "Ferruh Yigit <ferruh.yigit@intel.com>", "Cc": "dev@dpdk.org, John Daley <johndale@cisco.com>,\n\tHyong Youb Kim <hyonkim@cisco.com>, stable@dpdk.org", "Date": "Sat, 2 Mar 2019 02:42:50 -0800", "Message-Id": "<20190302104251.32565-13-hyonkim@cisco.com>", "X-Mailer": "git-send-email 2.16.2", "In-Reply-To": "<20190302104251.32565-1-hyonkim@cisco.com>", "References": "<20190302104251.32565-1-hyonkim@cisco.com>", "X-Outbound-SMTP-Client": "10.193.184.48, savbu-usnic-a.cisco.com", "X-Outbound-Node": "rcdn-core-11.cisco.com", "Subject": "[dpdk-dev] [PATCH v2 12/13] net/enic: fix an endian bug in VLAN\n\tmatch", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The VLAN fields in the NIC filter use little endian. The VLAN item is\nin big endian, so swap bytes.\n\nFixes: 6ced137607d0 (\"net/enic: flow API for NICs with advanced filters enabled\")\nCc: stable@dpdk.org\n\nSigned-off-by: Hyong Youb Kim <hyonkim@cisco.com>\n---\n doc/guides/nics/enic.rst | 10 ++++++++--\n drivers/net/enic/enic_flow.c | 12 ++++++++----\n 2 files changed, 16 insertions(+), 6 deletions(-)", "diff": "diff --git a/doc/guides/nics/enic.rst b/doc/guides/nics/enic.rst\nindex c1415dc0d..d4241ef45 100644\n--- a/doc/guides/nics/enic.rst\n+++ b/doc/guides/nics/enic.rst\n@@ -247,7 +247,7 @@ Generic Flow API is supported. The baseline support is:\n in the pattern.\n \n - Attributes: ingress\n- - Items: eth, ipv4, ipv6, udp, tcp, vxlan, inner eth, ipv4, ipv6, udp, tcp\n+ - Items: eth, vlan, ipv4, ipv6, udp, tcp, vxlan, inner eth, vlan, ipv4, ipv6, udp, tcp\n - Actions: queue and void\n - Selectors: 'is', 'spec' and 'mask'. 'last' is not supported\n - In total, up to 64 bytes of mask is allowed across all headers\n@@ -255,7 +255,7 @@ Generic Flow API is supported. The baseline support is:\n - **1300 and later series VICS with advanced filters enabled**\n \n - Attributes: ingress\n- - Items: eth, ipv4, ipv6, udp, tcp, vxlan, raw, inner eth, ipv4, ipv6, udp, tcp\n+ - Items: eth, vlan, ipv4, ipv6, udp, tcp, vxlan, raw, inner eth, vlan, ipv4, ipv6, udp, tcp\n - Actions: queue, mark, drop, flag, rss, passthru, and void\n - Selectors: 'is', 'spec' and 'mask'. 'last' is not supported\n - In total, up to 64 bytes of mask is allowed across all headers\n@@ -266,6 +266,12 @@ Generic Flow API is supported. The baseline support is:\n \n - Action: count\n \n+The VIC performs packet matching after applying VLAN strip. If VLAN\n+stripping is enabled, EtherType in the ETH item corresponds to the\n+stripped VLAN header's EtherType. Stripping does not affect the VLAN\n+item. TCI and EtherType in the VLAN item are matched against those in\n+the (stripped) VLAN header whether stripping is enabled or disabled.\n+\n More features may be added in future firmware and new versions of the VIC.\n Please refer to the release notes.\n \ndiff --git a/drivers/net/enic/enic_flow.c b/drivers/net/enic/enic_flow.c\nindex da43b31dc..b3172e7be 100644\n--- a/drivers/net/enic/enic_flow.c\n+++ b/drivers/net/enic/enic_flow.c\n@@ -579,12 +579,16 @@ enic_copy_item_vlan_v2(struct copy_item_args *arg)\n \t\t/* Outer TPID cannot be matched */\n \t\tif (eth_mask->ether_type)\n \t\t\treturn ENOTSUP;\n+\t\t/*\n+\t\t * When packet matching, the VIC always compares vlan-stripped\n+\t\t * L2, regardless of vlan stripping settings. So, the inner type\n+\t\t * from vlan becomes the ether type of the eth header.\n+\t\t */\n \t\teth_mask->ether_type = mask->inner_type;\n \t\teth_val->ether_type = spec->inner_type;\n-\n-\t\t/* Outer header. Use the vlan mask/val fields */\n-\t\tgp->mask_vlan = mask->tci;\n-\t\tgp->val_vlan = spec->tci;\n+\t\t/* For TCI, use the vlan mask/val fields (little endian). */\n+\t\tgp->mask_vlan = rte_be_to_cpu_16(mask->tci);\n+\t\tgp->val_vlan = rte_be_to_cpu_16(spec->tci);\n \t} else {\n \t\t/* Inner header. Mask/Val start at *inner_ofst into L5 */\n \t\tif ((*inner_ofst + sizeof(struct vlan_hdr)) >\n", "prefixes": [ "v2", "12/13" ] }