Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/50753/?format=api
{ "id": 50753, "url": "http://patches.dpdk.org/api/patches/50753/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190302104251.32565-8-hyonkim@cisco.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190302104251.32565-8-hyonkim@cisco.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190302104251.32565-8-hyonkim@cisco.com", "date": "2019-03-02T10:42:45", "name": "[v2,07/13] net/enic: enable limited PASSTHRU flow action", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6c2aca5e973a9936bc64cc68ad85035a650e5590", "submitter": { "id": 948, "url": "http://patches.dpdk.org/api/people/948/?format=api", "name": "Hyong Youb Kim (hyonkim)", "email": "hyonkim@cisco.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190302104251.32565-8-hyonkim@cisco.com/mbox/", "series": [ { "id": 3613, "url": "http://patches.dpdk.org/api/series/3613/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3613", "date": "2019-03-02T10:42:38", "name": "net/enic: 19.05 updates", "version": 2, "mbox": "http://patches.dpdk.org/series/3613/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/50753/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/50753/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 69E214C74;\n\tSat, 2 Mar 2019 11:44:44 +0100 (CET)", "from alln-iport-2.cisco.com (alln-iport-2.cisco.com\n\t[173.37.142.89]) by dpdk.org (Postfix) with ESMTP id A83404C74\n\tfor <dev@dpdk.org>; Sat, 2 Mar 2019 11:44:42 +0100 (CET)", "from rcdn-core-12.cisco.com ([173.37.93.148])\n\tby alln-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t02 Mar 2019 10:44:41 +0000", "from cisco.com (savbu-usnic-a.cisco.com [10.193.184.48])\n\tby rcdn-core-12.cisco.com (8.15.2/8.15.2) with ESMTP id\n\tx22Aif2e001188; Sat, 2 Mar 2019 10:44:41 GMT", "by cisco.com (Postfix, from userid 508933)\n\tid 4401E20F2001; Sat, 2 Mar 2019 02:44:41 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n\td=cisco.com; i=@cisco.com; l=4128; q=dns/txt; s=iport;\n\tt=1551523482; x=1552733082;\n\th=from:to:cc:subject:date:message-id:in-reply-to: references;\n\tbh=pYrkt6WqCMrajrmJMPPHCjWUw+/C808Fue1gv2yI/Wk=;\n\tb=EH7stdy+SrG+Ws3rEuMEJvts+0HGjuQ+//3O3ECeVIEdEZnz72v6hJZQ\n\tOPaB15iHUki47sDkVJqdEvoe7oZZ/ssCGTB58Bbdh0/A5dzgcpwbwbGMo\n\tZr2nPoK6W3hJ+ByNvJv7m0P6fu/638E43GTin8ZC2ouQq7WqFcGbVhT10 g=;", "X-IronPort-AV": "E=Sophos;i=\"5.58,431,1544486400\"; d=\"scan'208\";a=\"241896055\"", "From": "Hyong Youb Kim <hyonkim@cisco.com>", "To": "Ferruh Yigit <ferruh.yigit@intel.com>", "Cc": "dev@dpdk.org, John Daley <johndale@cisco.com>,\n\tHyong Youb Kim <hyonkim@cisco.com>", "Date": "Sat, 2 Mar 2019 02:42:45 -0800", "Message-Id": "<20190302104251.32565-8-hyonkim@cisco.com>", "X-Mailer": "git-send-email 2.16.2", "In-Reply-To": "<20190302104251.32565-1-hyonkim@cisco.com>", "References": "<20190302104251.32565-1-hyonkim@cisco.com>", "X-Outbound-SMTP-Client": "10.193.184.48, savbu-usnic-a.cisco.com", "X-Outbound-Node": "rcdn-core-12.cisco.com", "Subject": "[dpdk-dev] [PATCH v2 07/13] net/enic: enable limited PASSTHRU flow\n\taction", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Some apps like VPP use PASSTHRU+MARK flow rules to offload packet\nmatching to the NIC. Just like MARK+RSS used by OVS-DPDK and others,\nPASSTHRU+MARK is used to \"mark and then receive normally\". Recent VIC\nadapters support such flow rules, so enable PASSTHRU for this limited\nuse case.\n\nSigned-off-by: Hyong Youb Kim <hyonkim@cisco.com>\n---\n doc/guides/nics/enic.rst | 6 +++++-\n doc/guides/rel_notes/release_19_05.rst | 1 +\n drivers/net/enic/enic_flow.c | 20 ++++++++++++++++++++\n 3 files changed, 26 insertions(+), 1 deletion(-)", "diff": "diff --git a/doc/guides/nics/enic.rst b/doc/guides/nics/enic.rst\nindex ed093ef44..526e58ce9 100644\n--- a/doc/guides/nics/enic.rst\n+++ b/doc/guides/nics/enic.rst\n@@ -256,7 +256,7 @@ Generic Flow API is supported. The baseline support is:\n \n - Attributes: ingress\n - Items: eth, ipv4, ipv6, udp, tcp, vxlan, inner eth, ipv4, ipv6, udp, tcp\n- - Actions: queue, mark, drop, flag, rss, and void\n+ - Actions: queue, mark, drop, flag, rss, passthru, and void\n - Selectors: 'is', 'spec' and 'mask'. 'last' is not supported\n - In total, up to 64 bytes of mask is allowed across all headers\n \n@@ -451,6 +451,10 @@ PKT_RX_VLAN_STRIPPED mbuf flags would not be set. This mode is enabled with the\n were added. Since there currently is no grouping or priority support,\n 'catch-all' filters should be added last.\n - The supported range of IDs for the 'MARK' action is 0 - 0xFFFD.\n+ - RSS and PASSTHRU actions only support \"receive normally\". They are limited\n+ to supporting MARK + RSS and PASSTHRU + MARK to allow the application to mark\n+ packets and then receive them normally. These require 1400 series VIC adapters\n+ and latest firmware.\n \n - **Statistics**\n \ndiff --git a/doc/guides/rel_notes/release_19_05.rst b/doc/guides/rel_notes/release_19_05.rst\nindex 73403c79e..c8c12c47a 100644\n--- a/doc/guides/rel_notes/release_19_05.rst\n+++ b/doc/guides/rel_notes/release_19_05.rst\n@@ -80,6 +80,7 @@ New Features\n * **Updated the enic driver.**\n \n * Added limited support for RSS.\n+ * Added limited support for PASSTHRU.\n \n Removed Items\n -------------\ndiff --git a/drivers/net/enic/enic_flow.c b/drivers/net/enic/enic_flow.c\nindex 0f6b6b930..c6ed9e1b9 100644\n--- a/drivers/net/enic/enic_flow.c\n+++ b/drivers/net/enic/enic_flow.c\n@@ -283,6 +283,7 @@ static const enum rte_flow_action_type enic_supported_actions_v2_id[] = {\n \tRTE_FLOW_ACTION_TYPE_MARK,\n \tRTE_FLOW_ACTION_TYPE_FLAG,\n \tRTE_FLOW_ACTION_TYPE_RSS,\n+\tRTE_FLOW_ACTION_TYPE_PASSTHRU,\n \tRTE_FLOW_ACTION_TYPE_END,\n };\n \n@@ -292,6 +293,7 @@ static const enum rte_flow_action_type enic_supported_actions_v2_drop[] = {\n \tRTE_FLOW_ACTION_TYPE_FLAG,\n \tRTE_FLOW_ACTION_TYPE_DROP,\n \tRTE_FLOW_ACTION_TYPE_RSS,\n+\tRTE_FLOW_ACTION_TYPE_PASSTHRU,\n \tRTE_FLOW_ACTION_TYPE_END,\n };\n \n@@ -302,6 +304,7 @@ static const enum rte_flow_action_type enic_supported_actions_v2_count[] = {\n \tRTE_FLOW_ACTION_TYPE_DROP,\n \tRTE_FLOW_ACTION_TYPE_COUNT,\n \tRTE_FLOW_ACTION_TYPE_RSS,\n+\tRTE_FLOW_ACTION_TYPE_PASSTHRU,\n \tRTE_FLOW_ACTION_TYPE_END,\n };\n \n@@ -1072,6 +1075,7 @@ enic_copy_action_v2(struct enic *enic,\n {\n \tenum { FATE = 1, MARK = 2, };\n \tuint32_t overlap = 0;\n+\tbool passthru = false;\n \n \tFLOW_TRACE();\n \n@@ -1164,6 +1168,19 @@ enic_copy_action_v2(struct enic *enic,\n \t\t\toverlap |= FATE;\n \t\t\tbreak;\n \t\t}\n+\t\tcase RTE_FLOW_ACTION_TYPE_PASSTHRU: {\n+\t\t\t/*\n+\t\t\t * Like RSS above, PASSTHRU + MARK may be used to\n+\t\t\t * \"mark and then receive normally\". MARK usually comes\n+\t\t\t * after PASSTHRU, so remember we have seen passthru\n+\t\t\t * and check for mark later.\n+\t\t\t */\n+\t\t\tif (overlap & FATE)\n+\t\t\t\treturn ENOTSUP;\n+\t\t\toverlap |= FATE;\n+\t\t\tpassthru = true;\n+\t\t\tbreak;\n+\t\t}\n \t\tcase RTE_FLOW_ACTION_TYPE_VOID:\n \t\t\tcontinue;\n \t\tdefault:\n@@ -1171,6 +1188,9 @@ enic_copy_action_v2(struct enic *enic,\n \t\t\tbreak;\n \t\t}\n \t}\n+\t/* Only PASSTHRU + MARK is allowed */\n+\tif (passthru && !(overlap & MARK))\n+\t\treturn ENOTSUP;\n \tif (!(overlap & FATE))\n \t\treturn ENOTSUP;\n \tenic_action->type = FILTER_ACTION_V2;\n", "prefixes": [ "v2", "07/13" ] }