Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/50747/?format=api
{ "id": 50747, "url": "http://patches.dpdk.org/api/patches/50747/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190302104251.32565-2-hyonkim@cisco.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190302104251.32565-2-hyonkim@cisco.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190302104251.32565-2-hyonkim@cisco.com", "date": "2019-03-02T10:42:39", "name": "[v2,01/13] net/enic: remove unused code", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f16c1b2e72fbc1405bb14135715916ebcb0386ff", "submitter": { "id": 948, "url": "http://patches.dpdk.org/api/people/948/?format=api", "name": "Hyong Youb Kim (hyonkim)", "email": "hyonkim@cisco.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190302104251.32565-2-hyonkim@cisco.com/mbox/", "series": [ { "id": 3613, "url": "http://patches.dpdk.org/api/series/3613/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3613", "date": "2019-03-02T10:42:38", "name": "net/enic: 19.05 updates", "version": 2, "mbox": "http://patches.dpdk.org/series/3613/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/50747/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/50747/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AFDDA3576;\n\tSat, 2 Mar 2019 11:43:14 +0100 (CET)", "from alln-iport-4.cisco.com (alln-iport-4.cisco.com\n\t[173.37.142.91]) by dpdk.org (Postfix) with ESMTP id C76772B9E\n\tfor <dev@dpdk.org>; Sat, 2 Mar 2019 11:43:13 +0100 (CET)", "from rcdn-core-7.cisco.com ([173.37.93.143])\n\tby alln-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t02 Mar 2019 10:43:12 +0000", "from cisco.com (savbu-usnic-a.cisco.com [10.193.184.48])\n\tby rcdn-core-7.cisco.com (8.15.2/8.15.2) with ESMTP id x22AhCt6001307;\n\tSat, 2 Mar 2019 10:43:12 GMT", "by cisco.com (Postfix, from userid 508933)\n\tid 67E8F20F2001; Sat, 2 Mar 2019 02:43:12 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n\td=cisco.com; i=@cisco.com; l=4513; q=dns/txt; s=iport;\n\tt=1551523394; x=1552732994;\n\th=from:to:cc:subject:date:message-id:in-reply-to: references;\n\tbh=qY++9IAi7eZoqcQZ70tK2Bql4EUAUdfvLKwnnFnrad0=;\n\tb=MnUkRTthXIQZQuPUopLIzqh0XQegtTetHFA9Pfm29aHOEEs8TfctuuQz\n\tyeBD20IH/dOGcX14Bdq0w8VcnZqDzAZk5sy8sHUPz1yaPtAKSONyl4bWS\n\tCHQZ0skC11U9S+GiaKl9dJnhFjtnYUy1yVFHUDs3xt5fMGMoKg+fc3Naj g=;", "X-IronPort-AV": "E=Sophos;i=\"5.58,431,1544486400\"; d=\"scan'208\";a=\"241495734\"", "From": "Hyong Youb Kim <hyonkim@cisco.com>", "To": "Ferruh Yigit <ferruh.yigit@intel.com>", "Cc": "dev@dpdk.org, John Daley <johndale@cisco.com>,\n\tHyong Youb Kim <hyonkim@cisco.com>", "Date": "Sat, 2 Mar 2019 02:42:39 -0800", "Message-Id": "<20190302104251.32565-2-hyonkim@cisco.com>", "X-Mailer": "git-send-email 2.16.2", "In-Reply-To": "<20190302104251.32565-1-hyonkim@cisco.com>", "References": "<20190302104251.32565-1-hyonkim@cisco.com>", "X-Outbound-SMTP-Client": "10.193.184.48, savbu-usnic-a.cisco.com", "X-Outbound-Node": "rcdn-core-7.cisco.com", "Subject": "[dpdk-dev] [PATCH v2 01/13] net/enic: remove unused code", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Remove unused functions. Specifically, vnic_set_rss_key() is\nobsolete. enic_{add,del}_vlan() has never been supported in the\nfirmware. And, remove vnic_rss.c altogether as it becomes empty. These\nwere discovered by cppcheck.\n\nSigned-off-by: Hyong Youb Kim <hyonkim@cisco.com>\nReviewed-by: John Daley <johndale@cisco.com>\n---\n drivers/net/enic/Makefile | 1 -\n drivers/net/enic/base/vnic_rss.c | 23 -----------------------\n drivers/net/enic/base/vnic_rss.h | 5 -----\n drivers/net/enic/enic_res.c | 26 --------------------------\n drivers/net/enic/enic_res.h | 2 --\n drivers/net/enic/meson.build | 1 -\n 6 files changed, 58 deletions(-)\n delete mode 100644 drivers/net/enic/base/vnic_rss.c", "diff": "diff --git a/drivers/net/enic/Makefile b/drivers/net/enic/Makefile\nindex e39e47631..04bae35e3 100644\n--- a/drivers/net/enic/Makefile\n+++ b/drivers/net/enic/Makefile\n@@ -37,7 +37,6 @@ SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += base/vnic_wq.c\n SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += base/vnic_dev.c\n SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += base/vnic_intr.c\n SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += base/vnic_rq.c\n-SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += base/vnic_rss.c\n \n # The current implementation assumes 64-bit pointers\n CC_AVX2_SUPPORT=0\ndiff --git a/drivers/net/enic/base/vnic_rss.c b/drivers/net/enic/base/vnic_rss.c\ndeleted file mode 100644\nindex f41b8660f..000000000\n--- a/drivers/net/enic/base/vnic_rss.c\n+++ /dev/null\n@@ -1,23 +0,0 @@\n-/* SPDX-License-Identifier: BSD-3-Clause\n- * Copyright 2008-2017 Cisco Systems, Inc. All rights reserved.\n- * Copyright 2007 Nuova Systems, Inc. All rights reserved.\n- */\n-\n-#include \"enic_compat.h\"\n-#include \"vnic_rss.h\"\n-\n-void vnic_set_rss_key(union vnic_rss_key *rss_key, u8 *key)\n-{\n-\tu32 i;\n-\tu32 *p;\n-\tu16 *q;\n-\n-\tfor (i = 0; i < 4; ++i) {\n-\t\tp = (u32 *)(key + (10 * i));\n-\t\tiowrite32(*p++, &rss_key->key[i].b[0]);\n-\t\tiowrite32(*p++, &rss_key->key[i].b[4]);\n-\t\tq = (u16 *)p;\n-\t\tiowrite32(*q, &rss_key->key[i].b[8]);\n-\t}\n-}\n-\ndiff --git a/drivers/net/enic/base/vnic_rss.h b/drivers/net/enic/base/vnic_rss.h\nindex abd7b9f13..039041ece 100644\n--- a/drivers/net/enic/base/vnic_rss.h\n+++ b/drivers/net/enic/base/vnic_rss.h\n@@ -24,9 +24,4 @@ union vnic_rss_cpu {\n \tu64 raw[32];\n };\n \n-void vnic_set_rss_key(union vnic_rss_key *rss_key, u8 *key);\n-void vnic_set_rss_cpu(union vnic_rss_cpu *rss_cpu, u8 *cpu);\n-void vnic_get_rss_key(union vnic_rss_key *rss_key, u8 *key);\n-void vnic_get_rss_cpu(union vnic_rss_cpu *rss_cpu, u8 *cpu);\n-\n #endif /* _VNIC_RSS_H_ */\ndiff --git a/drivers/net/enic/enic_res.c b/drivers/net/enic/enic_res.c\nindex 24b2844f3..d289f3da8 100644\n--- a/drivers/net/enic/enic_res.c\n+++ b/drivers/net/enic/enic_res.c\n@@ -212,32 +212,6 @@ int enic_get_vnic_config(struct enic *enic)\n \treturn 0;\n }\n \n-int enic_add_vlan(struct enic *enic, u16 vlanid)\n-{\n-\tu64 a0 = vlanid, a1 = 0;\n-\tint wait = 1000;\n-\tint err;\n-\n-\terr = vnic_dev_cmd(enic->vdev, CMD_VLAN_ADD, &a0, &a1, wait);\n-\tif (err)\n-\t\tdev_err(enic_get_dev(enic), \"Can't add vlan id, %d\\n\", err);\n-\n-\treturn err;\n-}\n-\n-int enic_del_vlan(struct enic *enic, u16 vlanid)\n-{\n-\tu64 a0 = vlanid, a1 = 0;\n-\tint wait = 1000;\n-\tint err;\n-\n-\terr = vnic_dev_cmd(enic->vdev, CMD_VLAN_DEL, &a0, &a1, wait);\n-\tif (err)\n-\t\tdev_err(enic_get_dev(enic), \"Can't delete vlan id, %d\\n\", err);\n-\n-\treturn err;\n-}\n-\n int enic_set_nic_cfg(struct enic *enic, u8 rss_default_cpu, u8 rss_hash_type,\n \tu8 rss_hash_bits, u8 rss_base_cpu, u8 rss_enable, u8 tso_ipid_split_en,\n \tu8 ig_vlan_strip_en)\ndiff --git a/drivers/net/enic/enic_res.h b/drivers/net/enic/enic_res.h\nindex 3786bc0e2..faaaad9bd 100644\n--- a/drivers/net/enic/enic_res.h\n+++ b/drivers/net/enic/enic_res.h\n@@ -59,8 +59,6 @@\n struct enic;\n \n int enic_get_vnic_config(struct enic *);\n-int enic_add_vlan(struct enic *enic, u16 vlanid);\n-int enic_del_vlan(struct enic *enic, u16 vlanid);\n int enic_set_nic_cfg(struct enic *enic, u8 rss_default_cpu, u8 rss_hash_type,\n \tu8 rss_hash_bits, u8 rss_base_cpu, u8 rss_enable, u8 tso_ipid_split_en,\n \tu8 ig_vlan_strip_en);\ndiff --git a/drivers/net/enic/meson.build b/drivers/net/enic/meson.build\nindex 064487118..c381f1496 100644\n--- a/drivers/net/enic/meson.build\n+++ b/drivers/net/enic/meson.build\n@@ -6,7 +6,6 @@ sources = files(\n \t'base/vnic_dev.c',\n \t'base/vnic_intr.c',\n \t'base/vnic_rq.c',\n-\t'base/vnic_rss.c',\n \t'base/vnic_wq.c',\n \t'enic_clsf.c',\n \t'enic_ethdev.c',\n", "prefixes": [ "v2", "01/13" ] }