Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/50652/?format=api
{ "id": 50652, "url": "http://patches.dpdk.org/api/patches/50652/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1551368952-1871-2-git-send-email-rasland@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1551368952-1871-2-git-send-email-rasland@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1551368952-1871-2-git-send-email-rasland@mellanox.com", "date": "2019-02-28T15:49:26", "name": "[1/4] net/failsafe: replace local device with shared data", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3fdafb379a1ee3218363f97e4fe35a6a3880a226", "submitter": { "id": 513, "url": "http://patches.dpdk.org/api/people/513/?format=api", "name": "Raslan Darawsheh", "email": "rasland@mellanox.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1551368952-1871-2-git-send-email-rasland@mellanox.com/mbox/", "series": [ { "id": 3579, "url": "http://patches.dpdk.org/api/series/3579/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3579", "date": "2019-02-28T15:49:25", "name": "support secondary process for failsafe", "version": 1, "mbox": "http://patches.dpdk.org/series/3579/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/50652/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/50652/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 71B144C9C;\n\tThu, 28 Feb 2019 16:49:29 +0100 (CET)", "from EUR04-VI1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr80041.outbound.protection.outlook.com [40.107.8.41])\n\tby dpdk.org (Postfix) with ESMTP id 843CD44BE\n\tfor <dev@dpdk.org>; Thu, 28 Feb 2019 16:49:27 +0100 (CET)", "from AM6PR05MB5926.eurprd05.prod.outlook.com (20.179.2.27) by\n\tAM6PR05MB5458.eurprd05.prod.outlook.com (20.177.118.156) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1665.16; Thu, 28 Feb 2019 15:49:26 +0000", "from AM6PR05MB5926.eurprd05.prod.outlook.com\n\t([fe80::4d49:8512:d097:4a52]) by\n\tAM6PR05MB5926.eurprd05.prod.outlook.com\n\t([fe80::4d49:8512:d097:4a52%4]) with mapi id 15.20.1643.022;\n\tThu, 28 Feb 2019 15:49:26 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=38LIni2rl2oReIYD/hOCErzlPkOylAk7R5uHU6fCzZg=;\n\tb=na6zPQv7SvreIILwovDv7ZtBBcHR5dTmVzcIWTy4aH2jYygNcVjpj6mLTNTurhCmnguHtigb4peBvzbRRJdibO/AZ4nnFQXPHizL/Pg0goxyj032lwG2KR7WoCGM00jeInL7HFB4kstHQU+dsIeWmFDVhqIQ1pJ26Qga+iok73A=", "From": "Raslan Darawsheh <rasland@mellanox.com>", "To": "\"gaetan.rivet@6wind.com\" <gaetan.rivet@6wind.com>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,\n\tRaslan Darawsheh <rasland@mellanox.com>", "Thread-Topic": "[PATCH 1/4] net/failsafe: replace local device with shared data", "Thread-Index": "AQHUz30uklCFRK5rKUi+XcUCQDmtLg==", "Date": "Thu, 28 Feb 2019 15:49:26 +0000", "Message-ID": "<1551368952-1871-2-git-send-email-rasland@mellanox.com>", "References": "<1551368952-1871-1-git-send-email-rasland@mellanox.com>", "In-Reply-To": "<1551368952-1871-1-git-send-email-rasland@mellanox.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-mailer": "git-send-email 2.7.4", "x-clientproxiedby": "LO2P265CA0431.GBRP265.PROD.OUTLOOK.COM\n\t(2603:10a6:600:a0::35) To AM6PR05MB5926.eurprd05.prod.outlook.com\n\t(2603:10a6:20b:a9::27)", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=rasland@mellanox.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-originating-ip": "[37.142.13.130]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "fde37073-e5fe-4f02-670c-08d69d9450f2", "x-ms-office365-filtering-ht": "Tenant", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);\n\tSRVR:AM6PR05MB5458; ", "x-ms-traffictypediagnostic": "AM6PR05MB5458:", "x-ld-processed": "a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr", "x-microsoft-exchange-diagnostics": "=?iso-8859-1?Q?1; AM6PR05MB5458;\n\t23:lb6inJzpWyytmnCCSHrnprj+ju0pNgyYFVhd/Cv?=\n\t=?iso-8859-1?q?nvJ9T/yNa2fXWWfr7RSe8uLn4?=\n\t=?iso-8859-1?q?htz+Fdxlq2ubcvMOfPmIoqQOmjSDuMr3RzXuQwxwRr5HKxVevFF?=\n\t=?iso-8859-1?q?Wpa6LxQhnXcBlDaQJoR3Z/Z+6LyJ/ShGCM9FSnkRcxT4j4niGHd?=\n\t=?iso-8859-1?q?O4S3SN1zhlrjBYDlL+phMK/U2bWbh9olI6T000xP6TD3bvjTAiZ?=\n\t=?iso-8859-1?q?ieJKbtFbXisYGu1fzF4aV7h1Xp3c3rwcesjHROP0AncTdxJf3Kc?=\n\t=?iso-8859-1?q?spQISpWQE6hTl0oqGJjRmLUGLnqxy0GYQ/bJs4Zv1+ZrQCfMiR/?=\n\t=?iso-8859-1?q?LcfPkueWQabyPcUUOMMSHCs8WA4x9YlO78DK87yVRE0KWEJhZnq?=\n\t=?iso-8859-1?q?2rHIGHsidaq4tNJ3A5rxf8vC8KXIW9hs+B+VHpDfEwIKw73rnF7?=\n\t=?iso-8859-1?q?1EZAcbaETguKhOg1MqmNJx/RfRP0PcLEXax5W5xZ3/FR33cWVk+?=\n\t=?iso-8859-1?q?4NbHk8lvQMFXcbjcaQ4RFN/qWDtyqa7YH0pusB6uKbZ4nIDBk+n?=\n\t=?iso-8859-1?q?AiiSiLko9dn6/dEAGq5aMYuT/pg6k0KsXkGJupC+t5OvrqPjS+R?=\n\t=?iso-8859-1?q?7AbInGhxFb/0KIrWjRX8uPQk6c2QPE2PTUyLAqDrbEBzOYM+AiG?=\n\t=?iso-8859-1?q?qKg7spsXl+P84Xii15mzu9BGi/IJELEDC2Ggg5DmMiScqnFjNpN?=\n\t=?iso-8859-1?q?d13BukC4zXoXufIARR6rGNycDZWTzhGdtTMhVe5FtV3qKrrTp7f?=\n\t=?iso-8859-1?q?XDQK6ZLed0DuClFORI1IcoRp4VZUf9zy/G0W8FtUgY5raGkAE+O?=\n\t=?iso-8859-1?q?hp1ZQU/H9Oe/m5qoB3v2btBgX1ljapNNju5ocWQDTYjc8ZLkRWC?=\n\t=?iso-8859-1?q?2/7CDRFRD0g8SsRxS/dhxMF76cLBn6fwBxRZVxsaq+a7vV17YHF?=\n\t=?iso-8859-1?q?fOGGBxd6PTqJ1IfWoaoX/+xBgG+Tkc0vRN/jyltr2sd5aH6ZqBc?=\n\t=?iso-8859-1?q?ugVxjLQT4F35ZMQpnOmDf7fWpk1c8O6bYe3/hKdmCTz/FT9S93q?=\n\t=?iso-8859-1?q?0E/tAl5Bzx7yMDhMOCEi18IqCz+TBok4pgO2RSeoZWtKKN38gC2?=\n\t=?iso-8859-1?q?cYqwLM5wEpzByKmzvam2BUtLR62R2BxzSCASxt5T1haCqo/6GQ7?=\n\t=?iso-8859-1?q?GHN2C8PB3eelwsasODsefp3jEoyYFy9ZA+frTdOxbGDpajitPdH?=\n\t=?iso-8859-1?q?a21GmTjZvbjjDGDoHos5+dEHTscoBBOjyrZP4FsgyFQygLW9iNr?=\n\t=?iso-8859-1?q?kiO8rnH0h5D0nNtAVqZoyK17HXui0IIQ2ayO/aXgNlkfICj0ezd?=\n\t=?iso-8859-1?q?8O1u3Q55oeW+IK+LgN4TOXpegFFz4A5AKsZQa8mpBfEJb22sO1A?=\n\t=?iso-8859-1?q?0AtORgBSSzWKBw=3D=3D?=", "x-microsoft-antispam-prvs": "<AM6PR05MB545804A49A074DDE5756D5B6C2750@AM6PR05MB5458.eurprd05.prod.outlook.com>", "x-forefront-prvs": "0962D394D2", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(396003)(346002)(136003)(39860400002)(366004)(376002)(189003)(199004)(6116002)(3846002)(71200400001)(71190400001)(54906003)(25786009)(476003)(36756003)(478600001)(14454004)(2616005)(5660300002)(7736002)(305945005)(486006)(97736004)(6916009)(446003)(11346002)(50226002)(102836004)(8936002)(76176011)(52116002)(107886003)(81166006)(81156014)(8676002)(68736007)(186003)(386003)(2906002)(2501003)(6506007)(316002)(99286004)(53936002)(6436002)(6486002)(5640700003)(106356001)(2351001)(14444005)(256004)(66066001)(26005)(4326008)(6512007)(86362001)(105586002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR05MB5458;\n\tH:AM6PR05MB5926.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; MX:1; A:1; ", "received-spf": "None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "07Hm1OTLuitPD3eEOhZ9j+QdUPIzSJCPfHw75ZIvQlLw5ZQL93Dcf0br88xZnfIEvE2H9MbQmxestVj/RJWxgeOGsYtycQqytmFryYFRQyyHZ265JjcOoqUFX350j7bZzcdedrcH8K3Xq6EEA5fLWtrBj52V6Z3sSOmHlPAGv8fZSLugVpTNyQC1I1Ee41EwIuvKXiMroMKf8O3k0gFhtEMdUVRodA6y4wmTNRpb8MAqxdH9Q2yA4bkZXmxYjNQQcNod5jFBl7grK46Bmn5EfdQpj+guorsCjvTYrGvq5ElVnKieiW6GokzIIog8nW9T5hNv5RuwOXbw5imVgip1UkiaGcNzb/aMmQsECCv+efWzVbulpdA8oPS/LOLFM/kbLfqV6JWe5t4FApB7hPSdDRpfxRfMunsHfykOMUHAkDM=", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "fde37073-e5fe-4f02-670c-08d69d9450f2", "X-MS-Exchange-CrossTenant-originalarrivaltime": "28 Feb 2019 15:49:25.3534\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM6PR05MB5458", "Subject": "[dpdk-dev] [PATCH 1/4] net/failsafe: replace local device with\n\tshared data", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In multiprocess context, the private structure is shared between\nprocesses. The back reference from private to generic data was using\na pointer to a per process eth_dev. It's now changed to a reference of\nthe shared data.\n\nSigned-off-by: Raslan Darawsheh <rasland@mellanox.com>\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n drivers/net/failsafe/failsafe.c | 2 +-\n drivers/net/failsafe/failsafe_intr.c | 10 +++++-----\n drivers/net/failsafe/failsafe_ops.c | 4 ++--\n drivers/net/failsafe/failsafe_private.h | 8 ++++++--\n drivers/net/failsafe/failsafe_rxtx.c | 4 ++--\n 5 files changed, 16 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/failsafe/failsafe.c b/drivers/net/failsafe/failsafe.c\nindex 06e859e..68926ca 100644\n--- a/drivers/net/failsafe/failsafe.c\n+++ b/drivers/net/failsafe/failsafe.c\n@@ -181,7 +181,7 @@ fs_eth_dev_create(struct rte_vdev_device *vdev)\n \t\treturn -1;\n \t}\n \tpriv = PRIV(dev);\n-\tpriv->dev = dev;\n+\tpriv->data = dev->data;\n \tdev->dev_ops = &failsafe_ops;\n \tdev->data->mac_addrs = &PRIV(dev)->mac_addrs[0];\n \tdev->data->dev_link = eth_link;\ndiff --git a/drivers/net/failsafe/failsafe_intr.c b/drivers/net/failsafe/failsafe_intr.c\nindex 1c2cb71..09aa3c6 100644\n--- a/drivers/net/failsafe/failsafe_intr.c\n+++ b/drivers/net/failsafe/failsafe_intr.c\n@@ -133,8 +133,8 @@ fs_rx_event_proxy_service_install(struct fs_priv *priv)\n \t/* prepare service info */\n \tmemset(&service, 0, sizeof(struct rte_service_spec));\n \tsnprintf(service.name, sizeof(service.name), \"%s_Rx_service\",\n-\t\t priv->dev->data->name);\n-\tservice.socket_id = priv->dev->data->numa_node;\n+\t\t priv->data->name);\n+\tservice.socket_id = priv->data->numa_node;\n \tservice.callback = fs_rx_event_proxy_routine;\n \tservice.callback_userdata = priv;\n \n@@ -437,7 +437,7 @@ fs_rx_intr_vec_install(struct fs_priv *priv)\n \tunsigned int count;\n \tstruct rte_intr_handle *intr_handle;\n \n-\trxqs_n = priv->dev->data->nb_rx_queues;\n+\trxqs_n = priv->data->nb_rx_queues;\n \tn = RTE_MIN(rxqs_n, (uint32_t)RTE_MAX_RXTX_INTR_VEC_ID);\n \tcount = 0;\n \tintr_handle = &priv->intr_handle;\n@@ -452,7 +452,7 @@ fs_rx_intr_vec_install(struct fs_priv *priv)\n \t\treturn -rte_errno;\n \t}\n \tfor (i = 0; i < n; i++) {\n-\t\tstruct rxq *rxq = priv->dev->data->rx_queues[i];\n+\t\tstruct rxq *rxq = priv->data->rx_queues[i];\n \n \t\t/* Skip queues that cannot request interrupts. */\n \t\tif (rxq == NULL || rxq->event_fd < 0) {\n@@ -521,7 +521,7 @@ failsafe_rx_intr_install(struct rte_eth_dev *dev)\n {\n \tstruct fs_priv *priv = PRIV(dev);\n \tconst struct rte_intr_conf *const intr_conf =\n-\t\t\t&priv->dev->data->dev_conf.intr_conf;\n+\t\t\t&priv->data->dev_conf.intr_conf;\n \n \tif (intr_conf->rxq == 0 || dev->intr_handle != NULL)\n \t\treturn 0;\ndiff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c\nindex e3add40..65957a2 100644\n--- a/drivers/net/failsafe/failsafe_ops.c\n+++ b/drivers/net/failsafe/failsafe_ops.c\n@@ -452,7 +452,7 @@ fs_rx_queue_release(void *queue)\n \tif (queue == NULL)\n \t\treturn;\n \trxq = queue;\n-\tdev = rxq->priv->dev;\n+\tdev = &rte_eth_devices[rxq->priv->data->port_id];\n \tfs_lock(dev, 0);\n \tif (rxq->event_fd > 0)\n \t\tclose(rxq->event_fd);\n@@ -636,7 +636,7 @@ fs_tx_queue_release(void *queue)\n \tif (queue == NULL)\n \t\treturn;\n \ttxq = queue;\n-\tdev = txq->priv->dev;\n+\tdev = &rte_eth_devices[txq->priv->data->port_id];\n \tfs_lock(dev, 0);\n \tFOREACH_SUBDEV_STATE(sdev, i, dev, DEV_ACTIVE) {\n \t\tif (ETH(sdev)->data->tx_queues != NULL &&\ndiff --git a/drivers/net/failsafe/failsafe_private.h b/drivers/net/failsafe/failsafe_private.h\nindex 0dfea65..91b7167 100644\n--- a/drivers/net/failsafe/failsafe_private.h\n+++ b/drivers/net/failsafe/failsafe_private.h\n@@ -128,14 +128,18 @@ struct sub_device {\n \tunsigned int lsc_callback:1;\n };\n \n+/*\n+ * This is referenced by eth_dev->data->dev_private\n+ * This is shared between processes.\n+ */\n struct fs_priv {\n-\tstruct rte_eth_dev *dev;\n+\tstruct rte_eth_dev_data *data; /* backreference to shared data. */\n \t/*\n \t * Set of sub_devices.\n \t * subs[0] is the preferred device\n \t * any other is just another slave\n \t */\n-\tstruct sub_device *subs;\n+\tstruct sub_device *subs; /* shared between processes */\n \tuint8_t subs_head; /* if head == tail, no subs */\n \tuint8_t subs_tail; /* first invalid */\n \tuint8_t subs_tx; /* current emitting device */\ndiff --git a/drivers/net/failsafe/failsafe_rxtx.c b/drivers/net/failsafe/failsafe_rxtx.c\nindex 034f47b..231c832 100644\n--- a/drivers/net/failsafe/failsafe_rxtx.c\n+++ b/drivers/net/failsafe/failsafe_rxtx.c\n@@ -126,7 +126,7 @@ failsafe_tx_burst(void *queue,\n \tuint16_t nb_tx;\n \n \ttxq = queue;\n-\tsdev = TX_SUBDEV(txq->priv->dev);\n+\tsdev = TX_SUBDEV(&rte_eth_devices[txq->priv->data->port_id]);\n \tif (unlikely(fs_tx_unsafe(sdev)))\n \t\treturn 0;\n \tsub_txq = ETH(sdev)->data->tx_queues[txq->qid];\n@@ -147,7 +147,7 @@ failsafe_tx_burst_fast(void *queue,\n \tuint16_t nb_tx;\n \n \ttxq = queue;\n-\tsdev = TX_SUBDEV(txq->priv->dev);\n+\tsdev = TX_SUBDEV(&rte_eth_devices[txq->priv->data->port_id]);\n \tRTE_ASSERT(!fs_tx_unsafe(sdev));\n \tsub_txq = ETH(sdev)->data->tx_queues[txq->qid];\n \tFS_ATOMIC_P(txq->refcnt[sdev->sid]);\n", "prefixes": [ "1/4" ] }