Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/50585/?format=api
{ "id": 50585, "url": "http://patches.dpdk.org/api/patches/50585/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190228055650.25237-26-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190228055650.25237-26-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190228055650.25237-26-qi.z.zhang@intel.com", "date": "2019-02-28T05:56:38", "name": "[25/37] net/ice/base: minor fix", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "735715366c62b45d439c82714b1154df8025fe68", "submitter": { "id": 504, "url": "http://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190228055650.25237-26-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 3567, "url": "http://patches.dpdk.org/api/series/3567/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3567", "date": "2019-02-28T05:56:13", "name": "share code update.", "version": 1, "mbox": "http://patches.dpdk.org/series/3567/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/50585/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/50585/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3B31E1B107;\n\tThu, 28 Feb 2019 06:55:46 +0100 (CET)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby dpdk.org (Postfix) with ESMTP id 485F95F29\n\tfor <dev@dpdk.org>; Thu, 28 Feb 2019 06:55:39 +0100 (CET)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t27 Feb 2019 21:55:38 -0800", "from dpdk51.sh.intel.com ([10.67.110.190])\n\tby fmsmga006.fm.intel.com with ESMTP; 27 Feb 2019 21:55:37 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.58,422,1544515200\"; d=\"scan'208\";a=\"322784362\"", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "wenzhuo.lu@intel.com,\n\tqiming.yang@intel.com", "Cc": "paul.m.stillwell.jr@intel.com, dev@dpdk.org, ferruh.yigit@intel.com,\n\tQi Zhang <qi.z.zhang@intel.com>", "Date": "Thu, 28 Feb 2019 13:56:38 +0800", "Message-Id": "<20190228055650.25237-26-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20190228055650.25237-1-qi.z.zhang@intel.com>", "References": "<20190228055650.25237-1-qi.z.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH 25/37] net/ice/base: minor fix", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "1. Fix some problems with filling the HW tables.\n2. Fix a logic error in ice_rem_prof_from_list.\n\nSigned-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/ice/base/ice_flex_pipe.c | 18 +++++++++++++++---\n 1 file changed, 15 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_flex_pipe.c b/drivers/net/ice/base/ice_flex_pipe.c\nindex 887609204..1dd121b28 100644\n--- a/drivers/net/ice/base/ice_flex_pipe.c\n+++ b/drivers/net/ice/base/ice_flex_pipe.c\n@@ -2935,9 +2935,11 @@ static void ice_fill_tbl(struct ice_hw *hw, enum ice_block block_id, u32 sid)\n \n \twhile (sect) {\n \t\tswitch (sid) {\n+\t\tcase ICE_SID_XLT1_SW:\n \t\tcase ICE_SID_XLT1_FD:\n \t\tcase ICE_SID_XLT1_RSS:\n \t\tcase ICE_SID_XLT1_ACL:\n+\t\tcase ICE_SID_XLT1_PE:\n \t\t\txlt1 = (struct ice_xlt1_section *)sect;\n \t\t\tsrc = xlt1->value;\n \t\t\tsect_len = LE16_TO_CPU(xlt1->count) *\n@@ -2946,9 +2948,11 @@ static void ice_fill_tbl(struct ice_hw *hw, enum ice_block block_id, u32 sid)\n \t\t\tdst_len = hw->blk[block_id].xlt1.count *\n \t\t\t\tsizeof(*hw->blk[block_id].xlt1.t);\n \t\t\tbreak;\n+\t\tcase ICE_SID_XLT2_SW:\n \t\tcase ICE_SID_XLT2_FD:\n \t\tcase ICE_SID_XLT2_RSS:\n \t\tcase ICE_SID_XLT2_ACL:\n+\t\tcase ICE_SID_XLT2_PE:\n \t\t\txlt2 = (struct ice_xlt2_section *)sect;\n \t\t\tsrc = (u8 *)xlt2->value;\n \t\t\tsect_len = LE16_TO_CPU(xlt2->count) *\n@@ -2957,9 +2961,11 @@ static void ice_fill_tbl(struct ice_hw *hw, enum ice_block block_id, u32 sid)\n \t\t\tdst_len = hw->blk[block_id].xlt2.count *\n \t\t\t\tsizeof(*hw->blk[block_id].xlt2.t);\n \t\t\tbreak;\n+\t\tcase ICE_SID_PROFID_TCAM_SW:\n \t\tcase ICE_SID_PROFID_TCAM_FD:\n \t\tcase ICE_SID_PROFID_TCAM_RSS:\n \t\tcase ICE_SID_PROFID_TCAM_ACL:\n+\t\tcase ICE_SID_PROFID_TCAM_PE:\n \t\t\tpid = (struct ice_prof_id_section *)sect;\n \t\t\tsrc = (u8 *)pid->entry;\n \t\t\tsect_len = LE16_TO_CPU(pid->count) *\n@@ -2968,9 +2974,11 @@ static void ice_fill_tbl(struct ice_hw *hw, enum ice_block block_id, u32 sid)\n \t\t\tdst_len = hw->blk[block_id].prof.count *\n \t\t\t\tsizeof(*hw->blk[block_id].prof.t);\n \t\t\tbreak;\n+\t\tcase ICE_SID_PROFID_REDIR_SW:\n \t\tcase ICE_SID_PROFID_REDIR_FD:\n \t\tcase ICE_SID_PROFID_REDIR_RSS:\n \t\tcase ICE_SID_PROFID_REDIR_ACL:\n+\t\tcase ICE_SID_PROFID_REDIR_PE:\n \t\t\tpr = (struct ice_prof_redir_section *)sect;\n \t\t\tsrc = pr->redir_value;\n \t\t\tsect_len = LE16_TO_CPU(pr->count) *\n@@ -2979,15 +2987,19 @@ static void ice_fill_tbl(struct ice_hw *hw, enum ice_block block_id, u32 sid)\n \t\t\tdst_len = hw->blk[block_id].prof_redir.count *\n \t\t\t\tsizeof(*hw->blk[block_id].prof_redir.t);\n \t\t\tbreak;\n+\t\tcase ICE_SID_FLD_VEC_SW:\n \t\tcase ICE_SID_FLD_VEC_FD:\n \t\tcase ICE_SID_FLD_VEC_RSS:\n \t\tcase ICE_SID_FLD_VEC_ACL:\n+\t\tcase ICE_SID_FLD_VEC_PE:\n \t\t\tes = (struct ice_sw_fv_section *)sect;\n \t\t\tsrc = (u8 *)es->fv;\n \t\t\tsect_len = LE16_TO_CPU(es->count) *\n-\t\t\t\tsizeof(*hw->blk[block_id].prof_redir.t);\n+\t\t\t\thw->blk[block_id].es.fvw *\n+\t\t\t\tsizeof(*hw->blk[block_id].es.t);\n \t\t\tdst = (u8 *)hw->blk[block_id].es.t;\n \t\t\tdst_len = hw->blk[block_id].es.count *\n+\t\t\t\thw->blk[block_id].es.fvw *\n \t\t\t\tsizeof(*hw->blk[block_id].es.t);\n \t\t\tbreak;\n \t\tdefault:\n@@ -4964,8 +4976,8 @@ ice_rem_prof_id_flow(struct ice_hw *hw, enum ice_block blk, u16 vsi, u64 hdl)\n \t\t\t\tif (status)\n \t\t\t\t\tgoto err_ice_rem_prof_id_flow;\n \n-\t\t\t} else if (ice_find_dup_props_vsig(hw, blk, ©,\n-\t\t\t\t\t\t\t &vsig)) {\n+\t\t\t} else if (!ice_find_dup_props_vsig(hw, blk, ©,\n+\t\t\t\t\t\t\t &vsig)) {\n \t\t\t\t/* found an exact match */\n \t\t\t\t/* add or move VSI to the VSIG that matches */\n \t\t\t\t/* Search for a VSIG with a matching profile\n", "prefixes": [ "25/37" ] }