Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 50584,
    "url": "http://patches.dpdk.org/api/patches/50584/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190228055650.25237-25-qi.z.zhang@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190228055650.25237-25-qi.z.zhang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190228055650.25237-25-qi.z.zhang@intel.com",
    "date": "2019-02-28T05:56:37",
    "name": "[24/37] net/ice/base: remove local VSIG allocations",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "79f7f6b78be128269f0a5f83a2605178b12e4338",
    "submitter": {
        "id": 504,
        "url": "http://patches.dpdk.org/api/people/504/?format=api",
        "name": "Qi Zhang",
        "email": "qi.z.zhang@intel.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190228055650.25237-25-qi.z.zhang@intel.com/mbox/",
    "series": [
        {
            "id": 3567,
            "url": "http://patches.dpdk.org/api/series/3567/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3567",
            "date": "2019-02-28T05:56:13",
            "name": "share code update.",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/3567/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/50584/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/50584/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 10F3B7D4A;\n\tThu, 28 Feb 2019 06:55:45 +0100 (CET)",
            "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby dpdk.org (Postfix) with ESMTP id 0D8345F1B\n\tfor <dev@dpdk.org>; Thu, 28 Feb 2019 06:55:37 +0100 (CET)",
            "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t27 Feb 2019 21:55:37 -0800",
            "from dpdk51.sh.intel.com ([10.67.110.190])\n\tby fmsmga006.fm.intel.com with ESMTP; 27 Feb 2019 21:55:36 -0800"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.58,422,1544515200\"; d=\"scan'208\";a=\"322784358\"",
        "From": "Qi Zhang <qi.z.zhang@intel.com>",
        "To": "wenzhuo.lu@intel.com,\n\tqiming.yang@intel.com",
        "Cc": "paul.m.stillwell.jr@intel.com, dev@dpdk.org, ferruh.yigit@intel.com,\n\tQi Zhang <qi.z.zhang@intel.com>,\n\tVignesh Sridhar <vignesh.sridhar@intel.com>",
        "Date": "Thu, 28 Feb 2019 13:56:37 +0800",
        "Message-Id": "<20190228055650.25237-25-qi.z.zhang@intel.com>",
        "X-Mailer": "git-send-email 2.13.6",
        "In-Reply-To": "<20190228055650.25237-1-qi.z.zhang@intel.com>",
        "References": "<20190228055650.25237-1-qi.z.zhang@intel.com>",
        "Subject": "[dpdk-dev] [PATCH 24/37] net/ice/base: remove local VSIG allocations",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "If allocating a VSI to a VSIG fails the local allocations made for VSIG\nprofiles and change-lists will not be removed. Adding calls to free these\nentries on error in VSIG management calls.\n\nSigned-off-by: Vignesh Sridhar <vignesh.sridhar@intel.com>\nSigned-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/ice/base/ice_flex_pipe.c | 20 +++++++++++++++-----\n 1 file changed, 15 insertions(+), 5 deletions(-)",
    "diff": "diff --git a/drivers/net/ice/base/ice_flex_pipe.c b/drivers/net/ice/base/ice_flex_pipe.c\nindex 900a19387..887609204 100644\n--- a/drivers/net/ice/base/ice_flex_pipe.c\n+++ b/drivers/net/ice/base/ice_flex_pipe.c\n@@ -4523,8 +4523,10 @@ ice_add_prof_id_vsig(struct ice_hw *hw, enum ice_block blk, u16 vsig, u64 hdl,\n \n \t\t/* allocate the TCAM entry index */\n \t\tstatus = ice_alloc_tcam_ent(hw, blk, &tcam_idx);\n-\t\tif (status)\n+\t\tif (status) {\n+\t\t\tice_free(hw, p);\n \t\t\tgoto err_ice_add_prof_id_vsig;\n+\t\t}\n \n \t\tt->tcam[i].ptg = ptg;\n \t\tt->tcam[i].prof_id = map->prof_id;\n@@ -4563,6 +4565,7 @@ ice_add_prof_id_vsig(struct ice_hw *hw, enum ice_block blk, u16 vsig, u64 hdl,\n \n err_ice_add_prof_id_vsig:\n \t/* let caller clean up the change list */\n+\tice_free(hw, t);\n \treturn ICE_ERR_NO_MEMORY;\n }\n \n@@ -4587,16 +4590,18 @@ ice_create_prof_id_vsig(struct ice_hw *hw, enum ice_block blk, u16 vsi, u64 hdl,\n \t\treturn ICE_ERR_NO_MEMORY;\n \n \tnew_vsig = ice_vsig_alloc(hw, blk);\n-\tif (!new_vsig)\n-\t\treturn ICE_ERR_HW_TABLE;\n+\tif (!new_vsig) {\n+\t\tstatus = ICE_ERR_HW_TABLE;\n+\t\tgoto err_ice_create_prof_id_vsig;\n+\t}\n \n \tstatus = ice_move_vsi(hw, blk, vsi, new_vsig, chg);\n \tif (status)\n-\t\treturn status;\n+\t\tgoto err_ice_create_prof_id_vsig;\n \n \tstatus = ice_add_prof_id_vsig(hw, blk, new_vsig, hdl, chg);\n \tif (status)\n-\t\treturn status;\n+\t\tgoto err_ice_create_prof_id_vsig;\n \n \tp->type = ICE_VSIG_ADD;\n \tp->vsi = vsi;\n@@ -4606,6 +4611,11 @@ ice_create_prof_id_vsig(struct ice_hw *hw, enum ice_block blk, u16 vsi, u64 hdl,\n \tLIST_ADD(&p->list_entry, chg);\n \n \treturn ICE_SUCCESS;\n+\n+err_ice_create_prof_id_vsig:\n+\t/* let caller clean up the change list */\n+\tice_free(hw, p);\n+\treturn status;\n }\n \n /**\n",
    "prefixes": [
        "24/37"
    ]
}