Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/50438/?format=api
{ "id": 50438, "url": "http://patches.dpdk.org/api/patches/50438/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1550823230-16809-1-git-send-email-jiayu.hu@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1550823230-16809-1-git-send-email-jiayu.hu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1550823230-16809-1-git-send-email-jiayu.hu@intel.com", "date": "2019-02-22T08:13:50", "name": "vhost: fix interrupt suppression for the split ring", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "fd4cf83776db0059de220c30a0de812bd52ddd05", "submitter": { "id": 539, "url": "http://patches.dpdk.org/api/people/539/?format=api", "name": "Hu, Jiayu", "email": "jiayu.hu@intel.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1550823230-16809-1-git-send-email-jiayu.hu@intel.com/mbox/", "series": [ { "id": 3508, "url": "http://patches.dpdk.org/api/series/3508/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3508", "date": "2019-02-22T08:13:50", "name": "vhost: fix interrupt suppression for the split ring", "version": 1, "mbox": "http://patches.dpdk.org/series/3508/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/50438/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/50438/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DE5E02BD5;\n\tFri, 22 Feb 2019 09:14:16 +0100 (CET)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 55C22A3;\n\tFri, 22 Feb 2019 09:14:14 +0100 (CET)", "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t22 Feb 2019 00:14:13 -0800", "from dpdk15.sh.intel.com (HELO dpdk-jiayu15.sh.intel.com)\n\t([10.67.111.146])\n\tby orsmga004.jf.intel.com with ESMTP; 22 Feb 2019 00:14:11 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.58,398,1544515200\"; d=\"scan'208\";a=\"276997849\"", "From": "Jiayu Hu <jiayu.hu@intel.com>", "To": "dev@dpdk.org", "Cc": "tiwei.bie@intel.com, maxime.coquelin@redhat.com,\n\tJiayu Hu <jiayu.hu@intel.com>, stable@dpdk.org", "Date": "Fri, 22 Feb 2019 16:13:50 +0800", "Message-Id": "<1550823230-16809-1-git-send-email-jiayu.hu@intel.com>", "X-Mailer": "git-send-email 2.7.4", "Subject": "[dpdk-dev] [PATCH] vhost: fix interrupt suppression for the split\n\tring", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The VIRTIO_RING_F_EVENT_IDX feature of split ring might\nbe broken, as the value of signalled_used is unpredictable\nafter live migration or start up. This patch fixes it by\nusing signalled_used_valid.\n\nIn addition, this patch makes the VIRTIO_RING_F_EVENT_IDX\nimplementation of split ring match kernel backend to suppress\nmore interrupts.\n\nFixes: e37ff954405a (\"vhost: support virtqueue interrupt/notification suppression\")\nCc: stable@dpdk.org\n\nSigned-off-by: Jiayu Hu <jiayu.hu@intel.com>\n---\n lib/librte_vhost/vhost.h | 12 ++++++++----\n 1 file changed, 8 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h\nindex fc31796..c4e5e34 100644\n--- a/lib/librte_vhost/vhost.h\n+++ b/lib/librte_vhost/vhost.h\n@@ -633,16 +633,20 @@ vhost_vring_call_split(struct virtio_net *dev, struct vhost_virtqueue *vq)\n \tif (dev->features & (1ULL << VIRTIO_RING_F_EVENT_IDX)) {\n \t\tuint16_t old = vq->signalled_used;\n \t\tuint16_t new = vq->last_used_idx;\n+\t\tbool signalled_used_valid = vq->signalled_used_valid;\n+\n+\t\tvq->signalled_used = new;\n+\t\tvq->signalled_used_valid = true;\n \n \t\tVHOST_LOG_DEBUG(VHOST_DATA, \"%s: used_event_idx=%d, old=%d, new=%d\\n\",\n \t\t\t__func__,\n \t\t\tvhost_used_event(vq),\n \t\t\told, new);\n-\t\tif (vhost_need_event(vhost_used_event(vq), new, old)\n-\t\t\t&& (vq->callfd >= 0)) {\n-\t\t\tvq->signalled_used = vq->last_used_idx;\n+\n+\t\tif ((vhost_need_event(vhost_used_event(vq), new, old) &&\n+\t\t\t\t\t(vq->callfd >= 0)) ||\n+\t\t\t\tunlikely(!signalled_used_valid))\n \t\t\teventfd_write(vq->callfd, (eventfd_t) 1);\n-\t\t}\n \t} else {\n \t\t/* Kick the guest if necessary. */\n \t\tif (!(vq->avail->flags & VRING_AVAIL_F_NO_INTERRUPT)\n", "prefixes": [] }