Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/50192/?format=api
{ "id": 50192, "url": "http://patches.dpdk.org/api/patches/50192/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1549541873-17403-28-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1549541873-17403-28-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1549541873-17403-28-git-send-email-arybchenko@solarflare.com", "date": "2019-02-07T12:17:50", "name": "[27/30] net/sfc: move isolated flag in adapter shared", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "494851d9dfb1ac4a6ea146c6dd6f13dab1063e9f", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1549541873-17403-28-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 3407, "url": "http://patches.dpdk.org/api/series/3407/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3407", "date": "2019-02-07T12:17:25", "name": "net/sfc: improve multi-process support", "version": 1, "mbox": "http://patches.dpdk.org/series/3407/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/50192/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/50192/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 927551B58B;\n\tThu, 7 Feb 2019 13:18:50 +0100 (CET)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 317F51B4C9\n\tfor <dev@dpdk.org>; Thu, 7 Feb 2019 13:18:19 +0100 (CET)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id\n\tC493260005B for <dev@dpdk.org>; Thu, 7 Feb 2019 12:18:17 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Thu, 7 Feb 2019 04:18:11 -0800", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Thu, 7 Feb 2019 04:18:10 -0800", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tx17CI9Hi013312 for <dev@dpdk.org>; Thu, 7 Feb 2019 12:18:09 GMT", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\t80C3F1613EB\n\tfor <dev@dpdk.org>; Thu, 7 Feb 2019 12:18:09 +0000 (GMT)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "Date": "Thu, 7 Feb 2019 12:17:50 +0000", "Message-ID": "<1549541873-17403-28-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1549541873-17403-1-git-send-email-arybchenko@solarflare.com>", "References": "<1549541873-17403-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24412.006", "X-TM-AS-Result": "No-4.494900-4.000000-10", "X-TMASE-MatchedRID": "xkUsjeGIFohCR/FskDJObjj3DitIowB9VNyumldWne3RLEyE6G4DRHB4\n\t4IkzjfYy5pSjkyGV5DZvS2YZNWphNCnixsypv8PSo65WJt1k1O9xueIW2fKuyJ0Koq3EzpuHQIG\n\t0mTtr+QbuR/hwO2udkVbPZ6Ii5YaaMGg+wgnY/enJ5W6OZe5hhSH8kDR0dp2mACF5TKaad1/4+j\n\tJqxRaFP7mDEathwuYVsGRzEHTW2nEfE8yM4pjsDwtuKBGekqUpnH7sbImOEBT0p5l2o7bY5PZWY\n\tyK0pqmLT25rC7buOPpM65ZpS8rg94SOXWdTpNmZ53Wd/zULO/UoGZ6wXe0j6VuJm63v9t+iXAW/\n\tkHvSW5kvOSq+nxEQtagePGmIEwXO/4UC4n7D3uWJl6tigvYfL0uFvzEYSdV+", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--4.494900-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24412.006", "X-MDID": "1549541898-2cQsm5O08Nbd", "Subject": "[dpdk-dev] [PATCH 27/30] net/sfc: move isolated flag in adapter\n\tshared", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The flag is required in default RSS RETA get which does not make sense\nin isolated mode.\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/sfc.h | 3 ++-\n drivers/net/sfc/sfc_ethdev.c | 15 ++++++---------\n drivers/net/sfc/sfc_flow.c | 3 +--\n drivers/net/sfc/sfc_port.c | 2 +-\n drivers/net/sfc/sfc_rx.c | 3 +--\n 5 files changed, 11 insertions(+), 15 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc.h b/drivers/net/sfc/sfc.h\nindex 72992d68b..e8569bbbc 100644\n--- a/drivers/net/sfc/sfc.h\n+++ b/drivers/net/sfc/sfc.h\n@@ -131,7 +131,6 @@ struct sfc_port {\n \t * Flow API isolated mode overrides promisc and allmulti settings;\n \t * they won't be applied if isolated mode is active\n \t */\n-\tboolean_t\t\t\tisolated;\n \tboolean_t\t\t\tpromisc;\n \tboolean_t\t\t\tallmulti;\n \n@@ -184,6 +183,8 @@ struct sfc_adapter_shared {\n \n \tstruct sfc_rss\t\t\trss;\n \n+\tboolean_t\t\t\tisolated;\n+\n \tstruct rte_pci_addr\t\tpci_addr;\n \tuint16_t\t\t\tport_id;\n \ndiff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c\nindex 034229f37..c6bee09ee 100644\n--- a/drivers/net/sfc/sfc_ethdev.c\n+++ b/drivers/net/sfc/sfc_ethdev.c\n@@ -357,7 +357,7 @@ sfc_dev_filter_set(struct rte_eth_dev *dev, enum sfc_dev_filter_mode mode,\n \tif (*toggle != enabled) {\n \t\t*toggle = enabled;\n \n-\t\tif (port->isolated) {\n+\t\tif (sfc_sa2shared(sa)->isolated) {\n \t\t\tsfc_warn(sa, \"isolated mode is active on the port\");\n \t\t\tsfc_warn(sa, \"the change is to be applied on the next \"\n \t\t\t\t \"start provided that isolated mode is \"\n@@ -957,7 +957,7 @@ sfc_mac_addr_set(struct rte_eth_dev *dev, struct ether_addr *mac_addr)\n \t * on the next port start if the user prevents\n \t * isolated mode from being enabled.\n \t */\n-\tif (port->isolated) {\n+\tif (sfc_sa2shared(sa)->isolated) {\n \t\tsfc_warn(sa, \"isolated mode is active on the port\");\n \t\tsfc_warn(sa, \"will not set MAC address\");\n \t\tgoto unlock;\n@@ -1027,7 +1027,7 @@ sfc_set_mc_addr_list(struct rte_eth_dev *dev, struct ether_addr *mc_addr_set,\n \tint rc;\n \tunsigned int i;\n \n-\tif (port->isolated) {\n+\tif (sfc_sa2shared(sa)->isolated) {\n \t\tsfc_err(sa, \"isolated mode is active on the port\");\n \t\tsfc_err(sa, \"will not set multicast address list\");\n \t\treturn -ENOTSUP;\n@@ -1451,11 +1451,10 @@ sfc_dev_rss_hash_update(struct rte_eth_dev *dev,\n {\n \tstruct sfc_adapter *sa = dev->data->dev_private;\n \tstruct sfc_rss *rss = &sfc_sa2shared(sa)->rss;\n-\tstruct sfc_port *port = &sa->port;\n \tunsigned int efx_hash_types;\n \tint rc = 0;\n \n-\tif (port->isolated)\n+\tif (sfc_sa2shared(sa)->isolated)\n \t\treturn -ENOTSUP;\n \n \tif (rss->context_type != EFX_RX_SCALE_EXCLUSIVE) {\n@@ -1529,10 +1528,9 @@ sfc_dev_rss_reta_query(struct rte_eth_dev *dev,\n \tstruct sfc_adapter_shared *sas = sfc_adapter_shared_by_eth_dev(dev);\n \tstruct sfc_adapter *sa = dev->data->dev_private;\n \tstruct sfc_rss *rss = &sas->rss;\n-\tstruct sfc_port *port = &sa->port;\n \tint entry;\n \n-\tif (rss->context_type != EFX_RX_SCALE_EXCLUSIVE || port->isolated)\n+\tif (rss->context_type != EFX_RX_SCALE_EXCLUSIVE || sas->isolated)\n \t\treturn -ENOTSUP;\n \n \tif (rss->channels == 0)\n@@ -1563,13 +1561,12 @@ sfc_dev_rss_reta_update(struct rte_eth_dev *dev,\n {\n \tstruct sfc_adapter *sa = dev->data->dev_private;\n \tstruct sfc_rss *rss = &sfc_sa2shared(sa)->rss;\n-\tstruct sfc_port *port = &sa->port;\n \tunsigned int *rss_tbl_new;\n \tuint16_t entry;\n \tint rc = 0;\n \n \n-\tif (port->isolated)\n+\tif (sfc_sa2shared(sa)->isolated)\n \t\treturn -ENOTSUP;\n \n \tif (rss->context_type != EFX_RX_SCALE_EXCLUSIVE) {\ndiff --git a/drivers/net/sfc/sfc_flow.c b/drivers/net/sfc/sfc_flow.c\nindex 201c6cd06..01a81eab8 100644\n--- a/drivers/net/sfc/sfc_flow.c\n+++ b/drivers/net/sfc/sfc_flow.c\n@@ -2425,7 +2425,6 @@ sfc_flow_isolate(struct rte_eth_dev *dev, int enable,\n \t\t struct rte_flow_error *error)\n {\n \tstruct sfc_adapter *sa = dev->data->dev_private;\n-\tstruct sfc_port *port = &sa->port;\n \tint ret = 0;\n \n \tsfc_adapter_lock(sa);\n@@ -2435,7 +2434,7 @@ sfc_flow_isolate(struct rte_eth_dev *dev, int enable,\n \t\t\t\t NULL, \"please close the port first\");\n \t\tret = -rte_errno;\n \t} else {\n-\t\tport->isolated = (enable) ? B_TRUE : B_FALSE;\n+\t\tsfc_sa2shared(sa)->isolated = (enable) ? B_TRUE : B_FALSE;\n \t}\n \tsfc_adapter_unlock(sa);\n \ndiff --git a/drivers/net/sfc/sfc_port.c b/drivers/net/sfc/sfc_port.c\nindex 5eb4b3aca..1709dba4e 100644\n--- a/drivers/net/sfc/sfc_port.c\n+++ b/drivers/net/sfc/sfc_port.c\n@@ -226,7 +226,7 @@ sfc_port_start(struct sfc_adapter *sa)\n \tif (rc != 0)\n \t\tgoto fail_mac_pdu_set;\n \n-\tif (!port->isolated) {\n+\tif (!sfc_sa2shared(sa)->isolated) {\n \t\tstruct ether_addr *addr = &port->default_mac_addr;\n \n \t\tsfc_log_init(sa, \"set MAC address\");\ndiff --git a/drivers/net/sfc/sfc_rx.c b/drivers/net/sfc/sfc_rx.c\nindex 3b4b65f6e..cd8abc8ea 100644\n--- a/drivers/net/sfc/sfc_rx.c\n+++ b/drivers/net/sfc/sfc_rx.c\n@@ -669,7 +669,6 @@ sfc_rx_default_rxq_set_filter(struct sfc_adapter *sa, struct sfc_rxq *rxq)\n int\n sfc_rx_qstart(struct sfc_adapter *sa, unsigned int sw_index)\n {\n-\tstruct sfc_port *port = &sa->port;\n \tstruct sfc_rxq_info *rxq_info;\n \tstruct sfc_rxq *rxq;\n \tstruct sfc_evq *evq;\n@@ -731,7 +730,7 @@ sfc_rx_qstart(struct sfc_adapter *sa, unsigned int sw_index)\n \n \trxq_info->state |= SFC_RXQ_STARTED;\n \n-\tif ((sw_index == 0) && !port->isolated) {\n+\tif (sw_index == 0 && !sfc_sa2shared(sa)->isolated) {\n \t\trc = sfc_rx_default_rxq_set_filter(sa, rxq);\n \t\tif (rc != 0)\n \t\t\tgoto fail_mac_filter_default_rxq_set;\n", "prefixes": [ "27/30" ] }