Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/50181/?format=api
http://patches.dpdk.org/api/patches/50181/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1549541873-17403-24-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1549541873-17403-24-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1549541873-17403-24-git-send-email-arybchenko@solarflare.com", "date": "2019-02-07T12:17:46", "name": "[23/30] net/sfc: make main logging macro reusable in secondary", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6d1bb735b83501cf4e1cf1822ed65911ca76b83f", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1549541873-17403-24-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 3407, "url": "http://patches.dpdk.org/api/series/3407/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3407", "date": "2019-02-07T12:17:25", "name": "net/sfc: improve multi-process support", "version": 1, "mbox": "http://patches.dpdk.org/series/3407/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/50181/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/50181/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D667F1B535;\n\tThu, 7 Feb 2019 13:18:39 +0100 (CET)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[148.163.129.52]) by dpdk.org (Postfix) with ESMTP id A3D831B4B6\n\tfor <dev@dpdk.org>; Thu, 7 Feb 2019 13:18:16 +0100 (CET)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id\n\tBBD2860005B for <dev@dpdk.org>; Thu, 7 Feb 2019 12:18:15 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Thu, 7 Feb 2019 04:18:10 -0800", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Thu, 7 Feb 2019 04:18:10 -0800", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tx17CI9I5013293 for <dev@dpdk.org>; Thu, 7 Feb 2019 12:18:09 GMT", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\t4B0651613EB\n\tfor <dev@dpdk.org>; Thu, 7 Feb 2019 12:18:09 +0000 (GMT)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "Date": "Thu, 7 Feb 2019 12:17:46 +0000", "Message-ID": "<1549541873-17403-24-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1549541873-17403-1-git-send-email-arybchenko@solarflare.com>", "References": "<1549541873-17403-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24412.006", "X-TM-AS-Result": "No-6.139800-4.000000-10", "X-TMASE-MatchedRID": "kdClzEoqFPdgNTke+eoi16b8GfRpncAzlSphlGf1p5HfTFKBkQVCslzm\n\tbZmEF1O409NQNrxIpFYBtjkcfRMmqSnPugGsN3p5fuyIS1Zjfrtzd7C7BtJobvgnJH5vm2+g584\n\tAXn/P/n2DZO9Xbndg3h2a9WLoHBurxpw//AHNLCfhG1IOMb7PsIB84MMvKlea8JGeRYYBDDrY92\n\tZl64JjICuvI3j+W1HBXBw41v12Ht2PaFHMfVTC4BRFJJyf5BJe3QfwsVk0UbtuRXh7bFKB7ojLw\n\tF4bPHgHBwCCt2qcoHpffZztqnsXurwBcehf5XzEH8FerAT0dJY=", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--6.139800-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24412.006", "X-MDID": "1549541896-hn2UcaOqBnxl", "Subject": "[dpdk-dev] [PATCH 23/30] net/sfc: make main logging macro reusable\n\tin secondary", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Logging should be supported in secondary process and now we have\neverything required to share at least main logging macro.\nsfc_adapter is going to become primary process only.\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/sfc_ethdev.c | 14 ++++----------\n drivers/net/sfc/sfc_log.h | 28 ++++++++++++++--------------\n 2 files changed, 18 insertions(+), 24 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c\nindex 9f0036375..e30217cf1 100644\n--- a/drivers/net/sfc/sfc_ethdev.c\n+++ b/drivers/net/sfc/sfc_ethdev.c\n@@ -1922,12 +1922,6 @@ static const struct eth_dev_ops sfc_eth_dev_secondary_ops = {\n static int\n sfc_eth_dev_secondary_init(struct rte_eth_dev *dev, uint32_t logtype_main)\n {\n-\t/*\n-\t * Device private data has really many process-local pointers.\n-\t * Below code should be extremely careful to use data located\n-\t * in shared memory only.\n-\t */\n-\tstruct sfc_adapter *sa = dev->data->dev_private;\n \tstruct sfc_adapter_shared *sas = sfc_adapter_shared_by_eth_dev(dev);\n \tstruct sfc_adapter_priv *sap;\n \tconst struct sfc_dp_rx *dp_rx;\n@@ -1948,13 +1942,13 @@ sfc_eth_dev_secondary_init(struct rte_eth_dev *dev, uint32_t logtype_main)\n \n \tdp_rx = sfc_dp_find_rx_by_name(&sfc_dp_head, sas->dp_rx_name);\n \tif (dp_rx == NULL) {\n-\t\tSFC_LOG(sa, RTE_LOG_ERR, logtype_main,\n+\t\tSFC_LOG(sas, RTE_LOG_ERR, logtype_main,\n \t\t\t\"cannot find %s Rx datapath\", sas->dp_rx_name);\n \t\trc = ENOENT;\n \t\tgoto fail_dp_rx;\n \t}\n \tif (~dp_rx->features & SFC_DP_RX_FEAT_MULTI_PROCESS) {\n-\t\tSFC_LOG(sa, RTE_LOG_ERR, logtype_main,\n+\t\tSFC_LOG(sas, RTE_LOG_ERR, logtype_main,\n \t\t\t\"%s Rx datapath does not support multi-process\",\n \t\t\tsas->dp_rx_name);\n \t\trc = EINVAL;\n@@ -1963,13 +1957,13 @@ sfc_eth_dev_secondary_init(struct rte_eth_dev *dev, uint32_t logtype_main)\n \n \tdp_tx = sfc_dp_find_tx_by_name(&sfc_dp_head, sas->dp_tx_name);\n \tif (dp_tx == NULL) {\n-\t\tSFC_LOG(sa, RTE_LOG_ERR, logtype_main,\n+\t\tSFC_LOG(sas, RTE_LOG_ERR, logtype_main,\n \t\t\t\"cannot find %s Tx datapath\", sas->dp_tx_name);\n \t\trc = ENOENT;\n \t\tgoto fail_dp_tx;\n \t}\n \tif (~dp_tx->features & SFC_DP_TX_FEAT_MULTI_PROCESS) {\n-\t\tSFC_LOG(sa, RTE_LOG_ERR, logtype_main,\n+\t\tSFC_LOG(sas, RTE_LOG_ERR, logtype_main,\n \t\t\t\"%s Tx datapath does not support multi-process\",\n \t\t\tsas->dp_tx_name);\n \t\trc = EINVAL;\ndiff --git a/drivers/net/sfc/sfc_log.h b/drivers/net/sfc/sfc_log.h\nindex 97de9ae53..62c4f4dd1 100644\n--- a/drivers/net/sfc/sfc_log.h\n+++ b/drivers/net/sfc/sfc_log.h\n@@ -32,11 +32,10 @@ extern uint32_t sfc_logtype_driver;\n #define SFC_LOG_LEVEL_MCDI\tRTE_LOG_INFO\n \n /* Log PMD message, automatically add prefix and \\n */\n-#define SFC_LOG(sa, level, type, ...) \\\n+#define SFC_LOG(sas, level, type, ...) \\\n \tdo {\t\t\t\t\t\t\t\t\\\n-\t\tconst struct sfc_adapter_shared *_sas;\t\t\t\\\n+\t\tconst struct sfc_adapter_shared *_sas = (sas);\t\t\\\n \t\t\t\t\t\t\t\t\t\\\n-\t\t_sas = (sa)->priv.shared;\t\t\t\t\\\n \t\trte_log(level, type,\t\t\t\t\t\\\n \t\t\tRTE_FMT(\"PMD: sfc_efx \"\t\t\t\t\\\n \t\t\t\tPCI_PRI_FMT \" #%\" PRIu16\t\t\\\n@@ -53,39 +52,40 @@ extern uint32_t sfc_logtype_driver;\n \tdo {\t\t\t\t\t\t\t\t\\\n \t\tconst struct sfc_adapter *_sa = (sa);\t\t\t\\\n \t\t\t\t\t\t\t\t\t\\\n-\t\tSFC_LOG(_sa, RTE_LOG_ERR, _sa->priv.logtype_main,\t\\\n-\t\t\t__VA_ARGS__);\t\t\t\t\t\\\n+\t\tSFC_LOG(_sa->priv.shared, RTE_LOG_ERR,\t\t\t\\\n+\t\t\t_sa->priv.logtype_main, __VA_ARGS__);\t\t\\\n \t} while (0)\n \n #define sfc_warn(sa, ...) \\\n \tdo {\t\t\t\t\t\t\t\t\\\n \t\tconst struct sfc_adapter *_sa = (sa);\t\t\t\\\n \t\t\t\t\t\t\t\t\t\\\n-\t\tSFC_LOG(_sa, RTE_LOG_WARNING, _sa->priv.logtype_main,\t\\\n-\t\t\t__VA_ARGS__);\t\t\t\t\t\\\n+\t\tSFC_LOG(_sa->priv.shared, RTE_LOG_WARNING,\t\t\\\n+\t\t\t_sa->priv.logtype_main, __VA_ARGS__);\t\t\\\n \t} while (0)\n \n #define sfc_notice(sa, ...) \\\n \tdo {\t\t\t\t\t\t\t\t\\\n \t\tconst struct sfc_adapter *_sa = (sa);\t\t\t\\\n \t\t\t\t\t\t\t\t\t\\\n-\t\tSFC_LOG(_sa, RTE_LOG_NOTICE, _sa->priv.logtype_main,\t\\\n-\t\t\t__VA_ARGS__);\t\t\t\t\t\\\n+\t\tSFC_LOG(_sa->priv.shared, RTE_LOG_NOTICE,\t\t\\\n+\t\t\t_sa->priv.logtype_main, __VA_ARGS__);\t\t\\\n \t} while (0)\n \n #define sfc_info(sa, ...) \\\n \tdo {\t\t\t\t\t\t\t\t\\\n \t\tconst struct sfc_adapter *_sa = (sa);\t\t\t\\\n \t\t\t\t\t\t\t\t\t\\\n-\t\tSFC_LOG(_sa, RTE_LOG_INFO, _sa->priv.logtype_main,\t\\\n-\t\t\t__VA_ARGS__);\t\t\t\t\t\\\n+\t\tSFC_LOG(_sa->priv.shared, RTE_LOG_INFO,\t\t\t\\\n+\t\t\t_sa->priv.logtype_main, __VA_ARGS__);\t\t\\\n \t} while (0)\n \n #define sfc_log_init(sa, ...) \\\n \tdo {\t\t\t\t\t\t\t\t\\\n \t\tconst struct sfc_adapter *_sa = (sa);\t\t\t\\\n \t\t\t\t\t\t\t\t\t\\\n-\t\tSFC_LOG(_sa, RTE_LOG_INFO, _sa->priv.logtype_main,\t\\\n+\t\tSFC_LOG(_sa->priv.shared, RTE_LOG_INFO,\t\t\t\\\n+\t\t\t_sa->priv.logtype_main,\t\t\t\t\\\n \t\t\tRTE_FMT(\"%s(): \"\t\t\t\t\\\n \t\t\t\tRTE_FMT_HEAD(__VA_ARGS__ ,),\t\t\\\n \t\t\t\t__func__,\t\t\t\t\\\n@@ -96,8 +96,8 @@ extern uint32_t sfc_logtype_driver;\n \tdo {\t\t\t\t\t\t\t\t\\\n \t\tconst struct sfc_adapter *_sa = (sa);\t\t\t\\\n \t\t\t\t\t\t\t\t\t\\\n-\t\tSFC_LOG(_sa, SFC_LOG_LEVEL_MCDI, _sa->mcdi.logtype,\t\\\n-\t\t\t__VA_ARGS__);\t\t\t\t\t\\\n+\t\tSFC_LOG(_sa->priv.shared, SFC_LOG_LEVEL_MCDI,\t\t\\\n+\t\t\t_sa->mcdi.logtype, __VA_ARGS__);\t\t\\\n \t} while (0)\n \n \n", "prefixes": [ "23/30" ] }{ "id": 50181, "url": "