Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/50170/?format=api
{ "id": 50170, "url": "http://patches.dpdk.org/api/patches/50170/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1549541873-17403-7-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1549541873-17403-7-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1549541873-17403-7-git-send-email-arybchenko@solarflare.com", "date": "2019-02-07T12:17:29", "name": "[06/30] net/sfc: remove wrappers around Rx descriptor count and done", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6ae598ce964257c0c12c9835f8268e36e4287646", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1549541873-17403-7-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 3407, "url": "http://patches.dpdk.org/api/series/3407/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3407", "date": "2019-02-07T12:17:25", "name": "net/sfc: improve multi-process support", "version": 1, "mbox": "http://patches.dpdk.org/series/3407/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/50170/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/50170/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 70E781B4E9;\n\tThu, 7 Feb 2019 13:18:28 +0100 (CET)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 121351B4AF\n\tfor <dev@dpdk.org>; Thu, 7 Feb 2019 13:18:15 +0100 (CET)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id\n\tAF174600057 for <dev@dpdk.org>; Thu, 7 Feb 2019 12:18:13 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Thu, 7 Feb 2019 04:18:09 -0800", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Thu, 7 Feb 2019 04:18:09 -0800", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tx17CI8tb013217 for <dev@dpdk.org>; Thu, 7 Feb 2019 12:18:08 GMT", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\t553321613ED\n\tfor <dev@dpdk.org>; Thu, 7 Feb 2019 12:18:08 +0000 (GMT)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "Date": "Thu, 7 Feb 2019 12:17:29 +0000", "Message-ID": "<1549541873-17403-7-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1549541873-17403-1-git-send-email-arybchenko@solarflare.com>", "References": "<1549541873-17403-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24412.006", "X-TM-AS-Result": "No-1.683300-4.000000-10", "X-TMASE-MatchedRID": "b602RmutDtHl45tYrNr2LUf49ONH0RaSSjyMfjCRfaPfUZT83lbkEK1r\n\twNdVdYiphcnOL9mKiCalyH+LgJssgYbzTO6asfbjt1AhvyEKdj6vvh7pqacPxjFidTBRWb28OJo\n\tzVvs5N6Hi8zVgXoAltsIJ+4gwXrEtKsmEtKMlFWbE96C6spOjALc3aRtdAX970/RyN05C7T4SAL\n\ta9PJ21gMTRZw8hLeGKSCIhtrTD0pNy3hQOAmMb26EYlVDQzHYUWD4biWWzNyCqFrt9xUgp+uq+T\n\t0IcdvQ1BtPt5WQTZkLauEQaIW46K4YinWuMIb+inqg/VrSZEiM=", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10-1.683300-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24412.006", "X-MDID": "1549541894-UAAjzLZ2KDku", "Subject": "[dpdk-dev] [PATCH 06/30] net/sfc: remove wrappers around Rx\n\tdescriptor count and done", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "These wrappers are used in single place and just complicate reading\nand understanding if these ops could be supported in secondary process.\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/sfc_ethdev.c | 12 ++++++++++--\n drivers/net/sfc/sfc_rx.c | 22 ----------------------\n drivers/net/sfc/sfc_rx.h | 4 ----\n 3 files changed, 10 insertions(+), 28 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c\nindex 87a2c9431..36dc580ae 100644\n--- a/drivers/net/sfc/sfc_ethdev.c\n+++ b/drivers/net/sfc/sfc_ethdev.c\n@@ -1119,16 +1119,24 @@ static uint32_t\n sfc_rx_queue_count(struct rte_eth_dev *dev, uint16_t rx_queue_id)\n {\n \tstruct sfc_adapter *sa = dev->data->dev_private;\n+\tstruct sfc_rxq *rxq;\n+\n+\tSFC_ASSERT(rx_queue_id < sa->rxq_count);\n+\trxq = sa->rxq_info[rx_queue_id].rxq;\n \n-\treturn sfc_rx_qdesc_npending(sa, rx_queue_id);\n+\tif (rxq == NULL || (rxq->state & SFC_RXQ_STARTED) == 0)\n+\t\treturn 0;\n+\n+\treturn sa->dp_rx->qdesc_npending(rxq->dp);\n }\n \n static int\n sfc_rx_descriptor_done(void *queue, uint16_t offset)\n {\n \tstruct sfc_dp_rxq *dp_rxq = queue;\n+\tstruct sfc_rxq *rxq = sfc_rxq_by_dp_rxq(dp_rxq);\n \n-\treturn sfc_rx_qdesc_done(dp_rxq, offset);\n+\treturn offset < rxq->evq->sa->dp_rx->qdesc_npending(dp_rxq);\n }\n \n static int\ndiff --git a/drivers/net/sfc/sfc_rx.c b/drivers/net/sfc/sfc_rx.c\nindex dcccb96b1..44aee29e9 100644\n--- a/drivers/net/sfc/sfc_rx.c\n+++ b/drivers/net/sfc/sfc_rx.c\n@@ -530,28 +530,6 @@ struct sfc_dp_rx sfc_efx_rx = {\n \t.pkt_burst\t\t= sfc_efx_recv_pkts,\n };\n \n-unsigned int\n-sfc_rx_qdesc_npending(struct sfc_adapter *sa, unsigned int sw_index)\n-{\n-\tstruct sfc_rxq *rxq;\n-\n-\tSFC_ASSERT(sw_index < sa->rxq_count);\n-\trxq = sa->rxq_info[sw_index].rxq;\n-\n-\tif (rxq == NULL || (rxq->state & SFC_RXQ_STARTED) == 0)\n-\t\treturn 0;\n-\n-\treturn sa->dp_rx->qdesc_npending(rxq->dp);\n-}\n-\n-int\n-sfc_rx_qdesc_done(struct sfc_dp_rxq *dp_rxq, unsigned int offset)\n-{\n-\tstruct sfc_rxq *rxq = sfc_rxq_by_dp_rxq(dp_rxq);\n-\n-\treturn offset < rxq->evq->sa->dp_rx->qdesc_npending(dp_rxq);\n-}\n-\n static void\n sfc_rx_qflush(struct sfc_adapter *sa, unsigned int sw_index)\n {\ndiff --git a/drivers/net/sfc/sfc_rx.h b/drivers/net/sfc/sfc_rx.h\nindex 7231379a6..06e8eac8d 100644\n--- a/drivers/net/sfc/sfc_rx.h\n+++ b/drivers/net/sfc/sfc_rx.h\n@@ -149,10 +149,6 @@ uint64_t sfc_rx_get_queue_offload_caps(struct sfc_adapter *sa);\n void sfc_rx_qflush_done(struct sfc_rxq *rxq);\n void sfc_rx_qflush_failed(struct sfc_rxq *rxq);\n \n-unsigned int sfc_rx_qdesc_npending(struct sfc_adapter *sa,\n-\t\t\t\t unsigned int sw_index);\n-int sfc_rx_qdesc_done(struct sfc_dp_rxq *dp_rxq, unsigned int offset);\n-\n int sfc_rx_hash_init(struct sfc_adapter *sa);\n void sfc_rx_hash_fini(struct sfc_adapter *sa);\n int sfc_rx_hf_rte_to_efx(struct sfc_adapter *sa, uint64_t rte,\n", "prefixes": [ "06/30" ] }