Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/50167/?format=api
{ "id": 50167, "url": "http://patches.dpdk.org/api/patches/50167/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1549541873-17403-8-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1549541873-17403-8-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1549541873-17403-8-git-send-email-arybchenko@solarflare.com", "date": "2019-02-07T12:17:30", "name": "[07/30] net/sfc: make it simpler to change datapath ops location", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b0fd17b7e22ef8eff6ea4fb76ee2701e8267becc", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1549541873-17403-8-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 3407, "url": "http://patches.dpdk.org/api/series/3407/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3407", "date": "2019-02-07T12:17:25", "name": "net/sfc: improve multi-process support", "version": 1, "mbox": "http://patches.dpdk.org/series/3407/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/50167/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/50167/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 95BC81B4D6;\n\tThu, 7 Feb 2019 13:18:24 +0100 (CET)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 56D9A1B4AF\n\tfor <dev@dpdk.org>; Thu, 7 Feb 2019 13:18:14 +0100 (CET)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id\n\t31F82600057 for <dev@dpdk.org>; Thu, 7 Feb 2019 12:18:13 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Thu, 7 Feb 2019 04:18:09 -0800", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Thu, 7 Feb 2019 04:18:09 -0800", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tx17CI8L7013221 for <dev@dpdk.org>; Thu, 7 Feb 2019 12:18:08 GMT", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\t628011613E4\n\tfor <dev@dpdk.org>; Thu, 7 Feb 2019 12:18:08 +0000 (GMT)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "Date": "Thu, 7 Feb 2019 12:17:30 +0000", "Message-ID": "<1549541873-17403-8-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1549541873-17403-1-git-send-email-arybchenko@solarflare.com>", "References": "<1549541873-17403-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24412.006", "X-TM-AS-Result": "No-1.220400-4.000000-10", "X-TMASE-MatchedRID": "UFAELJy4t92Ic+vz4Wow0yYRREGYqtmUTJDl9FKHbrm82TV3yRt/mqYm\n\tf3n26fzqAwade5BKaDhZ8dIoq+XBRYh1eqwd24JQYwaJXrf2IXTGYnoF/CTeZZsoi2XrUn/Jn6K\n\tdMrRsL14qtq5d3cxkNUrJnk8Tj/KR2T0Vj7hHXlFK9H5ESthoOzLBzTU+2otENxztDcXp3qMbqi\n\t4bv1WErwOWGkF9QNFXvZi/zRe1L0IjCELN0+ElYJcKmKwj4x3aI6KkAL2A5kcMtYrw9BuTwqSmS\n\tPRgKSZMuowvJdIWQm5DDKa3G4nrLQ==", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--1.220400-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24412.006", "X-MDID": "1549541893-dY7njkWGwj4u", "Subject": "[dpdk-dev] [PATCH 07/30] net/sfc: make it simpler to change\n\tdatapath ops location", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Rx and Tx datapath ops should be stored in process private\ndata since these structures are located in the data section\n(not allocated from shared memory).\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/sfc_ethdev.c | 38 ++++++++++++++++++------------------\n 1 file changed, 19 insertions(+), 19 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c\nindex 36dc580ae..f49a1073a 100644\n--- a/drivers/net/sfc/sfc_ethdev.c\n+++ b/drivers/net/sfc/sfc_ethdev.c\n@@ -1735,6 +1735,8 @@ static int\n sfc_eth_dev_set_ops(struct rte_eth_dev *dev)\n {\n \tstruct sfc_adapter *sa = dev->data->dev_private;\n+\tconst struct sfc_dp_rx *dp_rx;\n+\tconst struct sfc_dp_tx *dp_tx;\n \tconst efx_nic_cfg_t *encp;\n \tunsigned int avail_caps = 0;\n \tconst char *rx_name = NULL;\n@@ -1761,13 +1763,13 @@ sfc_eth_dev_set_ops(struct rte_eth_dev *dev)\n \t\tgoto fail_kvarg_rx_datapath;\n \n \tif (rx_name != NULL) {\n-\t\tsa->dp_rx = sfc_dp_find_rx_by_name(&sfc_dp_head, rx_name);\n-\t\tif (sa->dp_rx == NULL) {\n+\t\tdp_rx = sfc_dp_find_rx_by_name(&sfc_dp_head, rx_name);\n+\t\tif (dp_rx == NULL) {\n \t\t\tsfc_err(sa, \"Rx datapath %s not found\", rx_name);\n \t\t\trc = ENOENT;\n \t\t\tgoto fail_dp_rx;\n \t\t}\n-\t\tif (!sfc_dp_match_hw_fw_caps(&sa->dp_rx->dp, avail_caps)) {\n+\t\tif (!sfc_dp_match_hw_fw_caps(&dp_rx->dp, avail_caps)) {\n \t\t\tsfc_err(sa,\n \t\t\t\t\"Insufficient Hw/FW capabilities to use Rx datapath %s\",\n \t\t\t\trx_name);\n@@ -1775,8 +1777,8 @@ sfc_eth_dev_set_ops(struct rte_eth_dev *dev)\n \t\t\tgoto fail_dp_rx_caps;\n \t\t}\n \t} else {\n-\t\tsa->dp_rx = sfc_dp_find_rx_by_caps(&sfc_dp_head, avail_caps);\n-\t\tif (sa->dp_rx == NULL) {\n+\t\tdp_rx = sfc_dp_find_rx_by_caps(&sfc_dp_head, avail_caps);\n+\t\tif (dp_rx == NULL) {\n \t\t\tsfc_err(sa, \"Rx datapath by caps %#x not found\",\n \t\t\t\tavail_caps);\n \t\t\trc = ENOENT;\n@@ -1784,7 +1786,7 @@ sfc_eth_dev_set_ops(struct rte_eth_dev *dev)\n \t\t}\n \t}\n \n-\tsa->dp_rx_name = sfc_strdup(sa->dp_rx->dp.name);\n+\tsa->dp_rx_name = sfc_strdup(dp_rx->dp.name);\n \tif (sa->dp_rx_name == NULL) {\n \t\trc = ENOMEM;\n \t\tgoto fail_dp_rx_name;\n@@ -1792,21 +1794,19 @@ sfc_eth_dev_set_ops(struct rte_eth_dev *dev)\n \n \tsfc_notice(sa, \"use %s Rx datapath\", sa->dp_rx_name);\n \n-\tdev->rx_pkt_burst = sa->dp_rx->pkt_burst;\n-\n \trc = sfc_kvargs_process(sa, SFC_KVARG_TX_DATAPATH,\n \t\t\t\tsfc_kvarg_string_handler, &tx_name);\n \tif (rc != 0)\n \t\tgoto fail_kvarg_tx_datapath;\n \n \tif (tx_name != NULL) {\n-\t\tsa->dp_tx = sfc_dp_find_tx_by_name(&sfc_dp_head, tx_name);\n-\t\tif (sa->dp_tx == NULL) {\n+\t\tdp_tx = sfc_dp_find_tx_by_name(&sfc_dp_head, tx_name);\n+\t\tif (dp_tx == NULL) {\n \t\t\tsfc_err(sa, \"Tx datapath %s not found\", tx_name);\n \t\t\trc = ENOENT;\n \t\t\tgoto fail_dp_tx;\n \t\t}\n-\t\tif (!sfc_dp_match_hw_fw_caps(&sa->dp_tx->dp, avail_caps)) {\n+\t\tif (!sfc_dp_match_hw_fw_caps(&dp_tx->dp, avail_caps)) {\n \t\t\tsfc_err(sa,\n \t\t\t\t\"Insufficient Hw/FW capabilities to use Tx datapath %s\",\n \t\t\t\ttx_name);\n@@ -1814,8 +1814,8 @@ sfc_eth_dev_set_ops(struct rte_eth_dev *dev)\n \t\t\tgoto fail_dp_tx_caps;\n \t\t}\n \t} else {\n-\t\tsa->dp_tx = sfc_dp_find_tx_by_caps(&sfc_dp_head, avail_caps);\n-\t\tif (sa->dp_tx == NULL) {\n+\t\tdp_tx = sfc_dp_find_tx_by_caps(&sfc_dp_head, avail_caps);\n+\t\tif (dp_tx == NULL) {\n \t\t\tsfc_err(sa, \"Tx datapath by caps %#x not found\",\n \t\t\t\tavail_caps);\n \t\t\trc = ENOENT;\n@@ -1823,7 +1823,7 @@ sfc_eth_dev_set_ops(struct rte_eth_dev *dev)\n \t\t}\n \t}\n \n-\tsa->dp_tx_name = sfc_strdup(sa->dp_tx->dp.name);\n+\tsa->dp_tx_name = sfc_strdup(dp_tx->dp.name);\n \tif (sa->dp_tx_name == NULL) {\n \t\trc = ENOMEM;\n \t\tgoto fail_dp_tx_name;\n@@ -1831,7 +1831,11 @@ sfc_eth_dev_set_ops(struct rte_eth_dev *dev)\n \n \tsfc_notice(sa, \"use %s Tx datapath\", sa->dp_tx_name);\n \n-\tdev->tx_pkt_burst = sa->dp_tx->pkt_burst;\n+\tsa->dp_rx = dp_rx;\n+\tsa->dp_tx = dp_tx;\n+\n+\tdev->rx_pkt_burst = dp_rx->pkt_burst;\n+\tdev->tx_pkt_burst = dp_tx->pkt_burst;\n \n \tdev->dev_ops = &sfc_eth_dev_ops;\n \n@@ -1839,8 +1843,6 @@ sfc_eth_dev_set_ops(struct rte_eth_dev *dev)\n \n fail_dp_tx_name:\n fail_dp_tx_caps:\n-\tsa->dp_tx = NULL;\n-\n fail_dp_tx:\n fail_kvarg_tx_datapath:\n \trte_free(sa->dp_rx_name);\n@@ -1848,8 +1850,6 @@ sfc_eth_dev_set_ops(struct rte_eth_dev *dev)\n \n fail_dp_rx_name:\n fail_dp_rx_caps:\n-\tsa->dp_rx = NULL;\n-\n fail_dp_rx:\n fail_kvarg_rx_datapath:\n \treturn rc;\n", "prefixes": [ "07/30" ] }