Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/50142/?format=api
{ "id": 50142, "url": "http://patches.dpdk.org/api/patches/50142/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1549450337-2890-1-git-send-email-pallantlax.poornima@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1549450337-2890-1-git-send-email-pallantlax.poornima@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1549450337-2890-1-git-send-email-pallantlax.poornima@intel.com", "date": "2019-02-06T10:52:17", "name": "hash: fix sprintf with snprintf", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "afe1206e75096662d9739b950cb2d531fded73e7", "submitter": { "id": 1131, "url": "http://patches.dpdk.org/api/people/1131/?format=api", "name": "Poornima, PallantlaX", "email": "pallantlax.poornima@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1549450337-2890-1-git-send-email-pallantlax.poornima@intel.com/mbox/", "series": [ { "id": 3395, "url": "http://patches.dpdk.org/api/series/3395/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3395", "date": "2019-02-06T10:52:17", "name": "hash: fix sprintf with snprintf", "version": 1, "mbox": "http://patches.dpdk.org/series/3395/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/50142/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/50142/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 888AA1B3BA;\n\tWed, 6 Feb 2019 11:53:01 +0100 (CET)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id E9AE21B3AD;\n\tWed, 6 Feb 2019 11:52:59 +0100 (CET)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t06 Feb 2019 02:52:59 -0800", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby FMSMGA003.fm.intel.com with ESMTP; 06 Feb 2019 02:52:57 -0800", "from wgcvswdev001.ir.intel.com (wgcvswdev001.ir.intel.com\n\t[10.102.246.100])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tx16Aquvg008568; Wed, 6 Feb 2019 10:52:56 GMT", "from wgcvswdev001.ir.intel.com (localhost [127.0.0.1])\n\tby wgcvswdev001.ir.intel.com with ESMTP id x16AqL4L003082;\n\tWed, 6 Feb 2019 10:52:21 GMT", "(from ppoornix@localhost)\n\tby wgcvswdev001.ir.intel.com with ? id x16AqLNB003077;\n\tWed, 6 Feb 2019 10:52:21 GMT" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.58,339,1544515200\"; d=\"scan'208\";a=\"131491773\"", "From": "Pallantla Poornima <pallantlax.poornima@intel.com>", "To": "dev@dpdk.org", "Cc": "reshma.pattan@intel.com, yipeng1.wang@intel.com, sameh.gobriel@intel.com,\n\tbruce.richardson@intel.com, pablo.de.lara.guarch@intel.com,\n\tPallantla Poornima <pallantlax.poornima@intel.com>, stable@dpdk.org", "Date": "Wed, 6 Feb 2019 10:52:17 +0000", "Message-Id": "<1549450337-2890-1-git-send-email-pallantlax.poornima@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": "<y>", "References": "<y>", "Subject": "[dpdk-dev] [PATCH] hash: fix sprintf with snprintf", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "sprintf function is not secure as it doesn't check the length of string.\nMore secure function snprintf is used.\n\nFixes: 473d1bebce (\"hash: allow to store data in hash table\")\nCc: stable@dpdk.org\n\nSigned-off-by: Pallantla Poornima <pallantlax.poornima@intel.com>\n---\n test/test/test_hash_perf.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/test/test/test_hash_perf.c b/test/test/test_hash_perf.c\nindex 525211180..c09b10f2e 100644\n--- a/test/test/test_hash_perf.c\n+++ b/test/test/test_hash_perf.c\n@@ -85,9 +85,11 @@ create_table(unsigned int with_data, unsigned int table_index,\n \n \tif (with_data)\n \t\t/* Table will store 8-byte data */\n-\t\tsprintf(name, \"test_hash%d_data\", hashtest_key_lens[table_index]);\n+\t\tsnprintf(name, sizeof(name), \"test_hash%d_data\",\n+\t\t\t\thashtest_key_lens[table_index]);\n \telse\n-\t\tsprintf(name, \"test_hash%d\", hashtest_key_lens[table_index]);\n+\t\tsnprintf(name, sizeof(name), \"test_hash%d\",\n+\t\t\t\thashtest_key_lens[table_index]);\n \n \n \tif (with_locks)\n", "prefixes": [] }