Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 50036,
    "url": "http://patches.dpdk.org/api/patches/50036/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190124165902.24178-4-i.maximets@samsung.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190124165902.24178-4-i.maximets@samsung.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190124165902.24178-4-i.maximets@samsung.com",
    "date": "2019-01-24T16:59:02",
    "name": "[3/3] net/virtio: add missing read barrier for packed dequeue",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "1c0d7ba108a92ab9b8880323fe796a1f4a2d27de",
    "submitter": {
        "id": 323,
        "url": "http://patches.dpdk.org/api/people/323/?format=api",
        "name": "Ilya Maximets",
        "email": "i.maximets@samsung.com"
    },
    "delegate": {
        "id": 2642,
        "url": "http://patches.dpdk.org/api/users/2642/?format=api",
        "username": "mcoquelin",
        "first_name": "Maxime",
        "last_name": "Coquelin",
        "email": "maxime.coquelin@redhat.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190124165902.24178-4-i.maximets@samsung.com/mbox/",
    "series": [
        {
            "id": 3318,
            "url": "http://patches.dpdk.org/api/series/3318/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3318",
            "date": "2019-01-24T16:58:59",
            "name": "net/virtio: missing/wrong read barriers.",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/3318/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/50036/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/50036/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 43BE85B2C;\n\tThu, 24 Jan 2019 17:59:25 +0100 (CET)",
            "from mailout2.w1.samsung.com (mailout2.w1.samsung.com\n\t[210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 941F75B2C\n\tfor <dev@dpdk.org>; Thu, 24 Jan 2019 17:59:23 +0100 (CET)",
            "from eucas1p1.samsung.com (unknown [182.198.249.206])\n\tby mailout2.w1.samsung.com (KnoxPortal) with ESMTP id\n\t20190124165923euoutp02fe75293394adbec5cbebbadd0e6ddf19~811xT3d6M1959619596euoutp02A\n\tfor <dev@dpdk.org>; Thu, 24 Jan 2019 16:59:23 +0000 (GMT)",
            "from eusmges2new.samsung.com (unknown [203.254.199.244]) by\n\teucas1p2.samsung.com (KnoxPortal) with ESMTP id\n\t20190124165922eucas1p2581104aa20f76492e3828ebe759b4b51~811ws0m0A0263702637eucas1p2S;\n\tThu, 24 Jan 2019 16:59:22 +0000 (GMT)",
            "from eucas1p2.samsung.com ( [182.198.249.207]) by\n\teusmges2new.samsung.com (EUCPMTA) with SMTP id 8A.62.04294.AEEE94C5;\n\tThu, 24 Jan 2019 16:59:22 +0000 (GMT)",
            "from eusmtrp1.samsung.com (unknown [182.198.249.138]) by\n\teucas1p1.samsung.com (KnoxPortal) with ESMTPA id\n\t20190124165921eucas1p1fee7e668285fc26bc4f01c6b5ec0b66a~811v1cUFO1987719877eucas1p1k;\n\tThu, 24 Jan 2019 16:59:21 +0000 (GMT)",
            "from eusmgms1.samsung.com (unknown [182.198.249.179]) by\n\teusmtrp1.samsung.com (KnoxPortal) with ESMTP id\n\t20190124165921eusmtrp1fe2a97d4c0052aac0e1b42005d1af1c9~811vm3cqM2842328423eusmtrp1K;\n\tThu, 24 Jan 2019 16:59:21 +0000 (GMT)",
            "from eusmtip2.samsung.com ( [203.254.199.222]) by\n\teusmgms1.samsung.com (EUCPMTA) with SMTP id BC.FF.04284.9EEE94C5;\n\tThu, 24 Jan 2019 16:59:21 +0000 (GMT)",
            "from imaximets.rnd.samsung.ru (unknown [106.109.129.180]) by\n\teusmtip2.samsung.com (KnoxPortal) with ESMTPA id\n\t20190124165920eusmtip29ef83526cfd19b46a1ad8e83a9f51849~811unSbqf1449914499eusmtip2K;\n\tThu, 24 Jan 2019 16:59:20 +0000 (GMT)"
        ],
        "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com\n\t20190124165923euoutp02fe75293394adbec5cbebbadd0e6ddf19~811xT3d6M1959619596euoutp02A",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n\ts=mail20170921; t=1548349163;\n\tbh=2u37m1MLaIa6aRG9bUA55Ahp1tUHqg9cnA3Gg5haU1c=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=GvHmM2WucLdOjH7rMG56q+bp+99kbUmVCTiEaZZWv9MAS41PlIevqL7bfI6dKoVDt\n\tlcB/QlVLQbS1L9AKcEjizn6F7bbH5cEro7fzw+eMXDejde0Nkr+pxanORRdk80fluy\n\tOG7a1w9es5INTlIi8aWu9AZbf0cjVdytEsuBOKyM=",
        "X-AuditID": "cbfec7f4-84fff700000010c6-32-5c49eeea3099",
        "From": "Ilya Maximets <i.maximets@samsung.com>",
        "To": "dev@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>, \"Michael S .\n\tTsirkin\" <mst@redhat.com>",
        "Cc": "Tiwei Bie <tiwei.bie@intel.com>, Zhihong Wang <zhihong.wang@intel.com>, \n\tJens Freimann <jfreimann@redhat.com>, Ilya Maximets\n\t<i.maximets@samsung.com>, stable@dpdk.org",
        "Date": "Thu, 24 Jan 2019 19:59:02 +0300",
        "Message-Id": "<20190124165902.24178-4-i.maximets@samsung.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<20190124165902.24178-1-i.maximets@samsung.com>",
        "X-Brightmail-Tracker": [
            "H4sIAAAAAAAAA+NgFvrFIsWRmVeSWpSXmKPExsWy7djP87qv3nnGGJxeqGDx7tN2Josr7T/Z\n\tLc6tWcpicaxzD4vF/1+vWC3+dfxht9ja8J/JYvPFSUwOHB6/Fixl9Vi85yWTx/t9V9k8+ras\n\tYgxgieKySUnNySxLLdK3S+DKmPh6K0vBPfaKLT05DYzH2LoYOTgkBEwkth7U72Lk4hASWMEo\n\tsezQAzYI5wujxPwFy9i7GDmBnM+MEjfuaoDYIA0vv75hhihazijx6X4XE4Tzg1Fi2ySQsZwc\n\tbAI6EqdWH2EEsUUEMiRO3n7OCFLELLCWUeJs5xMmkISwgI/Es4XXwGwWAVWJw99/MIPYvALW\n\tEl2LLzJCrJOXWL3hAFicU8BG4vPFaWD3SQh8ZpN4MPs5O0SRi0T/jFPMELawxKvjW6DiMhKn\n\tJ/ewQNj1EvdbXjJCNHcwSkw/9I8JImEvseX1OXZQaDALaEqs36UPEXaUmPP8ORMkkPgkbrwV\n\tBAkzA5mTtk1nhgjzSnS0CUFUq0j8Prgc6gIpiZvvPkNd4CHRMek7EyQU+xkltu/NmcAoPwth\n\t1wJGxlWM4qmlxbnpqcVGeanlesWJucWleel6yfm5mxiBKeL0v+NfdjDu+pN0iFGAg1GJh7fj\n\tkGeMEGtiWXFl7iFGCQ5mJRFe14tuMUK8KYmVValF+fFFpTmpxYcYpTlYlMR5qxkeRAsJpCeW\n\tpGanphakFsFkmTg4pRoYHS6xR6zi41qj0TZp7SZXjojOw3K3wktDCiVOBwSl6m6W6UjeUWbh\n\tf/HAw+VTXgpUl6979efd3ysCNcWx11dOkYzjX9ZueuSISeg71fWbZikbTwvdf7uE4bvjjwnt\n\t7A8CntXFpSs3Pn8/Y6tsQaHfDVOHuVN2v04+FJoiduFiyn7+tmnM6gbXlFiKMxINtZiLihMB\n\t5vWuUg0DAAA=",
            "H4sIAAAAAAAAA+NgFrrLLMWRmVeSWpSXmKPExsVy+t/xe7ov33nGGKxpVrV492k7k8WV9p/s\n\tFufWLGWxONa5h8Xi/69XrBb/Ov6wW2xt+M9ksfniJCYHDo9fC5ayeize85LJ4/2+q2wefVtW\n\tMQawROnZFOWXlqQqZOQXl9gqRRtaGOkZWlroGZlY6hkam8daGZkq6dvZpKTmZJalFunbJehl\n\tTHy9laXgHnvFlp6cBsZjbF2MnBwSAiYSL7++Ye5i5OIQEljKKHG5bw87REJK4sevC6wQtrDE\n\tn2tdbBBF3xglHrzYClbEJqAjcWr1EcYuRg4OEYEsiXevPUBqmAU2MkpMX7EErEZYwEfi2cJr\n\tTCA2i4CqxOHvP5hBbF4Ba4muxRcZIRbIS6zecAAszilgI/H54jSw64SAamY9+8Y8gZFvASPD\n\tKkaR1NLi3PTcYkO94sTc4tK8dL3k/NxNjMCg3Xbs5+YdjJc2Bh9iFOBgVOLh7TjkGSPEmlhW\n\tXJl7iFGCg1lJhNf1oluMEG9KYmVValF+fFFpTmrxIUZToKMmMkuJJucDIyqvJN7Q1NDcwtLQ\n\t3Njc2MxCSZz3vEFllJBAemJJanZqakFqEUwfEwenVANjiVD7sVx74e5YYaZpn69XfdOwPLjk\n\tzQYdtQkFfiYKHbnF7QpPX+/ONWX7LLpMuNgjf3fzp37elJM35CyrLKeu8Dt439/49rULL9Yc\n\tW6VUmnfsl9e3qU17piT6iYdN1y1xKtp8/1D4sahg149TOnp4NgVG/bN70szy9HbhOgNucwnh\n\tbjOlReJKLMUZiYZazEXFiQATXqhvcAIAAA=="
        ],
        "X-CMS-MailID": "20190124165921eucas1p1fee7e668285fc26bc4f01c6b5ec0b66a",
        "X-Msg-Generator": "CA",
        "Content-Type": "text/plain; charset=\"utf-8\"",
        "X-RootMTR": "20190124165921eucas1p1fee7e668285fc26bc4f01c6b5ec0b66a",
        "X-EPHeader": "CA",
        "CMS-TYPE": "201P",
        "X-CMS-RootMailID": "20190124165921eucas1p1fee7e668285fc26bc4f01c6b5ec0b66a",
        "References": "<20190124165902.24178-1-i.maximets@samsung.com>\n\t<CGME20190124165921eucas1p1fee7e668285fc26bc4f01c6b5ec0b66a@eucas1p1.samsung.com>",
        "Subject": "[dpdk-dev] [PATCH 3/3] net/virtio: add missing read barrier for\n\tpacked dequeue",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Read barrier is required between reading the flags (desc_is_used)\nand the content of descriptor to ensure the ordering.\nOtherwise, speculative read of desc.id could be reordered with\nreading of the desc.flags.\n\nFixes: a76290c8f1cf (\"net/virtio: implement Rx path for packed queues\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ilya Maximets <i.maximets@samsung.com>\n---\n drivers/net/virtio/virtio_rxtx.c | 1 +\n 1 file changed, 1 insertion(+)",
    "diff": "diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c\nindex 5ffed6a51..4c701c514 100644\n--- a/drivers/net/virtio/virtio_rxtx.c\n+++ b/drivers/net/virtio/virtio_rxtx.c\n@@ -124,6 +124,7 @@ virtqueue_dequeue_burst_rx_packed(struct virtqueue *vq,\n \t\tused_idx = vq->vq_used_cons_idx;\n \t\tif (!desc_is_used(&desc[used_idx], vq))\n \t\t\treturn i;\n+\t\tvirtio_rmb(vq->hw->weak_barriers);\n \t\tlen[i] = desc[used_idx].len;\n \t\tid = desc[used_idx].id;\n \t\tcookie = (struct rte_mbuf *)vq->vq_descx[id].cookie;\n",
    "prefixes": [
        "3/3"
    ]
}