Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/50005/?format=api
{ "id": 50005, "url": "http://patches.dpdk.org/api/patches/50005/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190122162714.9144-1-i.maximets@samsung.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190122162714.9144-1-i.maximets@samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190122162714.9144-1-i.maximets@samsung.com", "date": "2019-01-22T16:27:14", "name": "eal: fix parsing zero socket memory and limits", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "77f74604722d08eb6407c3d94ba3f4643860b14a", "submitter": { "id": 323, "url": "http://patches.dpdk.org/api/people/323/?format=api", "name": "Ilya Maximets", "email": "i.maximets@samsung.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190122162714.9144-1-i.maximets@samsung.com/mbox/", "series": [ { "id": 3294, "url": "http://patches.dpdk.org/api/series/3294/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3294", "date": "2019-01-22T16:27:14", "name": "eal: fix parsing zero socket memory and limits", "version": 1, "mbox": "http://patches.dpdk.org/series/3294/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/50005/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/50005/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 66DAF3237;\n\tTue, 22 Jan 2019 17:27:24 +0100 (CET)", "from mailout2.w1.samsung.com (mailout2.w1.samsung.com\n\t[210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 7F74425D9\n\tfor <dev@dpdk.org>; Tue, 22 Jan 2019 17:27:23 +0100 (CET)", "from eucas1p1.samsung.com (unknown [182.198.249.206])\n\tby mailout2.w1.samsung.com (KnoxPortal) with ESMTP id\n\t20190122162722euoutp02feaddf9f30afcb362600d2dcee2d5e09~8OHPe-Ei_2788627886euoutp02P\n\tfor <dev@dpdk.org>; Tue, 22 Jan 2019 16:27:22 +0000 (GMT)", "from eusmges2new.samsung.com (unknown [203.254.199.244]) by\n\teucas1p2.samsung.com (KnoxPortal) with ESMTP id\n\t20190122162721eucas1p21f8e32a969ee437ebc74086e44b67b02~8OHPAtJdx1473714737eucas1p2x;\n\tTue, 22 Jan 2019 16:27:21 +0000 (GMT)", "from eucas1p1.samsung.com ( [182.198.249.206]) by\n\teusmges2new.samsung.com (EUCPMTA) with SMTP id 0E.50.04294.964474C5;\n\tTue, 22 Jan 2019 16:27:21 +0000 (GMT)", "from eusmtrp1.samsung.com (unknown [182.198.249.138]) by\n\teucas1p1.samsung.com (KnoxPortal) with ESMTPA id\n\t20190122162720eucas1p1a9b93996c3a9384ba141313d3de9e37a~8OHOKH6cN1324213242eucas1p1E;\n\tTue, 22 Jan 2019 16:27:20 +0000 (GMT)", "from eusmgms2.samsung.com (unknown [182.198.249.180]) by\n\teusmtrp1.samsung.com (KnoxPortal) with ESMTP id\n\t20190122162720eusmtrp100cc6734adf5ab5f2fab613bce59f696~8OHN7_hRu0172601726eusmtrp1T;\n\tTue, 22 Jan 2019 16:27:20 +0000 (GMT)", "from eusmtip2.samsung.com ( [203.254.199.222]) by\n\teusmgms2.samsung.com (EUCPMTA) with SMTP id 32.66.04128.864474C5;\n\tTue, 22 Jan 2019 16:27:20 +0000 (GMT)", "from imaximets.rnd.samsung.ru (unknown [106.109.129.180]) by\n\teusmtip2.samsung.com (KnoxPortal) with ESMTPA id\n\t20190122162719eusmtip2aa329e20e4d956bb3a25b8e530f489b9~8OHNKsnv72152221522eusmtip2w;\n\tTue, 22 Jan 2019 16:27:19 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com\n\t20190122162722euoutp02feaddf9f30afcb362600d2dcee2d5e09~8OHPe-Ei_2788627886euoutp02P", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n\ts=mail20170921; t=1548174442;\n\tbh=q6DEmYJzTGC6NChfoqxDcKPKDC/1rB3mluicyZVD2E0=;\n\th=From:To:Cc:Subject:Date:References:From;\n\tb=B6tXLipHUqB0aekhLyCQRKFBsV7J6bBeTTgh64OZhu9RDZSMMYII+VLr3JY6luINV\n\taBxSoWtbdlL/YREzyJlusBr52Rpoo0CnT7F+MdfL3fmK5NBM+EhtlPdwj2Ni9asaB/\n\txTLc39KEv2BzeDHactwRDcvLHND03q1PIfsS6414=", "X-AuditID": "cbfec7f4-84fff700000010c6-be-5c47446996a1", "From": "Ilya Maximets <i.maximets@samsung.com>", "To": "dev@dpdk.org, Anatoly Burakov <anatoly.burakov@intel.com>", "Cc": "Thomas Monjalon <thomas@monjalon.net>, Ilya Maximets\n\t<i.maximets@samsung.com>, stable@dpdk.org", "Date": "Tue, 22 Jan 2019 19:27:14 +0300", "Message-Id": "<20190122162714.9144-1-i.maximets@samsung.com>", "X-Mailer": "git-send-email 2.17.1", "X-Brightmail-Tracker": [ "H4sIAAAAAAAAA+NgFrrHIsWRmVeSWpSXmKPExsWy7djPc7qZLu4xBtPPyVg8ureY2eLdp+1M\n\tFlfaf7Jb/Ov4w27x6cEJFgdWj18LlrJ6LN7zksnj2M1p7B59W1YxBrBEcdmkpOZklqUW6dsl\n\tcGUs6L3OVLCds2LVvz7mBsab7F2MnBwSAiYSx7ZMZ+xi5OIQEljBKPHy1T5WCOcLo8SW0+3M\n\tEM5nRonGqS0sXYwcYC3zHuhBxJczSrx+cpAdwvnBKHHl2S5mkLlsAjoSp1YfYQSxRQRsJf7e\n\t2A+2j1kgReLvpVcsILawgL3ExicvwOpZBFQlXi+4yARi8wpYSWyatpEV4j55idUbDoBdISFw\n\tgE2ivXcuE0TCRWLvxp9QTwhLvDq+BcqWkTg9uYcFwq6XuN/ykhGiuYNRYvqhf1DN9hJbXp9j\n\tB3mHWUBTYv0ufYjPHCXuTuODMPkkbrwVhDiZT2LStunMEGFeiY42IYgZKhK/Dy5nhrClJG6+\n\t+8wOUeIhcWxtAEhYSCBWYkLrGpYJjHKzEDYtYGRcxSieWlqcm55abJSXWq5XnJhbXJqXrpec\n\tn7uJERjrp/8d/7KDcdefpEOMAhyMSjy8P8zcY4RYE8uKK3MPMUpwMCuJ8LpedIsR4k1JrKxK\n\tLcqPLyrNSS0+xCjNwaIkzlvN8CBaSCA9sSQ1OzW1ILUIJsvEwSnVwNjZUn3rULWpUraM3mfj\n\tPywcnGtY3izLrN9RfMs6yb3fmu88l33/ii0e3b3rJzdZsO7vmyrUynHl5vf2+HDJI+5BKqnc\n\taucyzBQq3lR2x4hel8ne2PEqvSDZ4fYra92uqx+afm2uOCtjVMgTxzM/iDGM03ve/SWX6jOd\n\tZzS6sk826Vy7IKNRiaU4I9FQi7moOBEApAa8gvECAAA=", "H4sIAAAAAAAAA+NgFtrKLMWRmVeSWpSXmKPExsVy+t/xe7oZLu4xBjdeylg8ureY2eLdp+1M\n\tFlfaf7Jb/Ov4w27x6cEJFgdWj18LlrJ6LN7zksnj2M1p7B59W1YxBrBE6dkU5ZeWpCpk5BeX\n\t2CpFG1oY6RlaWugZmVjqGRqbx1oZmSrp29mkpOZklqUW6dsl6GUs6L3OVLCds2LVvz7mBsab\n\t7F2MHBwSAiYS8x7odTFycQgJLGWU6O3cztLFyAkUl5L48esCK4QtLPHnWhcbRNE3RomfC+eC\n\tFbEJ6EicWn2EEcQWEbCXuPyzmw1kKLNAmkTPn1yQsDBQeOOTF8wgNouAqsTrBReZQGxeASuJ\n\tTdM2Qs2Xl1i94QDzBEaeBYwMqxhFUkuLc9Nzi430ihNzi0vz0vWS83M3MQKDbNuxn1t2MHa9\n\tCz7EKMDBqMTD+8PMPUaINbGsuDL3EKMEB7OSCK/rRbcYId6UxMqq1KL8+KLSnNTiQ4ymQMsn\n\tMkuJJucDIyCvJN7Q1NDcwtLQ3Njc2MxCSZz3vEFllJBAemJJanZqakFqEUwfEwenVANj741q\n\tJss6l/iIQKv1AU5rXNXFjv+T+D279Krv3LmMQYUneNV+93bOfeAWmGszf8pKnV++k5acSBDY\n\tlperale/pH6yyoep/6a/XBj9KVhL7t+Byw//tsn+bHUMfvBm6zc7Tg2RJb3pZx4Kh71/sXLv\n\tv31bS3Z1Hi2z3j1tp4NqRtsSXy+P/7oZSizFGYmGWsxFxYkAWCNHIEgCAAA=" ], "X-CMS-MailID": "20190122162720eucas1p1a9b93996c3a9384ba141313d3de9e37a", "X-Msg-Generator": "CA", "Content-Type": "text/plain; charset=\"utf-8\"", "X-RootMTR": "20190122162720eucas1p1a9b93996c3a9384ba141313d3de9e37a", "X-EPHeader": "CA", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20190122162720eucas1p1a9b93996c3a9384ba141313d3de9e37a", "References": "<CGME20190122162720eucas1p1a9b93996c3a9384ba141313d3de9e37a@eucas1p1.samsung.com>", "Subject": "[dpdk-dev] [PATCH] eal: fix parsing zero socket memory and limits", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Modern memory mode allowes to not reserve any memory by the\n'--socket-mem' option. i.e. it could be possible to specify\nzero preallocated memory like '--socket-mem 0'.\nAlso, it should be possible to configure unlimited memory\nallocations by '--socket-limit 0'.\n\nBoth cases are impossible now and blocks starting the DPDK\napplication:\n\n ./dpdk-app --socket-limit 0 <...>\n EAL: invalid parameters for --socket-limit\n EAL: Invalid 'command line' arguments.\n Unable to initialize DPDK: Invalid argument\n\nFixes: 6b42f75632f0 (\"eal: enable non-legacy memory mode\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ilya Maximets <i.maximets@samsung.com>\n---\n lib/librte_eal/linuxapp/eal/eal.c | 4 ----\n 1 file changed, 4 deletions(-)", "diff": "diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c\nindex a386829f3..13f401684 100644\n--- a/lib/librte_eal/linuxapp/eal/eal.c\n+++ b/lib/librte_eal/linuxapp/eal/eal.c\n@@ -582,10 +582,6 @@ eal_parse_socket_arg(char *strval, volatile uint64_t *socket_arg)\n \t\tsocket_arg[i] = val;\n \t}\n \n-\t/* check if we have a positive amount of total memory */\n-\tif (total_mem == 0)\n-\t\treturn -1;\n-\n \treturn 0;\n }\n \n", "prefixes": [] }