Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/49949/?format=api
{ "id": 49949, "url": "http://patches.dpdk.org/api/patches/49949/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190118111434.45392-1-ferruh.yigit@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190118111434.45392-1-ferruh.yigit@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190118111434.45392-1-ferruh.yigit@intel.com", "date": "2019-01-18T11:14:33", "name": "[v3] raw/ifpga: fix memory leak", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "81b2c4af49ed5640cbaf6e7f297a272f8a47b91d", "submitter": { "id": 324, "url": "http://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190118111434.45392-1-ferruh.yigit@intel.com/mbox/", "series": [ { "id": 3262, "url": "http://patches.dpdk.org/api/series/3262/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3262", "date": "2019-01-18T11:14:33", "name": "[v3] raw/ifpga: fix memory leak", "version": 3, "mbox": "http://patches.dpdk.org/series/3262/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/49949/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/49949/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id F12D4288C;\n\tFri, 18 Jan 2019 12:14:39 +0100 (CET)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 68EF1271;\n\tFri, 18 Jan 2019 12:14:38 +0100 (CET)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t18 Jan 2019 03:14:37 -0800", "from silpixa00399752.ir.intel.com (HELO\n\tsilpixa00399752.ger.corp.intel.com) ([10.237.222.212])\n\tby orsmga005.jf.intel.com with ESMTP; 18 Jan 2019 03:14:35 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.56,491,1539673200\"; d=\"scan'208\";a=\"292569094\"", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "To": "dev@dpdk.org, Rosen Xu <rosen.xu@intel.com>,\n\tTianfei zhang <tianfei.zhang@intel.com>", "Cc": "Andy Pei <andy.pei@intel.com>,\n\tstable@dpdk.org", "Date": "Fri, 18 Jan 2019 11:14:33 +0000", "Message-Id": "<20190118111434.45392-1-ferruh.yigit@intel.com>", "X-Mailer": "git-send-email 2.17.2", "In-Reply-To": "<1547795784-340613-1-git-send-email-andy.pei@intel.com>", "References": "<1547795784-340613-1-git-send-email-andy.pei@intel.com>", "Subject": "[dpdk-dev] [PATCH v3] raw/ifpga: fix memory leak", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Andy Pei <andy.pei@intel.com>\n\nWhen ifpga_rawdev_create() allocate memory for a new rawdev,\nthe original code allocate redundant memory for adapter,\nwhich is a member of the rawdev. What is actually necessary is\nthe adapter to be initialized, not memory allocated.\n\nFixes: ef1e8ede3da5 (\"raw/ifpga: add Intel FPGA bus rawdev driver\")\nCc: stable@dpdk.org\n\nSigned-off-by: Andy Pei <andy.pei@intel.com>\nAcked-by: Tianfei zhang <tianfei.zhang@intel.com>\nAcked-by: Rosen Xu <rosen.xu@intel.com>\n---\nCc: rosen.xu@intel.com\n---\n drivers/raw/ifpga_rawdev/base/opae_hw_api.c | 14 +++++++-------\n drivers/raw/ifpga_rawdev/base/opae_hw_api.h | 3 ++-\n drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 12 ++++--------\n 3 files changed, 13 insertions(+), 16 deletions(-)", "diff": "diff --git a/drivers/raw/ifpga_rawdev/base/opae_hw_api.c b/drivers/raw/ifpga_rawdev/base/opae_hw_api.c\nindex a533dfea8..1541b6798 100644\n--- a/drivers/raw/ifpga_rawdev/base/opae_hw_api.c\n+++ b/drivers/raw/ifpga_rawdev/base/opae_hw_api.c\n@@ -303,25 +303,25 @@ static struct opae_adapter_ops *match_ops(struct opae_adapter *adapter)\n }\n \n /**\n- * opae_adapter_data_alloc - alloc opae_adapter_data data structure\n+ * opae_adapter_init - init opae_adapter data structure\n+ * @adapter: pointer of opae_adapter data structure\n * @name: adapter name.\n * @data: private data of this adapter.\n *\n- * Return: opae_adapter on success, otherwise NULL.\n+ * Return: 0 on success.\n */\n-struct opae_adapter *opae_adapter_alloc(const char *name, void *data)\n+int opae_adapter_init(struct opae_adapter *adapter,\n+\t\tconst char *name, void *data)\n {\n-\tstruct opae_adapter *adapter = opae_zmalloc(sizeof(*adapter));\n-\n \tif (!adapter)\n-\t\treturn NULL;\n+\t\treturn -ENOMEM;\n \n \tTAILQ_INIT(&adapter->acc_list);\n \tadapter->data = data;\n \tadapter->name = name;\n \tadapter->ops = match_ops(adapter);\n \n-\treturn adapter;\n+\treturn 0;\n }\n \n /**\ndiff --git a/drivers/raw/ifpga_rawdev/base/opae_hw_api.h b/drivers/raw/ifpga_rawdev/base/opae_hw_api.h\nindex 4bbc9df5c..332e0f3f6 100644\n--- a/drivers/raw/ifpga_rawdev/base/opae_hw_api.h\n+++ b/drivers/raw/ifpga_rawdev/base/opae_hw_api.h\n@@ -225,7 +225,8 @@ struct opae_adapter {\n void *opae_adapter_data_alloc(enum opae_adapter_type type);\n #define opae_adapter_data_free(data) opae_free(data)\n \n-struct opae_adapter *opae_adapter_alloc(const char *name, void *data);\n+int opae_adapter_init(struct opae_adapter *adapter,\n+\t\tconst char *name, void *data);\n #define opae_adapter_free(adapter) opae_free(adapter)\n \n int opae_adapter_enumerate(struct opae_adapter *adapter);\ndiff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c\nindex 32e318fc3..da772d026 100644\n--- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c\n+++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c\n@@ -409,9 +409,10 @@ ifpga_rawdev_create(struct rte_pci_device *pci_dev,\n \tdata->device_id = pci_dev->id.device_id;\n \tdata->vendor_id = pci_dev->id.vendor_id;\n \n+\tadapter = rawdev->dev_private;\n \t/* create a opae_adapter based on above device data */\n-\tadapter = opae_adapter_alloc(pci_dev->device.name, data);\n-\tif (!adapter) {\n+\tret = opae_adapter_init(adapter, pci_dev->device.name, data);\n+\tif (ret) {\n \t\tret = -ENOMEM;\n \t\tgoto free_adapter_data;\n \t}\n@@ -420,12 +421,10 @@ ifpga_rawdev_create(struct rte_pci_device *pci_dev,\n \trawdev->device = &pci_dev->device;\n \trawdev->driver_name = pci_dev->device.driver->name;\n \n-\trawdev->dev_private = adapter;\n-\n \t/* must enumerate the adapter before use it */\n \tret = opae_adapter_enumerate(adapter);\n \tif (ret)\n-\t\tgoto free_adapter;\n+\t\tgoto free_adapter_data;\n \n \t/* get opae_manager to rawdev */\n \tmgr = opae_adapter_get_mgr(adapter);\n@@ -436,9 +435,6 @@ ifpga_rawdev_create(struct rte_pci_device *pci_dev,\n \n \treturn ret;\n \n-free_adapter:\n-\tif (adapter)\n-\t\topae_adapter_free(adapter);\n free_adapter_data:\n \tif (data)\n \t\topae_adapter_data_free(data);\n", "prefixes": [ "v3" ] }