Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 49805,
    "url": "http://patches.dpdk.org/api/patches/49805/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190114211622.6900-2-yskoh@mellanox.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190114211622.6900-2-yskoh@mellanox.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190114211622.6900-2-yskoh@mellanox.com",
    "date": "2019-01-14T21:16:22",
    "name": "[v5,2/2] net/mlx5: fix instruction hotspot on replenishing Rx buffer",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "2785b81813dc3b238297719eb1b52aeaa5ade00b",
    "submitter": {
        "id": 636,
        "url": "http://patches.dpdk.org/api/people/636/?format=api",
        "name": "Yongseok Koh",
        "email": "yskoh@mellanox.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190114211622.6900-2-yskoh@mellanox.com/mbox/",
    "series": [
        {
            "id": 3175,
            "url": "http://patches.dpdk.org/api/series/3175/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3175",
            "date": "2019-01-14T21:16:22",
            "name": null,
            "version": 5,
            "mbox": "http://patches.dpdk.org/series/3175/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/49805/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/49805/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A91DE1B1D6;\n\tMon, 14 Jan 2019 22:16:33 +0100 (CET)",
            "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby dpdk.org (Postfix) with ESMTP id B50F11B160\n\tfor <dev@dpdk.org>; Mon, 14 Jan 2019 22:16:30 +0100 (CET)",
            "from Internal Mail-Server by MTLPINE1 (envelope-from\n\tyskoh@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 14 Jan 2019 23:16:29 +0200",
            "from scfae-sc-2.mti.labs.mlnx (scfae-sc-2.mti.labs.mlnx\n\t[10.101.0.96])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x0ELGOtu027251;\n\tMon, 14 Jan 2019 23:16:27 +0200"
        ],
        "From": "Yongseok Koh <yskoh@mellanox.com>",
        "To": "olivier.matz@6wind.com, shahafs@mellanox.com",
        "Cc": "dev@dpdk.org, arybchenko@solarflare.com, roszenrami@gmail.com,\n\tdavid.marchand@redhat.com, stable@dpdk.org",
        "Date": "Mon, 14 Jan 2019 13:16:22 -0800",
        "Message-Id": "<20190114211622.6900-2-yskoh@mellanox.com>",
        "X-Mailer": "git-send-email 2.11.0",
        "In-Reply-To": "<20190114211622.6900-1-yskoh@mellanox.com>",
        "References": "<20190109085426.39965-1-yskoh@mellanox.com>\n\t<20190114211622.6900-1-yskoh@mellanox.com>",
        "Subject": "[dpdk-dev] [PATCH v5 2/2] net/mlx5: fix instruction hotspot on\n\treplenishing Rx buffer",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "On replenishing Rx buffers for vectorized Rx, mbuf->buf_addr isn't needed\nto be accessed as it is static and easily calculated from the mbuf address.\nAccessing the mbuf content causes unnecessary load stall and it is worsened\non ARM.\n\nFixes: 545b884b1da3 (\"net/mlx5: fix buffer address posting in SSE Rx\")\nCc: stable@dpdk.org\n\nSigned-off-by: Yongseok Koh <yskoh@mellanox.com>\nAcked-by: Shahaf Shuler <shahafs@mellanox.com>\n---\n\nv5:\n* no change\n\nv4:\n* no change\n\nv3:\n* rte_mbuf_buf_addr_default() -> rte_mbuf_buf_addr()\n\nv2:\n* use the newly introduced API - rte_mbuf_buf_addr_default()\n* fix error in assert\n\n drivers/net/mlx5/mlx5_rxtx_vec.h | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/mlx5/mlx5_rxtx_vec.h b/drivers/net/mlx5/mlx5_rxtx_vec.h\nindex fda7004e2d..5df8e291e6 100644\n--- a/drivers/net/mlx5/mlx5_rxtx_vec.h\n+++ b/drivers/net/mlx5/mlx5_rxtx_vec.h\n@@ -102,7 +102,10 @@ mlx5_rx_replenish_bulk_mbuf(struct mlx5_rxq_data *rxq, uint16_t n)\n \t\treturn;\n \t}\n \tfor (i = 0; i < n; ++i) {\n-\t\twq[i].addr = rte_cpu_to_be_64((uintptr_t)elts[i]->buf_addr +\n+\t\tvoid *buf_addr = rte_mbuf_buf_addr(elts[i], rxq->mp);\n+\n+\t\tassert(buf_addr == elts[i]->buf_addr);\n+\t\twq[i].addr = rte_cpu_to_be_64((uintptr_t)buf_addr +\n \t\t\t\t\t      RTE_PKTMBUF_HEADROOM);\n \t\t/* If there's only one MR, no need to replace LKey in WQE. */\n \t\tif (unlikely(mlx5_mr_btree_len(&rxq->mr_ctrl.cache_bh) > 1))\n",
    "prefixes": [
        "v5",
        "2/2"
    ]
}