Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 49788,
    "url": "http://patches.dpdk.org/api/patches/49788/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190114100022.14867-2-yskoh@mellanox.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190114100022.14867-2-yskoh@mellanox.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190114100022.14867-2-yskoh@mellanox.com",
    "date": "2019-01-14T10:00:22",
    "name": "[2/2] app/testpmd: fix missing prefetch in macswap mode",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "0d521ba2c709d9683f3444b994e444cd684dbb58",
    "submitter": {
        "id": 636,
        "url": "http://patches.dpdk.org/api/people/636/?format=api",
        "name": "Yongseok Koh",
        "email": "yskoh@mellanox.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190114100022.14867-2-yskoh@mellanox.com/mbox/",
    "series": [
        {
            "id": 3160,
            "url": "http://patches.dpdk.org/api/series/3160/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3160",
            "date": "2019-01-14T10:00:22",
            "name": "[1/2] app/testpmd: fix wrong pointer reference in macswap",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/3160/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/49788/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/49788/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id ECC971B1EE;\n\tMon, 14 Jan 2019 11:00:45 +0100 (CET)",
            "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby dpdk.org (Postfix) with ESMTP id EB7D41B1F6\n\tfor <dev@dpdk.org>; Mon, 14 Jan 2019 11:00:43 +0100 (CET)",
            "from Internal Mail-Server by MTLPINE1 (envelope-from\n\tyskoh@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 14 Jan 2019 12:00:42 +0200",
            "from scfae-sc-2.mti.labs.mlnx (scfae-sc-2.mti.labs.mlnx\n\t[10.101.0.96])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x0EA0brv016885;\n\tMon, 14 Jan 2019 12:00:40 +0200"
        ],
        "From": "Yongseok Koh <yskoh@mellanox.com>",
        "To": "wenzhuo.lu@intel.com, jingjing.wu@intel.com, bernard.iremonger@intel.com",
        "Cc": "dev@dpdk.org, qi.z.zhang@intel.com, stable@dpdk.org",
        "Date": "Mon, 14 Jan 2019 02:00:22 -0800",
        "Message-Id": "<20190114100022.14867-2-yskoh@mellanox.com>",
        "X-Mailer": "git-send-email 2.11.0",
        "In-Reply-To": "<20190114100022.14867-1-yskoh@mellanox.com>",
        "References": "<20190114100022.14867-1-yskoh@mellanox.com>",
        "Subject": "[dpdk-dev] [PATCH 2/2] app/testpmd: fix missing prefetch in macswap\n\tmode",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Prefetching packet was missing when do_macswap() was optimized.\n\nFixes: 62b52877adbe (\"app/testpmd: batch MAC swap for performance on x86\")\nCc: qi.z.zhang@intel.com\nCc: stable@dpdk.org\n\nSigned-off-by: Yongseok Koh <yskoh@mellanox.com>\n---\n app/test-pmd/macswap_sse.h | 7 +++++++\n 1 file changed, 7 insertions(+)",
    "diff": "diff --git a/app/test-pmd/macswap_sse.h b/app/test-pmd/macswap_sse.h\nindex 662fe79cf9..2b6e7324da 100644\n--- a/app/test-pmd/macswap_sse.h\n+++ b/app/test-pmd/macswap_sse.h\n@@ -35,6 +35,13 @@ do_macswap(struct rte_mbuf *pkts[], uint16_t nb,\n \tr = nb;\n \n \twhile (r >= 4) {\n+\t\tif (r >= 8) {\n+\t\t\trte_prefetch0(rte_pktmbuf_mtod(pkts[i + 4], void *));\n+\t\t\trte_prefetch0(rte_pktmbuf_mtod(pkts[i + 5], void *));\n+\t\t\trte_prefetch0(rte_pktmbuf_mtod(pkts[i + 6], void *));\n+\t\t\trte_prefetch0(rte_pktmbuf_mtod(pkts[i + 7], void *));\n+\t\t}\n+\n \t\tmb[0] = pkts[i++];\n \t\teth_hdr[0] = rte_pktmbuf_mtod(mb[0], struct ether_hdr *);\n \t\taddr0 = _mm_loadu_si128((__m128i *)eth_hdr[0]);\n",
    "prefixes": [
        "2/2"
    ]
}