Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/49717/?format=api
{ "id": 49717, "url": "http://patches.dpdk.org/api/patches/49717/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190111122305.7133-19-shreyansh.jain@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190111122305.7133-19-shreyansh.jain@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190111122305.7133-19-shreyansh.jain@nxp.com", "date": "2019-01-11T12:25:05", "name": "[v3,18/19] net/dpaa2: change reference to private device", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "79e074cd2fee1d6ab46fabf4036001e45d8f5cff", "submitter": { "id": 497, "url": "http://patches.dpdk.org/api/people/497/?format=api", "name": "Shreyansh Jain", "email": "shreyansh.jain@nxp.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190111122305.7133-19-shreyansh.jain@nxp.com/mbox/", "series": [ { "id": 3123, "url": "http://patches.dpdk.org/api/series/3123/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3123", "date": "2019-01-11T12:24:01", "name": "NXP DPAA2 fixes and enhancements", "version": 3, "mbox": "http://patches.dpdk.org/series/3123/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/49717/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/49717/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EC3E71BB83;\n\tFri, 11 Jan 2019 13:25:08 +0100 (CET)", "from EUR03-VE1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr50074.outbound.protection.outlook.com [40.107.5.74])\n\tby dpdk.org (Postfix) with ESMTP id CE6CF1BC8A\n\tfor <dev@dpdk.org>; Fri, 11 Jan 2019 13:25:06 +0100 (CET)", "from VI1PR04MB4688.eurprd04.prod.outlook.com (20.177.56.80) by\n\tVI1PR04MB5455.eurprd04.prod.outlook.com (20.178.121.149) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1516.14; Fri, 11 Jan 2019 12:25:05 +0000", "from VI1PR04MB4688.eurprd04.prod.outlook.com\n\t([fe80::b1eb:7e7e:7b90:7b4]) by\n\tVI1PR04MB4688.eurprd04.prod.outlook.com\n\t([fe80::b1eb:7e7e:7b90:7b4%4]) with mapi id 15.20.1516.016;\n\tFri, 11 Jan 2019 12:25:05 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=uSwBuXjk3na+n0SgLfzsARRrOsYo9c63bFTscD+wjCY=;\n\tb=aEwXCdsljBY98fr2Rp8r2IOF7hpV7BLa2VD9ZK8QBVX8RC3DMXEIsYUhzthyXKJxj1OvXnpwjLZMli+6QGWbyvkAbFKym+KFYBpDrMtsZvxQu3ULvADeLYjDFFI5ZqRKEdPGl0ekcXP7ASAc2DWLJwpbZWfKb9nFGR3ZSl0NA9w=", "From": "Shreyansh Jain <shreyansh.jain@nxp.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>", "CC": "\"ferruh.yigit@intel.com\" <ferruh.yigit@intel.com>, Shreyansh Jain\n\t<shreyansh.jain@nxp.com>", "Thread-Topic": "[PATCH v3 18/19] net/dpaa2: change reference to private device", "Thread-Index": "AQHUqaiuNCGNMFGa3U2jI4IIPac5Eg==", "Date": "Fri, 11 Jan 2019 12:25:05 +0000", "Message-ID": "<20190111122305.7133-19-shreyansh.jain@nxp.com>", "References": "<20190111115712.6482-1-shreyansh.jain@nxp.com>\n\t<20190111122305.7133-1-shreyansh.jain@nxp.com>", "In-Reply-To": "<20190111122305.7133-1-shreyansh.jain@nxp.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[14.143.254.130]", "x-mailer": "git-send-email 2.17.1", "x-clientproxiedby": "TY2PR01CA0017.jpnprd01.prod.outlook.com\n\t(2603:1096:404:a::29) To VI1PR04MB4688.eurprd04.prod.outlook.com\n\t(2603:10a6:803:71::16)", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=shreyansh.jain@nxp.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-ms-publictraffictype": "Email", "x-microsoft-exchange-diagnostics": "1; VI1PR04MB5455;\n\t6:8RVCBHbQZWu+roLem5d3ua+b25Lek6WJUl1EZ2ybexgngcJ4WnpFQ8jYRPQ05xDIrdeG1ecd/ZopABW6Jm6OAlq63QWVOkhjSTt8liYBVln78LM8fTgijdEriQeODX4rd1L0XEtAdVhsCZH1LLIcx/O9bPSpHpoaRFbMEjGUqdb5wWZm5zdMm5bgw4cu6sNaVgt4b8Dq78mttSuUM/Eyie1fjPryWMg70stg5ODtwJ5N0PJsr0pnW6zRki9PNd2BPWhgTZVvL3n2cmmIC1DXTPh4G/qWktQkfNpkta+YVWSWa0JSC5qLTyF6dvXeZqBXsaTfiGQ8c30uGK7LS5nfXAPITUnYUmuQxHgyGWoLhDQyoimEm5eHVxMzQoSfnt+XqXiIuizIKSZuITl7JD/y++sqqE6a+1Rj5LJsiv2sOEmKYYovgV1qQ99wMgzK3SLIhmagxk9IfBaauKRqtcVKaA==;\n\t5:gP1q7kUJGhWmlzfqB3iq1eXyalmPlUDZG19Cg0UEMk8RsFvvpvDVrWdksf/cs1YfObrjNP4ouP2+/Nm5Zw8NoXvbOY1cK2QlUCuPmsn2XfRpiZa3eG2I+XYdNQ8upblmYhpOin4Mpa+Xd8Ll+8tKr9Cx2CF8N5/pV6OUjZXNMzafivKsRZLQq1nGVDHnri6uCLlOmpKb1EyMQnuNW/uAAQ==;\n\t7:VGroBv8S2bp5OQAagMabdZlr69RNQkCFb85a4jM2AIRAz0rg2FahzrI4/3lEnM0Ek1U0+lHrnsMS6L8JDO3aEija/2KUQO9tBqFrwz9a8HwEZ4Zto2kF2Fz6qbmot3RBZ7k7j+ZOZF2wt5HlKwz0Kg==", "x-ms-office365-filtering-correlation-id": "db4443c7-5cdf-45c3-48bb-08d677bfd125", "x-ms-office365-filtering-ht": "Tenant", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(4618075)(2017052603328)(7153060)(7193020);\n\tSRVR:VI1PR04MB5455; ", "x-ms-traffictypediagnostic": "VI1PR04MB5455:", "x-microsoft-antispam-prvs": "<VI1PR04MB5455CACB48F87DE942EBFF4490850@VI1PR04MB5455.eurprd04.prod.outlook.com>", "x-forefront-prvs": "09144DB0F7", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(136003)(366004)(376002)(39860400002)(396003)(346002)(189003)(199004)(66066001)(186003)(86362001)(71200400001)(2351001)(71190400001)(55236004)(386003)(36756003)(6506007)(26005)(99286004)(105586002)(6116002)(14444005)(106356001)(102836004)(2906002)(54906003)(5660300001)(3846002)(256004)(8936002)(97736004)(78486014)(50226002)(2501003)(6486002)(305945005)(6436002)(14454004)(7736002)(8676002)(316002)(1730700003)(81166006)(81156014)(5640700003)(4326008)(2616005)(446003)(6916009)(478600001)(1076003)(52116002)(6512007)(44832011)(486006)(76176011)(53936002)(11346002)(68736007)(476003)(25786009);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB5455;\n\tH:VI1PR04MB4688.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; MX:1; A:1; ", "received-spf": "None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "9RhjrDmlEtUQU6mLrC0ybrIvbZv3pSAeWtcoUbX8eSPdQvZf1zHHgZoJEmIeVR7mYbgEMSJ0yZCsqNEZ9WW8B/hZu69//yIhzOnU4NJPEGc36yaRKCrhBGcuVm5VkF6TQku447kHeXZ5PRkxUUxQj6vrNB9qDzSlEsTC81BuWTeGOy4SE/MPcF4+iJr771yqHNZVBTqGn0zb/hy5HVoNiaNcu010YGKfj/XIPF7ltq5zJJoguwaZAPVdxjjIdB4qBLhiyktXKpRJb2u+Tgq/jgg23QAu3GNc8+LZh2znEqbe7h2pYYoth6prZMUcAHe3HXjrAz2KgeB1yNrGNU6/gaIhQimfwFr1vJnIInJjlm3moS7yAeTXdLfbUUdmlu3027gTVnowS9kQw4tcEmAUbZghCr965Gsy0HIqDkeR3gY=", "spamdiagnosticoutput": "1:99", "spamdiagnosticmetadata": "NSPM", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "db4443c7-5cdf-45c3-48bb-08d677bfd125", "X-MS-Exchange-CrossTenant-originalarrivaltime": "11 Jan 2019 12:25:02.7188\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "VI1PR04MB5455", "Subject": "[dpdk-dev] [PATCH v3 18/19] net/dpaa2: change reference to private\n\tdevice", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The I/O threads for DPAA2 take their reference for bpool ID, the\nport ID and other info like qdid, from the rte_eth_dev. Further,\nto get this data during I/O operation, a reference of the RTE\ndevice is kept in the queue structure (dpaa2_queue).\n\nIn case of secondary processes, rte_eth_dev is not same as the\nprimary process. Thus, the reference goes invalid.\n\nThis patch changes the implementation to use the dev_private\nrather than the rte_eth_dev as that is shared area across\nall the processes.\n\nSigned-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>\n---\n drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 5 ++++-\n drivers/net/dpaa2/dpaa2_ethdev.c | 4 ++--\n drivers/net/dpaa2/dpaa2_rxtx.c | 18 ++++++++++--------\n 3 files changed, 16 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h b/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h\nindex 20c606dbe..626fcbbca 100644\n--- a/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h\n+++ b/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h\n@@ -127,7 +127,10 @@ typedef void (dpaa2_queue_cb_dqrr_t)(struct qbman_swp *swp,\n \n struct dpaa2_queue {\n \tstruct rte_mempool *mb_pool; /**< mbuf pool to populate RX ring. */\n-\tvoid *dev;\n+\tunion {\n+\t\tstruct rte_eth_dev_data *eth_data;\n+\t\tvoid *dev;\n+\t};\n \tint32_t eventfd;\t/*!< Event Fd of this queue */\n \tuint32_t fqid;\t\t/*!< Unique ID of this queue */\n \tuint8_t tc_index;\t/*!< traffic class identifier */\ndiff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c\nindex 3a20158da..2b90f4021 100644\n--- a/drivers/net/dpaa2/dpaa2_ethdev.c\n+++ b/drivers/net/dpaa2/dpaa2_ethdev.c\n@@ -244,7 +244,7 @@ dpaa2_alloc_rx_tx_queues(struct rte_eth_dev *dev)\n \t}\n \n \tfor (i = 0; i < priv->nb_rx_queues; i++) {\n-\t\tmc_q->dev = dev;\n+\t\tmc_q->eth_data = dev->data;\n \t\tpriv->rx_vq[i] = mc_q++;\n \t\tdpaa2_q = (struct dpaa2_queue *)priv->rx_vq[i];\n \t\tdpaa2_q->q_storage = rte_malloc(\"dq_storage\",\n@@ -260,7 +260,7 @@ dpaa2_alloc_rx_tx_queues(struct rte_eth_dev *dev)\n \t}\n \n \tfor (i = 0; i < priv->nb_tx_queues; i++) {\n-\t\tmc_q->dev = dev;\n+\t\tmc_q->eth_data = dev->data;\n \t\tmc_q->flow_id = 0xffff;\n \t\tpriv->tx_vq[i] = mc_q++;\n \t\tdpaa2_q = (struct dpaa2_queue *)priv->tx_vq[i];\ndiff --git a/drivers/net/dpaa2/dpaa2_rxtx.c b/drivers/net/dpaa2/dpaa2_rxtx.c\nindex 6e2e8abd7..2d4b9ef14 100644\n--- a/drivers/net/dpaa2/dpaa2_rxtx.c\n+++ b/drivers/net/dpaa2/dpaa2_rxtx.c\n@@ -509,7 +509,7 @@ dpaa2_dev_prefetch_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \tconst struct qbman_fd *fd, *next_fd;\n \tstruct qbman_pull_desc pulldesc;\n \tstruct queue_storage_info_t *q_storage = dpaa2_q->q_storage;\n-\tstruct rte_eth_dev *dev = dpaa2_q->dev;\n+\tstruct rte_eth_dev_data *eth_data = dpaa2_q->eth_data;\n \n \tif (unlikely(!DPAA2_PER_LCORE_ETHRX_DPIO)) {\n \t\tret = dpaa2_affine_qbman_ethrx_swp();\n@@ -613,9 +613,10 @@ dpaa2_dev_prefetch_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \t\t\tbufs[num_rx] = eth_sg_fd_to_mbuf(fd);\n \t\telse\n \t\t\tbufs[num_rx] = eth_fd_to_mbuf(fd);\n-\t\tbufs[num_rx]->port = dev->data->port_id;\n+\t\tbufs[num_rx]->port = eth_data->port_id;\n \n-\t\tif (dev->data->dev_conf.rxmode.offloads & DEV_RX_OFFLOAD_VLAN_STRIP)\n+\t\tif (eth_data->dev_conf.rxmode.offloads &\n+\t\t\t\tDEV_RX_OFFLOAD_VLAN_STRIP)\n \t\t\trte_vlan_strip(bufs[num_rx]);\n \n \t\tdq_storage++;\n@@ -716,8 +717,8 @@ dpaa2_dev_tx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \tstruct qbman_swp *swp;\n \tuint16_t num_tx = 0;\n \tuint16_t bpid;\n-\tstruct rte_eth_dev *dev = dpaa2_q->dev;\n-\tstruct dpaa2_dev_priv *priv = dev->data->dev_private;\n+\tstruct rte_eth_dev_data *eth_data = dpaa2_q->eth_data;\n+\tstruct dpaa2_dev_priv *priv = eth_data->dev_private;\n \tuint32_t flags[MAX_TX_RING_SLOTS] = {0};\n \n \tif (unlikely(!DPAA2_PER_LCORE_DPIO)) {\n@@ -729,7 +730,8 @@ dpaa2_dev_tx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \t}\n \tswp = DPAA2_PER_LCORE_PORTAL;\n \n-\tDPAA2_PMD_DP_DEBUG(\"===> dev =%p, fqid =%d\\n\", dev, dpaa2_q->fqid);\n+\tDPAA2_PMD_DP_DEBUG(\"===> eth_data =%p, fqid =%d\\n\",\n+\t\t\teth_data, dpaa2_q->fqid);\n \n \t/*Prepare enqueue descriptor*/\n \tqbman_eq_desc_clear(&eqdesc);\n@@ -772,7 +774,7 @@ dpaa2_dev_tx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \t\t\t\t rte_mbuf_refcnt_read((*bufs)) == 1)) {\n \t\t\t\t\tif (unlikely(((*bufs)->ol_flags\n \t\t\t\t\t\t& PKT_TX_VLAN_PKT) ||\n-\t\t\t\t\t\t(dev->data->dev_conf.txmode.offloads\n+\t\t\t\t\t\t(eth_data->dev_conf.txmode.offloads\n \t\t\t\t\t\t& DEV_TX_OFFLOAD_VLAN_INSERT))) {\n \t\t\t\t\t\tret = rte_vlan_insert(bufs);\n \t\t\t\t\t\tif (ret)\n@@ -794,7 +796,7 @@ dpaa2_dev_tx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \t\t\t}\n \n \t\t\tif (unlikely(((*bufs)->ol_flags & PKT_TX_VLAN_PKT) ||\n-\t\t\t\t(dev->data->dev_conf.txmode.offloads\n+\t\t\t\t(eth_data->dev_conf.txmode.offloads\n \t\t\t\t& DEV_TX_OFFLOAD_VLAN_INSERT))) {\n \t\t\t\tint ret = rte_vlan_insert(bufs);\n \t\t\t\tif (ret)\n", "prefixes": [ "v3", "18/19" ] }