Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/49716/?format=api
{ "id": 49716, "url": "http://patches.dpdk.org/api/patches/49716/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190111122305.7133-18-shreyansh.jain@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190111122305.7133-18-shreyansh.jain@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190111122305.7133-18-shreyansh.jain@nxp.com", "date": "2019-01-11T12:25:02", "name": "[v3,17/19] mempool/dpaa2: support saving context of buffer pool", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8e718ca8d72732d0580641a4e524a2a1ed9d097e", "submitter": { "id": 497, "url": "http://patches.dpdk.org/api/people/497/?format=api", "name": "Shreyansh Jain", "email": "shreyansh.jain@nxp.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190111122305.7133-18-shreyansh.jain@nxp.com/mbox/", "series": [ { "id": 3123, "url": "http://patches.dpdk.org/api/series/3123/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3123", "date": "2019-01-11T12:24:01", "name": "NXP DPAA2 fixes and enhancements", "version": 3, "mbox": "http://patches.dpdk.org/series/3123/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/49716/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/49716/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8F2CF1BC84;\n\tFri, 11 Jan 2019 13:25:05 +0100 (CET)", "from EUR01-HE1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr130080.outbound.protection.outlook.com [40.107.13.80])\n\tby dpdk.org (Postfix) with ESMTP id 9026C1BC84\n\tfor <dev@dpdk.org>; Fri, 11 Jan 2019 13:25:03 +0100 (CET)", "from VI1PR04MB4688.eurprd04.prod.outlook.com (20.177.56.80) by\n\tVI1PR04MB5455.eurprd04.prod.outlook.com (20.178.121.149) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1516.14; Fri, 11 Jan 2019 12:25:02 +0000", "from VI1PR04MB4688.eurprd04.prod.outlook.com\n\t([fe80::b1eb:7e7e:7b90:7b4]) by\n\tVI1PR04MB4688.eurprd04.prod.outlook.com\n\t([fe80::b1eb:7e7e:7b90:7b4%4]) with mapi id 15.20.1516.016;\n\tFri, 11 Jan 2019 12:25:02 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=dO7nx71akAxyn2bzrLrctMYV0YIqmzSGytZ5WiAisE8=;\n\tb=bjFLIaxL8dj6ooOanioyUYtKpqva3rglCXKrvk7rmQjNxMXgwefnABp4ZRn22VK6kKa5cS8wXqHdqQFlPwaQl63iaZu/Ll/zb9ZEim8GU3DREw0lI1aDTPgK8z6w4EESjP0ve1jZxLiVcBSkqsdJKEeYYVbrEzbHO1lrnoxIFDc=", "From": "Shreyansh Jain <shreyansh.jain@nxp.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>", "CC": "\"ferruh.yigit@intel.com\" <ferruh.yigit@intel.com>, Shreyansh Jain\n\t<shreyansh.jain@nxp.com>", "Thread-Topic": "[PATCH v3 17/19] mempool/dpaa2: support saving context of\n\tbuffer pool", "Thread-Index": "AQHUqaitqhZNypfa4kGxK/ZcXONTJg==", "Date": "Fri, 11 Jan 2019 12:25:02 +0000", "Message-ID": "<20190111122305.7133-18-shreyansh.jain@nxp.com>", "References": "<20190111115712.6482-1-shreyansh.jain@nxp.com>\n\t<20190111122305.7133-1-shreyansh.jain@nxp.com>", "In-Reply-To": "<20190111122305.7133-1-shreyansh.jain@nxp.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[14.143.254.130]", "x-mailer": "git-send-email 2.17.1", "x-clientproxiedby": "TY2PR01CA0017.jpnprd01.prod.outlook.com\n\t(2603:1096:404:a::29) To VI1PR04MB4688.eurprd04.prod.outlook.com\n\t(2603:10a6:803:71::16)", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=shreyansh.jain@nxp.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-ms-publictraffictype": "Email", "x-microsoft-exchange-diagnostics": "1; VI1PR04MB5455;\n\t6:MrZUT0RjmQmp56lKzgOniQw6ZklJBEPEe+ICV2Y21sGScXzgaHmssdPcHLxTnB9SnnOg1LGB84YlHxVux4Uj758SddC7ZtcsyQ775ugngYSJEFiAUdCtKZkTanLN/loZKKArlDJ/ii3lkZfdadBp8m6tpuwXDAOhsIhd/sLTVzLS4TBg5vODj/zbeq8DCbmAznRBblbC3AH/6zTjNnyXJ+b/29D5Bz1Q1dwzjNj3gPqDn4Ti5plJWgl3MS2rkXjwWuu6q0Nu1ja4uUunTyej2yeH26TqKLZpZt8bQn9F1YgKE8G8hN5gr7Xt1AgsoLN+kx48aDFwSs4J/19WnRUTLz+/oro0naqQmOcab93dZCrf1RIJ/I6ZkhCVK0w+20hiDDHe6PXtS6eooKN9Liip/OvQ1u/2lvnWaceT7EBiY+qXktSJ1hVVl+GXY+4bmMKj/TSzn/7Lg4qJx1m0FpeiKg==;\n\t5:AraCDs/RUAtUI/ixeYadZ6Ynek0CVtcDU9vkzh/Cq61BgXHdxSsV/YEFCPtQxAd/hBe2wAvmkcmOXCfjcfdwV2sZkQgqL1uVv89Qr/5nOoVshv4ITPDdOC5sP8qeJWB0hlrHbI+TIeJHY7WaTf9T2ebw8XDPlDtsxO7xnag7SosdaykfxtSxDPTx0yoOgGvPRPuv7mfz6mPTwIkueL3wiw==;\n\t7:Bc+PlAGcKLGtGl25NGX/Z5bOXZi+8hoBOlQO5KfTcdZx2zqIfeWINbXYj+QpR25P5E9ESEd96S/vpcSndzuTxdhReOAe5KE6fECtvwg5/WLrXu1wF9iD+BuS107WDwMZrffdouWONFEt78eN6gQE5Q==", "x-ms-office365-filtering-correlation-id": "9065594d-ca59-41b1-c05e-08d677bfcf3b", "x-ms-office365-filtering-ht": "Tenant", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(4618075)(2017052603328)(7153060)(7193020);\n\tSRVR:VI1PR04MB5455; ", "x-ms-traffictypediagnostic": "VI1PR04MB5455:", "x-microsoft-antispam-prvs": "<VI1PR04MB54551B676F7544EC30470B5C90850@VI1PR04MB5455.eurprd04.prod.outlook.com>", "x-forefront-prvs": "09144DB0F7", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(136003)(366004)(376002)(39860400002)(396003)(346002)(189003)(199004)(66066001)(186003)(86362001)(71200400001)(2351001)(71190400001)(55236004)(386003)(36756003)(6506007)(26005)(99286004)(105586002)(6116002)(14444005)(106356001)(102836004)(2906002)(54906003)(5660300001)(3846002)(256004)(8936002)(97736004)(78486014)(50226002)(2501003)(6486002)(305945005)(6436002)(14454004)(7736002)(8676002)(316002)(1730700003)(81166006)(81156014)(5640700003)(4326008)(2616005)(446003)(6916009)(478600001)(1076003)(52116002)(6512007)(44832011)(486006)(76176011)(53936002)(11346002)(68736007)(476003)(25786009);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB5455;\n\tH:VI1PR04MB4688.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; MX:1; A:1; ", "received-spf": "None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "j3tPtgvLfMS9XMeCyjmALW7dlJr54/eahQ87D4slyWeKslYmsgPSQdswH279X4xrRggT7J2pYls55rI5igCu48XO8WEuyJsWv8D/ks80k2HJiRLj76v5d4hwLwN/h5hhJyYmVo/dt0AwIOA1lHnqEvW9f6QE3THe4NdRv00hHktmK7wr1EPUIbR77CYYFQkO5wk9aFj0L+dmnBGk0kjFqgxxC4luow9DAV6ur8ybX0mAWChb5RjYF1ElHwfjR29rwdPtw4uCHH0M307qN5EOgz1lV9P46AOayzjxWeHziP2bF/R/GsKiKwPjtql4C4GXPFL7JtHva1eUKzxuyeBp3+juVHt0TyZKuwDVR4Wd4V7nnM3apbvctA8m9dztEEbOduUwwwcNEbY2kRR2tk+Bx/o1WPCI65CPZ7sC6Rlk/kw=", "spamdiagnosticoutput": "1:99", "spamdiagnosticmetadata": "NSPM", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "9065594d-ca59-41b1-c05e-08d677bfcf3b", "X-MS-Exchange-CrossTenant-originalarrivaltime": "11 Jan 2019 12:24:59.5226\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "VI1PR04MB5455", "Subject": "[dpdk-dev] [PATCH v3 17/19] mempool/dpaa2: support saving context\n\tof buffer pool", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Initial design was to have the buffer pool per process where a\nglobal static array stores the bpids. But, in case of secondary\nprocesses, this would not allow the I/O threads to translate the\nbpid in Rx'd packets.\n\nThis patch moves the array to a global area (rte_malloc) and in\ncase of Rx thread not containing a valid reference to the array,\nreference is build using the handle avaialble in the dpaa2_queue.\n\nSigned-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>\n---\n drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 1 +\n drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 12 +++++++++++-\n drivers/mempool/dpaa2/dpaa2_hw_mempool.h | 2 +-\n drivers/net/dpaa2/dpaa2_ethdev.c | 1 +\n drivers/net/dpaa2/dpaa2_rxtx.c | 5 +++++\n 5 files changed, 19 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h b/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h\nindex efbeebef9..20c606dbe 100644\n--- a/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h\n+++ b/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h\n@@ -141,6 +141,7 @@ struct dpaa2_queue {\n \t};\n \tstruct rte_event ev;\n \tdpaa2_queue_cb_dqrr_t *cb;\n+\tstruct dpaa2_bp_info *bp_array;\n };\n \n struct swp_active_dqs {\ndiff --git a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c\nindex 790cded80..335eae40e 100644\n--- a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c\n+++ b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c\n@@ -32,7 +32,7 @@\n \n #include <dpaax_iova_table.h>\n \n-struct dpaa2_bp_info rte_dpaa2_bpid_info[MAX_BPID];\n+struct dpaa2_bp_info *rte_dpaa2_bpid_info;\n static struct dpaa2_bp_list *h_bp_list;\n \n /* Dynamic logging identified for mempool */\n@@ -50,6 +50,16 @@ rte_hw_mbuf_create_pool(struct rte_mempool *mp)\n \n \tavail_dpbp = dpaa2_alloc_dpbp_dev();\n \n+\tif (rte_dpaa2_bpid_info == NULL) {\n+\t\trte_dpaa2_bpid_info = (struct dpaa2_bp_info *)rte_malloc(NULL,\n+\t\t\t\t sizeof(struct dpaa2_bp_info) * MAX_BPID,\n+\t\t\t\t RTE_CACHE_LINE_SIZE);\n+\t\tif (rte_dpaa2_bpid_info == NULL)\n+\t\t\treturn -ENOMEM;\n+\t\tmemset(rte_dpaa2_bpid_info, 0,\n+\t\t sizeof(struct dpaa2_bp_info) * MAX_BPID);\n+\t}\n+\n \tif (!avail_dpbp) {\n \t\tDPAA2_MEMPOOL_ERR(\"DPAA2 pool not available!\");\n \t\treturn -ENOENT;\ndiff --git a/drivers/mempool/dpaa2/dpaa2_hw_mempool.h b/drivers/mempool/dpaa2/dpaa2_hw_mempool.h\nindex 4d3468746..93694616e 100644\n--- a/drivers/mempool/dpaa2/dpaa2_hw_mempool.h\n+++ b/drivers/mempool/dpaa2/dpaa2_hw_mempool.h\n@@ -59,7 +59,7 @@ struct dpaa2_bp_info {\n #define mempool_to_bpinfo(mp) ((struct dpaa2_bp_info *)(mp)->pool_data)\n #define mempool_to_bpid(mp) ((mempool_to_bpinfo(mp))->bpid)\n \n-extern struct dpaa2_bp_info rte_dpaa2_bpid_info[MAX_BPID];\n+extern struct dpaa2_bp_info *rte_dpaa2_bpid_info;\n \n int rte_dpaa2_mbuf_alloc_bulk(struct rte_mempool *pool,\n \t\t void **obj_table, unsigned int count);\ndiff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c\nindex 861fbcd90..3a20158da 100644\n--- a/drivers/net/dpaa2/dpaa2_ethdev.c\n+++ b/drivers/net/dpaa2/dpaa2_ethdev.c\n@@ -485,6 +485,7 @@ dpaa2_dev_rx_queue_setup(struct rte_eth_dev *dev,\n \t}\n \tdpaa2_q = (struct dpaa2_queue *)priv->rx_vq[rx_queue_id];\n \tdpaa2_q->mb_pool = mb_pool; /**< mbuf pool to populate RX ring. */\n+\tdpaa2_q->bp_array = rte_dpaa2_bpid_info;\n \n \t/*Get the flow id from given VQ id*/\n \tflow_id = rx_queue_id % priv->nb_rx_queues;\ndiff --git a/drivers/net/dpaa2/dpaa2_rxtx.c b/drivers/net/dpaa2/dpaa2_rxtx.c\nindex 816ea00fd..6e2e8abd7 100644\n--- a/drivers/net/dpaa2/dpaa2_rxtx.c\n+++ b/drivers/net/dpaa2/dpaa2_rxtx.c\n@@ -518,6 +518,11 @@ dpaa2_dev_prefetch_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \t\t\treturn 0;\n \t\t}\n \t}\n+\n+\tif (unlikely(!rte_dpaa2_bpid_info &&\n+\t\t rte_eal_process_type() == RTE_PROC_SECONDARY))\n+\t\trte_dpaa2_bpid_info = dpaa2_q->bp_array;\n+\n \tswp = DPAA2_PER_LCORE_ETHRX_PORTAL;\n \tpull_size = (nb_pkts > dpaa2_dqrr_size) ? dpaa2_dqrr_size : nb_pkts;\n \tif (unlikely(!q_storage->active_dqs)) {\n", "prefixes": [ "v3", "17/19" ] }