Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/49715/?format=api
{ "id": 49715, "url": "http://patches.dpdk.org/api/patches/49715/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190111122305.7133-17-shreyansh.jain@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190111122305.7133-17-shreyansh.jain@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190111122305.7133-17-shreyansh.jain@nxp.com", "date": "2019-01-11T12:24:59", "name": "[v3,16/19] net/dpaa2: add API to support custom hash key", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8ce945598bbd8e36e22de3bad2fbe499c2dd727c", "submitter": { "id": 497, "url": "http://patches.dpdk.org/api/people/497/?format=api", "name": "Shreyansh Jain", "email": "shreyansh.jain@nxp.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190111122305.7133-17-shreyansh.jain@nxp.com/mbox/", "series": [ { "id": 3123, "url": "http://patches.dpdk.org/api/series/3123/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3123", "date": "2019-01-11T12:24:01", "name": "NXP DPAA2 fixes and enhancements", "version": 3, "mbox": "http://patches.dpdk.org/series/3123/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/49715/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/49715/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 90F2F1BC78;\n\tFri, 11 Jan 2019 13:25:01 +0100 (CET)", "from EUR03-VE1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr50063.outbound.protection.outlook.com [40.107.5.63])\n\tby dpdk.org (Postfix) with ESMTP id 4C1C01BC78\n\tfor <dev@dpdk.org>; Fri, 11 Jan 2019 13:25:00 +0100 (CET)", "from VI1PR04MB4688.eurprd04.prod.outlook.com (20.177.56.80) by\n\tVI1PR04MB5455.eurprd04.prod.outlook.com (20.178.121.149) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1516.14; Fri, 11 Jan 2019 12:24:59 +0000", "from VI1PR04MB4688.eurprd04.prod.outlook.com\n\t([fe80::b1eb:7e7e:7b90:7b4]) by\n\tVI1PR04MB4688.eurprd04.prod.outlook.com\n\t([fe80::b1eb:7e7e:7b90:7b4%4]) with mapi id 15.20.1516.016;\n\tFri, 11 Jan 2019 12:24:59 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=PC7qI6LRSzcO5yVWHOCM6HvoQY56fuN8Z2Ohmlb8lgs=;\n\tb=QWDoL4GUddEH3JcbpNdWleIh3+wHXEGu8JdJsu7NMVrJxMMKCPkVxYJubGs2x/tOoo5Ake+72kxX5I1M5b8981F5xtU5pOHUeMsWXzFOsjqeohY9BqKtoZQL9yfIPCIeD7NtvIav1/wWQdKT3y3nvnD/RT3Wz9lpd/XZWIGd2d4=", "From": "Shreyansh Jain <shreyansh.jain@nxp.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>", "CC": "\"ferruh.yigit@intel.com\" <ferruh.yigit@intel.com>, Nipun Gupta\n\t<nipun.gupta@nxp.com>", "Thread-Topic": "[PATCH v3 16/19] net/dpaa2: add API to support custom hash key", "Thread-Index": "AQHUqairtzmKjPpRuEaGU92hR5lrJQ==", "Date": "Fri, 11 Jan 2019 12:24:59 +0000", "Message-ID": "<20190111122305.7133-17-shreyansh.jain@nxp.com>", "References": "<20190111115712.6482-1-shreyansh.jain@nxp.com>\n\t<20190111122305.7133-1-shreyansh.jain@nxp.com>", "In-Reply-To": "<20190111122305.7133-1-shreyansh.jain@nxp.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[14.143.254.130]", "x-mailer": "git-send-email 2.17.1", "x-clientproxiedby": "TY2PR01CA0017.jpnprd01.prod.outlook.com\n\t(2603:1096:404:a::29) To VI1PR04MB4688.eurprd04.prod.outlook.com\n\t(2603:10a6:803:71::16)", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=shreyansh.jain@nxp.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-ms-publictraffictype": "Email", "x-microsoft-exchange-diagnostics": "1; VI1PR04MB5455;\n\t6:ptXqadWmYQ1I38sECUyM0aEhVi2VNBZ8eagoiGm5tn9h0n6nGuYg3FOhZRHRM6UPidC+dHfW7joQ9OX968sE5HBGLCKx9XZfUVFb0qoQhyAuMtHJs/zWm1fDyZKBk/39bu4SJBfQmf2k6AZnWMZcmWH9ohm5patX4TUIlTxnFJyR7bRG4bg3FB0ry7EqVmypeiWEU6iVZpHakIpmaJu/0hxgtjwDGmzKbmarHbjhjBY5UOIYMCsLuDMs3yWxb3yuUqPS8/S2nqQd0VmE9/vIN93qtcMYQftd1SGXDLmrSV5y/MmCD0V3nz//TGfHxQEOSaRvLsJmmj3/TcteITAHMfD3z5hiqKWzPdfkB5UOQw7pl9icY2zl1u7+eSHtfeyMXhYvX92tz4XoPpnIa53GLYCYVr5bBwkwqOTlOSn77pgy8GYy4ZOhRwaHicvLMTgiBDXuKDAWc5BFWRa9JC4ElA==;\n\t5:lR5NuW/BN7J8Bs6DzOJAN3Uy5m1ud0+QtuFNrltNKRh50Jtz3uMGIYRukeNg1+XVAK33/ts5oK2RgGyAS3SSGG3Jxs3IycKrHrQGmjexbIRDxhBplVup62KKDx9FFSQbaNcgwYoOq13RiTHsvM5l15R5NOT4OEXfXWF7wEbk5XpapLij/t6s864i1E8mOtmp+MZwtVPT2OiXvnGGJUW9fA==;\n\t7:NDTgfMRVa5hWgoRzN6wf3JBZmcqF68giHKxADQtxLXPCKeyZdWC1tM8dp5P7G1K57KuxpiQCVEEjCeUe+HqLFWLI2bg/dSdd+vvANyCFGd4cNqpbpTuNCGfmAsxTNiiaGCLuYylnT9X8CR3XumhFPQ==", "x-ms-office365-filtering-correlation-id": "f83d2934-ba81-4ba3-eb5c-08d677bfcd46", "x-ms-office365-filtering-ht": "Tenant", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(4618075)(2017052603328)(7153060)(7193020);\n\tSRVR:VI1PR04MB5455; ", "x-ms-traffictypediagnostic": "VI1PR04MB5455:", "x-microsoft-antispam-prvs": "<VI1PR04MB5455FFA700D153B2C95ABF7090850@VI1PR04MB5455.eurprd04.prod.outlook.com>", "x-forefront-prvs": "09144DB0F7", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(136003)(366004)(376002)(39860400002)(396003)(346002)(189003)(199004)(66066001)(186003)(86362001)(71200400001)(2351001)(71190400001)(55236004)(386003)(36756003)(6506007)(26005)(99286004)(105586002)(6116002)(14444005)(106356001)(102836004)(2906002)(54906003)(5660300001)(3846002)(256004)(8936002)(97736004)(78486014)(50226002)(2501003)(6486002)(305945005)(6436002)(14454004)(7736002)(8676002)(316002)(1730700003)(81166006)(81156014)(5640700003)(4326008)(2616005)(446003)(6916009)(478600001)(1076003)(52116002)(6512007)(44832011)(486006)(76176011)(53936002)(11346002)(68736007)(476003)(25786009);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB5455;\n\tH:VI1PR04MB4688.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; MX:1; A:1; ", "received-spf": "None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "Zf3+lpRsldNv6vd+gqjqFMUsl8xc4W8YddvrVTLnEJ527EzB5XuC6DguP46F8L2jSgUlhDK1HqIIEquwwwqminh1bFBjIVonSDQlxzRshht1jJjwDGvoUrfZQikW7rARPqFmsNw3FCbTD/HF0332bpTLJtUXOFgQI6VGmxC0U0Pm4/eWlvD+hOEGjCpLoGGxOYwg1s4hr15EYRrSX7PHjbHsh8Ok6e4A+1fI2KhhG22914aK4P+hE6DJK8kw8FrPFuyXnvhyNXMGlAmxE2V0uPbzgr3n97U6k3pJBuWrexvGhqKdYHwu92H0SKvkaMh7BU5lqCzJJGMqM1S2Pn6IQ59FY7druQKcQUBMAG9yH29Nqm/F3STp9NcSBhEHvB00cjRJuQEYQo5Qpw8W6xaKPeWIamrGnAo1y/lrK32NrV0=", "spamdiagnosticoutput": "1:99", "spamdiagnosticmetadata": "NSPM", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "f83d2934-ba81-4ba3-eb5c-08d677bfcd46", "X-MS-Exchange-CrossTenant-originalarrivaltime": "11 Jan 2019 12:24:56.2373\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "VI1PR04MB5455", "Subject": "[dpdk-dev] [PATCH v3 16/19] net/dpaa2: add API to support custom\n\thash key", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Nipun Gupta <nipun.gupta@nxp.com>\n\nThe DPAA2 hw can support a special offset based\nconfiguration to program distribution on hash.\nThis is for all cases, which are not directly supported.\n\ne.g. HASH based distribution on inner ip header\nof a GRE tunnel.\n\nSigned-off-by: Nipun Gupta <nipun.gupta@nxp.com>\n---\n drivers/net/dpaa2/base/dpaa2_hw_dpni.c | 52 ++++++++++++++++++++-\n drivers/net/dpaa2/rte_pmd_dpaa2.h | 28 +++++++++++\n drivers/net/dpaa2/rte_pmd_dpaa2_version.map | 1 +\n 3 files changed, 80 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/dpaa2/base/dpaa2_hw_dpni.c b/drivers/net/dpaa2/base/dpaa2_hw_dpni.c\nindex a6f86df8c..11f14931e 100644\n--- a/drivers/net/dpaa2/base/dpaa2_hw_dpni.c\n+++ b/drivers/net/dpaa2/base/dpaa2_hw_dpni.c\n@@ -1,7 +1,7 @@\n /* SPDX-License-Identifier: BSD-3-Clause\n *\n * Copyright (c) 2016 Freescale Semiconductor, Inc. All rights reserved.\n- * Copyright 2016 NXP\n+ * Copyright 2016-2018 NXP\n *\n */\n \n@@ -28,6 +28,56 @@ dpaa2_distset_to_dpkg_profile_cfg(\n \t\tuint64_t req_dist_set,\n \t\tstruct dpkg_profile_cfg *kg_cfg);\n \n+int\n+rte_pmd_dpaa2_set_custom_hash(uint16_t port_id,\n+\t\t\t uint16_t offset,\n+\t\t\t uint8_t size)\n+{\n+\tstruct rte_eth_dev *eth_dev = &rte_eth_devices[port_id];\n+\tstruct dpaa2_dev_priv *priv = eth_dev->data->dev_private;\n+\tstruct fsl_mc_io *dpni = priv->hw;\n+\tstruct dpni_rx_tc_dist_cfg tc_cfg;\n+\tstruct dpkg_profile_cfg kg_cfg;\n+\tvoid *p_params;\n+\tint ret, tc_index = 0;\n+\n+\tp_params = rte_zmalloc(\n+\t\tNULL, DIST_PARAM_IOVA_SIZE, RTE_CACHE_LINE_SIZE);\n+\tif (!p_params) {\n+\t\tDPAA2_PMD_ERR(\"Unable to allocate flow-dist parameters\");\n+\t\treturn -ENOMEM;\n+\t}\n+\n+\tkg_cfg.extracts[0].type = DPKG_EXTRACT_FROM_DATA;\n+\tkg_cfg.extracts[0].extract.from_data.offset = offset;\n+\tkg_cfg.extracts[0].extract.from_data.size = size;\n+\tkg_cfg.num_extracts = 1;\n+\n+\tret = dpkg_prepare_key_cfg(&kg_cfg, p_params);\n+\tif (ret) {\n+\t\tDPAA2_PMD_ERR(\"Unable to prepare extract parameters\");\n+\t\trte_free(p_params);\n+\t\treturn ret;\n+\t}\n+\n+\tmemset(&tc_cfg, 0, sizeof(struct dpni_rx_tc_dist_cfg));\n+\ttc_cfg.key_cfg_iova = (size_t)(DPAA2_VADDR_TO_IOVA(p_params));\n+\ttc_cfg.dist_size = eth_dev->data->nb_rx_queues;\n+\ttc_cfg.dist_mode = DPNI_DIST_MODE_HASH;\n+\n+\tret = dpni_set_rx_tc_dist(dpni, CMD_PRI_LOW, priv->token, tc_index,\n+\t\t\t\t &tc_cfg);\n+\trte_free(p_params);\n+\tif (ret) {\n+\t\tDPAA2_PMD_ERR(\n+\t\t\t \"Setting distribution for Rx failed with err: %d\",\n+\t\t\t ret);\n+\t\treturn ret;\n+\t}\n+\n+\treturn 0;\n+}\n+\n int\n dpaa2_setup_flow_dist(struct rte_eth_dev *eth_dev,\n \t\t uint64_t req_dist_set)\ndiff --git a/drivers/net/dpaa2/rte_pmd_dpaa2.h b/drivers/net/dpaa2/rte_pmd_dpaa2.h\nindex 57de27f21..7052d9da9 100644\n--- a/drivers/net/dpaa2/rte_pmd_dpaa2.h\n+++ b/drivers/net/dpaa2/rte_pmd_dpaa2.h\n@@ -59,4 +59,32 @@ rte_pmd_dpaa2_mux_flow_create(uint32_t dpdmux_id,\n \t\t\t struct rte_flow_item *pattern[],\n \t\t\t struct rte_flow_action *actions[]);\n \n+/**\n+ * @warning\n+ * @b EXPERIMENTAL: this API may change, or be removed, without prior notice\n+ *\n+ * Create a custom hash key on basis of offset of start of packet and size.\n+ * for e.g. if we need GRE packets (non-vlan and without any extra headers)\n+ * to be hashed on basis of inner IP header, we will provide offset as:\n+ * 14 (eth) + 20 (IP) + 4 (GRE) + 12 (Inner Src offset) = 50 and size\n+ * as 8 bytes.\n+ *\n+ * @param port_id\n+ * The port identifier of the Ethernet device.\n+ * @param offset\n+ * Offset from the start of packet which needs to be included to\n+ * calculate hash\n+ * @param size\n+ * Size of the hash input key\n+ *\n+ * @return\n+ * - 0 if successful.\n+ * - Negative in case of failure.\n+ */\n+__rte_experimental\n+int\n+rte_pmd_dpaa2_set_custom_hash(uint16_t port_id,\n+\t\t\t uint16_t offset,\n+\t\t\t uint8_t size);\n+\n #endif /* _RTE_PMD_DPAA2_H */\ndiff --git a/drivers/net/dpaa2/rte_pmd_dpaa2_version.map b/drivers/net/dpaa2/rte_pmd_dpaa2_version.map\nindex 1661c5fb5..d1b4cdb23 100644\n--- a/drivers/net/dpaa2/rte_pmd_dpaa2_version.map\n+++ b/drivers/net/dpaa2/rte_pmd_dpaa2_version.map\n@@ -15,5 +15,6 @@ EXPERIMENTAL {\n \tglobal:\n \n \trte_pmd_dpaa2_mux_flow_create;\n+\trte_pmd_dpaa2_set_custom_hash;\n \trte_pmd_dpaa2_set_timestamp;\n } DPDK_17.11;\n", "prefixes": [ "v3", "16/19" ] }