Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/49710/?format=api
{ "id": 49710, "url": "http://patches.dpdk.org/api/patches/49710/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190111122305.7133-12-shreyansh.jain@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190111122305.7133-12-shreyansh.jain@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190111122305.7133-12-shreyansh.jain@nxp.com", "date": "2019-01-11T12:24:42", "name": "[v3,11/19] bus/fslmc: rename portal pi index to consumer index", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "dfe99bb8b11beaab87b5033c32a76ba7b847d086", "submitter": { "id": 497, "url": "http://patches.dpdk.org/api/people/497/?format=api", "name": "Shreyansh Jain", "email": "shreyansh.jain@nxp.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190111122305.7133-12-shreyansh.jain@nxp.com/mbox/", "series": [ { "id": 3123, "url": "http://patches.dpdk.org/api/series/3123/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3123", "date": "2019-01-11T12:24:01", "name": "NXP DPAA2 fixes and enhancements", "version": 3, "mbox": "http://patches.dpdk.org/series/3123/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/49710/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/49710/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7B3CB1BC00;\n\tFri, 11 Jan 2019 13:24:45 +0100 (CET)", "from EUR01-HE1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr130085.outbound.protection.outlook.com [40.107.13.85])\n\tby dpdk.org (Postfix) with ESMTP id E0E6B1BC00\n\tfor <dev@dpdk.org>; Fri, 11 Jan 2019 13:24:43 +0100 (CET)", "from VI1PR04MB4688.eurprd04.prod.outlook.com (20.177.56.80) by\n\tVI1PR04MB5455.eurprd04.prod.outlook.com (20.178.121.149) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1516.14; Fri, 11 Jan 2019 12:24:42 +0000", "from VI1PR04MB4688.eurprd04.prod.outlook.com\n\t([fe80::b1eb:7e7e:7b90:7b4]) by\n\tVI1PR04MB4688.eurprd04.prod.outlook.com\n\t([fe80::b1eb:7e7e:7b90:7b4%4]) with mapi id 15.20.1516.016;\n\tFri, 11 Jan 2019 12:24:42 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=ZwIGfMC7Pa/Rr0Bbbfx996w9wTR9OZI77X6uZhXmIT4=;\n\tb=xBn//A8EtfYONwYJ+SrPqps+AZpJf11QC+wiRotUua2DQzeCC6jju1jxUy67U9E376vNKIX2U95n/3AxYPP1B6wcbxvDF2tR8TBoxVH5dzTYaYMTG1H46DbuWuSKVvCjjPYwBLsqkxbf/tSLinyasO+Ne9gCuZ8IUEpWBkcnTP0=", "From": "Shreyansh Jain <shreyansh.jain@nxp.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>", "CC": "\"ferruh.yigit@intel.com\" <ferruh.yigit@intel.com>, Hemant Agrawal\n\t<hemant.agrawal@nxp.com>, Youri Querry <youri.querry_1@nxp.com>", "Thread-Topic": "[PATCH v3 11/19] bus/fslmc: rename portal pi index to consumer\n\tindex", "Thread-Index": "AQHUqaih4NLgaFtYRUyBkSkXwCHT/A==", "Date": "Fri, 11 Jan 2019 12:24:42 +0000", "Message-ID": "<20190111122305.7133-12-shreyansh.jain@nxp.com>", "References": "<20190111115712.6482-1-shreyansh.jain@nxp.com>\n\t<20190111122305.7133-1-shreyansh.jain@nxp.com>", "In-Reply-To": "<20190111122305.7133-1-shreyansh.jain@nxp.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[14.143.254.130]", "x-mailer": "git-send-email 2.17.1", "x-clientproxiedby": "TY2PR01CA0017.jpnprd01.prod.outlook.com\n\t(2603:1096:404:a::29) To VI1PR04MB4688.eurprd04.prod.outlook.com\n\t(2603:10a6:803:71::16)", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=shreyansh.jain@nxp.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-ms-publictraffictype": "Email", "x-microsoft-exchange-diagnostics": "1; VI1PR04MB5455;\n\t6:uyzzGJUPlWHemRzopTsr0gQQS69D9KAHSpelr3eGzbXinCpxXHVP7yfdc39U4ZUvq1SaoE8XvzGx/PuZ9vvN815uybzVgk2ZXbXn3LTpV3ND9l6e/JzJvqx+uCvbGmCVXA68RCbNrJhGX+Is24LfuM2bSwd/EDyJuyAwnAzC+e4Q599WzJqc2WOCpPvAbAD8DbLmfH7PZlttE++vNIjkbegAoxd+6LwTgifiQXpKJcbQG+j1wtAwYdzCZc+XiLNVnZCasFrCWZTPxIsNS24xAyP4CVfJlrSOMTRvsWXrcuAs52shcs8VZ938JkmX3JihazMnGapFF0I329oRDHafdjWemc6Vn990GCwt1poUn17Qa4dhj+g2hENK6ZVHcszCCelroH9rgtyd0J4bJQyx996vHp1M4NJnY02uyBo8dnMsqV+qVekabeCuwdBZCLECxRX4B1TwJFv0B+j0ACaT9Q==;\n\t5:uB7fLFrna/5OO3yA2Z34F7Gi5ogAomXv5DeGKd+U0yOwJcVOZOkcuzWO6yCMyxkVrBhPt7c8ZlcWVr59ut1k/HH5atU8GmHRE0OyXJQ8RYK+TGSHVGEt4AjrBO+mLlkCmcf6KnJbL3BFGwv6hVZwqWgg3sPlEYfPEO4xT3jJ9Gnu+2L1tzzXiQd1/ZZvrg273fxKfYHnONz3sudfQwy/6w==;\n\t7:3HBJAROF4TKQhwN8N+Q0cZ8Qg/Jp9F5PAdB1uA1Cep7WCzqYs05DkwnUXW5SUgWBzjrULfuUJRA3q6lpGaPNaMrvjvzvznf9RP2DP3GHIhKvu4B11hFWHteGOB6iEQn0pa3AGAsr80n0wumWAX9wQw==", "x-ms-office365-filtering-correlation-id": "826ac6df-0e5b-432d-1c42-08d677bfc346", "x-ms-office365-filtering-ht": "Tenant", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(4618075)(2017052603328)(7153060)(7193020);\n\tSRVR:VI1PR04MB5455; ", "x-ms-traffictypediagnostic": "VI1PR04MB5455:", "x-microsoft-antispam-prvs": "<VI1PR04MB545587C036853C5FD1F4FC9490850@VI1PR04MB5455.eurprd04.prod.outlook.com>", "x-forefront-prvs": "09144DB0F7", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(136003)(366004)(376002)(39860400002)(396003)(346002)(189003)(199004)(66066001)(186003)(575784001)(86362001)(71200400001)(2351001)(71190400001)(55236004)(386003)(36756003)(6506007)(26005)(99286004)(105586002)(6116002)(14444005)(106356001)(102836004)(2906002)(54906003)(5660300001)(3846002)(256004)(8936002)(97736004)(78486014)(50226002)(2501003)(6486002)(305945005)(6436002)(14454004)(7736002)(8676002)(316002)(1730700003)(81166006)(81156014)(5640700003)(4326008)(2616005)(446003)(6916009)(478600001)(1076003)(52116002)(6512007)(44832011)(486006)(76176011)(53936002)(11346002)(68736007)(476003)(25786009);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB5455;\n\tH:VI1PR04MB4688.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; MX:1; A:1; ", "received-spf": "None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "b5UBf3uYXyGC+uWf1Sgr03hw2Sjdf+Y/WxOk0rpBOkz+by9sPc42ZEbnwoKN2Sxb/ZzsiJz/MMqDxrkhcqqNAgZgCIM8HdVNPF3qXQWiTHvS/n83NOik2F1N2W7fZG5fH9uVQyjZRbdRr2EwPtzv62xAUL7hM1k0qNkksa0D12s2r4ZxhyfxeJZLQKhrSliksT0YXAXACl5WtIFXgMF4dXyt6MDQtg4cu0AMcVXXZfLMATBUzZGhHiZ1LS7rUmN+2EqW52nhbEBEFDrIrnBfCuCj6UbVNyhIbYKbB99dM2mObCDMjVC1gMlavbKJADkthQIR79JYOXpO4aa6zu1lwD1BEfmfDWa8mppXPdq9HXH17aLybA9wR1KrAUZLaL2Wl2SwxQZSy/7EgO1hIXY2uiEzIdV71M+4/gNM6Mxkzr0=", "spamdiagnosticoutput": "1:99", "spamdiagnosticmetadata": "NSPM", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "826ac6df-0e5b-432d-1c42-08d677bfc346", "X-MS-Exchange-CrossTenant-originalarrivaltime": "11 Jan 2019 12:24:39.0635\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "VI1PR04MB5455", "Subject": "[dpdk-dev] [PATCH v3 11/19] bus/fslmc: rename portal pi index to\n\tconsumer index", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Hemant Agrawal <hemant.agrawal@nxp.com>\n\nThis is to align with the latest qbman hw library\n\nSigned-off-by: Youri Querry <youri.querry_1@nxp.com>\nSigned-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>\n---\n drivers/bus/fslmc/qbman/qbman_portal.c | 51 +++++++++++---------------\n drivers/bus/fslmc/qbman/qbman_portal.h | 2 +-\n 2 files changed, 23 insertions(+), 30 deletions(-)", "diff": "diff --git a/drivers/bus/fslmc/qbman/qbman_portal.c b/drivers/bus/fslmc/qbman/qbman_portal.c\nindex 08bfdc9f8..14f4b0344 100644\n--- a/drivers/bus/fslmc/qbman/qbman_portal.c\n+++ b/drivers/bus/fslmc/qbman/qbman_portal.c\n@@ -251,21 +251,21 @@ struct qbman_swp *qbman_swp_init(const struct qbman_swp_desc *d)\n \t}\n \n \tfor (mask_size = p->eqcr.pi_ring_size; mask_size > 0; mask_size >>= 1)\n-\t\tp->eqcr.pi_mask = (p->eqcr.pi_mask<<1) + 1;\n+\t\tp->eqcr.pi_ci_mask = (p->eqcr.pi_ci_mask<<1) + 1;\n \teqcr_pi = qbman_cinh_read(&p->sys, QBMAN_CINH_SWP_EQCR_PI);\n-\tp->eqcr.pi = eqcr_pi & p->eqcr.pi_mask;\n+\tp->eqcr.pi = eqcr_pi & p->eqcr.pi_ci_mask;\n \tp->eqcr.pi_vb = eqcr_pi & QB_VALID_BIT;\n \tif ((p->desc.qman_version & QMAN_REV_MASK) >= QMAN_REV_5000\n \t\t\t&& (d->cena_access_mode == qman_cena_fastest_access))\n-\t\tp->eqcr.ci = qbman_cinh_read(&p->sys,\n-\t\t\t\tQBMAN_CINH_SWP_EQCR_CI) & p->eqcr.pi_mask;\n+\t\tp->eqcr.ci = qbman_cinh_read(&p->sys, QBMAN_CINH_SWP_EQCR_PI)\n+\t\t\t\t\t & p->eqcr.pi_ci_mask;\n \telse\n-\t\tp->eqcr.ci = qbman_cinh_read(&p->sys,\n-\t\t\t\tQBMAN_CINH_SWP_EQCR_PI) & p->eqcr.pi_mask;\n+\t\tp->eqcr.ci = qbman_cinh_read(&p->sys, QBMAN_CINH_SWP_EQCR_CI)\n+\t\t\t\t\t & p->eqcr.pi_ci_mask;\n \tp->eqcr.available = p->eqcr.pi_ring_size -\n \t\t\t\tqm_cyc_diff(p->eqcr.pi_ring_size,\n-\t\t\t\tp->eqcr.ci & (p->eqcr.pi_mask<<1),\n-\t\t\t\tp->eqcr.pi & (p->eqcr.pi_mask<<1));\n+\t\t\t\tp->eqcr.ci & (p->eqcr.pi_ci_mask<<1),\n+\t\t\t\tp->eqcr.pi & (p->eqcr.pi_ci_mask<<1));\n \n \tportal_idx_map[p->desc.idx] = p;\n \treturn p;\n@@ -646,8 +646,8 @@ static int qbman_swp_enqueue_ring_mode_direct(struct qbman_swp *s,\n \tconst uint32_t *cl = qb_cl(d);\n \tuint32_t eqcr_ci, full_mask, half_mask;\n \n-\thalf_mask = (s->eqcr.pi_mask>>1);\n-\tfull_mask = s->eqcr.pi_mask;\n+\thalf_mask = (s->eqcr.pi_ci_mask>>1);\n+\tfull_mask = s->eqcr.pi_ci_mask;\n \tif (!s->eqcr.available) {\n \t\teqcr_ci = s->eqcr.ci;\n \t\ts->eqcr.ci = qbman_cena_read_reg(&s->sys,\n@@ -685,8 +685,8 @@ static int qbman_swp_enqueue_ring_mode_mem_back(struct qbman_swp *s,\n \tconst uint32_t *cl = qb_cl(d);\n \tuint32_t eqcr_ci, full_mask, half_mask;\n \n-\thalf_mask = (s->eqcr.pi_mask>>1);\n-\tfull_mask = s->eqcr.pi_mask;\n+\thalf_mask = (s->eqcr.pi_ci_mask>>1);\n+\tfull_mask = s->eqcr.pi_ci_mask;\n \tif (!s->eqcr.available) {\n \t\teqcr_ci = s->eqcr.ci;\n \t\ts->eqcr.ci = qbman_cena_read_reg(&s->sys,\n@@ -743,8 +743,8 @@ static int qbman_swp_enqueue_multiple_direct(struct qbman_swp *s,\n \tint i, num_enqueued = 0;\n \tuint64_t addr_cena;\n \n-\thalf_mask = (s->eqcr.pi_mask>>1);\n-\tfull_mask = s->eqcr.pi_mask;\n+\thalf_mask = (s->eqcr.pi_ci_mask>>1);\n+\tfull_mask = s->eqcr.pi_ci_mask;\n \tif (!s->eqcr.available) {\n \t\teqcr_ci = s->eqcr.ci;\n \t\ts->eqcr.ci = qbman_cena_read_reg(&s->sys,\n@@ -811,8 +811,8 @@ static int qbman_swp_enqueue_multiple_mem_back(struct qbman_swp *s,\n \tuint32_t eqcr_ci, eqcr_pi, half_mask, full_mask;\n \tint i, num_enqueued = 0;\n \n-\thalf_mask = (s->eqcr.pi_mask>>1);\n-\tfull_mask = s->eqcr.pi_mask;\n+\thalf_mask = (s->eqcr.pi_ci_mask>>1);\n+\tfull_mask = s->eqcr.pi_ci_mask;\n \tif (!s->eqcr.available) {\n \t\teqcr_ci = s->eqcr.ci;\n \t\ts->eqcr.ci = qbman_cena_read_reg(&s->sys,\n@@ -833,15 +833,6 @@ static int qbman_swp_enqueue_multiple_mem_back(struct qbman_swp *s,\n \t\t\t\tQBMAN_CENA_SWP_EQCR(eqcr_pi & half_mask));\n \t\tmemcpy(&p[1], &cl[1], 28);\n \t\tmemcpy(&p[8], &fd[i], sizeof(*fd));\n-\t\teqcr_pi++;\n-\t}\n-\n-\t/* Set the verb byte, have to substitute in the valid-bit */\n-\teqcr_pi = s->eqcr.pi;\n-\tfor (i = 0; i < num_enqueued; i++) {\n-\t\tp = qbman_cena_write_start_wo_shadow(&s->sys,\n-\t\t\t\tQBMAN_CENA_SWP_EQCR(eqcr_pi & half_mask));\n-\t\tp[0] = cl[0] | s->eqcr.pi_vb;\n \t\tif (flags && (flags[i] & QBMAN_ENQUEUE_FLAG_DCA)) {\n \t\t\tstruct qbman_eq_desc *d = (struct qbman_eq_desc *)p;\n \n@@ -849,6 +840,8 @@ static int qbman_swp_enqueue_multiple_mem_back(struct qbman_swp *s,\n \t\t\t\t((flags[i]) & QBMAN_EQCR_DCA_IDXMASK);\n \t\t}\n \t\teqcr_pi++;\n+\t\tp[0] = cl[0] | s->eqcr.pi_vb;\n+\n \t\tif (!(eqcr_pi & half_mask))\n \t\t\ts->eqcr.pi_vb ^= QB_VALID_BIT;\n \t}\n@@ -880,8 +873,8 @@ static int qbman_swp_enqueue_multiple_desc_direct(struct qbman_swp *s,\n \tint i, num_enqueued = 0;\n \tuint64_t addr_cena;\n \n-\thalf_mask = (s->eqcr.pi_mask>>1);\n-\tfull_mask = s->eqcr.pi_mask;\n+\thalf_mask = (s->eqcr.pi_ci_mask>>1);\n+\tfull_mask = s->eqcr.pi_ci_mask;\n \tif (!s->eqcr.available) {\n \t\teqcr_ci = s->eqcr.ci;\n \t\ts->eqcr.ci = qbman_cena_read_reg(&s->sys,\n@@ -943,8 +936,8 @@ static int qbman_swp_enqueue_multiple_desc_mem_back(struct qbman_swp *s,\n \tuint32_t eqcr_ci, eqcr_pi, half_mask, full_mask;\n \tint i, num_enqueued = 0;\n \n-\thalf_mask = (s->eqcr.pi_mask>>1);\n-\tfull_mask = s->eqcr.pi_mask;\n+\thalf_mask = (s->eqcr.pi_ci_mask>>1);\n+\tfull_mask = s->eqcr.pi_ci_mask;\n \tif (!s->eqcr.available) {\n \t\teqcr_ci = s->eqcr.ci;\n \t\ts->eqcr.ci = qbman_cena_read_reg(&s->sys,\ndiff --git a/drivers/bus/fslmc/qbman/qbman_portal.h b/drivers/bus/fslmc/qbman/qbman_portal.h\nindex 3b0fc540b..e54f2661c 100644\n--- a/drivers/bus/fslmc/qbman/qbman_portal.h\n+++ b/drivers/bus/fslmc/qbman/qbman_portal.h\n@@ -98,7 +98,7 @@ struct qbman_swp {\n \t\tuint32_t pi;\n \t\tuint32_t pi_vb;\n \t\tuint32_t pi_ring_size;\n-\t\tuint32_t pi_mask;\n+\t\tuint32_t pi_ci_mask;\n \t\tuint32_t ci;\n \t\tint available;\n \t} eqcr;\n", "prefixes": [ "v3", "11/19" ] }